On Tue, 10 Sep 2024 16:37:11 GMT, sbgoog wrote:
> FIleSystemPreferences.lockFile() catches an InterruptedException and just
> returns false, forgetting to re-interrupt the current thread. This leaves the
> caller with no way to observe that the thread was interrupted. This change
&
On Mon, 30 Sep 2024 15:58:53 GMT, Daniel Jeliński wrote:
> For future reference, as the bot says, don't force push. The bot will squash
> all commits before merging.
I didn't realize before pushing, but now I know. Thanks!
> The change looks good to me. Please update the copyright year.
I've
hread before returning.
sbgoog has updated the pull request incrementally with one additional commit
since the last revision:
Update Copyright year
-
Changes:
- all: https://git.openjdk.org/jdk/pull/20938/files
- new: https://git.openjdk.org/jdk/pull/20938/files/0b0304
On Mon, 30 Sep 2024 14:06:35 GMT, Daniel Fuchs wrote:
>> The status might not be explicitly checked, but setting the interrupted
>> status will make sure that subsequent calls to sleep/await/tryLock etc. will
>> not block.
>>
>> In general, we want to preserve the interrupted status until eith
hread before returning.
sbgoog has refreshed the contents of this pull request, and previous commits
have been removed. The incremental views will show differences compared to the
previous content of the PR. The pull request contains one new commit since the
last revision:
8339850: Restore t
On Fri, 27 Sep 2024 18:46:54 GMT, Daniel Jeliński wrote:
>> FIleSystemPreferences.lockFile() catches an InterruptedException and just
>> returns false, forgetting to re-interrupt the current thread. This leaves
>> the caller with no way to observe that the thread was interrupted. This
>> chang
On Tue, 10 Sep 2024 16:37:11 GMT, sbgoog wrote:
> FIleSystemPreferences.lockFile() catches an InterruptedException and just
> returns false, forgetting to re-interrupt the current thread. This leaves the
> caller with no way to observe that the thread was interrupted. This change
&
FIleSystemPreferences.lockFile() catches an InterruptedException and just
returns false, forgetting to re-interrupt the current thread. This leaves the
caller with no way to observe that the thread was interrupted. This change
restores the interrupted status on the current thread before returnin
