Re: RFR: 8354897: Support Soft/Weak Reference in AOT cache [v7]

2025-04-29 Thread Zhengyu Gu
On Wed, 30 Apr 2025 00:57:51 GMT, Ioi Lam wrote: >> src/hotspot/share/cds/aotReferenceObjSupport.cpp line 122: >> >>> 120: ik->initialize(CHECK); >>> 121: >>> 122: TempNewSymbol field_name = SymbolTable::new_symbol("N""ULL"); >> >> Why "N""ULL", not "NULL"? > > That's because a stand-lone

Re: RFR: 8354897: Support Soft/Weak Reference in AOT cache [v7]

2025-04-29 Thread Zhengyu Gu
On Tue, 29 Apr 2025 22:22:05 GMT, Ioi Lam wrote: >> This PR contains 2 parts >> >> - Upstream of Soft/Weak Reference support authored by @macarte from [the >> Leyden >> repo](https://github.com/openjdk/leyden/commit/4ca75d156519596e23abc8a312496b7c2f0e0ca5) >> - New C++ class `AOTReferenceObjS

Re: RFR: 8333962: Obsolete OldSize [v2]

2024-06-17 Thread Zhengyu Gu
On Fri, 14 Jun 2024 10:19:47 GMT, Albert Mingkun Yang wrote: >> Obsolete OldSize and related code. An internal variable `OldSize` is kept to >> capture the capacity of old-gen size. > > Albert Mingkun Yang has updated the pull request with a new target base due > to a merge or a rebase. The pul

Re: RFR: 8333962: Obsolete OldSize [v2]

2024-06-17 Thread Zhengyu Gu
On Fri, 14 Jun 2024 10:19:47 GMT, Albert Mingkun Yang wrote: >> Obsolete OldSize and related code. An internal variable `OldSize` is kept to >> capture the capacity of old-gen size. > > Albert Mingkun Yang has updated the pull request with a new target base due > to a merge or a rebase. The pul

Re: Question on Lambda function

2024-05-31 Thread Zhengyu Gu
Thanks a lot, Chen -Zhengyu From: Chen Liang Date: Friday, May 31, 2024 at 10:19 AM To: Zhengyu Gu Cc: core-libs-dev@openjdk.org Subject: Re: Question on Lambda function [External Email] Hi Zhengyu, This implementation is actually quite good in terms of

Re: Question on Lambda function

2024-05-31 Thread Zhengyu Gu
appreciate your insights. Thanks, -Zhengyu From: Zhengyu Gu Date: Wednesday, May 29, 2024 at 8:28 PM To: Chen Liang Cc: core-libs-dev@openjdk.org Subject: Re: Question on Lambda function Hi Chen, What is your usage pattern of these single-abstract-method implementations? Since it sounds

Re: Question on Lambda function

2024-05-29 Thread Zhengyu Gu
unloadable hidden classes, but its 3.x builds are not maven central so you have to build yourself. - Chen On Wed, May 29, 2024 at 3:35 PM Zhengyu Gu mailto:zhengyu...@servicenow.com>> wrote: Hi Chen, Thanks for the insights. We did refactor our code to avoid using LambdaMetaFactory,metaf

Re: Question on Lambda function

2024-05-29 Thread Zhengyu Gu
) here to stay, we must come up with a coding guideline to avoid excessive creation of Lambda classes, any pointers or suggestions would be greatly appreciated. Best, -Zhengyu From: Chen Liang Date: Wednesday, May 29, 2024 at 2:43 PM To: Zhengyu Gu Cc: core-libs-dev@openjdk.org Subject: Re

Question on Lambda function

2024-05-29 Thread Zhengyu Gu
Hello Lambda experts, Since we upgraded JDK from 11 to 17, we’re experiencing metaspace pressure, largely due to Lambda class implementation changes. There’s a scenario (see attached test case), that is especially puzzled me, hopefully, you can share some insights. In this test case, there is