Re: RFR: 8336881: [Linux] Support for hierarchical limits for Metrics [v9]

2024-10-01 Thread Zdenek Zambersky
On Mon, 30 Sep 2024 12:03:14 GMT, Severin Gehwolf wrote: >> Please review this fix for cgroups-based metrics reporting in the >> `jdk.internal.platform` package. This fix is supposed to address wrong >> reporting of certain limits if the limits aren't set at the leaf nodes. >> >> For example,

Re: RFR: 8333446: Add tests for hierarchical container support [v11]

2024-09-11 Thread Zdenek Zambersky
On Wed, 11 Sep 2024 14:13:50 GMT, Severin Gehwolf wrote: >> Please review this PR which adds test support for systemd slices so that >> bugs like [JDK-8217338](https://bugs.openjdk.org/browse/JDK-8217338) can be >> verified. The added test, `SystemdMemoryAwarenessTest` currently passes on >> c

Re: RFR: 8333446: Add tests for hierarchical container support [v10]

2024-09-10 Thread Zdenek Zambersky
On Tue, 10 Sep 2024 13:23:45 GMT, Severin Gehwolf wrote: >> Please review this PR which adds test support for systemd slices so that >> bugs like [JDK-8217338](https://bugs.openjdk.org/browse/JDK-8217338) can be >> verified. The added test, `SystemdMemoryAwarenessTest` currently passes on >> c

Re: RFR: 8333446: Add tests for hierarchical container support [v6]

2024-09-10 Thread Zdenek Zambersky
On Tue, 10 Sep 2024 13:23:37 GMT, Severin Gehwolf wrote: >> Looking through the coding it looks more or less okay to me; but if you >> really need to run it under user 'root' I think we will not have so much >> use for this in our test environments because we use other test users. >> Not sayi

Re: RFR: 8333446: Add tests for hierarchical container support [v9]

2024-09-10 Thread Zdenek Zambersky
On Mon, 9 Sep 2024 17:28:16 GMT, Zdenek Zambersky wrote: >> Severin Gehwolf has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request cont

Re: RFR: 8336881: [Linux] Support for hierarchical limits for Metrics [v6]

2024-09-09 Thread Zdenek Zambersky
On Thu, 5 Sep 2024 13:25:17 GMT, Severin Gehwolf wrote: >> Please review this fix for cgroups-based metrics reporting in the >> `jdk.internal.platform` package. This fix is supposed to address wrong >> reporting of certain limits if the limits aren't set at the leaf nodes. >> >> For example, o

Re: RFR: 8333446: Add tests for hierarchical container support [v9]

2024-09-09 Thread Zdenek Zambersky
On Wed, 4 Sep 2024 17:46:00 GMT, Severin Gehwolf wrote: >> Please review this PR which adds test support for systemd slices so that >> bugs like [JDK-8217338](https://bugs.openjdk.org/browse/JDK-8217338) can be >> verified. The added test, `SystemdMemoryAwarenessTest` currently passes on >> cg

Re: RFR: 8333446: Add tests for hierarchical container support [v5]

2024-08-28 Thread Zdenek Zambersky
On Tue, 27 Aug 2024 15:01:59 GMT, Severin Gehwolf wrote: > > If I am not mistaken, new test requires, that testsuite is ran as superuser > > (root). (Because it writes `/etc/systemd/system`, runs certain systemd > > commands). Should test be skipped for non-root? > > Thanks! I can add that. FW

Re: RFR: 8333446: Add tests for hierarchical container support [v5]

2024-08-27 Thread Zdenek Zambersky
On Tue, 20 Aug 2024 17:34:46 GMT, Severin Gehwolf wrote: >> Please review this PR which adds test support for systemd slices so that >> bugs like [JDK-8217338](https://bugs.openjdk.org/browse/JDK-8217338) can be >> verified. The added test, `SystemdMemoryAwarenessTest` currently passes on >> c