On Thu, 17 Jul 2025 07:04:00 GMT, Tobias Hartmann wrote:
>> @TobiHartmann, this change results in the following compiler error:
>>
>>
>> /home/vy/.../src/hotspot/share/opto/library_call.cpp:958:35: error: invalid
>> conversion from 'Node*' to 'RegionNode*' [-fpermissive]
>> 958 | generate_
try {
>
> jdk.internal.access.SharedSecrets.getJavaLangAccess().countPositives(new
> byte[]{1,2,3}, 2, 5);
> } catch (Exception exception) {
> lastException = exception;
> }
> }
> if (lastException != null) {
>
On Thu, 17 Jul 2025 06:13:30 GMT, Volkan Yazici wrote:
>> Validate input in `java.lang.StringCoding` intrinsic Java wrappers, improve
>> their documentation, enhance the checks in the associated IR or assembly
>> code, and adapt them to cause VM crash on invalid input.
>&g
On Thu, 17 Jul 2025 06:13:30 GMT, Volkan Yazici wrote:
>> Validate input in `java.lang.StringCoding` intrinsic Java wrappers, improve
>> their documentation, enhance the checks in the associated IR or assembly
>> code, and adapt them to cause VM crash on invalid input.
>&g
On Wed, 16 Jul 2025 05:28:55 GMT, Tobias Hartmann wrote:
>> Volkan Yazici has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request cont
try {
>
> jdk.internal.access.SharedSecrets.getJavaLangAccess().countPositives(new
> byte[]{1,2,3}, 2, 5);
> } catch (Exception exception) {
> lastException = exception;
> }
> }
> if (lastException != null) {
>
On Thu, 10 Jul 2025 12:23:06 GMT, Volkan Yazici wrote:
>> Volkan Yazici has refreshed the contents of this pull request, and previous
>> commits have been removed. The incremental views will show differences
>> compared to the previous content of the PR. The pull request co
try {
>
> jdk.internal.access.SharedSecrets.getJavaLangAccess().countPositives(new
> byte[]{1,2,3}, 2, 5);
> } catch (Exception exception) {
> lastException = exception;
> }
> }
> if (lastException != null) {
>
try {
>
> jdk.internal.access.SharedSecrets.getJavaLangAccess().countPositives(new
> byte[]{1,2,3}, 2, 5);
> } catch (Exception exception) {
> lastException = exception;
> }
> }
> if (lastException != null) {
>
try {
>
> jdk.internal.access.SharedSecrets.getJavaLangAccess().countPositives(new
> byte[]{1,2,3}, 2, 5);
> } catch (Exception exception) {
> lastException = exception;
> }
> }
> if (lastException != null) {
>
On Tue, 15 Jul 2025 19:45:33 GMT, Roger Riggs wrote:
>> Volkan Yazici has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - Minimize the number of touched lines in `vmIntrinsics.hpp`
>> - Remove Markdown-sty
On Tue, 15 Jul 2025 19:25:31 GMT, Roger Riggs wrote:
>> Volkan Yazici has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - Minimize the number of touched lines in `vmIntrinsics.hpp`
>> - Remove Markdown-sty
try {
>
> jdk.internal.access.SharedSecrets.getJavaLangAccess().countPositives(new
> byte[]{1,2,3}, 2, 5);
> } catch (Exception exception) {
> lastException = exception;
> }
> }
> if (lastException != null) {
>
On Mon, 14 Jul 2025 10:32:24 GMT, Damon Fenacci wrote:
> I left a couple of minor comments. I also noticed that you haven't yet added
> the benchmark results to the description: do you want to run them again after
> the reviews?
@dafedafe, thanks so much for the review! I've implemented the ch
On Mon, 14 Jul 2025 09:11:08 GMT, Damon Fenacci wrote:
>> Volkan Yazici has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - Minimize the number of touched lines in `vmIntrinsics.hpp`
>> - Remov
On Mon, 14 Jul 2025 10:27:45 GMT, Damon Fenacci wrote:
>> Volkan Yazici has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - Minimize the number of touched lines in `vmIntrinsics.hpp`
>> - Remov
On Mon, 14 Jul 2025 08:49:44 GMT, Damon Fenacci wrote:
>> Volkan Yazici has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - Minimize the number of touched lines in `vmIntrinsics.hpp`
>> - Remov
try {
>
> jdk.internal.access.SharedSecrets.getJavaLangAccess().countPositives(new
> byte[]{1,2,3}, 2, 5);
> } catch (Exception exception) {
> lastException = exception;
> }
> }
> if (lastException != null) {
>
On Thu, 10 Jul 2025 20:54:24 GMT, John R Rose wrote:
>> Validate input in `java.lang.StringCoding` intrinsic Java wrappers, improve
>> their documentation, enhance the checks in the associated IR or assembly
>> code, and adapt them to cause VM crash on invalid input.
>>
>> ## Implementation no
On Thu, 26 Jun 2025 10:48:37 GMT, Volkan Yazici wrote:
> Validate input in `java.lang.StringCoding` intrinsic Java wrappers, improve
> their documentation, enhance the checks in the associated C++ methods, and
> adapt them to cause VM crash on invalid input.
>
> ## Imple
On Fri, 27 Jun 2025 20:21:31 GMT, ExE Boss wrote:
>> My point is this is a performance-sensitive API. We are using a known-slow
>> check method `checkFromIndexSize` which may introduce a performance
>> regression.
>
> Maybe use `jdk.internal.util.Preconditions` directly instead?
> Suggestion:
>
On Fri, 27 Jun 2025 13:24:52 GMT, Chen Liang wrote:
>> But the original code already checks for `len >= 0`, right? See
>> `LibraryCallKit::inline_countPositives` -> `generate_string_range_check` ->
>> `// Offset and count must not be negative`
>>
>> This PR is about moving the range checks fro
On Fri, 4 Jul 2025 15:03:33 GMT, Volkan Yazici wrote:
>> Maybe use `jdk.internal.util.Preconditions` directly instead?
>> Suggestion:
>>
>> Preconditions.checkFromIndexSize(off, len, ba.length, null);
>
> @ExE-Boss, I consulted this internally and de
Validate input in `java.lang.StringCoding` intrinsic Java wrappers, improve
their documentation, enhance the checks in the associated C++ methods, and
adapt them to cause VM crash on invalid input.
## Implementation notes
The goal of the associated umbrella issue
[JDK-8156534](https://bugs.ope
On Wed, 18 Jun 2025 20:16:18 GMT, Roger Riggs wrote:
> Improve the documentation of Process use of system resources.
>
> Describe the implementation closing streams when no longer referenced.
> Clarify the interactions between inputStream and inputReader and errorStream
> and errorReader.
> Add
On Tue, 17 Jun 2025 20:16:05 GMT, Naoto Sato wrote:
> Refactored the internal handling of `stdin/out/err.encoding` to allow setting
> them only via command-line options by converting them into `StaticProperty`.
> This change prevents unexpected behavior caused by applications modifying
> these
On Fri, 30 May 2025 11:07:30 GMT, Volkan Yazici wrote:
> Passes the `Charset` read from the `stdin.encoding` system property while
> creating `InputStreamReader` or `Scanner` instances for `System.in`.
>
> `stdin.encoding` is a recently added property for Java 25 in
> [JDK
On Tue, 3 Jun 2025 20:09:51 GMT, Naoto Sato wrote:
>> Volkan Yazici has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix missing `java.io.Reader` import in `Ktab`
>
> I was thinking if someone made a typo fo
On Wed, 11 Jun 2025 11:22:57 GMT, Volkan Yazici wrote:
> Both `javax/script/PluggableContextTest.java` and its companion
> `test/jdk/javax/script/MyContext.java` were added in
> [JDK-6398614](https://bugs.openjdk.org/browse/JDK-6398614).
> [JDK-8246113](https://bugs.openjdk.or
On Fri, 13 Jun 2025 08:52:37 GMT, Athijegannathan Sundararajan
wrote:
>> Both `javax/script/PluggableContextTest.java` and its companion
>> `test/jdk/javax/script/MyContext.java` were added in
>> [JDK-6398614](https://bugs.openjdk.org/browse/JDK-6398614).
>> [JDK-8246113](https://bugs.openjdk
). Employing it
> throughout the entire code base is addressed by the parent ticket
> [JDK-8356893](https://bugs.openjdk.org/browse/JDK-8356893). JDK-8357995 this
> PR is addressing is a sub-task of JDK-8356893 and is concerned with only
> areas related to core libraries.
Volkan Yazici h
Both `javax/script/PluggableContextTest.java` and its companion
`test/jdk/javax/script/MyContext.java` were added in
[JDK-6398614](https://bugs.openjdk.org/browse/JDK-6398614).
[JDK-8246113](https://bugs.openjdk.org/browse/JDK-8246113) removed
`PluggableContextTest`, yet forgot `MyContext`, and
). Employing it
> throughout the entire code base is addressed by the parent ticket
> [JDK-8356893](https://bugs.openjdk.org/browse/JDK-8356893). JDK-8357995 this
> PR is addressing is a sub-task of JDK-8356893 and is concerned with only
> areas related to core libraries.
Volkan Yazici h
On Wed, 11 Jun 2025 10:29:52 GMT, Volkan Yazici wrote:
>> Volkan Yazici has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Improve code style
>>
>> Co-authored-by: Andrey Turbanov
>
> te
On Thu, 5 Jun 2025 10:13:24 GMT, Volkan Yazici wrote:
>> Passes the `Charset` read from the `stdin.encoding` system property while
>> creating `InputStreamReader` or `Scanner` instances for `System.in`.
>>
>> `stdin.encoding` is a recently added property for Java 25 in
On Thu, 5 Jun 2025 10:13:24 GMT, Volkan Yazici wrote:
>> Passes the `Charset` read from the `stdin.encoding` system property while
>> creating `InputStreamReader` or `Scanner` instances for `System.in`.
>>
>> `stdin.encoding` is a recently added property for Java 25 in
On Thu, 5 Jun 2025 18:30:40 GMT, Naoto Sato wrote:
>> Changes to generate CLDR resource bundles in UTF-8 encoding. The resource
>> files in `java.base` are supposed to be US English only, but they also need
>> to use UTF-8 as some of the names are non-ASCII (e.g., Türkiye)
>
> Naoto Sato has up
On Fri, 30 May 2025 11:57:39 GMT, Volkan Yazici wrote:
> Reverts certain [JDK-8353197](https://bugs.openjdk.org/browse/JDK-8353197)
> (which implements JavaDoc improvement and precautionary naming for certain
> unsafe methods in `jdk.internal.access.JavaLangAccess`) changes that are
). Employing it
> throughout the entire code base is addressed by the parent ticket
> [JDK-8356893](https://bugs.openjdk.org/browse/JDK-8356893). JDK-8357995 this
> PR is addressing is a sub-task of JDK-8356893 and is concerned with only
> areas related to core libraries.
Volkan Yazici h
On Wed, 4 Jun 2025 21:54:15 GMT, Naoto Sato wrote:
> The resource files in `java.base` are supposed to be US English only, but
> they also need to use UTF-8 as some of the names are non-ASCII (e.g., Türkiye)
@naotoj, shall we add this note as a comment to places where `-utf8` is added?
---
tails on the followed
> evaluation process.
Volkan Yazici has updated the pull request incrementally with one additional
commit since the last revision:
Add `@implSpec`
-
Changes:
- all: https://git.openjdk.org/jdk/pull/25545/files
- new: https://git.openjdk.org/jdk/pull/25545
On Wed, 4 Jun 2025 11:39:34 GMT, Per Minborg wrote:
>>> I wonder if we should add that implementations of the affected method
>>> _shall_ do bounds checking to reduce the likelihood of a new/updated native
>>> implementation miss that?
>>
>> @minborg, would you mind elaborating on this a bit,
On Wed, 4 Jun 2025 06:47:59 GMT, Jaikiran Pai wrote:
> Can I please get a review of this trivial doc-only change to the
> `jdk.zipfs`'s documentation? This moves the `accessMode` property listing to
> the top of the table instead of being at the bottom. With this change, the
> text about throw
On Tue, 3 Jun 2025 16:35:01 GMT, Weijun Wang wrote:
> I’m just not sure if we’ll end up changing the rule again in the future.
> Hardcoding the system property name makes me a bit uneasy, and the default
> fallback being hardcoded as well adds to that concern.
Thanks so much for the review @wa
On Fri, 30 May 2025 11:57:39 GMT, Volkan Yazici wrote:
> Reverts certain [JDK-8353197](https://bugs.openjdk.org/browse/JDK-8353197)
> (which implements JavaDoc improvement and precautionary naming for certain
> unsafe methods in `jdk.internal.access.JavaLangAccess`) changes that are
). Employing it
> throughout the entire code base is addressed by the parent ticket
> [JDK-8356893](https://bugs.openjdk.org/browse/JDK-8356893). JDK-8357995 this
> PR is addressing is a sub-task of JDK-8356893 and is concerned with only
> areas related to core libraries.
Volkan Yazici h
On Mon, 2 Jun 2025 19:27:14 GMT, Chris Plummer wrote:
>> Volkan Yazici has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Clean-up `MultiBreakpointsTarg`
>
> test/jdk/com/sun/jdi/MultiBreakpointsTest.java l
). Employing it
> throughout the entire code base is addressed by the parent ticket
> [JDK-8356893](https://bugs.openjdk.org/browse/JDK-8356893). JDK-8357995 this
> PR is addressing is a sub-task of JDK-8356893 and is concerned with only
> areas related to core libraries.
Volkan Yazici h
On Fri, 30 May 2025 14:23:24 GMT, Alan Bateman wrote:
>> Volkan Yazici has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Provide fallback for `stdin.encoding`
>> - Revert changes to `Application` and
). Employing it
> throughout the entire code base is addressed by the parent ticket
> [JDK-8356893](https://bugs.openjdk.org/browse/JDK-8356893). JDK-8357995 this
> PR is addressing is a sub-task of JDK-8356893 and is concerned with only
> areas related to core libraries.
Volkan Yazici h
On Sun, 1 Jun 2025 20:56:50 GMT, Erik Gahlin wrote:
>> Could I have review of an enhancement that adds rate-limited sampling to
>> Java event, including five events in the JDK (SocketRead, SocketWrite,
>> FileRead, FileWrite, and JavaExceptionThrow).
>>
>> Testing: test/jdk/jdk/jfr
>>
>> Than
On Fri, 30 May 2025 13:44:08 GMT, Weijun Wang wrote:
> Have you thought about creating a helper method for this purpose even if it's
> internal? At least, for the tests you can create one in `/test/lib`.
Required changes are pretty minimal – passing
`System.getProperty("stdin.encoding")` as an
Reverts certain [JDK-8353197](https://bugs.openjdk.org/browse/JDK-8353197)
(which implements JavaDoc improvement and precautionary naming for certain
unsafe methods in `jdk.internal.access.JavaLangAccess`) changes that are found
to be incorrect. See the JBS issue for details on the followed eval
Passes the `Charset` read from the `stdin.encoding` system property while
creating `InputStreamReader` or `Scanner` instances for `System.in`.
`stdin.encoding` is a recently added property for Java 25 in
[JDK-8350703](https://bugs.openjdk.org/browse/JDK-8350703). Employing it
throughout the ent
On Sun, 18 May 2025 11:11:32 GMT, Shaojin Wen wrote:
> When debugging getLong/getDouble/getDecimal of DigitList, the debugger will
> call the DigitList::toString method. At this time, DigitList::toString will
> modify tempBuilder, which will cause incorrect results.
_Nit:_ Would it be an overk
On Wed, 21 May 2025 20:56:31 GMT, Volkan Yazici wrote:
> There are several locations in the JDK source where `System.in` and
> `FileDescriptor.in` is read with `InputStreamReader` and `Scanner` using the
> default charset. As recommended by the recently merged
> [JDK-83
On Wed, 21 May 2025 19:29:08 GMT, Naoto Sato wrote:
>> `java.io.Console` uses the charset specified by the `stdout.encoding` system
>> property for both input and output. While this is generally sufficient,
>> since Console is intended for interactive terminal use, some platforms allow
>> diff
On Wed, 21 May 2025 21:37:07 GMT, Roger Riggs wrote:
>> There are several locations in the JDK source where `System.in` and
>> `FileDescriptor.in` is read with `InputStreamReader` and `Scanner` using the
>> default charset. As recommended by the recently merged
>> [JDK-8356420](https://bugs.op
There are several locations in the JDK source where `System.in` and
`FileDescriptor.in` is read with `InputStreamReader` and `Scanner` using the
default charset. As recommended by the recently merged
[JDK-8356420](https://bugs.openjdk.org/browse/JDK-8356420), this PR replaces
the default charse
On Tue, 20 May 2025 22:04:41 GMT, Naoto Sato wrote:
>> test/jdk/java/io/Console/StdinEncodingTest.java line 46:
>>
>>> 44: * @run junit StdinEncodingTest
>>> 45: */
>>> 46: public class StdinEncodingTest {
>>
>> AFAICT, there is no similar test (e.g., one using a mock `CharsetProvider`)
>> f
On Tue, 20 May 2025 22:04:24 GMT, Naoto Sato wrote:
>> All `FileDescriptor.in` encounters in `jdk.internal.org.jline.terminal` that
>> might need attention:
>>
>> src/jdk.internal.le/share/classes/jdk/internal/org/jline/terminal/impl/DumbTerminalProvider.java
>> src/jdk.internal.le/share/classe
On Tue, 20 May 2025 19:18:43 GMT, Volkan Yazici wrote:
>> src/jdk.internal.le/share/classes/jdk/internal/org/jline/JdkConsoleProviderImpl.java
>> line 160:
>>
>>> 158:
>>> 159: try {
>>> 160: Terminal terminal =
>
On Tue, 20 May 2025 10:40:39 GMT, Volkan Yazici wrote:
>> `java.io.Console` uses the charset specified by the `stdout.encoding` system
>> property for both input and output. While this is generally sufficient,
>> since Console is intended for interactive terminal use, so
On Fri, 16 May 2025 18:11:39 GMT, Naoto Sato wrote:
> `java.io.Console` uses the charset specified by the `stdout.encoding` system
> property for both input and output. While this is generally sufficient, since
> Console is intended for interactive terminal use, some platforms allow
> differen
On Fri, 16 May 2025 16:10:29 GMT, Shaojin Wen wrote:
>> Similar to PR #24982
>> Document preconditions on certain DecimalDigits methods that use operations
>> either unsafe and/or without range checks.
>
> Shaojin Wen has updated the pull request incrementally with one additional
> commit sinc
On Fri, 16 May 2025 09:45:43 GMT, Shaojin Wen wrote:
>> Similar to PR #24982
>> Document preconditions on certain DecimalDigits methods that use operations
>> either unsafe and/or without range checks.
>
> Shaojin Wen has updated the pull request incrementally with two additional
> commits sin
On Thu, 15 May 2025 06:24:44 GMT, Shaojin Wen wrote:
> Similar to PR #24982
> Document preconditions on certain DecimalDigits methods that use operations
> either unsafe and/or without range checks.
src/java.base/share/classes/jdk/internal/util/DecimalDigits.java line 297:
> 295: */
> 29
On Thu, 1 May 2025 05:33:29 GMT, Volkan Yazici wrote:
> Document preconditions on certain `JavaLangAccess` methods that use
> operations either unsafe and/or without range checks.
This pull request has now been integrated.
Changeset: 8fcfddb2
Author:Volkan Yazici
Committer: Chen
On Mon, 12 May 2025 19:42:15 GMT, Volkan Yazici wrote:
>> Document preconditions on certain `JavaLangAccess` methods that use
>> operations either unsafe and/or without range checks.
>
> Volkan Yazici has updated the pull request with a new target base due to a
> m
On Tue, 13 May 2025 15:51:12 GMT, Alan Bateman wrote:
>> Volkan Yazici has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contai
On Tue, 13 May 2025 12:34:01 GMT, Chen Liang wrote:
>> src/java.base/share/classes/java/io/InputStreamReader.java line 59:
>>
>>> 57: * new InputStreamReader(System.in,
>>> System.getProperty("stdin.encoding"));
>>> 58: * }
>>> 59: *
>>
>> There are several places in the sources that st
On Tue, 13 May 2025 03:15:25 GMT, Naoto Sato wrote:
>> With the introduction of `stdin.encoding`
>> ([JDK-8350703](https://bugs.openjdk.org/browse/JDK-8350703)), some guidance
>> for users to decode `System.in` would be desirable. Adding examples in the
>> field description would help.
>
> Nao
On Mon, 12 May 2025 17:07:57 GMT, Roger Riggs wrote:
>> Volkan Yazici has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Prefixed `JavaLangAccess::stringConcat1` with `unchecked`
>> - Fix `HexDigits` co
> Document preconditions on certain `JavaLangAccess` methods that use
> operations either unsafe and/or without range checks.
Volkan Yazici has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
brought in
> Document preconditions on certain `JavaLangAccess` methods that use
> operations either unsafe and/or without range checks.
Volkan Yazici has updated the pull request incrementally with one additional
commit since the last revision:
Apply suggestions from code review
Co-autho
On Mon, 12 May 2025 08:52:00 GMT, Jaikiran Pai wrote:
>> Volkan Yazici has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix copyright years
>
> src/java.base/share/classes/jdk/internal/access/JavaLangA
> Document preconditions on certain `JavaLangAccess` methods that use
> operations either unsafe and/or without range checks.
Volkan Yazici has updated the pull request incrementally with two additional
commits since the last revision:
- Prefixed `JavaLangAccess::stringConcat1
On Thu, 8 May 2025 14:51:48 GMT, Chen Liang wrote:
>> Volkan Yazici has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Prefix touched methods with `unchecked`
>
> Let's re-approve after copyright fix
> Document preconditions on certain `JavaLangAccess` methods that use
> operations either unsafe and/or without range checks.
Volkan Yazici has updated the pull request incrementally with one additional
commit since the last revision:
Fix copyright years
-
Changes:
On Thu, 8 May 2025 14:46:29 GMT, Chen Liang wrote:
>> Volkan Yazici has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Prefix touched methods with `unchecked`
>
> src/java.base/share/classes/java/io/DataIn
On Wed, 7 May 2025 07:52:37 GMT, Alan Bateman wrote:
>> Volkan Yazici has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix typo in pre-existing JavaDoc
>
> src/java.base/share/classes/jdk/internal/acces
> Document preconditions on certain `JavaLangAccess` methods that use
> operations either unsafe and/or without range checks.
Volkan Yazici has updated the pull request incrementally with one additional
commit since the last revision:
Prefix touched methods with `unc
On Wed, 7 May 2025 13:22:11 GMT, Raffaello Giulietti
wrote:
>> src/java.base/share/classes/jdk/internal/access/JavaLangAccess.java line 355:
>>
>>> 353: * UTF-16 representation.
>>> 354: *
>>> 355: * WARNING: This method does not perform any bound checks.
>>
>> Maybe not this P
On Wed, 7 May 2025 07:37:48 GMT, Alan Bateman wrote:
>> Volkan Yazici has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix typo in pre-existing JavaDoc
>
> src/java.base/share/classes/jdk/internal/acces
On Thu, 1 May 2025 13:00:37 GMT, Chen Liang wrote:
>> Volkan Yazici has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix typo in pre-existing JavaDoc
>
> src/java.base/share/classes/jdk/internal/acces
On Fri, 2 May 2025 14:39:55 GMT, Roger Riggs wrote:
>> Volkan Yazici has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix typo in pre-existing JavaDoc
>
> src/java.base/share/classes/jdk/internal/acces
On Wed, 7 May 2025 07:26:56 GMT, Volkan Yazici wrote:
>> Document preconditions on certain `JavaLangAccess` methods that use
>> operations either unsafe and/or without range checks.
>
> Volkan Yazici has updated the pull request incrementally with one additional
>
> Document preconditions on certain `JavaLangAccess` methods that use
> operations either unsafe and/or without range checks.
Volkan Yazici has updated the pull request incrementally with one additional
commit since the last revision:
Fix typo in pre-existing JavaDoc
-
C
Document preconditions on certain `JavaLangAccess` methods that use operations
either unsafe and/or without range checks.
-
Commit messages:
- Improve `JavaLangAccess` documentation
Changes: https://git.openjdk.org/jdk/pull/24982/files
Webrev: https://webrevs.openjdk.org/?repo=jd
On Wed, 30 Apr 2025 06:46:07 GMT, Volkan Yazici wrote:
> Replace manual bitwise operations in `hashCode` implementations of
> `java.time` with `Long::hashCode`.
This pull request has now been integrated.
Changeset: 18983b63
Author:Volkan Yazici
Committer: Naoto Sato
URL:
On Wed, 30 Apr 2025 15:01:08 GMT, Roger Riggs wrote:
>> Replace manual bitwise operations in `hashCode` implementations of
>> `java.time` with `Long::hashCode`.
>
> lgtm
@RogerRiggs, @minborg, @naotoj, thanks for the reviews. I've attached
successful `tier1,2` results to the ticket. I'd apprec
Replace manual bitwise operations in `hashCode` implementations of `java.time`
with `Long::hashCode`.
-
Commit messages:
- Use `Long::hashCode`
Changes: https://git.openjdk.org/jdk/pull/24959/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=24959&range=00
Issue: https://b
On Thu, 24 Apr 2025 00:33:20 GMT, Brian Burkhalter wrote:
> For tests of the `java.io` package, instead of doing this
>
> public static void main(String[] args) throws Exception {
> if (File.separatorChar != '\') {
> /* This test is only valid on win32 systems */
>
On Sat, 1 Mar 2025 07:50:44 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this doc-only change which proposes to improve
>> the API documentation of `DeflaterInputStream`, `DeflaterOutputStream`,
>> `InflaterInputStream` and `InflaterOutputStream` classes?
>>
>> As noted in https://
On Fri, 31 Jan 2025 19:42:55 GMT, Volkan Yazici wrote:
> Adds `test.lib.Utils::createTempFileOfSize` to generate
> `test/jdk/com/sun/net/httpserver/docs` contents at runtime. This directory
> contains `largefile.txt` of size 2.6MiB showing up as the 4th largest file
> tr
On Tue, 4 Feb 2025 14:26:23 GMT, Volkan Yazici wrote:
>> Adds `test.lib.Utils::createTempFileOfSize` to generate
>> `test/jdk/com/sun/net/httpserver/docs` contents at runtime. This directory
>> contains `largefile.txt` of size 2.6MiB showing up as the 4th largest file
On Tue, 4 Feb 2025 10:47:22 GMT, Daniel Fuchs wrote:
>> Volkan Yazici has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Assert that multiple files can be served using the same
>> `FileServerHandler`
On Tue, 4 Feb 2025 14:15:00 GMT, Daniel Fuchs wrote:
>> Volkan Yazici has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Replace `assert`s with conditionally thrown exceptions
>
> test/jdk/java/net/httpclient/
malizationTest.txt
> 3574947 test/jdk/java/foreign/libTestDowncallStack.c
> 7128495 test/jdk/java/foreign/libTestUpcallStack.c
>
>
> **Other highlights:**
>
> - `jdk.httpclient.test.lib.common.TestUtil` is removed in favor of similar
> alternatives in `test.lib.Utils` and `te
On Tue, 4 Feb 2025 10:46:33 GMT, Daniel Fuchs wrote:
>> Volkan Yazici has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Assert that multiple files can be served using the same
>> `FileServerHandler`
1 - 100 of 106 matches
Mail list logo
