On Wed, 11 Jun 2025 08:30:18 GMT, Christian Stein wrote:
>> Please review this fix to correctly parse tokens in an argument file that
>> contains trailing comments without preceding whitespace characters before
>> the '#' comment marker, the number sign.
>>
>> The specifaction of the `java` Co
On Mon, 2 Jun 2025 13:46:23 GMT, Christian Stein wrote:
> Please review this fix to correctly parse tokens in an argument file that
> contains trailing comments without preceding whitespace characters before the
> '#' comment marker, the number sign.
>
> The specifaction of the `java` Command
On Mon, 2 Jun 2025 13:48:23 GMT, Christian Stein wrote:
>> Please review this fix to correctly parse tokens in an argument file that
>> contains trailing comments without preceding whitespace characters before
>> the '#' comment marker, the number sign.
>>
>> The specifaction of the `java` Com
On Fri, 18 Apr 2025 00:06:26 GMT, Vicente Romero wrote:
> This PR is defining a new internal annotation,
> `@jdk.internal.RequiresIdentity`, with target types PARAMETER and
> TYPE_PARAMETER. The @RequiresIdentity annotation expresses the expectation
> that an argument to a giv
On Mon, 19 May 2025 14:35:40 GMT, Vicente Romero wrote:
>> This PR is defining a new internal annotation,
>> `@jdk.internal.RequiresIdentity`, with target types PARAMETER and
>> TYPE_PARAMETER. The @RequiresIdentity annotation expresses the expectation
>> that an argum
On Mon, 19 May 2025 14:35:40 GMT, Vicente Romero wrote:
>> This PR is defining a new internal annotation,
>> `@jdk.internal.RequiresIdentity`, with target types PARAMETER and
>> TYPE_PARAMETER. The @RequiresIdentity annotation expresses the expectation
>> that an argum
[1] https://bugs.openjdk.org/browse/JDK-8354556
Vicente Romero has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains 39 commits:
- Merge branch 'master' into JDK-8354556
- review comments
- addressing review comments
- addressing r
[1] https://bugs.openjdk.org/browse/JDK-8354556
Vicente Romero has updated the pull request incrementally with one additional
commit since the last revision:
review comments
-
Changes:
- all: https://git.openjdk.org/jdk/pull/24746/files
- new: https://git.openjdk.org/jdk/pull/
On Fri, 16 May 2025 11:54:07 GMT, Jan Lahoda wrote:
>> A consider class like this:
>>
>>
>> public class TwoMains {
>> private static void main(String... args) {}
>> static void main() {
>> System.out.println("Should be called, but is not.");
>> }
>> }
>>
>>
>> The `Method
On Fri, 16 May 2025 11:12:08 GMT, Jan Lahoda wrote:
>> A consider class like this:
>>
>>
>> public class TwoMains {
>> private static void main(String... args) {}
>> static void main() {
>> System.out.println("Should be called, but is not.");
>> }
>> }
>>
>>
>> The `Method
[1] https://bugs.openjdk.org/browse/JDK-8354556
Vicente Romero has updated the pull request incrementally with one additional
commit since the last revision:
addressing review comments
-
Changes:
- all: https://git.openjdk.org/jdk/pull/24746/files
- new: https://git.openjdk.org/
On Wed, 14 May 2025 18:27:18 GMT, Jan Lahoda wrote:
>> Vicente Romero has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 34 commits:
>>
>> - Merge branch 'master' into JDK-8354556
>> - Updat
[1] https://bugs.openjdk.org/browse/JDK-8354556
Vicente Romero has updated the pull request incrementally with one additional
commit since the last revision:
addressing review comments
-
Changes:
- all: https://git.openjdk.org/jdk/pull/24746/files
- new: https://git.openjdk.org/
On Wed, 14 May 2025 18:25:26 GMT, Jan Lahoda wrote:
>> Vicente Romero has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 34 commits:
>>
>> - Merge branch 'master' into JDK-8354556
>> - Updat
On Wed, 14 May 2025 18:23:09 GMT, Jan Lahoda wrote:
>> Vicente Romero has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 34 commits:
>>
>> - Merge branch 'master' into JDK-8354556
>> - Updat
[1] https://bugs.openjdk.org/browse/JDK-8354556
Vicente Romero has updated the pull request incrementally with one additional
commit since the last revision:
update warning message
-
Changes:
- all: https://git.openjdk.org/jdk/pull/24746/files
- new: https://git.openjdk.org/
On Fri, 18 Apr 2025 02:25:24 GMT, Chen Liang wrote:
>> Vicente Romero has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 34 commits:
>>
>> - Merge branch 'master' into JDK-8354556
>> - Updat
[1] https://bugs.openjdk.org/browse/JDK-8354556
Vicente Romero has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains 34 commits:
- Merge branch 'master' into JDK-8354556
- Update src/jdk.compiler/share/classes/com/sun/tools/javac
On Sat, 10 May 2025 20:38:36 GMT, Archie Cobbs wrote:
> FYI, this issue now effectively fixes [JDK-7004476 Lint.LintCategory should
> support aliases](https://bugs.openjdk.org/browse/JDK-7004476), which happened
> to be closed as "Rejected" on Monday. Not sure if anything needs to be done.
I g
On Sat, 10 May 2025 19:36:52 GMT, Chen Liang wrote:
> As much as I dislike streams, I think we will probably keep them for their
> conciseness except this one, which made things less concise.
thanks! committed
-
PR Comment: https://git.openjdk.org/jdk/pull/24746#issuecomment-28691
[1] https://bugs.openjdk.org/browse/JDK-8354556
Vicente Romero has updated the pull request incrementally with one additional
commit since the last revision:
Update src/jdk.compiler/share/classes/com/sun/tools/javac/code/Lint.java
Co-authored-by: Chen Liang
-
Changes:
- all:
On Sat, 10 May 2025 16:03:37 GMT, Vicente Romero wrote:
> > heh, I was doing the same, thanks anyway :)
>
> Awesome, thanks!
>
> Apologies for the mid-air collision :) I've merged your latest merge into my
> merge, leaving just a few minor fixes.
thanks!
--
[1] https://bugs.openjdk.org/browse/JDK-8354556
Vicente Romero has updated the pull request incrementally with two additional
commits since the last revision:
- additional changes from Archie
- removing dead code
-
Changes:
- all: https://git.openjdk.org/jdk/pull/24746/files
- new:
On Sat, 10 May 2025 15:31:45 GMT, Vicente Romero wrote:
>> This PR is defining a new internal annotation,
>> `@jdk.internal.RequiresIdentity`, with target types PARAMETER and
>> TYPE_PARAMETER. The @RequiresIdentity annotation expresses the expectation
>> that an argum
On Sat, 10 May 2025 15:31:45 GMT, Vicente Romero wrote:
>> This PR is defining a new internal annotation,
>> `@jdk.internal.RequiresIdentity`, with target types PARAMETER and
>> TYPE_PARAMETER. The @RequiresIdentity annotation expresses the expectation
>> that an argum
On Sat, 10 May 2025 15:41:18 GMT, Archie Cobbs wrote:
> > heh, I was doing the same, thanks anyway :)
>
> Awesome, thanks!
>
> Apologies for the mid-air collision :) I've merged your latest merge into my
> merge, leaving just a few minor fixes.
thanks!
-
PR Comment: https://git.
On Sat, 10 May 2025 15:31:17 GMT, Chen Liang wrote:
>> Vicente Romero has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> fixing bugs, removing dead code
>
> Thanks. Looks good, but the Lint to all option name
[1] https://bugs.openjdk.org/browse/JDK-8354556
Vicente Romero has updated the pull request incrementally with one additional
commit since the last revision:
integrating code from Archie
-
Changes:
- all: https://git.openjdk.org/jdk/pull/24746/files
- new: https://git.openjdk.org/
help
>> review; just remember to @liach.
>
>> Sure, I think vicente is open to patches and PRs to his fork. And I can help
>> review; just remember to @liach.
>
> OK thanks. I've rebased my changes on @vicente-romero-oracle's branch to
> simply any evalu
On Thu, 8 May 2025 18:55:34 GMT, Vicente Romero wrote:
>> Vicente Romero has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 26 commits:
>>
>> - Merge branch 'master' into JDK-8354556
>> - ad
On Fri, 9 May 2025 20:43:46 GMT, Chen Liang wrote:
>> Vicente Romero has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> fixing bugs, removing dead code
>
> make/langtools/src/classes/build/tools/symbolgenera
[1] https://bugs.openjdk.org/browse/JDK-8354556
Vicente Romero has updated the pull request incrementally with one additional
commit since the last revision:
fixing bugs, removing dead code
-
Changes:
- all: https://git.openjdk.org/jdk/pull/24746/files
- new: https://git.op
[1] https://bugs.openjdk.org/browse/JDK-8354556
Vicente Romero has updated the pull request incrementally with one additional
commit since the last revision:
additional documentation changes and bug fixes
-
Changes:
- all: https://git.openjdk.org/jdk/pull/24746/files
- new: https
[1] https://bugs.openjdk.org/browse/JDK-8354556
Vicente Romero has updated the pull request incrementally with one additional
commit since the last revision:
documentation and adding alias to lint categories
-
Changes:
- all: https://git.openjdk.org/jdk/pull/24746/files
- new: https
On Thu, 8 May 2025 13:33:45 GMT, Vicente Romero wrote:
>> This PR is defining a new internal annotation,
>> `@jdk.internal.RequiresIdentity`, with target types PARAMETER and
>> TYPE_PARAMETER. The @RequiresIdentity annotation expresses the expectation
>> that an argum
[1] https://bugs.openjdk.org/browse/JDK-8354556
Vicente Romero has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains 26 commits:
- Merge branch 'master' into JDK-8354556
- addressing review comment
- changes to test
- Merge branch &#
[1] https://bugs.openjdk.org/browse/JDK-8354556
Vicente Romero has updated the pull request incrementally with one additional
commit since the last revision:
addressing review comment
-
Changes:
- all: https://git.openjdk.org/jdk/pull/24746/files
- new: https://git.openjdk.org/
On Mon, 5 May 2025 09:40:16 GMT, Yudi Zheng wrote:
>> Vicente Romero has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> changes to test
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/code/Type.jav
[1] https://bugs.openjdk.org/browse/JDK-8354556
Vicente Romero has updated the pull request incrementally with one additional
commit since the last revision:
changes to test
-
Changes:
- all: https://git.openjdk.org/jdk/pull/24746/files
- new: https://git.openjdk.org/jdk/pull/
[1] https://bugs.openjdk.org/browse/JDK-8354556
Vicente Romero has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains 23 commits:
- Merge branch 'master' into JDK-8354556
- updating test
- final adjustments
- additional refactorings
[1] https://bugs.openjdk.org/browse/JDK-8354556
Vicente Romero has updated the pull request incrementally with one additional
commit since the last revision:
updating test
-
Changes:
- all: https://git.openjdk.org/jdk/pull/24746/files
- new: https://git.openjdk.org/jdk/pull/
On Thu, 1 May 2025 17:48:22 GMT, Jan Lahoda wrote:
>> This is a PR that implements JEP: Compact Source Files and Instance Main
>> Methods. Changes include:
>> - `java.io.IO` moved to `java.lang.IO`, and no longer uses
>> `System.console()` to implement the methods (thanks to @stuart-marks)
>> -
messages:
- final adjustments
- additional refactorings
- removing unneeded changes
- more refactorings
- more refactorings and tests
- refactoring
- refactoring
- covering more cases plus refactoring in order to simplify the code
- Merge branch 'JDK-8354556' of https://github.c
On Fri, 18 Apr 2025 02:32:06 GMT, Chen Liang wrote:
>> This PR is defining a new internal annotation,
>> `@jdk.internal.RequiresIdentity`, with target types PARAMETER and
>> TYPE_PARAMETER. The @RequiresIdentity annotation expresses the expectation
>> that an argument to a given method or cons
On Wed, 30 Apr 2025 18:03:29 GMT, Chen Liang wrote:
>> A prerequisite to #24760; this was part of it, but was split out to simplify
>> the review of the addition of `maskToAccessFlags(int, Location, CFFV)` by
>> minimizing the changes in javap. That patch will only need to update
>> `BasicWrit
On Mon, 28 Apr 2025 13:26:30 GMT, Jan Lahoda wrote:
>> This is a patch to finalize the module imports feature. Please see:
>> https://bugs.openjdk.org/browse/JDK-8344700
>
> Jan Lahoda has updated the pull request with a new target base due to a merge
> or a rebase. The pull request now contains
On Thu, 10 Apr 2025 01:03:01 GMT, Jan Lahoda wrote:
>> This is a PR that implements JEP: Compact Source Files and Instance Main
>> Methods. Changes include:
>> - `java.io.IO` moved to `java.lang.IO`, and no longer uses
>> `System.console()` to implement the methods (thanks to @stuart-marks)
>>
On Fri, 11 Apr 2025 11:20:30 GMT, Jan Lahoda wrote:
>> This is a patch to finalize the module imports feature. Please see:
>> https://bugs.openjdk.org/browse/JDK-8344700
>
> Jan Lahoda has updated the pull request with a new target base due to a merge
> or a rebase. The incremental webrev exclud
On Wed, 9 Apr 2025 15:04:24 GMT, Chen Liang wrote:
>> With all dependencies of com.sun.tools.classfile in the JDK converted to the
>> ClassFile API, we can remove this legacy library for release 25 like how we
>> removed ASM.
>>
>> Testing: built locally, running tier 1-3 tests
>>
>> Don't kn
On Mon, 7 Apr 2025 18:13:29 GMT, Jan Lahoda wrote:
>> This is a PR that implements JEP: Compact Source Files and Instance Main
>> Methods. Changes include:
>> - `java.io.IO` moved to `java.lang.IO`, and no longer uses
>> `System.console()` to implement the methods (thanks to @stuart-marks)
>> -
On Wed, 2 Apr 2025 16:59:16 GMT, Jan Lahoda wrote:
>> This is a patch to finalize the module imports feature. Please see:
>> https://bugs.openjdk.org/browse/JDK-8344700
>
> Jan Lahoda has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Reflecti
On Mon, 31 Mar 2025 17:40:25 GMT, Jan Lahoda wrote:
>> This is a patch to finalize the module imports feature. Please see:
>> https://bugs.openjdk.org/browse/JDK-8344700
>
> Jan Lahoda has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Fixing
On Wed, 26 Feb 2025 13:50:52 GMT, Jan Lahoda wrote:
> This is a patch to finalize the module imports feature. Please see:
> https://bugs.openjdk.org/browse/JDK-8344700
looks sensible
test/langtools/tools/javac/modules/EdgeCases.java line 1190:
> 1188:
> 1189: List expected = List.of(
On Wed, 18 Dec 2024 10:00:53 GMT, Jan Lahoda wrote:
> Hi all,
>
> This pull request contains a backport of commit
> [d50b725a](https://github.com/openjdk/jdk/commit/d50b725ac0f228f5b04dd68c123c7f6b263c0d02)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
> The commit being
On Wed, 13 Nov 2024 12:33:16 GMT, Jan Lahoda wrote:
>> This is a current patch for module imports declarations, second preview. At
>> least the JEP number and preview revision will need to be updated in
>> `jdk.internal.javac.PreviewFeature.Feature`, but otherwise I believe this is
>> ready to
On Tue, 5 Nov 2024 19:51:04 GMT, Vicente Romero wrote:
> Javac is not issuing a mandated unchecked cast warning for code like:
>
>
> import java.lang.invoke.VarHandle;
>
> class VarHandleCast {
> VarHandle vh;
> V method(Object obj) {
> retur
is what this
> PR is fixing
>
> TIA
>
> Note: I had to add some annotations to suppress warnings in java.base that
> were not being issued before due to the javac bug
Vicente Romero has updated the pull request incrementally with one additional
commit since the last revision:
is what this
> PR is fixing
>
> TIA
>
> Note: I had to add some annotations to suppress warnings in java.base that
> were not being issued before due to the javac bug
Vicente Romero has updated the pull request incrementally with one additional
commit since the last revision:
is what this
> PR is fixing
>
> TIA
>
> Note: I had to add some annotations to suppress warnings in java.base that
> were not being issued before due to the javac bug
Vicente Romero has updated the pull request incrementally with one additional
commit since the last revision:
is what this
> PR is fixing
>
> TIA
>
> Note: I had to add some annotations to suppress warnings in java.base that
> were not being issued before due to the javac bug
Vicente Romero has updated the pull request with a new target base due to a
merge or a rebase. The incremental w
On Mon, 4 Nov 2024 18:30:50 GMT, Nizar Benalla wrote:
>> Can I get a review for this patch that adds `@since` checker tests to the
>> following modules: java.compiler, jdk.compiler, jdk.javadoc and jdk.jdeps.
>> The initial test for `java.base` has been integrated in
>> [JDK-8331051](https://b
is what this
> PR is fixing
>
> TIA
>
> Note: I had to add some annotations to suppress warnings in java.base that
> were not being issued before due to the javac bug
Vicente Romero has updated the pull request with a new target base due to a
merge or a rebase. The incremental we
On Thu, 7 Nov 2024 13:59:03 GMT, Maurizio Cimadamore
wrote:
> Changes look good. The extra suppress warnings seem to indicate that the
> logic is now working as intended :-)
thanks for the review. As suggested above I created a CSR, could you please
review it too? Thanks!
-
PR C
is what this
> PR is fixing
>
> TIA
>
> Note: I had to add some annotations to suppress warnings in java.base that
> were not being issued before due to the javac bug
Vicente Romero has updated the pull request with a new target base due to a
merge or a rebase. The incremental we
Javac is not issuing a mandated unchecked cast warning for code like:
import java.lang.invoke.VarHandle;
class VarHandleCast {
VarHandle vh;
V method(Object obj) {
return (V)vh.getAndSet(this, obj);
}
}
according to the spec the return type inferred for this method poly
On Mon, 4 Nov 2024 22:23:50 GMT, Liam Miller-Cushon wrote:
>> This change fixes a bug preventing javac from emitting
>> 'compiler.warn.sun.proprietary' diagnostics if `--system` is set to a
>> non-default value. The diagnostics are currently emitted for values of
>> `--release`, and for the de
On Tue, 5 Nov 2024 01:03:14 GMT, Liam Miller-Cushon wrote:
>> lgtm
>
> @vicente-romero-oracle could you please take another look?
>
> I was preparing to integrate this, and the latest merge includes one new
> benchmark that requires another update:
> https://github.co
On Mon, 15 Apr 2024 19:01:08 GMT, Joe Darcy wrote:
> Get JDK 24 underway.
lgtm
-
Marked as reviewed by vromero (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/18787#pullrequestreview-2004323374
On Mon, 21 Oct 2024 14:49:34 GMT, Aggelos Biboudis
wrote:
>> After doing a build + bootcycle build confirms that these constants can be
>> removed.
>
> Aggelos Biboudis has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Update src/java.base/
On Fri, 4 Oct 2024 00:02:52 GMT, Liam Miller-Cushon wrote:
>> This change fixes a bug preventing javac from emitting
>> 'compiler.warn.sun.proprietary' diagnostics if `--system` is set to a
>> non-default value. The diagnostics are currently emitted for values of
>> `--release`, and for the de
On Mon, 14 Oct 2024 12:46:29 GMT, Jan Lahoda wrote:
>> This is a current patch for module imports declarations, second preview. At
>> least the JEP number and preview revision will need to be updated in
>> `jdk.internal.javac.PreviewFeature.Feature`, but otherwise I believe this is
>> ready to
On Wed, 17 Jul 2024 08:59:07 GMT, Adam Sotona wrote:
>> Class-File API is leaving preview.
>> This is a removal of all `@PreviewFeature` annotations from Class-File API.
>> It also bumps all `@since` tags and removes
>> `jdk.internal.javac.PreviewFeature.Feature.CLASSFILE_API`.
>>
>> Please rev
On Mon, 11 Dec 2023 23:33:16 GMT, Vicente Romero wrote:
> Reflection is not retrieving generic type information for mandated
> parameters. This is a known issue which has been explicitly stated in the API
> of some reflection methods. Fix for
> [JDK-8292275](https://bugs.openjd
e
> information for mandated parameters if available plus changing the spec of
> the related reflection methods.
>
> TIA
Vicente Romero has updated the pull request incrementally with one additional
commit since the last revision:
fixing lines length
-
Changes:
- al
e
> information for mandated parameters if available plus changing the spec of
> the related reflection methods.
>
> TIA
Vicente Romero has updated the pull request incrementally with one additional
commit since the last revision:
more review comments
-
Changes:
- al
e
> information for mandated parameters if available plus changing the spec of
> the related reflection methods.
>
> TIA
Vicente Romero has updated the pull request incrementally with one additional
commit since the last revision:
addressing review comments
-
Changes:
e
> information for mandated parameters if available plus changing the spec of
> the related reflection methods.
>
> TIA
Vicente Romero has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
brought in by th
On Tue, 12 Dec 2023 22:21:29 GMT, Joe Darcy wrote:
>> Vicente Romero has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> fixing comment
>
> As the core reflection code will encounter record classes compiled
On Mon, 29 Apr 2024 20:17:29 GMT, Joe Darcy wrote:
>> Vicente Romero has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> minor refactoring
>
> test/jdk/java/lang/reflect/records/R10.jcod line 1:
>
>&
e
> information for mandated parameters if available plus changing the spec of
> the related reflection methods.
>
> TIA
Vicente Romero has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
brought in by th
On Mon, 6 May 2024 16:07:26 GMT, Adam Sotona wrote:
>> Hi,
>> During performance optimization work on Class-File API as JDK lambda
>> generator we found some static initialization killers.
>> One of them is `java.lang.classfile.Attributes` with tens of static fields
>> initialized with individu
e
> information for mandated parameters if available plus changing the spec of
> the related reflection methods.
>
> TIA
Vicente Romero has updated the pull request incrementally with one additional
commit since the last revision:
minor refactoring
-
Changes:
- all: htt
On Sat, 27 Apr 2024 00:14:23 GMT, Chen Liang wrote:
>> Vicente Romero has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> code refactoring
>
> src/java.base/share/classes/java/lang/reflect/Execu
e
> information for mandated parameters if available plus changing the spec of
> the related reflection methods.
>
> TIA
Vicente Romero has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
brought in by th
e
> information for mandated parameters if available plus changing the spec of
> the related reflection methods.
>
> TIA
Vicente Romero has updated the pull request incrementally with one additional
commit since the last revision:
code refactoring
-
Changes:
- all: htt
On Fri, 26 Apr 2024 21:27:55 GMT, Chen Liang wrote:
>> Vicente Romero has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> special case the new code for records only
>
> src/java.base/share/classes/java/lang/re
e
> information for mandated parameters if available plus changing the spec of
> the related reflection methods.
>
> TIA
Vicente Romero has updated the pull request incrementally with one additional
commit since the last revision:
additional tests
-
Changes:
- all: htt
e
> information for mandated parameters if available plus changing the spec of
> the related reflection methods.
>
> TIA
Vicente Romero has updated the pull request incrementally with one additional
commit since the last revision:
special case the new code for records onl
e
> information for mandated parameters if available plus changing the spec of
> the related reflection methods.
>
> TIA
Vicente Romero has updated the pull request incrementally with one additional
commit since the last revision:
adding more tests
-
Changes:
- all: htt
On Thu, 25 Apr 2024 23:24:07 GMT, Jonathan Gibbons wrote:
>> Please review the updates to support a proposed new
>> `-Xlint:dangling-doc-comments` option.
>>
>> The work can be thought of as in 3 parts:
>>
>> 1. An update to the `javac` internal class `DeferredLintHandler` so that it
>> is po
On Wed, 24 Apr 2024 15:00:34 GMT, Vicente Romero wrote:
>> Vicente Romero has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> adding comment to jcod file
>
> test
> Will this fix be backported to JDK 21?
e
> information for mandated parameters if available plus changing the spec of
> the related reflection methods.
>
> TIA
Vicente Romero has updated the pull request incrementally with one additional
commit since the last revision:
Update test/jdk/java/lang/reflect/records/RecordReflec
e
> information for mandated parameters if available plus changing the spec of
> the related reflection methods.
>
> TIA
Vicente Romero has updated the pull request incrementally with one additional
commit since the last revision:
making the javadoc less general
-
Chan
e
> information for mandated parameters if available plus changing the spec of
> the related reflection methods.
>
> TIA
Vicente Romero has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
brought in by th
On Thu, 14 Dec 2023 04:00:58 GMT, Vicente Romero wrote:
>> Reflection is not retrieving generic type information for mandated
>> parameters. This is a known issue which has been explicitly stated in the
>> API of some reflection methods. Fix for
>> [JDK-8292275](
On Fri, 19 Apr 2024 13:17:18 GMT, Jan Lahoda wrote:
>> This is an implementation of JEP JDK-8315129: Module Import Declarations
>> (Preview). Please see the JEP for details:
>> https://bugs.openjdk.org/browse/JDK-8315129
>>
>> It is mostly straightforward - the module imports are parsed, and th
On Thu, 18 Apr 2024 12:11:19 GMT, Jan Lahoda wrote:
>> This is an implementation of JEP JDK-8315129: Module Import Declarations
>> (Preview). Please see the JEP for details:
>> https://bugs.openjdk.org/browse/JDK-8315129
>>
>> It is mostly straightforward - the module imports are parsed, and th
On Mon, 15 Apr 2024 19:01:08 GMT, Joe Darcy wrote:
> Get JDK 24 underway.
lgtm
-
Marked as reviewed by vromero (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/18787#pullrequestreview-2004323374
On Tue, 9 Apr 2024 09:28:23 GMT, Jan Lahoda wrote:
>> This is a patch for javac, that adds the Derived Record Creation
>> expressions. The current draft specification for the feature is:
>> https://cr.openjdk.org/~gbierman/jep468/jep468-20240326/specs/derived-record-creation-jls.html
>>
>> The
On Mon, 8 Apr 2024 16:21:19 GMT, Jan Lahoda wrote:
>> This is a patch for javac, that adds the Derived Record Creation
>> expressions. The current draft specification for the feature is:
>> https://cr.openjdk.org/~gbierman/jep468/jep468-20240326/specs/derived-record-creation-jls.html
>>
>> The
1 - 100 of 214 matches
Mail list logo
