On Fri, 9 May 2025 20:05:10 GMT, Weijun Wang wrote:
>> Finalize the KDF API.
>
> Weijun Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> new algorithms in SunJCE
Updates look good. Thanks~
-
Marked as reviewed by valeriep
On Fri, 2 May 2025 18:49:34 GMT, Weijun Wang wrote:
>> Finalize the KDF API.
>
> Weijun Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> fine tuning debug log and exception message
Looks good.
-
Marked as reviewed by vale
On Fri, 2 May 2025 18:49:34 GMT, Weijun Wang wrote:
>> Finalize the KDF API.
>
> Weijun Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> fine tuning debug log and exception message
test/jdk/com/sun/crypto/provider/KDF/HKDFSaltIKMTest.j
On Thu, 19 Dec 2024 12:33:40 GMT, Weijun Wang wrote:
>> `Asserts.assertNotEquals` shows "expected 12345 to not equal 12345" which
>> sounds redundant, just say "expected not equals but was 12345".
>>
>> `Asserts.assertEqualsByteArray` uses the words "expected... to equal...".
>> Modify it to f
On Thu, 19 Dec 2024 12:26:12 GMT, Weijun Wang wrote:
>> test/lib/jdk/test/lib/Asserts.java line 448:
>>
>>> 446: if ((unexpected == actual) || (unexpected != null &&
>>> unexpected.equals(actual))) {
>>> 447: msg = Objects.toString(msg, "assertNotEquals")
>>> 448:
On Wed, 18 Dec 2024 14:00:53 GMT, Weijun Wang wrote:
>> `Asserts.assertNotEquals` shows "expected 12345 to not equal 12345" which
>> sounds redundant, just say "expected not equals but was 12345".
>>
>> `Asserts.assertEqualsByteArray` uses the words "expected... to equal...".
>> Modify it to f
On Wed, 18 Dec 2024 14:00:53 GMT, Weijun Wang wrote:
>> `Asserts.assertNotEquals` shows "expected 12345 to not equal 12345" which
>> sounds redundant, just say "expected not equals but was 12345".
>>
>> `Asserts.assertEqualsByteArray` uses the words "expected... to equal...".
>> Modify it to f
On Wed, 18 Dec 2024 13:56:14 GMT, Weijun Wang wrote:
>> Also, it's not about "the same byte array", but more like "the same bytes"
>> or have equal values, right? This applies to other methods as well.
>
> Correct, I'll fix.
>
> As for its usages (in `ML_KEM_Test.java` etc), I'll be happy to fi
On Wed, 18 Dec 2024 02:16:55 GMT, Valerie Peng wrote:
>> Weijun Wang has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contain
On Tue, 17 Dec 2024 15:07:26 GMT, Weijun Wang wrote:
>> `Asserts.assertNotEquals` shows "expected 12345 to not equal 12345" which
>> sounds redundant, just say "expected not equals but was 12345".
>>
>> `Asserts.assertEqualsByteArray` uses the words "expected... to equal...".
>> Modify it to f
On Fri, 20 Sep 2024 00:33:39 GMT, Weijun Wang wrote:
> `Asserts.assertNotEquals` shows "expected 12345 to not equal 12345" which
> sounds redundant, just say "expected not equals but was 12345".
>
> `Asserts.assertEqualsByteArray` uses the words "expected... to equal...".
> Modify it to follow
On Fri, 20 Sep 2024 00:33:39 GMT, Weijun Wang wrote:
> `Asserts.assertNotEquals` shows "expected 12345 to not equal 12345" which
> sounds redundant, just say "expected not equals but was 12345".
>
> `Asserts.assertEqualsByteArray` uses the words "expected... to equal...".
> Modify it to follow
On Fri, 14 Jun 2024 10:39:45 GMT, Ferenc Rakoczi wrote:
>> This PR removes some unnecessary conversions between byte arrays and long
>> arrays during SHA3 digest computations.
>
> Ferenc Rakoczi has updated the pull request incrementally with one additional
> commit since the last revision:
>
On Fri, 14 Jun 2024 10:39:45 GMT, Ferenc Rakoczi wrote:
>> This PR removes some unnecessary conversions between byte arrays and long
>> arrays during SHA3 digest computations.
>
> Ferenc Rakoczi has updated the pull request incrementally with one additional
> commit since the last revision:
>
On Fri, 14 Jun 2024 09:47:31 GMT, Ferenc Rakoczi wrote:
>> src/java.base/share/classes/sun/security/provider/SHA3.java line 73:
>>
>>> 71: // The following array is allocated to size WIDTH bytes, but we only
>>> 72: // ever use the first blockSize bytes it (for bytes <-> long
>>> conver
On Wed, 12 Jun 2024 14:08:43 GMT, Ferenc Rakoczi wrote:
>> This PR removes some unnecessary conversions between byte arrays and long
>> arrays during SHA3 digest computations.
>
> Ferenc Rakoczi has updated the pull request incrementally with one additional
> commit since the last revision:
>
On Sat, 17 Feb 2024 14:08:12 GMT, Weijun Wang wrote:
>> Many crypto service classes require a `SecureRandom` object at
>> initialization. This test goes through each of them and calculates
>> (generate, encrypt, sign,...) twice with the same `SecureRandom` object and
>> ensures the output is t
On Tue, 13 Feb 2024 22:30:28 GMT, Weijun Wang wrote:
>> Many crypto service classes require a `SecureRandom` object at
>> initialization. This test goes through each of them and calculates
>> (generate, encrypt, sign,...) twice with the same `SecureRandom` object and
>> ensures the output is t
On Tue, 13 Feb 2024 22:30:28 GMT, Weijun Wang wrote:
>> Many crypto service classes require a `SecureRandom` object at
>> initialization. This test goes through each of them and calculates
>> (generate, encrypt, sign,...) twice with the same `SecureRandom` object and
>> ensures the output is t
On Tue, 5 Sep 2023 22:49:41 GMT, Erik Joelsson wrote:
> There are a number of files in the `test` directory that have an incorrect
> copyright header, which includes the "classpath" exception text. This patch
> removes that text from all test files that I could find it in. I did this
> using a
On Mon, 3 Jul 2023 17:51:10 GMT, Anthony Scarpino wrote:
>> Hi,
>>
>> I need a code review for moving the contents of the jdk.crypto.ec module
>> into java.base. This moves the SunEC JCE Provider (Elliptic Curve) into
>> java.base. EC has always been separate from the base module/pkg because
On Mon, 26 Jun 2023 22:52:18 GMT, Anthony Scarpino
wrote:
>> Hi,
>>
>> I need a code review for moving the contents of the jdk.crypto.ec module
>> into java.base. This moves the SunEC JCE Provider (Elliptic Curve) into
>> java.base. EC has always been separate from the base module/pkg becau
On Mon, 19 Sep 2022 16:12:18 GMT, Sean Coffey wrote:
>> Add a JFR Event for `java.security.Provider.getService(String type, String
>> algorithm)` calls.
>
> Sean Coffey has updated the pull request incrementally with one additional
> commit since the last revision:
>
> update from review com
On Mon, 19 Sep 2022 15:52:08 GMT, Sean Mullan wrote:
>> I had this as the original design actually. I'm not sure how interesting it
>> would be to record such "no-service" type events. It would probably add 2-4
>> times the number of events for this event type to a typical recording, given
>>
24 matches
Mail list logo
