Integrated: JDK-8027711: Unify wildcarding syntax for CompileCommand and CompileOnly

2023-06-12 Thread Tobias Holenstein
On Thu, 4 May 2023 13:36:22 GMT, Tobias Holenstein wrote: > At the moment `CompileCommand` and `CompileOnly` use different syntax for > matching methods. > > ### Old CompileOnly format > - matching a **method name** with **class name** and **package name**: > `-XX:Compil

Re: RFR: JDK-8027711: Unify wildcarding syntax for CompileCommand and CompileOnly [v6]

2023-06-10 Thread Tobias Holenstein
ke pattern used > with `CompileOnly` and plug it into compile command file. Syntax used by > CompileOnly is also not very intuitive. > > `CompileOnly` is convenient because it's shorter to write and takes lists of > patterns, whereas `CompileCommand` only takes one patt

Re: RFR: JDK-8027711: Unify wildcarding syntax for CompileCommand and CompileOnly [v5]

2023-06-09 Thread Tobias Holenstein
ke pattern used > with `CompileOnly` and plug it into compile command file. Syntax used by > CompileOnly is also not very intuitive. > > `CompileOnly` is convenient because it's shorter to write and takes lists of > patterns, whereas `CompileCommand` only takes one patt

Re: RFR: JDK-8027711: Unify wildcarding syntax for CompileCommand and CompileOnly [v4]

2023-06-09 Thread Tobias Holenstein
ke pattern used > with `CompileOnly` and plug it into compile command file. Syntax used by > CompileOnly is also not very intuitive. > > `CompileOnly` is convenient because it's shorter to write and takes lists of > patterns, whereas `CompileCommand` only takes one pattern per

Re: RFR: JDK-8027711: Unify wildcarding syntax for CompileCommand and CompileOnly [v3]

2023-06-09 Thread Tobias Holenstein
On Wed, 17 May 2023 16:52:17 GMT, Vladimir Kozlov wrote: >> Tobias Holenstein has updated the pull request incrementally with 11 >> additional commits since the last revision: >> >> - Update TestStableUShort.java >> - Update TestStableUByte.java >> - Upda

Re: RFR: JDK-8027711: Unify wildcarding syntax for CompileCommand and CompileOnly [v3]

2023-06-08 Thread Tobias Holenstein
ke pattern used > with `CompileOnly` and plug it into compile command file. Syntax used by > CompileOnly is also not very intuitive. > > `CompileOnly` is convenient because it's shorter to write and takes lists of > patterns, whereas `CompileCommand` only takes one patt

Re: RFR: JDK-8027711: Unify wildcarding syntax for CompileCommand and CompileOnly [v2]

2023-05-24 Thread Tobias Holenstein
On Tue, 23 May 2023 07:55:35 GMT, Christian Hagedorn wrote: >> Tobias Holenstein has updated the pull request incrementally with three >> additional commits since the last revision: >> >> - Update Test8211698.java >> - Update src/hotspot/share/compiler/comp

Re: RFR: JDK-8282797: CompileCommand parsing errors should exit VM [v3]

2023-05-24 Thread Tobias Holenstein
On Wed, 24 May 2023 09:30:58 GMT, Tobias Hartmann wrote: >> Tobias Holenstein has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Update Scenario.java >> - Update compilerOracle.cpp > > test/hotspot/

Re: RFR: JDK-8282797: CompileCommand parsing errors should exit VM [v3]

2023-05-24 Thread Tobias Holenstein
e: '-XX:CompileCommand=,,' > Use: '-XX:CompileCommand=help' for more information and to list all option. > > Error: Could not create the Java Virtual Machine. > Error: A fatal exception has occurred. Program will exit. > > > ### Updated Tests > Up

Re: RFR: JDK-8282797: CompileCommand parsing errors should exit VM [v3]

2023-05-24 Thread Tobias Holenstein
On Wed, 24 May 2023 08:20:32 GMT, Christian Hagedorn wrote: >> Tobias Holenstein has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Update Scenario.java >> - Update compilerOracle.cpp > > src/hotsp

Re: RFR: JDK-8282797: CompileCommand parsing errors should exit VM [v2]

2023-05-24 Thread Tobias Holenstein
On Wed, 24 May 2023 09:29:53 GMT, Tobias Hartmann wrote: >> Tobias Holenstein has updated the pull request incrementally with four >> additional commits since the last revision: >> >> - Update >> test/hotspot/jtreg/compiler/compilercontrol/share/scenario

Re: RFR: JDK-8282797: CompileCommand parsing errors should exit VM [v2]

2023-05-24 Thread Tobias Holenstein
e: '-XX:CompileCommand=,,' > Use: '-XX:CompileCommand=help' for more information and to list all option. > > Error: Could not create the Java Virtual Machine. > Error: A fatal exception has occurred. Program will exit. > > > ### Updated Tests > Up

Re: RFR: JDK-8282797: CompileCommand parsing errors should exit VM [v2]

2023-05-24 Thread Tobias Holenstein
On Wed, 24 May 2023 09:29:10 GMT, Christian Hagedorn wrote: >> Tobias Holenstein has updated the pull request incrementally with four >> additional commits since the last revision: >> >> - Update >> test/hotspot/jtreg/compiler/compilercontrol/share/scenario

RFR: JDK-8282797: CompileCommand parsing errors should exit VM

2023-05-23 Thread Tobias Holenstein
Currently, errors during compile command parsing just print an error but don't exit the VM. As a result, issues go unnoticed. With this PR the behavior is changed to exit the VM when an error occurs. E.g. `java -XX:CompileCommand=compileonly,HashMap:: -version` will exit the VM after a parsing

Re: RFR: JDK-8027711: Unify wildcarding syntax for CompileCommand and CompileOnly [v2]

2023-05-23 Thread Tobias Holenstein
ke pattern used > with `CompileOnly` and plug it into compile command file. Syntax used by > CompileOnly is also not very intuitive. > > `CompileOnly` is convenient because it's shorter to write and takes lists of > patterns, whereas `CompileCommand` only takes one pattern

Re: RFR: JDK-8027711: Unify wildcarding syntax for CompileCommand and CompileOnly [v2]

2023-05-23 Thread Tobias Holenstein
On Tue, 23 May 2023 08:01:07 GMT, Christian Hagedorn wrote: >> Tobias Holenstein has updated the pull request incrementally with three >> additional commits since the last revision: >> >> - Update Test8211698.java >> - Update src/hotspot/share/compiler/comp

Re: RFR: JDK-8027711: Unify wildcarding syntax for CompileCommand and CompileOnly

2023-05-17 Thread Tobias Holenstein
On Thu, 4 May 2023 13:36:22 GMT, Tobias Holenstein wrote: > At the moment `CompileCommand` and `CompileOnly` use different syntax for > matching methods. > > ### Old CompileOnly format > - matching a **method name** with **class name** and **package name**: > `-XX:Compil

RFR: JDK-8027711: Unify wildcarding syntax for CompileCommand and CompileOnly

2023-05-17 Thread Tobias Holenstein
At the moment `CompileCommand` and `CompileOnly` use different syntax for matching methods. ### Old CompileOnly format - matching a **method name** with **class name** and **package name**: `-XX:CompileOnly=package/path/Class.method` `-XX:CompileOnly=package/path/Class::method` `-XX:CompileOnly=