Re: RFR: 8316882: Do not close ZipFileSystem on interrupt

2024-07-21 Thread Technici4n
On Sun, 21 Jul 2024 13:29:36 GMT, Technici4n wrote: > Hi, > > Here is a fix for https://bugs.openjdk.org/browse/JDK-8316882, following the > `FileChannelImpl#setUninterruptible` pattern used in `Files.readAllBytes` for > example. > > There has been some discussion

RFR: 8316882: Do not close ZipFileSystem on interrupt

2024-07-21 Thread Technici4n
Hi, Here is a fix for https://bugs.openjdk.org/browse/JDK-8316882, following the `FileChannelImpl#setUninterruptible` pattern used in `Files.readAllBytes` for example. There has been some discussion on nio-dev about more broadly rethinking the interrupt handling for `FileChannels`, for example

Withdrawn: 8314986: Module readability resolution is slow with large numbers of automatic modules

2023-12-29 Thread Technici4n
On Tue, 26 Sep 2023 14:19:55 GMT, Technici4n wrote: > Fixes the issue (hopefully) by resolving automatic modules and automatic > module dependencies after propagation of non-automatic transitive > dependencies. The module tests run. > > I also added a few asserts to va

Re: RFR: 8314986: Module readability resolution is slow with large numbers of automatic modules

2023-10-26 Thread Technici4n
On Tue, 26 Sep 2023 14:57:58 GMT, Alan Bateman wrote: >> Fixes the issue (hopefully) by resolving automatic modules and automatic >> module dependencies after propagation of non-automatic transitive >> dependencies. The module tests run. >> >> I also added a few asserts to validate that the au

Re: RFR: 8314986: Module readability resolution is slow with large numbers of automatic modules

2023-09-27 Thread Technici4n
On Tue, 26 Sep 2023 14:54:37 GMT, Chen Liang wrote: >> Fixes the issue (hopefully) by resolving automatic modules and automatic >> module dependencies after propagation of non-automatic transitive >> dependencies. The module tests run. >> >> I also added a few asserts to validate that the auto

Re: RFR: 8314986: Module readability resolution is slow with large numbers of automatic modules

2023-09-26 Thread Technici4n
On Tue, 26 Sep 2023 14:19:55 GMT, Technici4n wrote: > Fixes the issue (hopefully) by resolving automatic modules and automatic > module dependencies after propagation of non-automatic transitive > dependencies. The module tests run. > > I also added a few asserts to va

RFR: 8314986: Module readability resolution is slow with large numbers of automatic modules

2023-09-26 Thread Technici4n
Fixes the issue (hopefully) by resolving automatic modules and automatic module dependencies after propagation of non-automatic transitive dependencies. The module tests run. I also added a few asserts to validate that the automatic modules don't read themselves (previously this was the case wi