Re: RFR: 8344706: Implement JEP 512: Compact Source Files and Instance Main Methods [v5]

2025-05-01 Thread Tatsunori Uchino
On Thu, 1 May 2025 23:33:00 GMT, Tatsunori Uchino wrote: >> `InputStreamReader` and `Scanner` taking `stdin.encoding` is an interesting >> idea, but would introduce compatiblity concerns. It would have been simpler >> if we had `stdin/out/err.encoding` system propertie

Re: RFR: 8344706: Implement JEP 512: Compact Source Files and Instance Main Methods [v5]

2025-05-01 Thread Tatsunori Uchino
On Thu, 1 May 2025 17:40:56 GMT, Naoto Sato wrote: >> Hello @tats-u , there is no bother, I appreciate you looking at this. >> >> The addition of `stdin.encoding` in >> [JDK-8350703](https://bugs.openjdk.org/browse/JDK-8350703) (#24738) happened >> very quickly. I worked with @naotoj and @Alan

Re: RFR: 8344706: Implement JEP 512: Compact Source Files and Instance Main Methods [v5]

2025-05-01 Thread Tatsunori Uchino
On Sun, 27 Apr 2025 14:23:50 GMT, Tatsunori Uchino wrote: >> I misunderstood that I have tested `stdin.encoding`. >> I cannot confirm that `stdin.encoding` is changed in Windows to proper ones >> because it has not been included in the latest EA build (20) and I cannot &

Re: RFR: 8344706: Compiler Implementation of Compact Source Files and Instance Main Methods [v5]

2025-04-27 Thread Tatsunori Uchino
On Sun, 27 Apr 2025 14:21:32 GMT, Tatsunori Uchino wrote: >> I believe that after: >> https://github.com/openjdk/jdk/pull/24738 >> the `stdin.encoding` property is set when the process is connected to a >> console, which is probably the main case where the

Re: RFR: 8344706: Compiler Implementation of Compact Source Files and Instance Main Methods [v5]

2025-04-27 Thread Tatsunori Uchino
On Sun, 27 Apr 2025 10:51:33 GMT, Jan Lahoda wrote: >> src/java.base/share/classes/java/lang/IO.java line 192: >> >>> 190: String enc = System.getProperty("stdin.encoding", ""); >>> 191: Charset cs = Charset.forName(enc, StandardCharsets.UTF_8); >>> 192: br =

Re: RFR: 8344706: Compiler Implementation of Compact Source Files and Instance Main Methods [v5]

2025-04-27 Thread Tatsunori Uchino
On Tue, 22 Apr 2025 12:39:05 GMT, Jan Lahoda wrote: >> This is a PR that implements JEP: Compact Source Files and Instance Main >> Methods. Changes include: >> - `java.io.IO` moved to `java.lang.IO`, and no longer uses >> `System.console()` to implement the methods (thanks to @stuart-marks) >>