On Thu, 31 Oct 2024 07:15:16 GMT, Taizo Kurashige wrote:
> To resolve java/io/File/GetXSpace.java failure, I fix libGetXSpace.c to use
> Cygwin’s `df` to get the size for comparison if the test target drive is a
> CD-ROM drive.
>
> As described in JDK-8343342, GetDiskSpaceInf
On Mon, 23 Dec 2024 13:18:09 GMT, Taizo Kurashige wrote:
>> To resolve java/io/File/GetXSpace.java failure, I fix libGetXSpace.c to use
>> Cygwin’s `df` to get the size for comparison if the test target drive is a
>> CD-ROM drive.
>>
>> As described in JDK-834
On Wed, 18 Dec 2024 23:02:34 GMT, Brian Burkhalter wrote:
> So I don't see any difference between a physical drive and a mounted ISO file
> with respect to this test.
I understood that the test fails on both the physical CD drive and the mounted
ISO file.
In my environment, testing with a mou
> I think this fix may also resolves the similar failure reported at
> https://github.com/openjdk/jdk/pull/12397#issuecomment-1705164515.
>
> Thanks
Taizo Kurashige has updated the pull request incrementally with one additional
commit since the last revision:
java.lang.Runtime.exec
> I think this fix may also resolves the similar failure reported at
> https://github.com/openjdk/jdk/pull/12397#issuecomment-1705164515.
>
> Thanks
Taizo Kurashige has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the u
On Fri, 13 Dec 2024 21:10:31 GMT, Brian Burkhalter wrote:
> It fails for me on a Windows 11 laptop with an external CD drive with a CD
> inserted. On Cygwin the df command gives:
Could you tell me what the result would be if you tested using a virtual drive
with the iso file mounted instead of
On Wed, 11 Dec 2024 18:45:43 GMT, Brian Burkhalter wrote:
>> test/jdk/java/io/File/libGetXSpace.c line 165:
>>
>>> 163: #ifdef WINDOWS
>>> 164: JNIEXPORT jboolean JNICALL
>>> 165: Java_GetXSpace_isCDDrive
>>
>> The native `GetXSpace` method needs to be defined on all platforms,
>> otherwise we
On Thu, 12 Dec 2024 23:20:51 GMT, Brian Burkhalter wrote:
>> Taizo Kurashige has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add ifdef WINDOWS
>
> test/jdk/java/io/File/GetXSpace.java line 415:
>
> I think this fix may also resolves the similar failure reported at
> https://github.com/openjdk/jdk/pull/12397#issuecomment-1705164515.
>
> Thanks
Taizo Kurashige has updated the pull request incrementally with two additional
commits since the last revision:
- Fix getCDDriveSp
> I think this fix may also resolves the similar failure reported at
> https://github.com/openjdk/jdk/pull/12397#issuecomment-1705164515.
>
> Thanks
Taizo Kurashige has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unre
> I think this fix may also resolves the similar failure reported at
> https://github.com/openjdk/jdk/pull/12397#issuecomment-1705164515.
>
> Thanks
Taizo Kurashige has updated the pull request incrementally with one additional
commit since the last revision:
Add ifdef WINDOWS
---
> I think this fix may also resolves the similar failure reported at
> https://github.com/openjdk/jdk/pull/12397#issuecomment-1705164515.
>
> Thanks
Taizo Kurashige has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the un
> I think this fix may also resolves the similar failure reported at
> https://github.com/openjdk/jdk/pull/12397#issuecomment-1705164515.
>
> Thanks
Taizo Kurashige has updated the pull request incrementally with one additional
commit since the last revision:
Modify to execute d
> I think this fix may also resolves the similar failure reported at
> https://github.com/openjdk/jdk/pull/12397#issuecomment-1705164515.
>
> Thanks
Taizo Kurashige has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unr
> I think this fix may also resolves the similar failure reported at
> https://github.com/openjdk/jdk/pull/12397#issuecomment-1705164515.
>
> Thanks
Taizo Kurashige has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unre
On Thu, 31 Oct 2024 07:15:16 GMT, Taizo Kurashige wrote:
> To resolve java/io/File/GetXSpace.java failure, I fix libGetXSpace.c to use
> Cygwin’s `df` to get the size for comparison if the test target drive is a
> CD-ROM drive.
>
> As described in JDK-8343342, GetDiskSpaceInf
On Thu, 31 Oct 2024 07:15:16 GMT, Taizo Kurashige wrote:
> To resolve java/io/File/GetXSpace.java failure, I fix libGetXSpace.c to use
> Cygwin’s `df` to get the size for comparison if the test target drive is a
> CD-ROM drive.
>
> As described in JDK-8343342, GetDiskSpaceInf
On Fri, 1 Nov 2024 16:13:57 GMT, Brian Burkhalter wrote:
>> To resolve java/io/File/GetXSpace.java failure, I fix libGetXSpace.c to use
>> Cygwin’s `df` to get the size for comparison if the test target drive is a
>> CD-ROM drive.
>>
>> As described in JDK-8343342, GetDiskSpaceInformationW ca
On Fri, 15 Nov 2024 09:43:15 GMT, Taizo Kurashige wrote:
> To resolve tools/jpackage/windows/Win8301247Test.java failure, I made "wmic"
> executed with "chcp 437". This ensures that the English message "No
> Instance(s) Available." is output on localized
On Thu, 21 Nov 2024 04:32:50 GMT, Taizo Kurashige wrote:
>> To resolve tools/jpackage/windows/Win8301247Test.java failure, I made "wmic"
>> executed with "chcp 437". This ensures that the English message "No
>> Instance(s) Available." is outp
On Thu, 21 Nov 2024 04:32:50 GMT, Taizo Kurashige wrote:
>> To resolve tools/jpackage/windows/Win8301247Test.java failure, I made "wmic"
>> executed with "chcp 437". This ensures that the English message "No
>> Instance(s) Available." is outp
On Thu, 21 Nov 2024 04:32:50 GMT, Taizo Kurashige wrote:
>> To resolve tools/jpackage/windows/Win8301247Test.java failure, I made "wmic"
>> executed with "chcp 437". This ensures that the English message "No
>> Instance(s) Available." is outp
iers
>
> After fix, I ran tools/jpackage tests importing jdk.jpackage.test.Executor or
> jdk.jpackage.test.WindowsHelper.killAppLauncherProcess on Windows Server 2019
> (Japanese and English locales). I confirmed that they pass.
>
> Thanks
Taizo Kurashige has updated the pull reque
On Wed, 20 Nov 2024 04:22:48 GMT, Taizo Kurashige wrote:
>> To resolve tools/jpackage/windows/Win8301247Test.java failure, I made "wmic"
>> executed with "chcp 437". This ensures that the encoding is UTF8 and that
>> the English message "No Ins
On Fri, 15 Nov 2024 14:23:36 GMT, Alexey Semenyuk wrote:
> I'm not sure "65001" is the right choice if the request is to get the output
> in English. Would "437" or "850" be more appropriate arguments for the "chcp"
> command?
After receiving your comment, I ran the chcp command on Windows Ser
On Fri, 15 Nov 2024 14:20:00 GMT, Alexey Semenyuk wrote:
>> Taizo Kurashige has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix indent
>
> test/jdk/tools/jpackage/helpers/jdk/jpackage/test/Exe
On Wed, 20 Nov 2024 03:16:47 GMT, Alexey Semenyuk wrote:
>> Taizo Kurashige has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix indent
>
> test/jdk/tools/jpackage/helpers/jdk/jpackage/test/Executor.java li
On Wed, 20 Nov 2024 03:13:23 GMT, Alexey Semenyuk wrote:
>> Taizo Kurashige has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix indent
>
> test/jdk/tools/jpackage/helpers/jdk/jpackage/test/Exe
win32/intl/code-page-identifiers
>
> After fix, I ran tools/jpackage tests importing jdk.jpackage.test.Executor or
> jdk.jpackage.test.WindowsHelper.killAppLauncherProcess on Windows Server 2019
> (Japanese and English locales). I confirmed that they pass.
>
> Thanks
Taizo Ku
On Fri, 15 Nov 2024 13:25:01 GMT, Alexey Semenyuk wrote:
> The implementation may change, but the name of the function should remain the
> same.
That certainly makes sense. I changed setWinEnableUTF8 to
setWinRunWithEnglishOutput as you suggested.
> I'd run suppress the output of "chcp" comma
win32/intl/code-page-identifiers
>
> After fix, I ran tools/jpackage tests importing jdk.jpackage.test.Executor or
> jdk.jpackage.test.WindowsHelper.killAppLauncherProcess on Windows Server 2019
> (Japanese and English locales). I confirmed that they pass.
>
> Thanks
Taizo Ku
win32/intl/code-page-identifiers
>
> After fix, I ran tools/jpackage tests importing jdk.jpackage.test.Executor or
> jdk.jpackage.test.WindowsHelper.killAppLauncherProcess on Windows Server 2019
> (Japanese and English locales). I confirmed that they pass.
>
> Thanks
Taizo Kura
To resolve tools/jpackage/windows/Win8301247Test.java failure, I made "wmic"
executed with "chcp 65001". This ensures that the encoding is UTF8 and that the
English message "No Instance(s) Available." is output on localized windows
platforms.
I have referred to the following for how to use chcp
To resolve java/io/File/GetXSpace.java failure, I fix libGetXSpace.c to use
Cygwin’s `df` to get the size for comparison if the test target drive is a
CD-ROM drive.
As described in JDK-8343342, GetDiskSpaceInformationW can't get information
about the size of the CD-ROM drive.
GetDiskFreeSpace
34 matches
Mail list logo
