Re: RFR: 8292914: Introduce a system property that enables stable names for lambda proxy classes [v7]

2023-01-09 Thread Strahinja Stanojevic
On Mon, 21 Nov 2022 16:46:43 GMT, Strahinja Stanojevic wrote: >> This PR introduces an option to output stable names for the lambda classes >> in the JDK. A stable name consists of two parts: The first part is the >> predefined value `$$Lambda$` appended to the lambda captur

Re: RFR: 8292914: Introduce a system property that enables stable names for lambda proxy classes [v7]

2022-11-21 Thread Strahinja Stanojevic
We can see that the introduced hash value does not change between two calls > of the method `createPlainLambdas`. That was not the case in the JDK run > without this change. Those lambdas are extracted directly from the test. Strahinja Stanojevic has updated the pull request incrementally with on

Re: RFR: 8292914: Introduce a system property that enables stable names for lambda proxy classes [v6]

2022-11-21 Thread Strahinja Stanojevic
We can see that the introduced hash value does not change between two calls > of the method `createPlainLambdas`. That was not the case in the JDK run > without this change. Those lambdas are extracted directly from the test. Strahinja Stanojevic has updated the pull request incrementally with on

Re: RFR: 8292914: Introduce a system property that enables stable names for lambda proxy classes [v5]

2022-11-21 Thread Strahinja Stanojevic
We can see that the introduced hash value does not change between two calls > of the method `createPlainLambdas`. That was not the case in the JDK run > without this change. Those lambdas are extracted directly from the test. Strahinja Stanojevic has refreshed the contents of this pull request

Re: RFR: 8292914: Introduce a system property that enables stable names for lambda proxy classes [v4]

2022-11-21 Thread Strahinja Stanojevic
We can see that the introduced hash value does not change between two calls > of the method `createPlainLambdas`. That was not the case in the JDK run > without this change. Those lambdas are extracted directly from the test. Strahinja Stanojevic has updated the pull request incrementally with

Re: RFR: 8292914: Introduce a system property that enables stable names for lambda proxy classes

2022-10-18 Thread Strahinja Stanojevic
On Tue, 6 Sep 2022 16:47:03 GMT, Ioi Lam wrote: >> This PR introduces a system property that creates stable names for the >> lambda classes in the JDK. Instead of using an atomic counter in the lambda >> name, we can use a 32-bit hash after `$$Lambda$`. Thus, the name becomes >> `lambdaCapturi

Re: RFR: 8292914: Introduce a system property that enables stable names for lambda proxy classes [v3]

2022-10-18 Thread Strahinja Stanojevic
On Thu, 15 Sep 2022 11:50:57 GMT, Strahinja Stanojevic wrote: >> This PR introduces a system property that creates stable names for the >> lambda classes in the JDK. Instead of using an atomic counter in the lambda >> name, we can use a 32-bit hash after `$$Lambda$`. Thus

Re: RFR: 8292914: Introduce a system property that enables stable names for lambda classes [v3]

2022-09-15 Thread Strahinja Stanojevic
t it. Appending `#` only affects the > hash length, but not its stability. > > Link to the related issue: https://bugs.openjdk.org/browse/JDK-8292914 Strahinja Stanojevic has updated the pull request incrementally with one additional commit since the last revision: Add addit

Re: RFR: JDK-8292914: Introduce a system property that enables stable names for lambda classes

2022-09-07 Thread Strahinja Stanojevic
On Tue, 6 Sep 2022 16:47:03 GMT, Ioi Lam wrote: > Have you tested with method references? Two references to the same method > will result in a single `JVM_CONSTANT_InvokeDynamic` constant pool entry in > the classfile, but it's invoked by two callsites. As a result, two different > lambda prox

Re: RFR: JDK-8292914: Introduce a system property that enables stable names for lambda classes [v2]

2022-09-07 Thread Strahinja Stanojevic
t it. Appending `#` only affects the > hash length, but not its stability. > > Link to the related issue: https://bugs.openjdk.org/browse/JDK-8292914 Strahinja Stanojevic has updated the pull request incrementally with one additional commit since the last revision: Enhance test with

RFR: JDK-8292914: Introduce a system property that enables stable names for lambda classes

2022-09-05 Thread Strahinja Stanojevic
This PR introduces a system property that creates stable names for the lambda classes in the JDK. Instead of using an atomic counter in the lambda name, we can use a 32-bit hash after `$$Lambda$`. Thus, the name becomes `lambdaCapturingClass$$Lambda$hashValue`. Parameters used to create a stable