Re: RFR: 8319958: test/jdk/java/io/File/libGetXSpace.c does not compile on Windows 32-bit [v2]

2023-11-14 Thread Stewart X Addison
On Mon, 13 Nov 2023 14:04:22 GMT, Stewart X Addison wrote: >> ~~I will force push to change ONLY the commit message once I get a bug >> created - I am not currently an author. In draft until I do that.~~ Done >> >> FYI @andrew-m-leonard (who I've discussed this

Integrated: 8319958: test/jdk/java/io/File/libGetXSpace.c does not compile on Windows 32-bit

2023-11-14 Thread Stewart X Addison
On Mon, 13 Nov 2023 12:02:11 GMT, Stewart X Addison wrote: > ~~I will force push to change ONLY the commit message once I get a bug > created - I am not currently an author. In draft until I do that.~~ Done > > FYI @andrew-m-leonard (who I've discussed this with) and @GoeLin

Re: RFR: 8319958: test/jdk/java/io/File/libGetXSpace.c does not compile on Windows 32-bit [v2]

2023-11-14 Thread Stewart X Addison
On Mon, 13 Nov 2023 14:04:22 GMT, Stewart X Addison wrote: >> ~~I will force push to change ONLY the commit message once I get a bug >> created - I am not currently an author. In draft until I do that.~~ Done >> >> FYI @andrew-m-leonard (who I've discussed this

Re: RFR: 8319958: test/jdk/java/io/File/libGetXSpace.c does not compile on Windows 32-bit [v2]

2023-11-14 Thread Stewart X Addison
On Mon, 13 Nov 2023 14:04:22 GMT, Stewart X Addison wrote: >> ~~I will force push to change ONLY the commit message once I get a bug >> created - I am not currently an author. In draft until I do that.~~ Done >> >> FYI @andrew-m-leonard (who I've discussed this

Re: RFR: 8319958: test/jdk/java/io/File/libGetXSpace.c does not compile on Windows 32-bit [v2]

2023-11-14 Thread Stewart X Addison
On Tue, 14 Nov 2023 13:10:50 GMT, Aleksey Shipilev wrote: >> Stewart X Addison has refreshed the contents of this pull request, and >> previous commits have been removed. The incremental views will show >> differences compared to the previous content of the PR. The pull re

Re: RFR: 8319958: test/jdk/java/io/File/libGetXSpace.c does not compile on Windows 32-bit [v2]

2023-11-14 Thread Stewart X Addison
On Tue, 14 Nov 2023 13:10:50 GMT, Aleksey Shipilev wrote: > As a matter of course, please enable the GH testing and make sure the testing > passes. Go to https://github.com/sxa/jdk/actions, enable the workflows, then > trigger the workflow against your branch. Thanks - I had it on some of my o

Re: RFR: 8319958: test/jdk/java/io/File/libGetXSpace.c does not compile on Windows 32-bit [v2]

2023-11-14 Thread Stewart X Addison
On Mon, 13 Nov 2023 21:18:59 GMT, Brian Burkhalter wrote: > Looks good. I verified that the test still builds and succeeds on Win64. I've also verified that it's ok on all three Windows platforms (x86, x64, aarch64) for JDK17 so should be good to go in here and be backported without problems.

Re: RFR: 8319958: test/jdk/java/io/File/libGetXSpace.c does not compile on Windows 32-bit

2023-11-13 Thread Stewart X Addison
On Mon, 13 Nov 2023 12:02:11 GMT, Stewart X Addison wrote: > ~~I will force push to change ONLY the commit message once I get a bug > created - I am not currently an author. In draft until I do that.~~ Done > > FYI @andrew-m-leonard (who I've discussed this with) and @GoeLin

Re: RFR: 8319958: test/jdk/java/io/File/libGetXSpace.c does not compile on Windows 32-bit [v2]

2023-11-13 Thread Stewart X Addison
In JDK21: > https://github.com/openjdk/jdk21u/commit/3ef834fc6fc245accffc41da714358fc82f22657#diff-6a0b6da94fe13f6caf3b50072a6bef7d559c4b5fc92de7aa2e3c0079f33190d3 > That change was backported to JDK17 three weeks ago in > https://github.com/openjdk/jdk17u/commit/f85053f578125d1af7c3c762d966fee8283a6ce2 Stewart

RFR: JDK-8319958: Fix ifdef to support WIN32 in libGetXSpace.c

2023-11-13 Thread Stewart X Addison
~~I will force push to change ONLY the commit message once I get a bug created - I am not currently an author. In draft until I do that.~~ Done FYI @andrew-m-leonard (who I've discussed this with) and @GoeLin This fixes a build break which has shown up on 32-bit Windows (Deprecated but not remo