Integrated: 8357597: Proxy.getInvocationHandler throws NullPointerException instead of IllegalArgumentException for null

2025-05-27 Thread Steffen Nießing
On Fri, 23 May 2025 16:05:08 GMT, Steffen Nießing wrote: > `Proxy#getInvocationHandler(Object)` throws a `NullPointerException` if the > specified argument is `null`. This PR adds the missing `throws` declaration > for the NPE. This pull request has now been integrated. Changeset:

Re: RFR: 8357597: Proxy.getInvocationHandler throws NullPointerException instead of IllegalArgumentException for null [v2]

2025-05-26 Thread Steffen Nießing
On Mon, 26 May 2025 05:43:49 GMT, Jaikiran Pai wrote: >> Steffen Nießing has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8357597: Update copyright year > > The change looks OK to me. Please update the c

Re: RFR: 8357597: Proxy.getInvocationHandler throws NullPointerException instead of IllegalArgumentException for null [v2]

2025-05-26 Thread Steffen Nießing
> `Proxy#getInvocationHandler(Object)` throws a `NullPointerException` if the > specified argument is `null`. This PR adds the missing `throws` declaration > for the NPE. Steffen Nießing has updated the pull request incrementally with one additional commit since the last revision:

RFR: 8357597: Proxy.getInvocationHandler throws NullPointerException instead of IllegalArgumentException for null

2025-05-23 Thread Steffen Nießing
`Proxy#getInvocationHandler(Object)` throws a `NullPointerException` if the specified argument is `null`. This PR adds the missing `throws` declaration for the NPE. - Commit messages: - 8357597: Add throws declaration for NPE Changes: https://git.openjdk.org/jdk/pull/25419/files

Missing throws declaration for NullPointerException in Proxy#getInvocationHandler

2025-05-22 Thread Steffen Nießing
Hi, recently I've come across the documentation of Proxy#getInvocationHandler(Object) and recognized that there's a missing throws declaration for a NullPointerException. The expression Proxy.getInvocationHandler(null) fails, because proxy.getClass() is called without asserting that proxy is n

Integrated: 8356119: Typo in bytecode behavior for Lookup.findGetter

2025-05-05 Thread Steffen Nießing
On Sun, 4 May 2025 16:45:11 GMT, Steffen Nießing wrote: > JavaDoc only: This PR fixes a typo in the `bytecode behavior` table entry for > Lookup.findGetter. This pull request has now been integrated. Changeset: 2a4f37cc Author:Steffen Nießing Committer: Chen Liang URL:

Re: RFR: 8356119: Typo in bytecode behavior for Lookup.findGetter [v2]

2025-05-05 Thread Steffen Nießing
On Mon, 5 May 2025 18:59:29 GMT, Steffen Nießing wrote: >> JavaDoc only: This PR fixes a typo in the `bytecode behavior` table entry >> for Lookup.findGetter. > > Steffen Nießing has updated the pull request with a new target base due to a > merge or a rebase. The increm

JavaDoc: NPE in java.net.http.HttpHeaders

2025-05-05 Thread Steffen Nießing
Hello, recently I've discovered that the JavaDoc of the instance methods of java.net.http.HttpHeaders lacks the throws declarations for NullPointerExceptions. The static creator method `of` contains such a declaration. So the snippet `HttpHeaders.of(null, null)` is documented to throw an NPE,

Re: RFR: 8356119: Typo in bytecode behavior for Lookup.findGetter [v2]

2025-05-05 Thread Steffen Nießing
On Sun, 4 May 2025 17:01:54 GMT, Chen Liang wrote: > Thanks for the mailing list communication and reply. > > Check out https://openjdk.org/guide/ for more steps. For example, a patch > should usually wait 24 hours for sufficient reviews. @liach Thanks for the fast review and the creation of th

Re: RFR: 8356119: Typo in bytecode behavior for Lookup.findGetter

2025-05-05 Thread Steffen Nießing
On Sun, 4 May 2025 17:20:29 GMT, Eirik Bjørsnøs wrote: > Nit: Would be nice if the PR title/description made it clear for the casual > reader that this is a documentation/Javadoc typo, as opposed to a code issue. Thanks for the hint. I've updated the PR accordingly. > This gives reviewers som

Re: RFR: 8356119: Typo in bytecode behavior for Lookup.findGetter [v2]

2025-05-05 Thread Steffen Nießing
> JavaDoc only: This PR fixes a typo in the `bytecode behavior` table entry for > Lookup.findGetter. Steffen Nießing has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. Th

RFR: 8356119: Typo in bytecode behavior for Lookup.findGetter

2025-05-04 Thread Steffen Nießing
This PR fixes a typo in the bytecode cast for Lookup.findGetter. - Commit messages: - 8356119: Correct field type for bytecode cast Changes: https://git.openjdk.org/jdk/pull/25024/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=25024&range=00 Issue: https://bugs.openjdk.o

Documentation fix in MethodHandles.Lookup

2025-05-03 Thread Steffen Nießing
Hello, I've found a small documentation inconvenience in the MethodHandles.Lookup class documentation. In the Lookup Factory Methods table the field types of the member and bytecode definitions for lookup.findGetter diverge: https://github.com/openjdk/jdk/blob/master/src/java.base/share/classes

Re: JavaDoc fix in java.util.Date

2025-05-01 Thread Steffen Nießing
s, though in some > cases backward compatibility has forced them to be specified. > > Regards, Roger > > On 4/30/25 4:37 PM, Steffen Nießing wrote: > >> Thanks, haven't seen unsigned right shift before. You're right, it should be >> fine to use the unsigned o

Re: JavaDoc fix in java.util.Date

2025-04-30 Thread Steffen Nießing
t; ------------ >> *From:* core-libs-dev on behalf of >> Joseph D. Darcy >> *Sent:* Wednesday, April 30, 2025 2:54 PM >> *To:* Steffen Nießing ; core-libs- >> d...@openjdk.org >> *Subject:* Re: Jav

JavaDoc fix in java.util.Date

2025-04-30 Thread Steffen Nießing
Hello, I'm new to the OpenJDK community and plan to make my first change. I've found a small mistake in the documentation of java.util.Date#hashCode(). The documentation provides a Java expression of the returned value, which uses a non-existent operator '>>>'. Now I'm searching for a sponsor