Re: RFR: 8356128: Correct documentation for --linux-package-deps [v4]

2025-06-03 Thread Stefan Lobbenmeier
On Tue, 27 May 2025 19:48:11 GMT, Stefan Lobbenmeier wrote: >> The documentation suggests that --linux-package-deps is a boolean option, >> while in fact it is a string option with dependencies separated by comma and >> space >> >> You can tell that this option i

Integrated: 8356128: Correct documentation for --linux-package-deps

2025-06-03 Thread Stefan Lobbenmeier
On Fri, 14 Feb 2025 15:01:35 GMT, Stefan Lobbenmeier wrote: > The documentation suggests that --linux-package-deps is a boolean option, > while in fact it is a string option with dependencies separated by comma and > space > > You can tell that this option is supposed to have a

Re: RFR: 8356128: Correct documentation for --linux-package-deps [v4]

2025-06-03 Thread Stefan Lobbenmeier
On Tue, 27 May 2025 19:48:11 GMT, Stefan Lobbenmeier wrote: >> The documentation suggests that --linux-package-deps is a boolean option, >> while in fact it is a string option with dependencies separated by comma and >> space >> >> You can tell that this option i

Re: RFR: 8356128: Correct documentation for --linux-package-deps [v3]

2025-05-27 Thread Stefan Lobbenmeier
On Wed, 21 May 2025 20:51:48 GMT, Alexander Matveev wrote: >> Stefan Lobbenmeier has updated the pull request incrementally with one >> additional commit since the last revision: >> >> also use in other locations > > src/jdk.jpackage/share/man/jpackage.md

Re: RFR: 8356128: Correct documentation for --linux-package-deps [v4]

2025-05-27 Thread Stefan Lobbenmeier
m/openjdk/jdk/blob/fea5f2b1458cdd53f437e59caaffaa6e22fb59a7/src/jdk.jpackage/linux/classes/jdk/jpackage/internal/LinuxPackageBundler.java#L366-L372 Stefan Lobbenmeier has updated the pull request incrementally with one additional commit since the last revision: Correct backtick position - Chang

Re: RFR: 8356128: Correct documentation for --linux-package-deps [v3]

2025-05-21 Thread Stefan Lobbenmeier
On Wed, 21 May 2025 19:33:13 GMT, Alexander Matveev wrote: >> Stefan Lobbenmeier has updated the pull request incrementally with one >> additional commit since the last revision: >> >> also use in other locations > > src/jdk.jpackage/share/classes/j

Re: RFR: 8356128: Correct documentation for --linux-package-deps [v2]

2025-05-21 Thread Stefan Lobbenmeier
On Wed, 21 May 2025 11:56:31 GMT, Alexey Semenyuk wrote: > Thank you for making the change! Other property files and jpackage.md should > also be updated to sync them with HelpResources.properties. Done, sorry I missed them - PR Comment: https://git.openjdk.org/jdk/pull/23638#issu

Re: RFR: 8356128: Correct documentation for --linux-package-deps [v3]

2025-05-21 Thread Stefan Lobbenmeier
m/openjdk/jdk/blob/fea5f2b1458cdd53f437e59caaffaa6e22fb59a7/src/jdk.jpackage/linux/classes/jdk/jpackage/internal/LinuxPackageBundler.java#L366-L372 Stefan Lobbenmeier has updated the pull request incrementally with one additional commit since the last revision: also use in other locations - Chang

Re: RFR: 8356128: Correct documentation for --linux-package-deps [v2]

2025-05-21 Thread Stefan Lobbenmeier
On Wed, 21 May 2025 12:07:52 GMT, Alexey Semenyuk wrote: >> Stefan Lobbenmeier has updated the pull request incrementally with one >> additional commit since the last revision: >> >> change cli option to single string as suggested in PR review > > src/jdk.jpack

Re: RFR: 8356128: Correct documentation for --linux-package-deps [v2]

2025-05-21 Thread Stefan Lobbenmeier
On Wed, 21 May 2025 10:00:39 GMT, Stefan Lobbenmeier wrote: >> The documentation suggests that --linux-package-deps is a boolean option, >> while in fact it is a string option with dependencies separated by comma and >> space >> >> You can tell that this option i

Re: RFR: 8356128: Correct documentation for --linux-package-deps [v2]

2025-05-21 Thread Stefan Lobbenmeier
On Wed, 21 May 2025 09:57:10 GMT, Stefan Lobbenmeier wrote: >> src/jdk.jpackage/share/classes/jdk/jpackage/internal/resources/HelpResources.properties >> line 298: >> >>> 296: \ --linux-menu-group \n\ >>> 297: \ Menu group this application is plac

RFR: 8356128: Correct documentation for --linux-package-deps

2025-05-05 Thread Stefan Lobbenmeier
The documentation suggests that --linux-package-deps is a boolean option, while in fact it is a string option with dependencies separated by comma and space You can tell that this option is supposed to have an argument here: https://github.com/openjdk/jdk/blob/fea5f2b1458cdd53f437e59caaffaa6e22f

Re: RFR: 8356128: Correct documentation for --linux-package-deps

2025-05-05 Thread Stefan Lobbenmeier
On Fri, 14 Feb 2025 15:01:35 GMT, Stefan Lobbenmeier wrote: > The documentation suggests that --linux-package-deps is a boolean option, > while in fact it is a string option with dependencies separated by comma and > space > > You can tell that this option is supposed to have a