On Fri, 9 Aug 2024 15:21:22 GMT, Emanuel Peter wrote:
>> @vnkozlov Thank you for reviewing the patch.
>
> @smita-kamath I think I just found another regression of this feature:
> https://bugs.openjdk.org/browse/JDK-8338126
> Can you please have a look?
@eme64, Sure will look
On Fri, 5 Aug 2022 16:36:23 GMT, Smita Kamath wrote:
> 8289552: Make intrinsic conversions between bit representations of half
> precision values and floats
This pull request has now been integrated.
Changeset: 07946aa4
Author: Smita Kamath
Committer: Sandhya Viswanatha
On Mon, 10 Oct 2022 21:05:58 GMT, Vladimir Kozlov wrote:
>> Smita Kamath has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Updated instruct to use kmovw
>
> I started new testing.
@vnkozlov Tha
ed and all tier1 tests passed.
>
>> @sviswa7 The failure is due to
>> [JDK-8293618](https://bugs.openjdk.org/browse/JDK-8293618), @smita-kamath
>> please merge with master. Thanks.
>
> Yes, I tested with latest JDK sources which includes JDK-8293618.
@vnkozlov, I have imp
On Tue, 4 Oct 2022 09:07:42 GMT, Quan Anh Mai wrote:
>>> You can use `kmovwl` instead which will relax the avx512bw constraint,
>>> however, you will need avx512vl for `evcvtps2ph`. Thanks.
>>
>> Yes, in general all AVX512VL targets support AVX512BW, but cloud instances
>> give freedom to enab
> 8289552: Make intrinsic conversions between bit representations of half
> precision values and floats
Smita Kamath has updated the pull request incrementally with one additional
commit since the last revision:
Updated instruct to use kmovw
-
Changes:
- all:
On Mon, 3 Oct 2022 08:34:06 GMT, Quan Anh Mai wrote:
>> src/hotspot/cpu/x86/x86.ad line 3674:
>>
>>> 3672: %}
>>> 3673:
>>> 3674: instruct convF2HF_mem_reg(memory mem, regF src, kReg ktmp, rRegI
>>> rtmp) %{
>>
>> You can use `kmovwl` instead which will relax the avx512bw constraint,
>> howe
On Fri, 30 Sep 2022 09:59:02 GMT, Bhavana Kilambi wrote:
>> Smita Kamath has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Addressed review comment to update test case
>
> Hi, would you be adding IR tests t
> 8289552: Make intrinsic conversions between bit representations of half
> precision values and floats
Smita Kamath has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase. Th
On Thu, 29 Sep 2022 18:34:41 GMT, Vladimir Kozlov wrote:
>> @vnkozlov I have addressed all review comments. Could you please run the
>> patch through your testing? Thanks a lot for all the help.
>
> @smita-kamath I have builds failures. Please, build and test yourself to
On Wed, 21 Sep 2022 16:41:19 GMT, Vladimir Kozlov wrote:
>> Smita Kamath has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Addressed review comments
>
> tier2 and 3 passed. I will wait update with test and
> 8289552: Make intrinsic conversions between bit representations of half
> precision values and floats
Smita Kamath has updated the pull request incrementally with one additional
commit since the last revision:
Addressed review comment to update test case
-
Changes:
On Tue, 27 Sep 2022 13:20:51 GMT, Jatin Bhateja wrote:
>> Smita Kamath has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Addressed review comments
>
> I have verified my other comments, we can either handle
On Wed, 21 Sep 2022 16:41:19 GMT, Vladimir Kozlov wrote:
>> Smita Kamath has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Addressed review comments
>
> tier2 and 3 passed. I will wait update with test and
On Wed, 21 Sep 2022 17:49:51 GMT, Jatin Bhateja wrote:
>> Smita Kamath has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Addressed review comments
>
> src/hotspot/share/opto/conve
> 8289552: Make intrinsic conversions between bit representations of half
> precision values and floats
Smita Kamath has updated the pull request incrementally with one additional
commit since the last revision:
Addressed review comments
-
Changes:
- all:
> 8289552: Make intrinsic conversions between bit representations of half
> precision values and floats
Smita Kamath has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase. Th
On Fri, 2 Sep 2022 00:52:49 GMT, Smita Kamath wrote:
>> 8289552: Make intrinsic conversions between bit representations of half
>> precision values and floats
>
> Smita Kamath has updated the pull request incrementally with one additional
> commit since the last revis
On Thu, 1 Sep 2022 21:17:30 GMT, Vladimir Kozlov wrote:
>> Yes; I removed support for --release 7 in JDK 20 early today.
>>
>>
>> On Thu, Sep 1, 2022 at 1:36 PM Paul Sandoz ***@***.***> wrote:
>>
>>> Likely requires a merge with master.
>>>
>>> —
>>> Reply to this email directly, view it on Gi
On Thu, 1 Sep 2022 21:17:30 GMT, Vladimir Kozlov wrote:
>> Yes; I removed support for --release 7 in JDK 20 early today.
>>
>>
>> On Thu, Sep 1, 2022 at 1:36 PM Paul Sandoz ***@***.***> wrote:
>>
>>> Likely requires a merge with master.
>>>
>>> —
>>> Reply to this email directly, view it on Gi
On Fri, 2 Sep 2022 15:59:23 GMT, Paul Sandoz wrote:
>> Smita Kamath has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Addressed review comments
>
> Can you please file a follow up issue to write a test (gtest
> 8289552: Make intrinsic conversions between bit representations of half
> precision values and floats
Smita Kamath has updated the pull request incrementally with one additional
commit since the last revision:
Addressed review comments
-
Changes:
- all:
> 8289552: Make intrinsic conversions between bit representations of half
> precision values and floats
Smita Kamath has updated the pull request incrementally with one additional
commit since the last revision:
Added missing parantheses
-
Changes:
- all:
> 8289552: Make intrinsic conversions between bit representations of half
> precision values and floats
Smita Kamath has updated the pull request incrementally with one additional
commit since the last revision:
Addressed review comments, updated microbenchmark
-
C
On Thu, 25 Aug 2022 03:15:52 GMT, Sandhya Viswanathan
wrote:
>> Smita Kamath has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Updated copyright comment
>
> src/hotspot/cpu/x86/x86_64.ad line 11330:
>
> 8289552: Make intrinsic conversions between bit representations of half
> precision values and floats
Smita Kamath has updated the pull request incrementally with one additional
commit since the last revision:
Updated copyright comment
-
Changes:
- all:
> 8289552: Make intrinsic conversions between bit representations of half
> precision values and floats
Smita Kamath has updated the pull request incrementally with one additional
commit since the last revision:
Updated test cases as per review comments
-
Changes:
> 8289552: Make intrinsic conversions between bit representations of half
> precision values and floats
Smita Kamath has updated the pull request incrementally with one additional
commit since the last revision:
Addressed review comments, updated test cases and microben
On Fri, 5 Aug 2022 16:36:23 GMT, Smita Kamath wrote:
> 8289552: Make intrinsic conversions between bit representations of half
> precision values and floats
JMH results
Before patch
Benchmark (TESTSIZE) Mode Cnt
Score Error
> 8289552: Make intrinsic conversions between bit representations of half
> precision values and floats
Smita Kamath has updated the pull request incrementally with one additional
commit since the last revision:
Added a jmh microbenchmark
-
Changes:
- all:
On Fri, 5 Aug 2022 22:15:37 GMT, Joe Darcy wrote:
>> 8289552: Make intrinsic conversions between bit representations of half
>> precision values and floats
>
> src/hotspot/share/runtime/sharedRuntime.cpp line 450:
>
>> 448: JRT_END
>> 449:
>> 450: JRT_LEAF(jshort, SharedRuntime::f2hf(jfloat x
On Fri, 5 Aug 2022 21:58:40 GMT, Vladimir Kozlov wrote:
>> 8289552: Make intrinsic conversions between bit representations of half
>> precision values and floats
>
> Please add JMH microbenchmark and show results.
@vnkozlov Thank you for your comment. I will add a jmh test case.
-
On Fri, 5 Aug 2022 16:36:23 GMT, Smita Kamath wrote:
> 8289552: Make intrinsic conversions between bit representations of half
> precision values and floats
Hi All,
This change is to provide intrinsic implementation for conversion between
floats and half precision floating point f
8289552: Make intrinsic conversions between bit representations of half
precision values and floats
-
Commit messages:
- Intrinsic conversions between halffloat and floats
Changes: https://git.openjdk.org/jdk/pull/9781/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=9781&ra
34 matches
Mail list logo
