Trivial change to exclude the test from running with Xcomp flag.
The test fails because the number of GCs as reported by the MXBean doesn't
match the expected number. This is due to the additional GC happening due to
CodeCache crossing its threshold.
We could increase the code cache or restrict
On Tue, 8 Oct 2024 17:10:43 GMT, Ramkumar Sunderbabu
wrote:
> The time difference check might fail for scenarios such as batch compilation.
> It is safer to give a bigger allowance of 10 seconds instead of 0.1 sec.
>
> Testing: The test was run for 100 times with -Xcomp option
On Tue, 15 Oct 2024 15:29:54 GMT, Daniel Fuchs wrote:
>> AFAIU, the original intention of the test is to check if Instant.now and
>> Instant.now(Clock.systemUTC()) returns almost same time since the underlying
>> clock is same.
>> Given that premise,
>> suggestion 1: it does the job but doesn't
On Tue, 15 Oct 2024 13:08:37 GMT, Daniel Fuchs wrote:
>> Ramkumar Sunderbabu has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> checking if time is monotonic
>
> test/jdk/java/time/tck/java/time/TCKIn
> The time difference check might fail for scenarios such as batch compilation.
> It is safer to give a bigger allowance of 10 seconds instead of 0.1 sec.
>
> Testing: The test was run for 100 times with -Xcomp option.
Ramkumar Sunderbabu has updated the pull request incrementa
On Wed, 9 Oct 2024 14:50:30 GMT, Ramkumar Sunderbabu
wrote:
> The System property "docker.support" defined in VMProps gives a wrong
> impression that it is tied to docker alone. The property is common for any
> container runtime. Hence, it needs to be renamed as
> The time difference check might fail for scenarios such as batch compilation.
> It is safer to give a bigger allowance of 10 seconds instead of 0.1 sec.
>
> Testing: The test was run for 100 times with -Xcomp option.
Ramkumar Sunderbabu has updated the pull request incrementa
On Thu, 10 Oct 2024 15:12:44 GMT, Roger Riggs wrote:
>> If your objection is primarily on Math.abs, is this ok?
>> `
>> long diff = test.toEpochMilli() - expected.toEpochMilli();
>> assertTrue(diff >= 0 && diff < 10_000); // less than 10 secs
>> `
>
> I don't think there is any
er2,tier3 - to check stability
> tier5 - to run container tests
>
> Negative Testing:
> Ran the following groups in hosts where container is not present.
> open/test/hotspot/jtreg/containers/
> open/test/jdk/jdk/internal/platform/docker/
> open/test/jdk/jdk/internal/platfor
On Tue, 8 Oct 2024 17:10:43 GMT, Ramkumar Sunderbabu
wrote:
> The time difference check might fail for scenarios such as batch compilation.
> It is safer to give a bigger allowance of 10 seconds instead of 0.1 sec.
>
> Testing: The test was run for 100 times with -Xcomp option.
B
The System property "docker.support" defined in VMProps gives a wrong
impression that it is tied to docker alone. The property is common for any
container runtime. Hence, it needs to be renamed as "container.support".
Positive Testing:
tier1,tier2,tier3 - to check stability
tier5 - to run contai
On Wed, 9 Oct 2024 01:10:54 GMT, Ramkumar Sunderbabu
wrote:
>> test/jdk/java/time/tck/java/time/TCKInstant.java line 193:
>>
>>> 191: Instant test = Instant.now();
>>> 192: long diff = Math.abs(test.toEpochMilli() -
>>> expected.toEpo
On Tue, 8 Oct 2024 19:50:54 GMT, Roger Riggs wrote:
>> The time difference check might fail for scenarios such as batch
>> compilation. It is safer to give a bigger allowance of 10 seconds instead of
>> 0.1 sec.
>>
>> Testing: The test was run for 100 times with -Xcomp option.
>
> test/jdk/jav
The time difference check might fail for scenarios such as batch compilation.
It is safer to give a bigger allowance of 10 seconds instead of 0.1 sec.
Testing: The test was run for 100 times with -Xcomp option.
-
Commit messages:
- initial commit
Changes: https://git.openjdk.org/j
JDK-8318668 was not reproducible in repeated runs. Hence, I am pulling it out
of problem listing. Additionally I have increased logging so that it is easier
to debug when the issue happens again.
Testing:
tier1,tier2,tier3
tier6-comp,tier8-comp
-
Commit messages:
- initial commit
15 matches
Mail list logo
