Integrated: 8289508: Improve test coverage for XPath Axes: ancestor, ancestor-or-self, preceding, and preceding-sibling

2022-09-20 Thread Rahul Prabhu
On Thu, 8 Sep 2022 06:19:10 GMT, Rahul Prabhu wrote: > Created two files for testing XPath Axes: XPathAncestors.java tests the > ancestor and ancestor-or-self axes, while XPathPrecedingTest.java tests the > preceding and preceding-sibling axes. This pull request has now been i

Re: RFR: 8289508: Improve test coverage for XPath Axes: ancestor, ancestor-or-self, preceding, and preceding-sibling [v4]

2022-09-16 Thread Rahul Prabhu
On Thu, 15 Sep 2022 21:13:53 GMT, Joe Wang wrote: >> Rahul Prabhu has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8289508: fixed whitespace > > Looks good overall. > > Note that if the editor

Re: RFR: 8289508: Improve test coverage for XPath Axes: ancestor, ancestor-or-self, preceding, and preceding-sibling [v6]

2022-09-16 Thread Rahul Prabhu
> Created two files for testing XPath Axes: XPathAncestors.java tests the > ancestor and ancestor-or-self axes, while XPathPrecedingTest.java tests the > preceding and preceding-sibling axes. Rahul Prabhu has updated the pull request incrementally with one additional commit since

Re: RFR: 8289508: Improve test coverage for XPath Axes: ancestor, ancestor-or-self, preceding, and preceding-sibling [v5]

2022-09-16 Thread Rahul Prabhu
> Created two files for testing XPath Axes: XPathAncestors.java tests the > ancestor and ancestor-or-self axes, while XPathPrecedingTest.java tests the > preceding and preceding-sibling axes. Rahul Prabhu has updated the pull request incrementally with one additional commit since

Re: RFR: 8289508: Improve test coverage for XPath Axes: ancestor, ancestor-or-self, preceding, and preceding-sibling [v4]

2022-09-14 Thread Rahul Prabhu
> Created two files for testing XPath Axes: XPathAncestors.java tests the > ancestor and ancestor-or-self axes, while XPathPrecedingTest.java tests the > preceding and preceding-sibling axes. Rahul Prabhu has updated the pull request incrementally with one additional commit since

Re: RFR: 8289508: Improve test coverage for XPath Axes: ancestor, ancestor-or-self, preceding, and preceding-sibling [v4]

2022-09-14 Thread Rahul Prabhu
On Tue, 13 Sep 2022 05:23:20 GMT, Joe Wang wrote: >> Rahul Prabhu has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8289508: fixed whitespace > > It would be nice to cover some of the assertions made

Re: RFR: 8289508: Improve test coverage for XPath Axes: ancestor, ancestor-or-self, preceding, and preceding-sibling [v3]

2022-09-14 Thread Rahul Prabhu
> Created two files for testing XPath Axes: XPathAncestors.java tests the > ancestor and ancestor-or-self axes, while XPathPrecedingTest.java tests the > preceding and preceding-sibling axes. Rahul Prabhu has updated the pull request incrementally with one additional commit since

Re: RFR: 8289508: Improve test coverage for XPath Axes: ancestor, ancestor-or-self, preceding, and preceding-sibling [v2]

2022-09-14 Thread Rahul Prabhu
> Created two files for testing XPath Axes: XPathAncestors.java tests the > ancestor and ancestor-or-self axes, while XPathPrecedingTest.java tests the > preceding and preceding-sibling axes. Rahul Prabhu has refreshed the contents of this pull request, and previous commits have bee

Re: RFR: 8289508: Improve test coverage for XPath Axes: ancestor, ancestor-or-self, preceding, and preceding-sibling

2022-09-08 Thread Rahul Prabhu
On Thu, 8 Sep 2022 15:54:03 GMT, Rajan Halade wrote: >> Created two files for testing XPath Axes: XPathAncestors.java tests the >> ancestor and ancestor-or-self axes, while XPathPrecedingTest.java tests the >> preceding and preceding-sibling axes. > > Please fix jcheck issues. Code has trailing

RFR: 8289508: Improve test coverage for XPath Axes: ancestor, ancestor-or-self, preceding, and preceding-sibling

2022-09-08 Thread Rahul Prabhu
Created two files for testing XPath Axes: XPathAncestors.java tests the ancestor and ancestor-or-self axes, while XPathPrecedingTest.java tests the preceding and preceding-sibling axes. - Commit messages: - Update XPathAncestorsTest.java to remove whitespace - 8289508: Update Prec

Integrated: 8230374: maxOutputSize, instead of javatest.maxOutputSize, should be used in TEST.properties

2022-09-01 Thread Rahul Prabhu
On Mon, 29 Aug 2022 21:25:29 GMT, Rahul Prabhu wrote: > Rewrote javatest.maxOutputSize as maxOutputSize in the TEST.properties file > in test/jdk/jdk/lambda to match the same declarations in other > TEST.properties files. The jtreg specification with the correct syntax for > maxO

Re: RFR: 8230374: maxOutputSize, instead of javatest.maxOutputSize, should be used in TEST.properties

2022-08-31 Thread Rahul Prabhu
On Mon, 29 Aug 2022 21:25:29 GMT, Rahul Prabhu wrote: > Rewrote javatest.maxOutputSize as maxOutputSize in the TEST.properties file > in test/jdk/jdk/lambda to match the same declarations in other > TEST.properties files. The jtreg specification with the correct syntax for > maxO

RFR: 8230374: maxOutputSize, instead of javatest.maxOutputSize, should be used in TEST.properties

2022-08-31 Thread Rahul Prabhu
Rewrote javatest.maxOutputSize as maxOutputSize in the TEST.properties file in test/jdk/jdk/lambda to match the same declarations in other TEST.properties files. The jtreg specification with the correct syntax for maxOutputSize is at https://openjdk.org/jtreg/tag-spec.html. - Commi