Re: RFE: Refactor java.util.Optional and add NonNull checks

2023-08-28 Thread Quân Anh Mai
; > > OptionalOfTest.emDynamicAnonymous thrpt 30 > 549907.559 > ± 14560.954 ops/s > > OptionalOfTest.emJdk thrpt 30 > 557858.903 > ± 2851.076 ops/s > > *OptionalOfTest.emNestedStatic

Re: RFE: Refactor java.util.Optional and add NonNull checks

2023-08-28 Thread Quân Anh Mai
Hi, Polymorphism is a performance killer. Normally this does not matter much, but for thin wrappers such as Optional, this is one of the most important factor. Behaviour polymorphism requires virtual dispatch and prevents inlining. This is really detrimental, as simple operations such as a getter

Re: Add String & Character ASCII case conversion methods

2023-04-11 Thread Quân Anh Mai
Hi, To propose deprecation of String::toLowerCase() and String::toUpperCase(), you can create a patch as normal, with an addition of a CSR ticket that describes the situation and the proposed solution. After that, you can ask for someone from core-libs to review the ticket. The change can be merge