Integrated: 8294980: test/jdk/java/lang/invoke 15 test classes use experimental bytecode library

2023-11-08 Thread Mourad Abbay
On Thu, 19 Oct 2023 14:37:06 GMT, Mourad Abbay wrote: > early experimental version of the bytecode library is bundled under: > test/jdk/lib/testlibrary/bytecode > > following tests reference it: > test/jdk/java/lang/invoke/common/test/java/lang/invoke/lib/InstructionHelper.java

Re: RFR: 8294980: test/jdk/java/lang/invoke 15 test classes use experimental bytecode library [v5]

2023-11-08 Thread Mourad Abbay
On Wed, 8 Nov 2023 12:15:13 GMT, Adam Sotona wrote: >> You can see `java.lang.constant.ConstantUtils.validateMemberName` > > So how is it possible that `testValidNames` has been passing with the name? > Conversion should not change the tested subjects. I think the old experimental library wasn't

Re: RFR: 8294980: test/jdk/java/lang/invoke 15 test classes use experimental bytecode library [v5]

2023-11-08 Thread Mourad Abbay
On Wed, 8 Nov 2023 12:26:26 GMT, Mourad Abbay wrote: >> So how is it possible that `testValidNames` has been passing with the name? >> Conversion should not change the tested subjects. > > I think the old experimental library wasn't validating constant name. In the >

Re: RFR: 8294980: test/jdk/java/lang/invoke 15 test classes use experimental bytecode library [v5]

2023-11-08 Thread Mourad Abbay
On Wed, 8 Nov 2023 12:09:57 GMT, Mourad Abbay wrote: >> test/jdk/java/lang/invoke/condy/CondyNameValidationTest.java line 72: >> >>> 70: return Stream.of("", >>> 71: "", >>> 72:

Re: RFR: 8294980: test/jdk/java/lang/invoke 15 test classes use experimental bytecode library [v5]

2023-11-08 Thread Mourad Abbay
On Wed, 8 Nov 2023 11:56:27 GMT, Adam Sotona wrote: >> Mourad Abbay has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 21 addi

Re: RFR: 8294980: test/jdk/java/lang/invoke 15 test classes use experimental bytecode library [v5]

2023-11-07 Thread Mourad Abbay
onTest.java > test/jdk/java/lang/invoke/condy/CondyBSMValidationTest.java > test/jdk/java/lang/invoke/condy/CondyNameValidationTest.java > test/jdk/java/lang/invoke/condy/CondyBSMException.java > test/jdk/java/lang/invoke/condy/CondyInterfaceWithOverpassMethods.java Mourad Abbay has updated the pull reques

Re: RFR: 8294980: test/jdk/java/lang/invoke 15 test classes use experimental bytecode library [v4]

2023-11-07 Thread Mourad Abbay
onTest.java > test/jdk/java/lang/invoke/condy/CondyBSMValidationTest.java > test/jdk/java/lang/invoke/condy/CondyNameValidationTest.java > test/jdk/java/lang/invoke/condy/CondyBSMException.java > test/jdk/java/lang/invoke/condy/CondyInterfaceWithOverpassMethods.java Mourad Abbay has updated the pull request

Re: RFR: 8294980: test/jdk/java/lang/invoke 15 test classes use experimental bytecode library [v3]

2023-11-07 Thread Mourad Abbay
onTest.java > test/jdk/java/lang/invoke/condy/CondyBSMValidationTest.java > test/jdk/java/lang/invoke/condy/CondyNameValidationTest.java > test/jdk/java/lang/invoke/condy/CondyBSMException.java > test/jdk/java/lang/invoke/condy/CondyInterfaceWithOverpassMethods.java Mourad Abbay has updated the pull reques

Re: RFR: 8294980: test/jdk/java/lang/invoke 15 test classes use experimental bytecode library [v2]

2023-11-03 Thread Mourad Abbay
onTest.java > test/jdk/java/lang/invoke/condy/CondyBSMValidationTest.java > test/jdk/java/lang/invoke/condy/CondyNameValidationTest.java > test/jdk/java/lang/invoke/condy/CondyBSMException.java > test/jdk/java/lang/invoke/condy/CondyInterfaceWithOverpassMethods.java Mourad Abbay has updated the pull request

Re: RFR: 8294980: test/jdk/java/lang/invoke 15 test classes use experimental bytecode library

2023-11-03 Thread Mourad Abbay
On Mon, 23 Oct 2023 01:15:54 GMT, Chen Liang wrote: >> early experimental version of the bytecode library is bundled under: >> test/jdk/lib/testlibrary/bytecode >> >> following tests reference it: >> test/jdk/java/lang/invoke/common/test/java/lang/invoke/lib/InstructionHelper.java >> test/jdk/ja

RFR: 8294980: test/jdk/java/lang/invoke 15 test classes use experimental bytecode library

2023-11-03 Thread Mourad Abbay
early experimental version of the bytecode library is bundled under: test/jdk/lib/testlibrary/bytecode following tests reference it: test/jdk/java/lang/invoke/common/test/java/lang/invoke/lib/InstructionHelper.java test/jdk/java/lang/invoke/condy/CondyWithGarbageTest.java test/jdk/java/lang/invoke

Integrated: 8317034: Remove redundant type cast in the java.util.stream package

2023-10-02 Thread Mourad Abbay
On Wed, 27 Sep 2023 08:50:20 GMT, Mourad Abbay wrote: > Remove redundant type cast in the java.util.stream package. This pull request has now been integrated. Changeset: ad81abd2 Author: Mourad Abbay Committer: Paul Sandoz URL: https://git.openjdk.org/jdk/com

Integrated: 8316998: Remove redundant type arguments in the java.util.stream package

2023-09-29 Thread Mourad Abbay
On Wed, 27 Sep 2023 00:58:01 GMT, Mourad Abbay wrote: > Remove cases of redundant type arguments in the java.util.stream package. This pull request has now been integrated. Changeset: fa0697a6 Author: Mourad Abbay Committer: Paul Sandoz URL: https://git.openjdk.org/jdk/com

Re: RFR: 8316998: Remove redundant type arguments in the java.util.stream package [v3]

2023-09-28 Thread Mourad Abbay
On Fri, 29 Sep 2023 00:35:08 GMT, Paul Sandoz wrote: > > Are you referring to the expand of lambdas and the extra whitespaces ? > > Yes, sometimes the IDE just does it automatically! Is there a way I can make the IDE respect the code style? - PR Comment: https://git.openjdk.org/jd

Re: RFR: 8316998: Remove redundant type arguments in the java.util.stream package [v3]

2023-09-28 Thread Mourad Abbay
On Thu, 28 Sep 2023 22:05:15 GMT, Paul Sandoz wrote: > Looks good. Note a general rule to mostly follow is to try and stick to the > prevailing style in source being modified and not make additional and > unrelated changes (no matter how tempting it might be). In this case i don't > have stron

Integrated: 8317119: Remove unused imports in the java.util.stream package

2023-09-28 Thread Mourad Abbay
On Wed, 27 Sep 2023 17:45:58 GMT, Mourad Abbay wrote: > Remove unused imports in the java.util.stream package. This pull request has now been integrated. Changeset: f2c221de Author: Mourad Abbay Committer: Paul Sandoz URL: https://git.openjdk.org/jdk/com

Re: RFR: 8317034: Redundant type cast [v3]

2023-09-27 Thread Mourad Abbay
> Remove redundant type cast in the java.util.stream package. Mourad Abbay has updated the pull request incrementally with one additional commit since the last revision: Update copyright year. - Changes: - all: https://git.openjdk.org/jdk/pull/15942/files - new: ht

Re: RFR: 8317119: Unused imports in the java.util.stream package [v2]

2023-09-27 Thread Mourad Abbay
> Remove unused imports in the java.util.stream package. Mourad Abbay has updated the pull request incrementally with one additional commit since the last revision: Update copyright year. - Changes: - all: https://git.openjdk.org/jdk/pull/15949/files - new: ht

Re: RFR: 8316998: Remove redundant type arguments [v3]

2023-09-27 Thread Mourad Abbay
> Remove cases of redundant type arguments in the java.util.stream package. Mourad Abbay has updated the pull request incrementally with one additional commit since the last revision: Update copyright year. - Changes: - all: https://git.openjdk.org/jdk/pull/15936/files -

Re: RFR: 8316998: Remove redundant type arguments [v2]

2023-09-27 Thread Mourad Abbay
> Remove cases of redundant type arguments in the java.util.stream package. Mourad Abbay has updated the pull request incrementally with one additional commit since the last revision: Remove redundant type arguments. - Changes: - all: https://git.openjdk.org/jdk/pull/15

Re: RFR: 8317034: Redundant type cast [v2]

2023-09-27 Thread Mourad Abbay
> Remove redundant type cast in the java.util.stream package. Mourad Abbay has updated the pull request incrementally with one additional commit since the last revision: Apply Paul's review. - Changes: - all: https://git.openjdk.org/jdk/pull/15942/files - ne

RFR: 8317119: Unused imports in the java.util.stream package

2023-09-27 Thread Mourad Abbay
Remove unused imports in the java.util.stream package. - Commit messages: - Remove unused imports. Changes: https://git.openjdk.org/jdk/pull/15949/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=15949&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8317119 Stats: 9 l

RFR: 8317034: Redundant type cast

2023-09-27 Thread Mourad Abbay
Remove redundant type cast in the java.util.stream package. - Commit messages: - Remove redundant type cast. Changes: https://git.openjdk.org/jdk/pull/15942/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=15942&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8317034

RFR: 8316998: Remove redundant type arguments

2023-09-26 Thread Mourad Abbay
Remove cases of redundant type arguments in the java.util.stream package. - Commit messages: - Remove redundant type arguments. Changes: https://git.openjdk.org/jdk/pull/15936/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=15936&range=00 Issue: https://bugs.openjdk.org/br

Integrated: 8271268: Fix Javadoc links for Stream.mapMulti

2023-09-25 Thread Mourad Abbay
On Mon, 18 Sep 2023 18:09:57 GMT, Mourad Abbay wrote: > Fix Javadoc links for Stream.mapMulti, Stream.MapMultiInt, > Stream.mapMultiToInt, Stream.mapMultiToLong and Stream.mapMultiToDouble. This pull request has now been integrated. Changeset: afa48333 Author:Mourad Abbay Committer

Re: RFR: 8271268: Fix Javadoc links for Stream.mapMulti [v4]

2023-09-22 Thread Mourad Abbay
> Fix Javadoc links for Stream.mapMulti, Stream.MapMultiInt, > Stream.mapMultiToInt, Stream.mapMultiToLong and Stream.mapMultiToDouble. Mourad Abbay has updated the pull request incrementally with one additional commit since the last revision: Update full name - C

Re: RFR: 8271268: Fix Javadoc links for Stream.mapMulti [v3]

2023-09-22 Thread Mourad Abbay
> Fix Javadoc links for Stream.mapMulti, Stream.MapMultiInt, > Stream.mapMultiToInt, Stream.mapMultiToLong and Stream.mapMultiToDouble. Mourad Abbay has updated the pull request incrementally with one additional commit since the last revision: Display links to Stream.flatM

Re: RFR: 8271268: Fix Javadoc links for Stream.mapMulti [v2]

2023-09-22 Thread Mourad Abbay
> Fix Javadoc links for Stream.mapMulti, Stream.MapMultiInt, > Stream.mapMultiToInt, Stream.mapMultiToLong and Stream.mapMultiToDouble. Mourad Abbay has updated the pull request incrementally with one additional commit since the last revision: Display links to Stream.flatM

Re: RFR: 8271268: Fix Javadoc links for Stream.mapMulti

2023-09-22 Thread Mourad Abbay
On Fri, 22 Sep 2023 11:06:13 GMT, Chen Liang wrote: >> Fix Javadoc links for Stream.mapMulti, Stream.MapMultiInt, >> Stream.mapMultiToInt, Stream.mapMultiToLong and Stream.mapMultiToDouble. > > Then it's a bug with Intellij IDEA not able to parse these links correctly. > It should be fixed in t

Re: RFR: 8271268: Fix Javadoc links for Stream.mapMulti

2023-09-22 Thread Mourad Abbay
On Fri, 22 Sep 2023 08:42:39 GMT, Chen Liang wrote: >> Fix Javadoc links for Stream.mapMulti, Stream.MapMultiInt, >> Stream.mapMultiToInt, Stream.mapMultiToLong and Stream.mapMultiToDouble. > > What is this patch looking to fix? The link is not broken in the first place. > This `#mapMulti mapMu

RFR: 8271268: Fix Javadoc links for Stream.mapMulti

2023-09-20 Thread Mourad Abbay
Fix Javadoc links for Stream.mapMulti, Stream.MapMultiInt, Stream.mapMultiToInt, Stream.mapMultiToLong and Stream.mapMultiToDouble. - Commit messages: - Fix Javadoc links for Stream.mapMulti. Changes: https://git.openjdk.org/jdk/pull/15794/files Webrev: https://webrevs.openjdk.org