Integrated: 8348986: Improve coverage of enhanced exception messages

2025-06-03 Thread Michael McMahon
On Thu, 6 Mar 2025 10:24:13 GMT, Michael McMahon wrote: > Hi, > > Enhanced exception messages are designed to hide sensitive information such > as hostnames, IP > addresses from exception message strings, unless the enhanced mode for the > specific category > has be

Re: RFR: 8348986: Improve coverage of enhanced exception messages [v20]

2025-06-03 Thread Michael McMahon
om the message text. > > The changes to the java.security conf file describe the exact changes in > terms of the categories now > supported and any changes in behavior. > > Thanks, > Michael Michael McMahon has updated the pull request incrementally with one additional commit si

Re: RFR: 8348986: Improve coverage of enhanced exception messages [v19]

2025-06-03 Thread Michael McMahon
om the message text. > > The changes to the java.security conf file describe the exact changes in > terms of the categories now > supported and any changes in behavior. > > Thanks, > Michael Michael McMahon has updated the pull request with a new target base due to a merge or

Re: RFR: 8348986: Improve coverage of enhanced exception messages [v18]

2025-05-30 Thread Michael McMahon
om the message text. > > The changes to the java.security conf file describe the exact changes in > terms of the categories now > supported and any changes in behavior. > > Thanks, > Michael Michael McMahon has updated the pull request incrementally with two additional commits s

Re: RFR: 8348986: Improve coverage of enhanced exception messages [v17]

2025-05-30 Thread Michael McMahon
om the message text. > > The changes to the java.security conf file describe the exact changes in > terms of the categories now > supported and any changes in behavior. > > Thanks, > Michael Michael McMahon has updated the pull request incrementally with one additional commit sin

Re: RFR: 8348986: Improve coverage of enhanced exception messages [v16]

2025-05-30 Thread Michael McMahon
On Fri, 30 May 2025 13:32:08 GMT, Sean Mullan wrote: >> Michael McMahon has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fixed problem with j.n.HostPortRange > > src/java.base/share/conf/security/java.

Re: RFR: 8348986: Improve coverage of enhanced exception messages [v16]

2025-05-30 Thread Michael McMahon
om the message text. > > The changes to the java.security conf file describe the exact changes in > terms of the categories now > supported and any changes in behavior. > > Thanks, > Michael Michael McMahon has updated the pull request incrementally with one additional commit sin

Re: RFR: 8348986: Improve coverage of enhanced exception messages [v15]

2025-05-30 Thread Michael McMahon
On Fri, 30 May 2025 09:39:36 GMT, Michael McMahon wrote: >> Hi, >> >> Enhanced exception messages are designed to hide sensitive information such >> as hostnames, IP >> addresses from exception message strings, unless the enhanced mode for the >> speci

Re: RFR: 8348986: Improve coverage of enhanced exception messages [v15]

2025-05-30 Thread Michael McMahon
om the message text. > > The changes to the java.security conf file describe the exact changes in > terms of the categories now > supported and any changes in behavior. > > Thanks, > Michael Michael McMahon has updated the pull request with a new target base due to a merge or a r

Re: RFR: 8348986: Improve coverage of enhanced exception messages [v13]

2025-05-30 Thread Michael McMahon
On Thu, 29 May 2025 14:35:11 GMT, Michael McMahon wrote: >> Hi, >> >> Enhanced exception messages are designed to hide sensitive information such >> as hostnames, IP >> addresses from exception message strings, unless the enhanced mode for the >> speci

Re: RFR: 8348986: Improve coverage of enhanced exception messages [v14]

2025-05-30 Thread Michael McMahon
om the message text. > > The changes to the java.security conf file describe the exact changes in > terms of the categories now > supported and any changes in behavior. > > Thanks, > Michael Michael McMahon has updated the pull request incrementally with one additiona

Re: RFR: 8348986: Improve coverage of enhanced exception messages [v13]

2025-05-29 Thread Michael McMahon
om the message text. > > The changes to the java.security conf file describe the exact changes in > terms of the categories now > supported and any changes in behavior. > > Thanks, > Michael Michael McMahon has updated the pull request incrementally with one additional

Re: RFR: 8348986: Improve coverage of enhanced exception messages [v12]

2025-05-29 Thread Michael McMahon
On Wed, 28 May 2025 23:13:21 GMT, Mark Sheppard wrote: > here are a few files with IOException, UnknownHostException and > MalformedURLException, which are worth reviewing for Exception that may have > been missed > > IOEXception: > > open/src/java.base/share/classes/sun/net/www/protocol/http

Re: RFR: 8348986: Improve coverage of enhanced exception messages [v11]

2025-05-29 Thread Michael McMahon
On Mon, 26 May 2025 20:39:51 GMT, Mark Sheppard wrote: > You could take a slightly more radical approach, and rather than applying a > filter explicitly on the exception message, adopt a builder pattern for the > creation of the filter exceptions, for example > > FilteredExceptionBuilder / Enh

Re: RFR: 8348986: Improve coverage of enhanced exception messages [v11]

2025-05-28 Thread Michael McMahon
On Mon, 26 May 2025 17:40:39 GMT, Mark Sheppard wrote: >> Michael McMahon has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 28 commits: >> >> - Merge branch 'master' into 8348986-exceptions >&g

Re: RFR: 8348986: Improve coverage of enhanced exception messages [v11]

2025-05-28 Thread Michael McMahon
On Mon, 26 May 2025 17:07:45 GMT, Mark Sheppard wrote: >> Michael McMahon has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 28 commits: >> >> - Merge branch 'master' into 8348986-exceptions >&g

Re: RFR: 8348986: Improve coverage of enhanced exception messages [v12]

2025-05-28 Thread Michael McMahon
om the message text. > > The changes to the java.security conf file describe the exact changes in > terms of the categories now > supported and any changes in behavior. > > Thanks, > Michael Michael McMahon has updated the pull request with a new target base due to a merge o

Integrated: 8353124: java/lang/Thread/virtual/stress/Skynet.java#Z times out on macosx-x64-debug

2025-05-27 Thread Michael McMahon
On Tue, 20 May 2025 15:25:52 GMT, Michael McMahon wrote: > Hi, > > This is a simple test update which increases a timeout from 300s to 400 to > account for slow mac os test machines. > A repeat 50 test of :jdk_lang passes. I will run this a few more times before > pushing

Re: RFR: 8353124: java/lang/Thread/virtual/stress/Skynet.java#Z times out on macosx-x64-debug [v2]

2025-05-27 Thread Michael McMahon
> Hi, > > This is a simple test update which increases a timeout from 300s to 400 to > account for slow mac os test machines. > A repeat 50 test of :jdk_lang passes. I will run this a few more times before > pushing, if the change is acceptable. > > Thanks, > M

Re: RFR: 8348986: Improve coverage of enhanced exception messages [v11]

2025-05-26 Thread Michael McMahon
om the message text. > > The changes to the java.security conf file describe the exact changes in > terms of the categories now > supported and any changes in behavior. > > Thanks, > Michael Michael McMahon has updated the pull request with a new target base due to a merge or a r

RFR: 8353124: java/lang/Thread/virtual/stress/Skynet.java#Z times out on macosx-x64-debug

2025-05-20 Thread Michael McMahon
Hi, This is a simple test update which increases a timeout from 300s to 400 to account for slow mac os test machines. A repeat 50 test of :jdk_lang passes. I will run this a few more times before pushing, if the change is acceptable. Thanks, Michael - Commit messages: - test upda

Re: RFR: 8348986: Improve coverage of enhanced exception messages [v10]

2025-05-16 Thread Michael McMahon
om the message text. > > The changes to the java.security conf file describe the exact changes in > terms of the categories now > supported and any changes in behavior. > > Thanks, > Michael Michael McMahon has updated the pull request with a new target base due to a merge or

Re: RFR: 8348986: Improve coverage of enhanced exception messages [v9]

2025-04-29 Thread Michael McMahon
om the message text. > > The changes to the java.security conf file describe the exact changes in > terms of the categories now > supported and any changes in behavior. > > Thanks, > Michael Michael McMahon has updated the pull request with a new target base due to a merge o

Re: RFR: 8348986: Improve coverage of enhanced exception messages [v8]

2025-04-25 Thread Michael McMahon
om the message text. > > The changes to the java.security conf file describe the exact changes in > terms of the categories now > supported and any changes in behavior. > > Thanks, > Michael Michael McMahon has updated the pull request with a new target base due to a merge or

Re: RFR: 8348986: Improve coverage of enhanced exception messages [v7]

2025-04-24 Thread Michael McMahon
om the message text. > > The changes to the java.security conf file describe the exact changes in > terms of the categories now > supported and any changes in behavior. > > Thanks, > Michael Michael McMahon has updated the pull request incrementally with one additional commit s

Re: RFR: 8349910: Implement HTTP/3 for the HTTP Client API

2025-04-23 Thread Michael McMahon
On Fri, 18 Apr 2025 18:47:52 GMT, Chen Liang wrote: >> Hi, >> >> Please find here a PR for the implementation of JEP [JDK-8291976: HTTP/3 for >> the HTTP Client API](https://bugs.openjdk.org/browse/JDK-8291976). >> >> The CSR can be viewed at [JDK-8350588: Implement HTTP/3 for the HTTP Client

Re: RFR: 8348986: Improve coverage of enhanced exception messages [v6]

2025-04-15 Thread Michael McMahon
om the message text. > > The changes to the java.security conf file describe the exact changes in > terms of the categories now > supported and any changes in behavior. > > Thanks, > Michael Michael McMahon has updated the pull request with a new target base due to a merge or

Re: RFR: 8348986: Improve coverage of enhanced exception messages [v5]

2025-04-15 Thread Michael McMahon
On Mon, 14 Apr 2025 14:20:39 GMT, Daniel Fuchs wrote: >> Michael McMahon has updated the pull request incrementally with one >> additional commit since the last revision: >> >> update to minimise code changes > > test/jdk/java/net/URI/Test.java line 29: >

Re: RFR: 8348986: Improve coverage of enhanced exception messages [v5]

2025-04-15 Thread Michael McMahon
On Mon, 14 Apr 2025 13:51:30 GMT, Daniel Fuchs wrote: >> Michael McMahon has updated the pull request incrementally with one >> additional commit since the last revision: >> >> update to minimise code changes > > src/java.base/share/classes/java/net/

Re: RFR: 8348986: Improve coverage of enhanced exception messages [v5]

2025-04-10 Thread Michael McMahon
On Thu, 10 Apr 2025 21:26:21 GMT, Michael McMahon wrote: >> Hi, >> >> Enhanced exception messages are designed to hide sensitive information such >> as hostnames, IP >> addresses from exception message strings, unless the enhanced mode for the >> speci

Re: RFR: 8348986: Improve coverage of enhanced exception messages [v5]

2025-04-10 Thread Michael McMahon
om the message text. > > The changes to the java.security conf file describe the exact changes in > terms of the categories now > supported and any changes in behavior. > > Thanks, > Michael Michael McMahon has updated the pull request incrementally with one additional commit si

Re: RFR: 8348986: Improve coverage of enhanced exception messages [v4]

2025-04-09 Thread Michael McMahon
om the message text. > > The changes to the java.security conf file describe the exact changes in > terms of the categories now > supported and any changes in behavior. > > Thanks, > Michael Michael McMahon has updated the pull request with a new target base due to a merge o

Re: RFR: 8348986: Improve coverage of enhanced exception messages [v3]

2025-03-06 Thread Michael McMahon
om the message text. > > The changes to the java.security conf file describe the exact changes in > terms of the categories now > supported and any changes in behavior. > > Thanks, > Michael Michael McMahon has updated the pull request incrementally with one additional commi

Re: RFR: 8348986: Improve coverage of enhanced exception messages [v2]

2025-03-06 Thread Michael McMahon
om the message text. > > The changes to the java.security conf file describe the exact changes in > terms of the categories now > supported and any changes in behavior. > > Thanks, > Michael Michael McMahon has updated the pull request incrementally with one additional commi

RFR: 8348986: Improve coverage of enhanced exception messages

2025-03-06 Thread Michael McMahon
Hi, Enhanced exception messages are designed to hide sensitive information such as hostnames, IP addresses from exception message strings, unless the enhanced mode for the specific category has been explicitly enabled. Enhanced exceptions were first introduced in 8204233 in JDK 11 and update

Re: RFR: 8338383: Implement JEP 491: Synchronize Virtual Threads without Pinning

2024-11-06 Thread Michael McMahon
On Thu, 17 Oct 2024 14:28:30 GMT, Patricio Chilano Mateo wrote: > This is the implementation of JEP 491: Synchronize Virtual Threads without > Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for > further details. > > In order to make the code review easier the changes hav

Re: RFR: 8338383: Implement JEP 491: Synchronize Virtual Threads without Pinning [v16]

2024-10-29 Thread Michael McMahon
On Tue, 29 Oct 2024 00:04:09 GMT, Patricio Chilano Mateo wrote: >> This is the implementation of JEP 491: Synchronize Virtual Threads without >> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for >> further details. >> >> In order to make the code review easier the change

Re: RFR: 8338411: Implement JEP 486: Permanently Disable the Security Manager [v3]

2024-10-25 Thread Michael McMahon
On Thu, 24 Oct 2024 13:19:55 GMT, Sean Mullan wrote: >> This is the implementation of JEP 486: Permanently Disable the Security >> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The >> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the >> main ch

Re: RFR: 8338411: Implement JEP 486: Permanently Disable the Security Manager [v2]

2024-10-22 Thread Michael McMahon
On Fri, 18 Oct 2024 19:03:30 GMT, Sean Mullan wrote: >> This is the implementation of JEP 486: Permanently Disable the Security >> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The >> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the >> main ch

Re: RFR: 8338445: jdk.internal.loader.URLClassPath may leak JarFile instance when dealing with unexpected Class-Path entry in manifest [v3]

2024-08-28 Thread Michael McMahon
On Tue, 27 Aug 2024 08:38:23 GMT, Jaikiran Pai wrote: >> Can I please get a review of this change which proposes to fix the issue >> noted in https://bugs.openjdk.org/browse/JDK-8338445? >> >> The JDK internal class `jdk.internal.loader.URLClassPath` is used by >> classloader implementations i

Re: RFR: 8338445: jdk.internal.loader.URLClassPath may leak JarFile instance when dealing with unexpected Class-Path entry in manifest [v2]

2024-08-26 Thread Michael McMahon
On Mon, 26 Aug 2024 03:47:49 GMT, Jaikiran Pai wrote: >> Can I please get a review of this change which proposes to fix the issue >> noted in https://bugs.openjdk.org/browse/JDK-8338445? >> >> The JDK internal class `jdk.internal.loader.URLClassPath` is used by >> classloader implementations i

Re: RFR: 8338445: jdk.internal.loader.URLClassPath may leak JarFile instance when dealing with unexpected Class-Path entry in manifest [v2]

2024-08-26 Thread Michael McMahon
On Mon, 26 Aug 2024 15:36:25 GMT, Jaikiran Pai wrote: >> Is the if statement at line 470 redundant then? Presumably the code can >> reach here. > > Hello Michael, >> Is the if statement at line 470 redundant then? > > `Loader.getClassPath()` can return null (and it does for some implementations

Re: RFR: 8338445: jdk.internal.loader.URLClassPath may leak JarFile instance when dealing with unexpected Class-Path entry in manifest [v2]

2024-08-26 Thread Michael McMahon
On Mon, 26 Aug 2024 15:27:39 GMT, Daniel Fuchs wrote: >> src/java.base/share/classes/jdk/internal/loader/URLClassPath.java line 470: >> >>> 468: continue; >>> 469: } >>> 470: if (loaderClassPathURLs != null) { >> >> I'm missing something here. Why does th

Re: RFR: 8338445: jdk.internal.loader.URLClassPath may leak JarFile instance when dealing with unexpected Class-Path entry in manifest [v2]

2024-08-26 Thread Michael McMahon
On Mon, 26 Aug 2024 03:47:49 GMT, Jaikiran Pai wrote: >> Can I please get a review of this change which proposes to fix the issue >> noted in https://bugs.openjdk.org/browse/JDK-8338445? >> >> The JDK internal class `jdk.internal.loader.URLClassPath` is used by >> classloader implementations i

Re: RFR: JDK-8327474 Review use of java.io.tmpdir in jdk tests [v3]

2024-03-26 Thread Michael McMahon
On Thu, 21 Mar 2024 17:13:46 GMT, Bill Huang wrote: >> This task addresses an essential aspect of our testing infrastructure: the >> proper handling and cleanup of temporary files and socket files created >> during test execution. The motivation behind these changes is to prevent the >> accumu

Re: CFV: New Core Libraries Group Member: Per-Ake Minborg

2024-03-22 Thread Michael McMahon
Vote: Yes On 19/03/2024 16:19, Daniel Fuchs wrote: Hi, I hereby nominate Per-Ake Minborg (pminborg) [1] to Membership in the Core Libraries Group [4]. Per-Ake is an OpenJDK Reviewer, a committer in the Leyden and Panama projects, and a member of Oracle’s Java Core Libraries team. Per-Ake ha

Re: CFV: New Core Libraries Group Member: Viktor Klang

2024-02-21 Thread Michael McMahon
Vote: Yes On 20/02/2024 17:51, Naoto Sato wrote: Vote: yes Naoto On 2/19/24 3:40 PM, Stuart Marks wrote: I hereby nominate Viktor Klang [6] to Membership in the Core Libraries Group [4]. Viktor has been a member of the Java team in Oracle since 2022, and he is currently a Committer on th

Re: CFV: New Core Libraries Group Member: Raffaello Giulietti

2024-02-14 Thread Michael McMahon
Vote: Yes On 13/02/2024 20:25, Brian Burkhalter wrote: I hereby nominate Raffaello Giulietti to Membership in the Core Libraries Group. Raffaello has been working in the Core Library team at Oracle since April, 2022. He has authored more than 50 contributions to OpenJDK in a number of areas i

Re: HttpURLConnection cache issues leading to crashes in JGSS w/ native GSS introduced by 8303809

2023-10-23 Thread Michael McMahon
Hi, Thanks for bringing this to our attention. You are right that this is a misuse of the authentication cache in the case of Kerberos (Negotiate) authentication. Though that is not the case for other auth schemes, because normally what gets cached are credentials, rather than security tokens

Re: RFR: 8308748: JNU_GetStringPlatformChars may write to String's internal memory array

2023-05-26 Thread Michael McMahon
On Wed, 24 May 2023 09:24:46 GMT, Rudi Horn wrote: > This change prevents the contents of the internal string array from being > copied back when releasing it. There was an unrelated change to these functions recently. You might want to rebase this PR with the latest version. - P

Integrated: 8300038: Make new version of JNU_GetStringPlatformChars which checks for null characters

2023-05-25 Thread Michael McMahon
On Mon, 22 May 2023 13:19:04 GMT, Michael McMahon wrote: > This PR creates a new version of the JNI utility function > JNU_GetStringPlatformChars called JNU_GetStringPlatformCharsStrict, which > performs additional validation of the returned string, namely that it does > not

Re: RFR: 8300038: Make new version of JNU_GetStringPlatformChars which checks for null characters [v4]

2023-05-25 Thread Michael McMahon
On Wed, 24 May 2023 20:46:23 GMT, Michael McMahon wrote: >> This PR creates a new version of the JNI utility function >> JNU_GetStringPlatformChars called JNU_GetStringPlatformCharsStrict, which >> performs additional validation of the returned string, namely that it does

Re: RFR: 8300038: Make new version of JNU_GetStringPlatformChars which checks for null characters [v3]

2023-05-24 Thread Michael McMahon
On Wed, 24 May 2023 14:30:01 GMT, Alan Bateman wrote: > I skimmed through the changes and mostly look okay. There's a few usage of > "NULL" in exception messages that I assume should be "NUL character". > Probably need to bump the copyright date on several files. You might want to > find a bet

Re: RFR: 8300038: Make new version of JNU_GetStringPlatformChars which checks for null characters [v4]

2023-05-24 Thread Michael McMahon
iew the effect of > making the switch. Otherwise, surprising behavior changes might occur (eg > undocumented IAE being thrown to user code instead of some other exception). Michael McMahon has updated the pull request with a new target base due to a merge or a rebase. The pull request n

Re: RFR: 8300038: Make new version of JNU_GetStringPlatformChars which checks for null characters [v3]

2023-05-24 Thread Michael McMahon
iew the effect of > making the switch. Otherwise, surprising behavior changes might occur (eg > undocumented IAE being thrown to user code instead of some other exception). Michael McMahon has updated the pull request with a new target base due to a merge or a rebase. The pull request n

Re: RFR: 8300038: Make new version of JNU_GetStringPlatformChars which checks for null characters [v2]

2023-05-23 Thread Michael McMahon
iew the effect of > making the switch. Otherwise, surprising behavior changes might occur (eg > undocumented IAE being thrown to user code instead of some other exception). Michael McMahon has updated the pull request incrementally with one additional commit since the last

RFR: 8300038: Make new version of JNU_GetStringPlatformChars which checks for null characters

2023-05-23 Thread Michael McMahon
This PR creates a new version of the JNI utility function JNU_GetStringPlatformChars called JNU_GetStringPlatformCharsStrict, which performs additional validation of the returned string, namely that it does not contain any embedded NULL characters. If any such characters are found the function

Re: RFR: 7065228: To interpret case-insensitive string locale independently [v2]

2023-05-19 Thread Michael McMahon
On Wed, 17 May 2023 13:53:55 GMT, Darragh Clarke wrote: >> Updated instances of `toLowerCase` and `toUpperCase` in several net and io >> files to specify `Locale.ROOT` to ensure that case conversion issues don't >> occur, >> >> I didn't add any new tests but ran tier 1-3 with no issues > > Dar

Re: RFR: 7065228: To interpret case-insensitive string locale independently [v2]

2023-05-19 Thread Michael McMahon
On Wed, 17 May 2023 13:53:55 GMT, Darragh Clarke wrote: >> Updated instances of `toLowerCase` and `toUpperCase` in several net and io >> files to specify `Locale.ROOT` to ensure that case conversion issues don't >> occur, >> >> I didn't add any new tests but ran tier 1-3 with no issues > > Dar

Re: RFR: 8297976: Remove sun.net.ProgressMonitor and related classes [v4]

2022-12-06 Thread Michael McMahon
On Tue, 6 Dec 2022 13:42:04 GMT, Daniel Jeliński wrote: >> Please review this patch that removes progress monitoring classes used by >> UrlConnection. >> Since Java 9 these classes are not used in the JDK, and are not exported >> from java.base. If anyone was still using them, reimplementing th

Re: RFR: 8294241: Deprecate URL public constructors [v4]

2022-11-03 Thread Michael McMahon
On Thu, 3 Nov 2022 11:20:03 GMT, Daniel Fuchs wrote: >> Deprecate URL constructors. Developers are encouraged to use `java.net.URI` >> to parse or construct any URL. >> >> The `java.net.URL` class does not itself encode or decode any URL components >> according to the escaping mechanism define

Re: RFR: 8294241: Deprecate URL public constructors [v4]

2022-11-03 Thread Michael McMahon
On Thu, 3 Nov 2022 10:56:28 GMT, Daniel Fuchs wrote: >> Deprecate URL constructors. Developers are encouraged to use `java.net.URI` >> to parse or construct any URL. >> >> The `java.net.URL` class does not itself encode or decode any URL components >> according to the escaping mechanism define

Re: Unused class java.net.InetAddressContainer

2022-10-27 Thread Michael McMahon
Hi, That class was used in the old PlainSocketImpl socket implementation and was left over when we removed it. I'll file an issue to delete it. Thanks, Michael. On 27/10/2022 12:53, Andrey Turbanov wrote: Hello. As I can see, the class 'java.net.InetAddressContainer' is unused in JDK java

Re: RFR: 8294241: Deprecate URL public constructors

2022-10-27 Thread Michael McMahon
On Thu, 27 Oct 2022 05:14:19 GMT, ExE Boss wrote: >> src/java.base/share/classes/java/net/JarURLConnection.java line 177: >> >>> 175: @SuppressWarnings("deprecation") >>> 176: var tmp = jarFileURL = new URL(spec.substring(0, separator++)); >>> 177: >> >> I realise that @Suppres

Re: RFR: 8294241: Deprecate URL public constructors

2022-10-26 Thread Michael McMahon
On Wed, 26 Oct 2022 16:00:56 GMT, Daniel Fuchs wrote: > Deprecate URL constructors. Developers are encouraged to use `java.net.URI` > to parse or construct any URL. > > The `java.net.URL` class does not itself encode or decode any URL components > according to the escaping mechanism defined in

Re: RFR: 8295470: Update openjdk.java.net => openjdk.org URLs in test code

2022-10-18 Thread Michael McMahon
On Tue, 18 Oct 2022 11:55:06 GMT, Magnus Ihse Bursie wrote: > This is a continuation of the effort to update all our URLs to the new > top-level domain. > > This patch updates (most) URLs in testing code. There still exists references > to openjdk.java.net, but that are not strictly used as no

Re: RFR: 8289768: Clean up unused code [v3]

2022-07-11 Thread Michael McMahon
On Fri, 8 Jul 2022 07:08:46 GMT, Daniel Jeliński wrote: >> This patch removes many unused variables and one unused label reported by >> the compilers when relevant warnings are enabled. >> >> The unused code was found by compiling after removing `unused` from the list >> of disabled warnings

Re: RFR: JDK-8288746: HttpClient resources could be reclaimed more eagerly

2022-06-27 Thread Michael McMahon
On Mon, 20 Jun 2022 14:09:27 GMT, Daniel Fuchs wrote: > Hi, > > Please find here a patch that should help the HttpClient's SelectorManager > thread to terminate more timely, allowing the resources consumed by the > client to be released earlier. > > The idea is to use a Cleaner registered wit