Re: RFR: 8352003: Support --add-opens with -XX:+AOTClassLinking

2025-04-17 Thread Matias Saavedra Silva
On Wed, 16 Apr 2025 18:21:41 GMT, Calvin Cheung wrote: > This RFE allows --add-opens to be specified for AOT cache creation. AOT cache > can be used during production run with --add-opens option as long as the same > set of options is used during assembly phase. > > Passed tiers 1 - 4 testing.

Re: RFR: 8352001: AOT cache should not contain classes injected into built-in class loaders [v2]

2025-04-15 Thread Matias Saavedra Silva
On Sat, 12 Apr 2025 18:37:18 GMT, Ioi Lam wrote: >> During an application's training run, it's possible to inject classes into >> the built-in platform/app class loaders with reflection calls. >> >> - Before [JDK-8348426](https://bugs.openjdk.org/browse/JDK-8348426), only >> the names of thes

Re: RFR: 8352437: Support --add-exports with -XX:+AOTClassLinking [v3]

2025-04-01 Thread Matias Saavedra Silva
On Thu, 27 Mar 2025 22:13:02 GMT, Ioi Lam wrote: >> `-XX:+AOTClassLinking` requires the CDS archived full module graph (FMG). >> >> - Before this PR, when `--add-export` is specified, FMG is disabled, so >> AOT caches created with `-XX:+AOTClassLinking` cannot be loaded. >> - After this PR, i

Re: RFR: 8332340: Add JavacBench as a test case for CDS [v4]

2024-05-23 Thread Matias Saavedra Silva
On Wed, 22 May 2024 16:49:36 GMT, Ioi Lam wrote: >> JavacBench is a test program that compiles 90 Java source files. It uses a >> fair amount of invokedynamic callsites, so it's good for testing CDS support >> for indy and lambda expressions. >> >> This test was first integrated into the >> [

Re: RFR: 8332340: Add JavacBench as a test case for CDS [v3]

2024-05-21 Thread Matias Saavedra Silva
On Mon, 20 May 2024 17:24:22 GMT, Ioi Lam wrote: >> JavacBench is a test program that compiles 90 Java source files. It uses a >> fair amount of invokedynamic callsites, so it's good for testing CDS support >> for indy and lambda expressions. >> >> This test was first integrated into the >> [

Re: RFR: 8314250: CDS dump error message: Invoker type parameter must start and end with Object: L3I_L [v2]

2024-03-08 Thread Matias Saavedra Silva
On Fri, 8 Mar 2024 06:51:21 GMT, Calvin Cheung wrote: >> To avoid the CDS dump error message, a fix is during dumping a classlist, >> check if an invoker can be archived. >> If not, don't write the invoker info into the classlist, i.e. don't call >> `logLambdaFormInvoker()`. While generating h

Re: RFR: 8327138: Clean up status management in cdsConfig.hpp and CDS.java

2024-03-06 Thread Matias Saavedra Silva
On Sat, 2 Mar 2024 01:18:06 GMT, Ioi Lam wrote: > A few clean ups: > > 1. Rename functions like "`s_loading_full_module_graph()` to > `is_using_full_module_graph()`. The meaning of "loading" is not clear: it > might be interpreted as to cover only the period where the artifact is being > load

Integrated: 8306582: Remove MetaspaceShared::exit_after_static_dump()

2023-08-02 Thread Matias Saavedra Silva
On Thu, 13 Jul 2023 21:25:17 GMT, Matias Saavedra Silva wrote: > Currently we exit the VM after static dumping with > `MetaspaceShared::exit_after_static_dump()`. > > > // We have finished dumping the static archive. At this point, there may be > pending VM > /

Re: RFR: 8306582: Remove MetaspaceShared::exit_after_static_dump() [v3]

2023-08-02 Thread Matias Saavedra Silva
On Thu, 27 Jul 2023 18:07:12 GMT, Ioi Lam wrote: >> Matias Saavedra Silva has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Refactored KlassToOopHandleTable, Ioi and Alan comments > > Looks good. Just a coup

Re: RFR: 8306582: Remove MetaspaceShared::exit_after_static_dump() [v5]

2023-08-01 Thread Matias Saavedra Silva
inals. > 3. The handling of -Xshare:dump during argument parsing such that the VM can > continue and exit normally with an exit code of 0. > > Verified with tier 1-9 tests. Matias Saavedra Silva has updated the pull request with a new target base due to a merge or a rebase. The in

Re: RFR: 8306582: Remove MetaspaceShared::exit_after_static_dump() [v4]

2023-08-01 Thread Matias Saavedra Silva
On Tue, 1 Aug 2023 17:02:46 GMT, Calvin Cheung wrote: >> Matias Saavedra Silva has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Ioi comments > > src/hotspot/share/oops/constantPool.cpp line 30

Re: RFR: 8306582: Remove MetaspaceShared::exit_after_static_dump() [v4]

2023-07-27 Thread Matias Saavedra Silva
inals. > 3. The handling of -Xshare:dump during argument parsing such that the VM can > continue and exit normally with an exit code of 0. > > Verified with tier 1-9 tests. Matias Saavedra Silva has updated the pull request incrementally with one additional commit since the last r

Re: RFR: 8306582: Remove MetaspaceShared::exit_after_static_dump() [v3]

2023-07-27 Thread Matias Saavedra Silva
inals. > 3. The handling of -Xshare:dump during argument parsing such that the VM can > continue and exit normally with an exit code of 0. > > Verified with tier 1-9 tests. Matias Saavedra Silva has updated the pull request incrementally with one additional commit since the last revi

Re: RFR: 8306582: Remove MetaspaceShared::exit_after_static_dump() [v2]

2023-07-26 Thread Matias Saavedra Silva
On Wed, 26 Jul 2023 18:52:41 GMT, Alan Bateman wrote: >> Matias Saavedra Silva has updated the pull request with a new target base >> due to a merge or a rebase. The pull request now contains five commits: >> >> - Merge fix >> - Restores java loader

Re: RFR: 8306582: Remove MetaspaceShared::exit_after_static_dump()

2023-07-25 Thread Matias Saavedra Silva
On Thu, 13 Jul 2023 21:25:17 GMT, Matias Saavedra Silva wrote: > Currently we exit the VM after static dumping with > `MetaspaceShared::exit_after_static_dump()`. > > > // We have finished dumping the static archive. At this point, there may be > pending VM > /

Re: RFR: 8306582: Remove MetaspaceShared::exit_after_static_dump() [v2]

2023-07-25 Thread Matias Saavedra Silva
inals. > 3. The handling of -Xshare:dump during argument parsing such that the VM can > continue and exit normally with an exit code of 0. > > Verified with tier 1-9 tests. Matias Saavedra Silva has updated the pull request with a new target base due to a merge or a rebase. The pull re

Re: RFR: 8306582: Remove MetaspaceShared::exit_after_static_dump()

2023-07-24 Thread Matias Saavedra Silva
On Mon, 17 Jul 2023 16:55:03 GMT, Ioi Lam wrote: >> Currently we exit the VM after static dumping with >> `MetaspaceShared::exit_after_static_dump()`. >> >> >> // We have finished dumping the static archive. At this point, there may be >> pending VM >> // operations. We have changed some g

RFR: 8306582: Remove MetaspaceShared::exit_after_static_dump()

2023-07-14 Thread Matias Saavedra Silva
Currently we exit the VM after static dumping with `MetaspaceShared::exit_after_static_dump()`. // We have finished dumping the static archive. At this point, there may be pending VM // operations. We have changed some global states (such as vmClasses::_klasses) that // may cause these VM