Re: RFR: 8355962: RISCV64 cross build fails after 8354996

2025-05-02 Thread Man Cao
On Fri, 2 May 2025 19:14:27 GMT, Chen Liang wrote: > Roll back the HelloClasslist downcall generation that caused cross build > failures for riscv64 and aarch64 from x86-64. > > Testing: riscv64 cross build Marked as reviewed by manc (Committer). Yes, I tested that this change fixes the failu

Re: RFR: 8349620: Add VMProps for static JDK [v2]

2025-02-18 Thread Man Cao
On Tue, 18 Feb 2025 19:26:09 GMT, Jiangli Zhou wrote: >> Please review this change that adds the `jdk.static` VMProps. It can be used >> to skip tests not for running on static JDK. >> >> This also adds a new WhiteBox native method, >> `jdk.test.whitebox.WhiteBox.isStatic()`, which is used by

Re: compatibility impact of JDK-8325621 (Improve jspawnhelper version checks)

2024-08-13 Thread Man Cao
HI, In addition to Liam's point, I'd like to point out: 1. The version check in jspawnhelper is for the full JDK version. This means any future in-place JDK update could trigger this problem for long-running applications. 2. Typical Linux package managers (e.g. apt, yum) seem to update the JDK pa

Re: RFR: 8309688: Data race on java.io.ClassCache$CacheRef.strongReferent [v6]

2023-06-15 Thread Man Cao
On Thu, 15 Jun 2023 18:22:46 GMT, Man Cao wrote: >> Hi all, >> >> Could anyone review this small fix for a data race in >> java.io.ClassCache$CacheRef? This fix makes the code safer by making the >> code data-race-free. > > Man Cao has updated the

Integrated: 8309688: Data race on java.io.ClassCache$CacheRef.strongReferent

2023-06-15 Thread Man Cao
On Thu, 8 Jun 2023 22:06:56 GMT, Man Cao wrote: > Hi all, > > Could anyone review this small fix for a data race in > java.io.ClassCache$CacheRef? This fix makes the code safer by making the code > data-race-free. This pull request has now been integrated. Changeset: 5c705166

Re: RFR: 8309688: Data race on java.io.ClassCache$CacheRef.strongReferent [v5]

2023-06-15 Thread Man Cao
On Thu, 15 Jun 2023 08:23:58 GMT, Aleksey Shipilev wrote: >> Man Cao has updated the pull request with a new target base due to a merge >> or a rebase. The incremental webrev excludes the unrelated changes brought >> in by the merge/rebase. The pull request contains five

Re: RFR: 8309688: Data race on java.io.ClassCache$CacheRef.strongReferent [v6]

2023-06-15 Thread Man Cao
> Hi all, > > Could anyone review this small fix for a data race in > java.io.ClassCache$CacheRef? This fix makes the code safer by making the code > data-race-free. Man Cao has updated the pull request incrementally with one additional commit since the last revision:

Re: RFR: 8309688: Data race on java.io.ClassCache$CacheRef.strongReferent [v5]

2023-06-14 Thread Man Cao
> Hi all, > > Could anyone review this small fix for a data race in > java.io.ClassCache$CacheRef? This fix makes the code safer by making the code > data-race-free. Man Cao has updated the pull request with a new target base due to a merge or a rebase. The incremental webr

Re: RFR: 8309688: Data race on java.io.ClassCache$CacheRef.strongReferent [v4]

2023-06-14 Thread Man Cao
On Thu, 15 Jun 2023 00:05:32 GMT, Man Cao wrote: >> Hi all, >> >> Could anyone review this small fix for a data race in >> java.io.ClassCache$CacheRef? This fix makes the code safer by making the >> code data-race-free. > > Man Cao has updated the

Re: RFR: 8309688: Data race on java.io.ClassCache$CacheRef.strongReferent [v4]

2023-06-14 Thread Man Cao
> Hi all, > > Could anyone review this small fix for a data race in > java.io.ClassCache$CacheRef? This fix makes the code safer by making the code > data-race-free. Man Cao has updated the pull request incrementally with one additional commit since the last revision: Remov

Re: RFR: 8309688: Data race on java.io.ClassCache$CacheRef.strongReferent [v2]

2023-06-13 Thread Man Cao
On Tue, 13 Jun 2023 19:42:44 GMT, Aleksey Shipilev wrote: >> Man Cao has updated the pull request with a new target base due to a merge >> or a rebase. The incremental webrev excludes the unrelated changes brought >> in by the merge/rebase. The pull request contains two

Re: RFR: 8309688: Data race on java.io.ClassCache$CacheRef.strongReferent [v3]

2023-06-13 Thread Man Cao
> Hi all, > > Could anyone review this small fix for a data race in > java.io.ClassCache$CacheRef? This fix makes the code safer by making the code > data-race-free. Man Cao has updated the pull request incrementally with one additional commit since the last revision:

Re: RFR: 8309688: Data race on java.io.ClassCache$CacheRef.strongReferent [v2]

2023-06-13 Thread Man Cao
> Hi all, > > Could anyone review this small fix for a data race in > java.io.ClassCache$CacheRef? This fix makes the code safer by making the code > data-race-free. Man Cao has updated the pull request with a new target base due to a merge or a rebase. The incremental webr

Re: RFR: 8309688: Data race on java.io.ClassCache$CacheRef.strongReferent

2023-06-09 Thread Man Cao
On Thu, 8 Jun 2023 22:06:56 GMT, Man Cao wrote: > Hi all, > > Could anyone review this small fix for a data race in > java.io.ClassCache$CacheRef? This fix makes the code safer by making the code > data-race-free. Agree with the analysis that this race looks benign, and the s

Re: RFR: 8309688: Data race on java.io.ClassCache$CacheRef.strongReferent

2023-06-08 Thread Man Cao
On Thu, 8 Jun 2023 22:06:56 GMT, Man Cao wrote: > Hi all, > > Could anyone review this small fix for a data race in > java.io.ClassCache$CacheRef? This fix makes the code safer by making the code > data-race-free. The presubmit failure on linux-x86 looks unrelated to this P

Re: RFR: 8309688: Data race on java.io.ClassCache$CacheRef.strongReferent

2023-06-08 Thread Man Cao
On Thu, 8 Jun 2023 22:06:56 GMT, Man Cao wrote: > Hi all, > > Could anyone review this small fix for a data race in > java.io.ClassCache$CacheRef? This fix makes the code safer by making the code > data-race-free. The pre-submit failures for windows are due to https://b

RFR: 8309688: Data race on java.io.ClassCache$CacheRef.strongReferent

2023-06-08 Thread Man Cao
Hi all, Could anyone review this small fix for a data race in java.io.ClassCache$CacheRef? This fix makes the code safer by making the code data-race-free. - Commit messages: - 8309688: Data race on java.io.ClassCache.strongReferent Changes: https://git.openjdk.org/jdk/pull/14386

Re: RFR: JDK-8293466: libjsig should ignore non-modifying sigaction calls

2022-09-10 Thread Man Cao
On Sat, 10 Sep 2022 06:15:05 GMT, Thomas Stuefe wrote: > Found during code review of > [JDK-8292695](https://bugs.openjdk.org/browse/JDK-8292695). > > We have two bugs in libjsig when we install hotspot signal handlers. Relevant > code in libjsig: > > > int sigaction(int sig, const struct si