Re: Missing throws declaration for NullPointerException in Proxy#getInvocationHandler

2025-05-22 Thread Kevin Bourrillion
I think Steffen is almost certainly right that this was an accidental omission. That omission results in the `@throws IAE` line being *interpreted* as also applying to null, but I doubt it was ever meant that way. I think adding a `@throws NPE` is the right fix, and makes the class more consist

Re: Reg: Proposal: Generalized Number.parseNumber(String) Method for Java

2025-03-29 Thread Kevin Bourrillion
I appreciate you raising this; I think it is relevant to some internal discussions we’re having about the future of Number. Here’s some personal reactions from a team member (not a team consensus opinion): Unfortunately, we’ve found many times that `Number` is a pretty deficient return type tha

Re: Adding BigDecimal.valueOf(float val) constructor

2025-02-13 Thread Kevin Bourrillion
My latest thoughts; please advise if I have misunderstood anything. On Jan 24, 2025, at 3:11 AM, Jan Kowalski wrote: I'd say that, if it's possible, we should reduce the arithmetic artifacts, rather than introduce them through not really needed, and not visible at the first sight, type conver

Re: Adopting SequencedCollection via multi-release jars?

2025-02-06 Thread Kevin Bourrillion
Thanks Fabian! I am trying to get a conversation going about this, and I really appreciate this prod. The fact that a library API like Guava's still can’t use APIs from Java 9 (7 years later) is pretty sad. I am pretty sure there won't be any quick fixes, but I do think we need to push on this

Re: Adding BigDecimal.valueOf(float val) constructor

2025-01-23 Thread Kevin Bourrillion
Hi, Before addressing your request I want to try to just add a little context as to what’s really going on (after which Joe will probably correct me). You might know some or all of this, but it’s a refresher for everyone (including myself). First, the value 0.1d is a “human-friendly” representa

Re: Request for Enhancement: Objects.checkPositionIndex(int, int)

2025-01-13 Thread Kevin Bourrillion
Oh hey, I named those Guava methods. :-) This was my attempt to promote the terms “position indexes vs. element indexes” and hope that the idea caught on... which I’d say it still never has. I’m surprised you even noticed the methods. The notion is that “element indexes” are the buckets and “po

RE: Deprecate Double.MIN_VALUE?

2024-12-11 Thread Kevin Bourrillion
The team isn't unanimous about this yet, but I think it's worth considering fully. I've filed https://bugs.openjdk.org/browse/JDK-8346033 and gave my analysis of the situation there. I'll try to nudge it to some resolution - thanks for raising it! > On Mon Dec 2 23:17:12 UTC 2024, Éamonn McMan

Re: RFR: 8340133: Add concise usage message to the java executable [v8]

2024-11-12 Thread Kevin Bourrillion
On Tue, 12 Nov 2024 13:17:13 GMT, Jan Lahoda wrote: >> Currently, running `java` without any parameters will lead to an output that >> is a full `--help`, which is over 100 lines (on my computer at least), and >> it feels overwhelming. And many people might actually want to run >> JShell/REPL,

Re: RFR: 8340133: Add concise usage message to the java executable [v8]

2024-11-12 Thread Kevin Bourrillion
On Tue, 12 Nov 2024 13:17:13 GMT, Jan Lahoda wrote: >> Currently, running `java` without any parameters will lead to an output that >> is a full `--help`, which is over 100 lines (on my computer at least), and >> it feels overwhelming. And many people might actually want to run >> JShell/REPL,

Re: RFR: 8342566: Improve javadoc of java.lang.annotation.ElementType [v3]

2024-11-12 Thread Kevin Bourrillion
> 8342566: Improve javadoc of java.lang.annotation.ElementType Kevin Bourrillion has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains nine additio

Re: RFR: 8342566: Improve javadoc of java.lang.annotation.ElementType [v2]

2024-10-25 Thread Kevin Bourrillion
> 8342566: Improve javadoc of java.lang.annotation.ElementType Kevin Bourrillion has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains eight additio

Re: RFR: 8341566: Add Reader.of(CharSequence) [v15]

2024-10-23 Thread Kevin Bourrillion
On Wed, 23 Oct 2024 08:58:30 GMT, Markus KARG wrote: >> This Pull Requests proposes an implementation for >> [JDK-8341566](https://bugs.openjdk.org/browse/JDK-8341566): Adding the new >> method `public static Reader Reader.of(CharSequence)` will return an >> anonymous, non-synchronized impleme

Re: RFR: 8342566: Improve javadoc of java.lang.annotation.ElementType

2024-10-21 Thread Kevin Bourrillion
On Tue, 15 Oct 2024 19:54:08 GMT, Chen Liang wrote: >> Well, this is one of the ambiguous contexts listed above. Not sure if I'm >> reading this right. What's the "inconsistency" you mean? > > Say you have a record component like: > `record Sample(@Anno int val)` > Where `@Anno` applies to `RECO

Re: RFR: 8342566: Improve javadoc of java.lang.annotation.ElementType

2024-10-21 Thread Kevin Bourrillion
On Mon, 14 Oct 2024 20:31:51 GMT, Kevin Bourrillion wrote: > 8342566: Improve javadoc of java.lang.annotation.ElementType Thanks so much Chen! I'm interested in your general thoughts: does it make sense where I have currently "drawn the line", as far as what information b

Re: RFR: 8342566: Improve javadoc of java.lang.annotation.ElementType

2024-10-21 Thread Kevin Bourrillion
On Tue, 15 Oct 2024 02:10:30 GMT, Chen Liang wrote: >> 8342566: Improve javadoc of java.lang.annotation.ElementType > > src/java.base/share/classes/java/lang/annotation/ElementType.java line 42: > >> 40: * } >> 41: * >> 42: * Declaration annotations and type-use annotations > > Meta: if we a

RFR: 8342566: Improve javadoc of java.lang.annotation.ElementType

2024-10-21 Thread Kevin Bourrillion
8342566: Improve javadoc of java.lang.annotation.ElementType - Commit messages: - Merge branch 'openjdk:master' into element-type-javadoc - Merge branch 'openjdk:master' into element-type-javadoc - handle review comments from Chen - maybe ready for review now - Merge branch 'open

Re: RFR: 8340133: Investigate if the java launcher could give hints about JShell [v4]

2024-10-21 Thread Kevin Bourrillion
On Mon, 21 Oct 2024 09:41:50 GMT, Jan Lahoda wrote: >> Currently, running `java` without any parameters will lead to an output that >> is a full `--help`, which is over 100 lines (on my computer at least), and >> it feels overwhelming. And many people might actually want to run >> JShell/REPL,

Re: RFR: 8340133: Investigate if the java launcher could give hints about JShell [v2]

2024-10-10 Thread Kevin Bourrillion
On Thu, 10 Oct 2024 17:54:51 GMT, Jan Lahoda wrote: >> Currently, running `java` without any parameters will lead to an output that >> is a full `--help`, which is over 100 lines (on my computer at least), and >> it feels overwhelming. And many people might actually want to run >> JShell/REPL,

Re: RFR: 8340133: Investigate if the java launcher could give hints about JShell

2024-10-09 Thread Kevin Bourrillion
On Tue, 8 Oct 2024 15:28:17 GMT, Jan Lahoda wrote: > Currently, running `java` without any parameters will lead to an output that > is a full `--help`, which is over 100 lines (on my computer at least), and it > feels overwhelming. And many people might actually want to run JShell/REPL, > not

Re: RFR: 8338398: Trivially fix grammar and typos

2024-08-14 Thread Kevin Bourrillion
On Wed, 14 Aug 2024 13:38:34 GMT, Pavel Rappo wrote: > This PR fixes a few trivial grammar issues and typos in documentation. > > The main issue is the use of the word "timeout". To my mind, timeout, a > duration, is not the same as deadline, which is a point in time, an instant, > which allow

Re: RFR: 8336043: Add quality of implementation discussion to Object.{equals, toString, hashCode}

2024-07-17 Thread Kevin Bourrillion
On Thu, 11 Jul 2024 00:10:02 GMT, Stuart Marks wrote: >> First pass at adding some quality of implementation discussions around the >> overridable methods of Object. > > src/java.base/share/classes/java/lang/Object.java line 53: > >> 51: * {@link VirtualMachineError} is possible during the exe

Re: In support of Instant.minus(Instant)

2024-05-02 Thread Kevin Bourrillion
Most users don't and won't know anything about "affine spaces" *per se*, however, it's not a super unusual relationship for two types to have. A few examples Point2D and Vector2D Instant and Duration Pitch and Interval (i.e. music theory) If Java has operator overloading one day, I would feel it