On Wed, 19 Mar 2025 20:07:26 GMT, Roger Riggs wrote:
>> The current test program for the logging feature added in JDK-8301627 does
>> not fully check some important cases.
>>
>> Issue Details:
>> The test does not properly check cases where logging might not happen due to
>> different logging
On Wed, 19 Mar 2025 20:09:51 GMT, Roger Riggs wrote:
>> KIRIYAMA Takuya has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8352016: Improve java/lang/RuntimeTests/RuntimeExitLogTest.java
>
> test/jdk/java
onments.
> - Windows Server 2022 Standard 21H2
> - Red Hat Enterprise Linux release 9.2 (Plow)
>
> Could you please review this fix?
KIRIYAMA Takuya has updated the pull request incrementally with one additional
commit since the last revision:
8352016: Improve java/lang/RuntimeTes
On Tue, 25 Mar 2025 18:39:22 GMT, Roger Riggs wrote:
>> I see. This test only takes a very short time, but shouldn't the cases be
>> added?
>
> Still no, starting a new Java runtime isn't that quick, and it brings no
> additional value.
> All tests are run 10's of thousands of times in every re
On Wed, 26 Mar 2025 16:24:20 GMT, Jaikiran Pai wrote:
>> KIRIYAMA Takuya has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8352016: Improve java/lang/RuntimeTests/RuntimeExitLogTest.java
>
> t
onments.
> - Windows Server 2022 Standard 21H2
> - Red Hat Enterprise Linux release 9.2 (Plow)
>
> Could you please review this fix?
KIRIYAMA Takuya has updated the pull request incrementally with one additional
commit since the last revision:
8352016: Improve java/lang/RuntimeTes
On Wed, 19 Mar 2025 19:54:41 GMT, Roger Riggs wrote:
>> KIRIYAMA Takuya has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8352016: Improve java/lang/RuntimeTests/RuntimeExitLogTest.java
>
> test/jdk/java
On Wed, 19 Mar 2025 20:07:26 GMT, Roger Riggs wrote:
> Out of curiosity, what raised this as an issue that needed more tests? Was
> there a failure of some implementation that caused a bug?
Thank you for your comment.
No, I haven't found any bugs yet.
This is an important feature that is often
On Tue, 18 Mar 2025 12:34:37 GMT, Mikhail Yankelevich
wrote:
>> KIRIYAMA Takuya has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8352016: Improve java/lang/RuntimeTests/RuntimeExitLogTest.java
>
> t
The current test program for the logging feature added in JDK-8301627 does not
fully check some important cases.
Issue Details:
The test does not properly check cases where logging might not happen due to
different logging levels. (e.g. ALL, TRACE, WARNING, etc.)
The check for the logged stack t
On Fri, 9 Sep 2022 08:30:55 GMT, KIRIYAMA Takuya wrote:
> Could you please review the JDK-8293579 bug fixes?
>
> tools/jpackage/share/jdk/jpackage/tests/UnicodeArgsTest.java attempts to give
> the launcher the character which is encoded by Windows API
> WideCharToMultiByte()
On Wed, 28 Sep 2022 09:45:32 GMT, KIRIYAMA Takuya wrote:
>> Could you please review the JDK-8293579 bug fixes?
>>
>> tools/jpackage/share/jdk/jpackage/tests/UnicodeArgsTest.java attempts to
>> give
>> the launcher the character which is encoded by Windo
On Thu, 29 Sep 2022 19:03:18 GMT, Alexey Semenyuk wrote:
>> Well, what concerns me with the current fix is that it is simply patching
>> only the case for the Japanese setup. We don't know if the same failure
>> would happen in other setups (I'm pretty sure the same failure would happen
>> wit
On Wed, 28 Sep 2022 18:00:09 GMT, Naoto Sato wrote:
>> KIRIYAMA Takuya has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8293579: tools/jpackage/share/jdk/jpackage/tests/UnicodeArgsTest.java
>> fails on Japa
On Wed, 14 Sep 2022 21:07:41 GMT, Naoto Sato wrote:
>> Could you please review the JDK-8293579 bug fixes?
>>
>> tools/jpackage/share/jdk/jpackage/tests/UnicodeArgsTest.java attempts to
>> give
>> the launcher the character which is encoded by Windows API
>> WideCharToMultiByte()
>> from UNIC
> with
> "e"(0x0065) as substitute. Therefore, "Ă©"(0x00e9) and "e"(0x0065) are
> compared
> in this test and judged to be different characters, and return as failed.
>
> So, in the Japanese encoding("MS932", "SJIS"), the test s
On Wed, 6 Jul 2022 06:40:32 GMT, KIRIYAMA Takuya wrote:
> I removed a section of via JDK_JAVA_OPTIONS because including main class is
> not allowed in the specification.
> This behavior is added in JDK-8170832, which add JAVA_OPTIONS environment
> variable. At this time, this test
On Wed, 21 Sep 2022 16:49:23 GMT, Naoto Sato wrote:
>> KIRIYAMA Takuya has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8289797: tools/launcher/I18NArgTest.java fails on Japanese Windows
>> environme
and get Passed on Japanese Windows environment.
> Could you review this fix, please?
KIRIYAMA Takuya has updated the pull request incrementally with one additional
commit since the last revision:
8289797: tools/launcher/I18NArgTest.java fails on Japanese Windows environment
-
On Fri, 16 Sep 2022 16:19:35 GMT, Naoto Sato wrote:
>> Extract to a byte array with the appropriate charset and then HexFormat the
>> bytearray.
>>
>>
>> var SysPropHexVal =
>> HexFormat.of().formatHex(sysPropVal.getBytes(StandardCharsets.UTF_16));
>
> Thanks, Roger. You beat me to it 🙂
and get Passed on Japanese Windows environment.
> Could you review this fix, please?
KIRIYAMA Takuya has updated the pull request incrementally with one additional
commit since the last revision:
8289797: tools/launcher/I18NArgTest.java fails on Japanese Windows environment
-
On Sat, 27 Aug 2022 00:19:28 GMT, Naoto Sato wrote:
>> KIRIYAMA Takuya has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8289797: tools/launcher/I18NArgTest.java fails on Japanese Windows
>
> test/jdk/tools/
and get Passed on Japanese Windows environment.
> Could you review this fix, please?
KIRIYAMA Takuya has updated the pull request incrementally with one additional
commit since the last revision:
8289797: tools/launcher/I18NArgTest.java fails on Japanese Windows environment
-
On Sat, 27 Aug 2022 00:20:46 GMT, Naoto Sato wrote:
>> KIRIYAMA Takuya has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8289797: tools/launcher/I18NArgTest.java fails on Japanese Windows
>
> test/jdk/tools/
On Fri, 9 Sep 2022 23:23:04 GMT, Naoto Sato wrote:
> I just wonder if the fix is working as intended... Since JDK18,
> `file.encoding` is always `UTF-8` with JEP 400, so the switch expression
> seems to fall into the `default` clause?
You’re right. `file.encoding` may not be useful for this te
Could you please review the JDK-8293579 bug fixes?
tools/jpackage/share/jdk/jpackage/tests/UnicodeArgsTest.java attempts to give
the launcher the character which is encoded by Windows API
WideCharToMultiByte()
from UNICODE "Ă©"(0x00e9) as an argument. However, this test fails because the
code p
and get Passed on Japanese Windows environment.
> Could you review this fix, please?
KIRIYAMA Takuya has updated the pull request incrementally with one additional
commit since the last revision:
8289797: tools/launcher/I18NArgTest.java fails on Japanese Windows
-
Chang
On Fri, 8 Jul 2022 12:10:29 GMT, Jaikiran Pai wrote:
>> I removed a section of via JDK_JAVA_OPTIONS because including main class is
>> not allowed in the specification.
>> This behavior is added in JDK-8170832, which add JAVA_OPTIONS environment
>> variable. At this time, this test is mismatch
and get Passed on Japanese Windows environment.
> Could you review this fix, please?
KIRIYAMA Takuya has updated the pull request incrementally with one additional
commit since the last revision:
8289797: tools/launcher/I18NArgTest.java fails on Japanese Windows
-
Chang
On Fri, 8 Jul 2022 12:10:29 GMT, Jaikiran Pai wrote:
>> I removed a section of via JDK_JAVA_OPTIONS because including main class is
>> not allowed in the specification.
>> This behavior is added in JDK-8170832, which add JAVA_OPTIONS environment
>> variable. At this time, this test is mismatch
I removed a section of via JDK_JAVA_OPTIONS because including main class is not
allowed in the specification.
This behavior is added in JDK-8170832, which add JAVA_OPTIONS　environment
variable. At this time, this test is mismatch with the specification.
I tried to test and get Passed on Japanese
31 matches
Mail list logo
