On Tue, 17 Dec 2024 13:45:02 GMT, Jan Kratochvil
wrote:
> There are 2 typos and I find the API a bit complex so it does not help a new
> perplexed user of the API to be additionally confused by typos.
This pull request has now been integrated.
Changeset: a5503fb6
Author: Jan Krat
On Tue, 17 Dec 2024 13:45:02 GMT, Jan Kratochvil
wrote:
> There are 2 typos and I find the API a bit complex so it does not help a new
> perplexed user of the API to be additionally confused by typos.
@JornVernee
-
PR Comment: https://git.openjdk.org/jdk/pull/22792#issuec
There are 2 typos and I find the API a bit complex so it does not help a new
perplexed user of the API to be additionally confused by typos.
-
Commit messages:
- 8346432: java.lang.foreign.Linker comment typo
Changes: https://git.openjdk.org/jdk/pull/22792/files
Webrev: https://w
On Thu, 28 Dec 2023 12:55:22 GMT, Jan Kratochvil
wrote:
> The testcase requires root permissions.
>
> Fix by Severin Gehwolf.
> Testcase by Jan Kratochvil.
This pull request has been closed without being integrated.
-
PR: https://git.openjdk.org/jdk/pull/17198
On Sat, 17 Aug 2024 05:29:31 GMT, Jan Kratochvil
wrote:
>> The testcase requires root permissions.
>>
>> Fix by Severin Gehwolf.
>> Testcase by Jan Kratochvil.
>
> Jan Kratochvil has updated the pull request with a new target base due to a
> merge or a reba
> The testcase requires root permissions.
>
> Fix by Severin Gehwolf.
> Testcase by Jan Kratochvil.
Jan Kratochvil has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains 12 commits:
- Functionality fixes after the refactoriz
On Wed, 14 Aug 2024 15:55:53 GMT, Severin Gehwolf wrote:
>> Jan Kratochvil has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Testcase update upon review by Severin Gehwolf
>
> test/hotspot/jtreg/containers
On Mon, 12 Aug 2024 18:36:51 GMT, Severin Gehwolf wrote:
>> Jan Kratochvil has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Inline adjust_controller() twice
>> - Revert "Unify 4 copies of adjust_cont
On Wed, 14 Aug 2024 14:56:26 GMT, Severin Gehwolf wrote:
>> Jan Kratochvil has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Testcase update upon review by Severin Gehwolf
>
> test/hotspot/jtreg/containers
On Mon, 12 Aug 2024 18:39:46 GMT, Severin Gehwolf wrote:
>> Jan Kratochvil has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Inline adjust_controller() twice
>> - Revert "Unify 4 copies of adjust_cont
> The testcase requires root permissions.
>
> Fix by Severin Gehwolf.
> Testcase by Jan Kratochvil.
Jan Kratochvil has updated the pull request incrementally with one additional
commit since the last revision:
Testcase update upon review by Severin Gehwolf
-
Chan
On Mon, 29 Jul 2024 05:03:22 GMT, Jan Kratochvil
wrote:
>> src/hotspot/os/linux/cgroupUtil_linux.cpp line 64:
>>
>>> 62: return cpu->adjust_controller(cpu_total);
>>> 63: }
>>> 64: return cpu;
>>
>> I guess an alternative - and
> The testcase requires root permissions.
>
> Fix by Severin Gehwolf.
> Testcase by Jan Kratochvil.
Jan Kratochvil has updated the pull request incrementally with two additional
commits since the last revision:
- Inline adjust_controller() twice
- Revert "Unify 4 copies of
> The testcase requires root permissions.
>
> Fix by Severin Gehwolf.
> Testcase by Jan Kratochvil.
Jan Kratochvil has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains four commits:
- Implement vm.cgroup.
On Mon, 22 Jul 2024 13:48:29 GMT, Severin Gehwolf wrote:
>> Jan Kratochvil has refreshed the contents of this pull request, and previous
>> commits have been removed. Incremental views are not available.
>
> test/hotspot/jtreg/containers/cgroup/NestedCgroup.java l
> The testcase requires root permissions.
>
> Fix by Severin Gehwolf.
> Testcase by Jan Kratochvil.
Jan Kratochvil has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains 260 commits:
- Implement vm.cgroup.
On Mon, 22 Jul 2024 09:07:31 GMT, Severin Gehwolf wrote:
>> Jan Kratochvil has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Unify 4 copies of adjust_controller()
>
> src/hotspot/os/linux/cgroupUtil_linux.cpp
> The testcase requires root permissions.
>
> Fix by Severin Gehwolf.
> Testcase by Jan Kratochvil.
Jan Kratochvil has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains 117 commits:
- Fix testcase compatibility with Alpine
On Thu, 18 Jul 2024 14:48:02 GMT, Jan Kratochvil
wrote:
>> The testcase requires root permissions.
>>
>> Fix by Severin Gehwolf.
>> Testcase by Jan Kratochvil.
>
> Jan Kratochvil has updated the pull request incrementally with one additional
> commit since
On Fri, 12 Jul 2024 13:12:11 GMT, Severin Gehwolf wrote:
> There ought to be a way to remove the duplication between cgv1 and cgv2's
> impl of `adjust_controller()` but I haven't spent time on that.
I have tied to implemented but I am fine to drop it if you don't like it.
-
PR Com
> The testcase requires root permissions.
>
> Fix by Severin Gehwolf.
> Testcase by Jan Kratochvil.
Jan Kratochvil has updated the pull request incrementally with one additional
commit since the last revision:
Unify 4 copies of adjust_controller()
-
Changes:
> The testcase requires root permissions.
>
> Fix by Severin Gehwolf.
> Testcase by Jan Kratochvil.
Jan Kratochvil has updated the pull request incrementally with one additional
commit since the last revision:
Fix a needless whitespace change
-
Changes:
On Mon, 15 Jul 2024 05:56:12 GMT, Jan Kratochvil
wrote:
>> The testcase requires root permissions.
>>
>> Fix by Severin Gehwolf.
>> Testcase by Jan Kratochvil.
>
> Jan Kratochvil has updated the pull request incrementally with 10 additional
> commits since
> The testcase requires root permissions.
>
> Fix by Severin Gehwolf.
> Testcase by Jan Kratochvil.
Jan Kratochvil has updated the pull request incrementally with 10 additional
commits since the last revision:
- Merge branch 'master-jdk-8322420_cgroup_hierarchy_walk_init-t
On Thu, 11 Jul 2024 06:54:27 GMT, Jan Kratochvil
wrote:
>> The testcase requires root permissions.
>>
>> Fix by Severin Gehwolf.
>> Testcase by Jan Kratochvil.
>
> Jan Kratochvil has updated the pull request with a new target base due to a
> merge or a reba
On Thu, 11 Jul 2024 12:49:24 GMT, Severin Gehwolf wrote:
>> Jan Kratochvil has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 103 commits:
>>
>> - Fix the gtest
>> - fix compilation warning
On Thu, 11 Jul 2024 12:47:38 GMT, Severin Gehwolf wrote:
>> Jan Kratochvil has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 103 commits:
>>
>> - Fix the gtest
>> - fix compilation warning
On Thu, 11 Jul 2024 10:39:23 GMT, Severin Gehwolf wrote:
>> Jan Kratochvil has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 103 commits:
>>
>> - Fix the gtest
>> - fix compilation warning
On Thu, 11 Jul 2024 16:46:13 GMT, Severin Gehwolf wrote:
>> Please review this PR which adds test support for systemd slices so that
>> bugs like [JDK-8217338](https://bugs.openjdk.org/browse/JDK-8217338) can be
>> verified. The added test, `SystemdMemoryAwarenessTest` currently passes on
>> c
On Thu, 11 Jul 2024 09:23:58 GMT, Severin Gehwolf wrote:
> > ```
> > * `CPUQuota` (changed it to `AllowedCPUs`) does not work for me - it
> > properly distributes the load but JDK still sees all available CPU cores (4
> > of my VM).
> > ```
>
> Could you elaborate on that? What does not work?
On Thu, 11 Jul 2024 06:50:21 GMT, Jan Kratochvil
wrote:
>> The testcase requires root permissions.
>>
>> Designed by Severin Gehwolf, implemented by Jan Kratochvil.
>
> Jan Kratochvil has updated the pull request with a new target base due to a
> merge or a r
On Wed, 22 May 2024 15:02:18 GMT, Jan Kratochvil
wrote:
>> The testcase requires root permissions.
>>
>> Designed by Severin Gehwolf, implemented by Jan Kratochvil.
>
> Jan Kratochvil has updated the pull request with a new target base due to a
> merge or a r
> The testcase requires root permissions.
>
> Designed by Severin Gehwolf, implemented by Jan Kratochvil.
Jan Kratochvil has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains 103 commits:
- Fix the gtest
- fix compilatio
On Mon, 1 Jul 2024 14:43:58 GMT, Severin Gehwolf wrote:
>> Please review this PR which adds test support for systemd slices so that
>> bugs like [JDK-8217338](https://bugs.openjdk.org/browse/JDK-8217338) can be
>> verified. The added test, `SystemdMemoryAwarenessTest` currently passes on
>> cg
On Mon, 1 Jul 2024 14:43:58 GMT, Severin Gehwolf wrote:
>> Please review this PR which adds test support for systemd slices so that
>> bugs like [JDK-8217338](https://bugs.openjdk.org/browse/JDK-8217338) can be
>> verified. The added test, `SystemdMemoryAwarenessTest` currently passes on
>> cg
On Thu, 20 Jun 2024 12:06:43 GMT, Severin Gehwolf wrote:
>> Please review this enhancement to the container detection code which allows
>> it to figure out whether the JVM is actually running inside a container
>> (`podman`, `docker`, `crio`), or with some other means that enforces
>> memory/c
> The testcase requires root permissions.
>
> Designed by Severin Gehwolf, implemented by Jan Kratochvil.
Jan Kratochvil has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains 74 commits:
- .
- .
- Merge branch 'jdk-
On Wed, 8 May 2024 02:56:10 GMT, Jan Kratochvil wrote:
>> The testcase requires root permissions.
>>
>> Designed by Severin Gehwolf, implemented by Jan Kratochvil.
>
> Jan Kratochvil has updated the pull request with a new target base due to a
> merge or a r
> The testcase requires root permissions.
>
> Designed by Severin Gehwolf, implemented by Jan Kratochvil.
Jan Kratochvil has updated the pull request incrementally with one additional
commit since the last revision:
whitespace fix
-
Changes:
- all: https://git.op
> The testcase requires root permissions.
>
> Designed by Severin Gehwolf, implemented by Jan Kratochvil.
Jan Kratochvil has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains 49 commits:
- centos7 compat
- 64a5feb6:
On Sun, 10 Mar 2024 14:40:09 GMT, Jan Kratochvil
wrote:
>> The testcase requires root permissions.
>>
>> Designed by Severin Gehwolf, implemented by Jan Kratochvil.
>
> Jan Kratochvil has updated the pull request with a new target base due to a
> merge or a r
On Sun, 10 Mar 2024 14:40:09 GMT, Jan Kratochvil
wrote:
>> The testcase requires root permissions.
>>
>> Designed by Severin Gehwolf, implemented by Jan Kratochvil.
>
> Jan Kratochvil has updated the pull request with a new target base due to a
> merge or a r
On Sun, 10 Mar 2024 14:40:09 GMT, Jan Kratochvil
wrote:
>> The testcase requires root permissions.
>>
>> Designed by Severin Gehwolf, implemented by Jan Kratochvil.
>
> Jan Kratochvil has updated the pull request with a new target base due to a
> merge or a r
On Sun, 10 Mar 2024 14:40:09 GMT, Jan Kratochvil
wrote:
>> The testcase requires root permissions.
>>
>> Designed by Severin Gehwolf, implemented by Jan Kratochvil.
>
> Jan Kratochvil has updated the pull request with a new target base due to a
> merge or a r
On Fri, 19 Apr 2024 05:18:51 GMT, Laurence Cable wrote:
> I think (I am agreeing with you Severin) that the goal of the heuristic is to
> inform the JVM (and any associated serviceability tools) that the JVM is in a
> resource constrained/managed execution context...
"resource constrained" (my
On Thu, 11 Apr 2024 12:08:02 GMT, Severin Gehwolf wrote:
>> Please review this enhancement to the container detection code which allows
>> it to figure out whether the JVM is actually running inside a container
>> (`podman`, `docker`, `crio`), or with some other means that enforces
>> memory/c
On Tue, 16 Apr 2024 15:17:33 GMT, Severin Gehwolf wrote:
> The idea here is to use this property to tune OpenJDK for in-container,
> specifically k8s, use. In such a setup it's custom to run a single process
> within set resource constraints.
The in-container tuning means to use all the availa
On Thu, 11 Apr 2024 12:08:02 GMT, Severin Gehwolf wrote:
>> Please review this enhancement to the container detection code which allows
>> it to figure out whether the JVM is actually running inside a container
>> (`podman`, `docker`, `crio`), or with some other means that enforces
>> memory/c
On Wed, 21 Feb 2024 14:02:12 GMT, Severin Gehwolf wrote:
> I'm surprised that the hierarchical memory limit look-up wouldn't see it for
> v1. Either way, using the traversal approach you'd see that `foo/bar` has `2
> GB`, when traversing up the hierarchy you'd see `1 GB` for `foo` and use that
On Wed, 21 Feb 2024 13:20:20 GMT, Severin Gehwolf wrote:
> One goal of this patch would be to unify how this works for cgroup v1 and
> cgroup v2.
That is not much possible anyway as currently cgroup2 has to traverse the
directories while after the kernel patch gets accepted it will be faster
On Tue, 20 Feb 2024 15:15:09 GMT, Jan Kratochvil
wrote:
>> The testcase requires root permissions.
>>
>> Designed by Severin Gehwolf, implemented by Jan Kratochvil.
>
> Jan Kratochvil has updated the pull request with a new target base due to a
> merge or a r
> The testcase requires root permissions.
>
> Designed by Severin Gehwolf, implemented by Jan Kratochvil.
Jan Kratochvil has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains 35 commits:
- Fix whitespace
- Merge branch
On Wed, 31 Jan 2024 15:33:01 GMT, Jan Kratochvil
wrote:
>> It looks like this patch needs a bit more discussion. Generally, it would be
>> good to have the functionality, but I'm unsure about the proposed
>> implementation.
>>
>> Walking the directory hie
> The testcase requires root permissions.
Jan Kratochvil has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains 23 commits:
- Disable cgroup.subtree_control testcase on cgroup1
- Extend the testcase
- Implement cgroup.subtree_cont
> The testcase requires root permissions.
Jan Kratochvil has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
brought in by the merge/rebase. The pull request contains 15 additional commits
since the last revis
On Fri, 12 Jan 2024 17:12:37 GMT, Severin Gehwolf wrote:
> Walking the directory hierarchy (**and** interface files) on every call of
> `physical_memory()` (or `active_processor_count()` for CPU) seems concerning.
I have therefore implemented a hierarchical `memory.stat` extension for cgroup2
> The testcase requires root permissions.
Jan Kratochvil has updated the pull request incrementally with one additional
commit since the last revision:
Remove unneeded jdk.test.lib.helpers.ClassFileInstaller
-
Changes:
- all: https://git.openjdk.org/jdk/pull/17198/fi
On Fri, 12 Jan 2024 16:26:58 GMT, Severin Gehwolf wrote:
>> Jan Kratochvil has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix gtest testcases compilation errors
>
> test/hotspot/jtreg/containers/cg
> The testcase requires root permissions.
Jan Kratochvil has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
brought in by the merge/rebase. The pull request contains ten additional
commits since the l
> The testcase requires root permissions.
Jan Kratochvil has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
brought in by the merge/rebase. The pull request contains four additional
commits since the l
On Thu, 28 Dec 2023 15:19:23 GMT, Jan Kratochvil
wrote:
>> The testcase requires root permissions.
>
> Jan Kratochvil has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Fix gtest testcases compilation errors
ping, ar
> The testcase requires root permissions.
Jan Kratochvil has updated the pull request incrementally with one additional
commit since the last revision:
Fix gtest testcases compilation errors
-
Changes:
- all: https://git.openjdk.org/jdk/pull/17198/files
- new: ht
The testcase requires root permissions.
-
Commit messages:
- 8322420: [Linux] cgroup v2: Limits in parent nested control groups are not
detected
- 4c556a78:
Changes: https://git.openjdk.org/jdk/pull/17198/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=17198&range=00
Is
63 matches
Mail list logo
