ted is verified manually running jtreg with retain=all.
Henry Jen has updated the pull request incrementally with one additional commit
since the last revision:
Clean up jtreg directives
-
Changes:
- all: https://git.openjdk.org/jdk/pull/25981/files
- new: https://git.openjdk.org
On Fri, 27 Jun 2025 06:28:32 GMT, Eirik Bjørsnøs wrote:
>> Henry Jen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Adapt review feedbacks
>
> test/jdk/tools/jlink/JLink2Packages.java line
ted is verified manually running jtreg with retain=all.
Henry Jen has updated the pull request incrementally with one additional commit
since the last revision:
Adapt review feedbacks
-
Changes:
- all: https://git.openjdk.org/jdk/pull/25981/files
- new: https://git.openjdk.org/jdk/p
ted is verified manually running jtreg with retain=all.
Henry Jen has updated the pull request incrementally with one additional commit
since the last revision:
Update copyright year
-
Changes:
- all: https://git.openjdk.org/jdk/pull/25981/files
- new: https://git.openjdk.org/jdk/p
ted is verified manually running jtreg with retain=all.
Henry Jen has updated the pull request incrementally with one additional commit
since the last revision:
Update copyright year
-
Changes:
- all: https://git.openjdk.org/jdk/pull/25981/files
- new: https://git.openjdk.org/jdk/p
Create a jar directly from the memory instead of real file, this should reduce
the I/O overhead which likely the reason for the time out.
The issue is not reproducible locally, and fails intermittently, so we simply
trying to reduce time needed.
The jar file created is verified manually running j
On Wed, 18 Jun 2025 01:51:28 GMT, Naoto Sato wrote:
>> Alisen Chung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix unicode escapes
>
> src/jdk.jlink/share/classes/jdk/tools/jimage/resources/jimage_de.properties
> line 1:
>
>> 1: #
On Fri, 4 Apr 2025 00:39:04 GMT, Henry Jen wrote:
> This PR check the jar file to ensure entries are consistent from the central
> directory and local file header. Also check there is no duplicate entry names
> that could override the desired content by accident.
This pull reques
> This PR check the jar file to ensure entries are consistent from the central
> directory and local file header. Also check there is no duplicate entry names
> that could override the desired content by accident.
Henry Jen has updated the pull request with a new target base due to a
> This PR check the jar file to ensure entries are consistent from the central
> directory and local file header. Also check there is no duplicate entry names
> that could override the desired content by accident.
Henry Jen has updated the pull request with a new target base due to a
> This PR check the jar file to ensure entries are consistent from the central
> directory and local file header. Also check there is no duplicate entry names
> that could override the desired content by accident.
Henry Jen has updated the pull request incrementally with one addition
On Wed, 14 May 2025 17:27:25 GMT, Lance Andersen wrote:
>> UTF-8 messed up the index, we don't want any conversion to happen.
>> Warning: Entry META-INFMAANIFEST.MF in local file header is not in central
>> directory
>> Warning: Entry META-INF/BANIFEST.MF in local file header is not in central
On Thu, 22 May 2025 11:42:04 GMT, Jaikiran Pai wrote:
>> Henry Jen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Validator to take a file, use term JAR file
>
> test/jdk/tools/jar/ValidatorTest.
On Thu, 22 May 2025 12:25:04 GMT, Lance Andersen wrote:
>> Non-zero could also mean negative which we currently do not do nor do,I see
>> that going forward as part of future additions to validate
>
> We are somewhat inconsistent in documenting the exit code from our commands
> as many do not i
> This PR check the jar file to ensure entries are consistent from the central
> directory and local file header. Also check there is no duplicate entry names
> that could override the desired content by accident.
Henry Jen has updated the pull request incrementally with one addition
On Wed, 21 May 2025 20:21:18 GMT, Lance Andersen wrote:
>> src/jdk.jartool/share/man/jar.md line 223:
>>
>>> 221: As a jar archive is based on ZIP format, it is possible to create a
>>> jar archive using tools
>>> 222: other than the `jar` command. The --validate option may be used to
>>> perf
On Wed, 21 May 2025 16:53:17 GMT, Jaikiran Pai wrote:
>> Henry Jen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Mismatched order is considered invalid
>
> src/jdk.jartool/share/classes/sun/tools/jar
> This PR check the jar file to ensure entries are consistent from the central
> directory and local file header. Also check there is no duplicate entry names
> that could override the desired content by accident.
Henry Jen has updated the pull request incrementally with one addition
> This PR check the jar file to ensure entries are consistent from the central
> directory and local file header. Also check there is no duplicate entry names
> that could override the desired content by accident.
Henry Jen has updated the pull request incrementally with one addition
On Wed, 21 May 2025 14:00:03 GMT, Lance Andersen wrote:
>>> For the inconsistent order in the LOC and CEN, we can treat it as invalid,
>>> I chose not to because that's not a violation, but if we do extend that as
>>> specification for JAR file format, then we can change that to invalid and
>>
On Tue, 20 May 2025 18:30:46 GMT, Lance Andersen wrote:
>> We report all issues, not just one, so that would also involve what do we
>> prioritized for the exit code...
>> In general, a non-zero code for invalid jar needs attention. We still 0 with
>> unmatched order.
>> Also the process could
On Tue, 20 May 2025 18:00:47 GMT, Lance Andersen wrote:
>> src/jdk.jartool/share/man/jar.md line 235:
>>
>>> 233:
>>> 234: The jar tool will return a status code of 0 if there were no integrity
>>> issues encountered and a
>>> 235: status code of 1 an issue was found. When an integrity issue i
> This PR check the jar file to ensure entries are consistent from the central
> directory and local file header. Also check there is no duplicate entry names
> that could override the desired content by accident.
Henry Jen has updated the pull request incrementally with one addition
On Sat, 17 May 2025 01:27:38 GMT, Henry Jen wrote:
>> This PR check the jar file to ensure entries are consistent from the central
>> directory and local file header. Also check there is no duplicate entry
>> names that could override the desired content by accident.
>
&g
On Mon, 19 May 2025 19:56:52 GMT, Jiangli Zhou wrote:
>> @sendaoYan Please let me know if you have any additional review comments,
>> thanks.
>>
>> Also looking for a 'R'eviewer for reviewing. Thanks!
>
> A friendly ping
LGTM.
-
PR Review Comment: https://git.openjdk.org/jdk/pull
On Wed, 14 May 2025 15:44:08 GMT, Jiangli Zhou wrote:
>> Please review this PR for skipping
>> jdk/test/lib/process/TestNativeProcessBuilder on static-jdk. Duplicating the
>> context from https://bugs.openjdk.org/browse/JDK-8356904 description:
>>
>> jdk/test/lib/process/TestNativeProcessBuild
> This PR check the jar file to ensure entries are consistent from the central
> directory and local file header. Also check there is no duplicate entry names
> that could override the desired content by accident.
Henry Jen has updated the pull request incrementally with one addition
On Wed, 7 May 2025 17:28:34 GMT, Lance Andersen wrote:
>> Henry Jen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Restore Validator access level
>
> test/jdk/tools/jar/ValidatorTest.java line 232:
On Wed, 7 May 2025 18:00:23 GMT, Henry Jen wrote:
>> src/jdk.jartool/share/classes/sun/tools/jar/Validator.java line 127:
>>
>>> 125:
>>> 126: public DedupEntryNames(boolean isCEN) {
>>> 127: this.isCEN = isCEN;
>>
>> Mig
> This PR check the jar file to ensure entries are consistent from the central
> directory and local file header. Also check there is no duplicate entry names
> that could override the desired content by accident.
Henry Jen has updated the pull request incrementally with one addition
> This PR check the jar file to ensure entries are consistent from the central
> directory and local file header. Also check there is no duplicate entry names
> that could override the desired content by accident.
Henry Jen has updated the pull request incrementally with one addition
On Wed, 7 May 2025 17:41:07 GMT, Lance Andersen wrote:
>> Henry Jen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Restore Validator access level
>
> test/jdk/tools/jar/ValidatorTest.java line 145:
&
On Wed, 7 May 2025 17:13:19 GMT, Lance Andersen wrote:
>> Henry Jen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Restore Validator access level
>
> src/jdk.jartool/share/classes/sun/tools/jar/Vali
> This PR check the jar file to ensure entries are consistent from the central
> directory and local file header. Also check there is no duplicate entry names
> that could override the desired content by accident.
Henry Jen has updated the pull request incrementally with one addition
> This PR check the jar file to ensure entries are consistent from the central
> directory and local file header. Also check there is no duplicate entry names
> that could override the desired content by accident.
Henry Jen has updated the pull request incrementally with one addition
> This PR check the jar file to ensure entries are consistent from the central
> directory and local file header. Also check there is no duplicate entry names
> that could override the desired content by accident.
Henry Jen has updated the pull request incrementally with one addition
> This PR check the jar file to ensure entries are consistent from the central
> directory and local file header. Also check there is no duplicate entry names
> that could override the desired content by accident.
Henry Jen has updated the pull request incrementally with one addition
On Tue, 29 Apr 2025 00:02:58 GMT, Chen Liang wrote:
>> Henry Jen has updated the pull request with a new target base due to a merge
>> or a rebase. The incremental webrev excludes the unrelated changes brought
>> in by the merge/rebase. The pull request contains three
On Fri, 4 Apr 2025 16:41:52 GMT, Lance Andersen wrote:
>> Yes, in a perfect world there will be a 1 to 1 match but either way we
>> should sanity check it in case something happened
>
>> Is the ordering required by ZIP or Jar format? We can certainly do that if
>> that's under spec and not an i
> This PR check the jar file to ensure entries are consistent from the central
> directory and local file header. Also check there is no duplicate entry names
> that could override the desired content by accident.
Henry Jen has updated the pull request with a new target base due to a
On Wed, 23 Apr 2025 00:56:18 GMT, Jiangli Zhou wrote:
>> Please review this PR that changes to use `NativeLibraries.loadLibrary()`
>> for loading the `libsyslookup` in `jdk.internal.foreign.SystemLookup` class.
>>
>> `NativeLibraries.loadLibrary()` handles both the shared library and (static)
On Tue, 22 Apr 2025 23:29:02 GMT, Jiangli Zhou wrote:
>> Please review this PR that changes to use `NativeLibraries.loadLibrary()`
>> for loading the `libsyslookup` in `jdk.internal.foreign.SystemLookup` class.
>>
>> `NativeLibraries.loadLibrary()` handles both the shared library and (static)
On Thu, 17 Apr 2025 20:51:10 GMT, Chen Liang wrote:
>> When jdeps was migrated from old classfile to ClassFile API, the parsing
>> semantic changed - error checks are now made lazily, and nested crashes from
>> malformed signature or other problems is now latent, after a `ClassModel`
>> instan
On Fri, 11 Apr 2025 22:45:55 GMT, Chen Liang wrote:
> When jdeps was migrated from old classfile to ClassFile API, the parsing
> semantic changed - error checks are now made lazily, and nested crashes from
> malformed signature or other problems is now latent, after a `ClassModel`
> instance i
On Fri, 4 Apr 2025 15:59:47 GMT, Henry Jen wrote:
>> src/jdk.jartool/share/classes/sun/tools/jar/Validator.java line 99:
>>
>>> 97: if (!entryNames.contains(entryName)) {
>>> 98: missingEntryNames.add(entryName);
>>> 99:
On Fri, 4 Apr 2025 12:39:47 GMT, Lance Andersen wrote:
>> This PR check the jar file to ensure entries are consistent from the central
>> directory and local file header. Also check there is no duplicate entry
>> names that could override the desired content by accident.
>
> src/jdk.jartool/sha
This PR check the jar file to ensure entries are consistent from the central
directory and local file header. Also check there is no duplicate entry names
that could override the desired content by accident.
-
Commit messages:
- 8345431: Detect duplicate entries in jar files with j
On Tue, 1 Apr 2025 17:33:43 GMT, Alan Bateman wrote:
> `jmod create` maps the contents of the module to a set of packages. This
> mapping derives illegal package names when class resources are located in
> non-package locations, e.g. in the META-INF tree. `jlink` also has an issue
> in this ar
On Sat, 8 Mar 2025 00:28:15 GMT, Henry Jen wrote:
> JDK-8349989: jlink can use String.replace instead of String.replaceAll
This pull request has now been integrated.
Changeset: 0ff1c083
Author: Henry Jen
URL:
https://git.openjdk.org/jdk/com
> JDK-8349989: jlink can use String.replace instead of String.replaceAll
Henry Jen has updated the pull request incrementally with one additional commit
since the last revision:
Address review feedbacks
-
Changes:
- all: https://git.openjdk.org/jdk/pull/23954/files
-
On Sun, 9 Mar 2025 18:11:07 GMT, Chen Liang wrote:
>> src/jdk.jdeps/share/classes/com/sun/tools/jdeps/JdepsTask.java line 794:
>>
>>> 792: log.format("%-40s %s%n",
>>> 793:"-".repeat(internalApiTitle.length()),
>>> 794:
> JDK-8349989: jlink can use String.replace instead of String.replaceAll
Henry Jen has updated the pull request incrementally with one additional commit
since the last revision:
Update copyright year
-
Changes:
- all: https://git.openjdk.org/jdk/pull/23954/files
- new: ht
JDK-8349989: jlink can use String.replace instead of String.replaceAll
-
Commit messages:
- JDK-8349989: jlink can use String.replace instead of String.replaceAll
- JDK-8349984: (jdeps) jdeps can use String.repeat instead of String.replaceAll
Changes: https://git.openjdk.org/jdk/pu
On Wed, 15 Jan 2025 05:14:51 GMT, Henry Jen wrote:
> jimage use the same code to parse command line options, the resource bundle
> for jimage also need update.
This pull request has now been integrated.
Changeset: a3be97e2
Author: Henry Jen
URL:
https://git.openjdk.org/jdk/
jimage use the same code to parse command line options, the resource bundle for
jimage also need update.
-
Commit messages:
- 8347761: Test tools/jimage/JImageExtractTest.java fails after JDK-8303884
Changes: https://git.openjdk.org/jdk/pull/23123/files
Webrev: https://webrevs.op
On Wed, 8 Jan 2025 09:08:11 GMT, Per Minborg wrote:
> > Do we have a sense on how easy would it be, moving forward, to preserve the
> > "correct" order of imports? E.g. if I add a new one using IntelliJ
> > autocompletion, where would it end up? Has this patch been generated using
> > the IDE'
On Tue, 3 Dec 2024 19:59:56 GMT, Henry Jen wrote:
> Improving option value handling to support passing argument value starts with
> "--".
>
> Before the fix, in following example, --add-modules will be considered as
> another option for JLink instead of argumen
On Tue, 14 Jan 2025 09:06:21 GMT, Yasumasa Suenaga wrote:
>> Henry Jen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Use different error message for ambiguous gnu-style options as value
>
> It's b
On Fri, 10 Jan 2025 14:58:36 GMT, Severin Gehwolf wrote:
>> During code review of
>> [JDK-8346239](https://bugs.openjdk.org/browse/JDK-8346239) a few comments
>> were made after the PR integrated. This follow-up patch cleans this up and
>> adds a unit test for the `JimageDiffGenerator` class.
erly handled as
> argument value
> --add-options=--add-modules=jdk.incubator.concurrent
Henry Jen has updated the pull request incrementally with one additional commit
since the last revision:
Update copyright year
-
Changes:
- all: https://git.openjdk.org/jdk/pull/22526/file
On Mon, 13 Jan 2025 21:58:43 GMT, Henry Jen wrote:
> Sort services provided by a module to ensure reproduce same result.
This pull request has now been integrated.
Changeset: dfd215b7
Author: Henry Jen
URL:
https://git.openjdk.org/jdk/commit/dfd215b7e9e40526006448369c8847aadfe09
Sort services provided by a module to ensure reproduce same result.
-
Commit messages:
- 8347376: tools/jlink/runtimeImage/JavaSEReproducibleTest.java and
PackagedModulesVsRuntimeImageLinkTest.java failed after JDK-8321413
Changes: https://git.openjdk.org/jdk/pull/23088/files
Web
erly handled as
> argument value
> --add-options=--add-modules=jdk.incubator.concurrent
Henry Jen has updated the pull request incrementally with one additional commit
since the last revision:
Use different error message for ambiguous gnu-style options as value
-
Changes:
- al
On Wed, 8 Jan 2025 00:40:04 GMT, Henry Jen wrote:
>> Improving option value handling to support passing argument value starts
>> with "--".
>>
>> Before the fix, in following example, --add-modules will be considered as
>> another option for JLink ins
On Thu, 9 Jan 2025 18:25:16 GMT, Severin Gehwolf wrote:
>> During code review of
>> [JDK-8346239](https://bugs.openjdk.org/browse/JDK-8346239) a few comments
>> were made after the PR integrated. This follow-up patch cleans this up and
>> adds a unit test for the `JimageDiffGenerator` class.
>
On Thu, 9 Jan 2025 17:32:39 GMT, Severin Gehwolf wrote:
> During code review of
> [JDK-8346239](https://bugs.openjdk.org/browse/JDK-8346239) a few comments
> were made after the PR integrated. This follow-up patch cleans this up and
> adds a unit test for the `JimageDiffGenerator` class.
>
>
On Mon, 16 Sep 2024 17:50:52 GMT, Henry Jen wrote:
> This PR split out large array/set construction into separate factory methods
> to avoid oversized method trying to construct several of those.
>
> In order to do that, we will need to generate those help methods on demand in
On Thu, 2 Jan 2025 18:43:35 GMT, Henry Jen wrote:
>> I would expect the next token would be parsed as the value. I suggest to
>> explore that and see how complex it would be.
>>
>> It seems awkward if the following are accepted:
>>
>> --add-options &qu
On Thu, 19 Dec 2024 18:14:39 GMT, Severin Gehwolf wrote:
> Please review this fairly simple change to improve how the
> `JimageDiffGenerator` works. The original implementation is pretty naive and
> read all bytes into memory and then compared them. This improved version only
> reads bytes on
On Sun, 22 Sep 2024 15:38:19 GMT, Alan Bateman wrote:
>> This PR split out large array/set construction into separate factory methods
>> to avoid oversized method trying to construct several of those.
>>
>> In order to do that, we will need to generate those help methods on demand
>> in the cl
handled as
> argument value. Also using "" with multiple values will be recognized
> properly. So following form should work
> --add-options "--add-modules jdk.incubator.concurrent"
> --add-options=--add-modules=jdk.incubator.concurrent
Henry Jen has updated the
er is captured in advance, this count could mismatch as built
> time and run time.
>
> So we make this build in advance, and use a static array for values referred
> more than once.
>
> All the codegen instead of giving index to be loaded, the builder snippet now
> load the wa
On Thu, 5 Dec 2024 17:45:32 GMT, Mandy Chung wrote:
>> --style argument still could be a real jlink argument, better check would be
>> to see if that's a valid jlink option rather than just "--".
>> The other alternative would be like what proposed by @YaSuenag, simply take
>> the next token a
On Fri, 20 Dec 2024 22:32:00 GMT, Mandy Chung wrote:
>> Henry Jen has updated the pull request with a new target base due to a merge
>> or a rebase. The incremental webrev excludes the unrelated changes brought
>> in by the merge/rebase. The pull request contains 16
On Fri, 13 Dec 2024 23:29:23 GMT, Henry Jen wrote:
>> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/SystemModulesPlugin.java
>> line 584:
>>
>>> 582: private void dedups(ModuleDescriptor md) {
>>> 583: // exports
>>
er is captured in advance, this count could mismatch as built
> time and run time.
>
> So we make this build in advance, and use a static array for values referred
> more than once.
>
> All the codegen instead of giving index to be loaded, the builder snippet now
> load the wa
On Fri, 20 Dec 2024 22:20:16 GMT, Mandy Chung wrote:
>> Henry Jen has updated the pull request with a new target base due to a merge
>> or a rebase. The incremental webrev excludes the unrelated changes brought
>> in by the merge/rebase. The pull request contains 16
er is captured in advance, this count could mismatch as built
> time and run time.
>
> So we make this build in advance, and use a static array for values referred
> more than once.
>
> All the codegen instead of giving index to be loaded, the builder snippet now
> load the wa
er is captured in advance, this count could mismatch as built
> time and run time.
>
> So we make this build in advance, and use a static array for values referred
> more than once.
>
> All the codegen instead of giving index to be loaded, the builder snippet now
> load the wa
On Fri, 13 Dec 2024 23:24:33 GMT, Mandy Chung wrote:
>> Henry Jen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Move up Snippet setup as a builder
>
> src/jdk.jlink/share/classes/jdk/tools/jlink/i
On Fri, 13 Dec 2024 22:42:47 GMT, Mandy Chung wrote:
>> Henry Jen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Move up Snippet setup as a builder
>
> src/jdk.jlink/share/classes/jd
On Fri, 13 Dec 2024 23:06:47 GMT, Mandy Chung wrote:
>> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/SystemModulesPlugin.java
>> line 1136:
>>
>>> 1134: /*
>>> 1135: * SetReference count references to the set, and use
>>> LoadableSet under the hood to
>
er is captured in advance, this count could mismatch as built
> time and run time.
>
> So we make this build in advance, and use a static array for values referred
> more than once.
>
> All the codegen instead of giving index to be loaded, the builder snippet now
> load the wa
On Fri, 6 Dec 2024 00:43:29 GMT, Damon Nguyen wrote:
>> That's because the English source file had an update to introduce those
>> double single quotes. (See
>> https://cr.openjdk.org/~jlu/output/src/jdk.compiler/share/classes/com/sun/tools/javac/resources/javac.html).
>> It's just being updat
On Thu, 5 Dec 2024 22:36:12 GMT, Justin Lu wrote:
> Please review this PR which contains the open L10n drop changes for RDP1.
>
> I recommend viewing the improved diffs which are built out by Jon's tool
> here: https://cr.openjdk.org/~jlu/output/. As always, I can not confirm the
> correctnes
On Tue, 3 Dec 2024 22:43:17 GMT, Mandy Chung wrote:
>> Henry Jen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix style
>
> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/TaskH
handled as
> argument value. Also using "" with multiple values will be recognized
> properly. So following form should work
> --add-options "--add-modules jdk.incubator.concurrent"
> --add-options=--add-modules=jdk.incubator.concurrent
Henry Jen has updated t
ild time, and then later be replaced with value from
> VersionProps.
>
> To keep current behavior, we treat 'N/A' value as no-op to mimic current
> build behavior. Perhaps we don't really need this, as proper value should be
> set with `branding.conf` in officia
On Wed, 4 Dec 2024 18:27:45 GMT, Mandy Chung wrote:
>> src/java.base/share/classes/java/lang/VersionProps.java.template line 128:
>>
>>> 126:
>>> 127: // In case VM is not yet set this property
>>> 128: props.putIfAbsent("java.vm.vendor", VENDOR_VM);
>>
>> Can this system prope
On Wed, 4 Dec 2024 18:03:42 GMT, Mandy Chung wrote:
>> Henry Jen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Clean up adapting review comments
>
> make/autoconf/spec.gmk.template line 276:
>
>&
ild time, and then later be replaced with value from
> VersionProps.
>
> To keep current behavior, we treat 'N/A' value as no-op to mimic current
> build behavior. Perhaps we don't really need this, as proper value should be
> set with `branding.conf` in officia
On Wed, 4 Dec 2024 06:15:56 GMT, Henry Jen wrote:
>> Or are you assuming/expecting the VersionProps value is null unless being
>> overridden? You could initialize the VersionProps value to be the same as
>> what VENDOR is at build time and always use it to set the
>> A
On Wed, 4 Dec 2024 06:04:09 GMT, David Holmes wrote:
>> src/hotspot/share/runtime/abstract_vm_version.cpp line 132:
>>
>>> 130:
>>> 131: static const char vm_vendor_string[sizeof(VENDOR) < VENDOR_PADDING ?
>>> VENDOR_PADDING : sizeof(VENDOR)] = VENDOR;
>>> 132: const char* Abstract_VM_Version:
On Wed, 4 Dec 2024 05:24:15 GMT, Henry Jen wrote:
>> Add jlink plugins to allow branding change for java.vendor, java.vm.vendor
>> and java.vendor.url.
>>
>> The jlink plugin will change the value in java.lang.VersionProps, which will
>> set those property va
On Wed, 4 Dec 2024 05:24:15 GMT, Henry Jen wrote:
>> Add jlink plugins to allow branding change for java.vendor, java.vm.vendor
>> and java.vendor.url.
>>
>> The jlink plugin will change the value in java.lang.VersionProps, which will
>> set those property va
ild time, and then later be replaced with value from
> VersionProps.
>
> To keep current behavior, we treat 'N/A' value as no-op to mimic current
> build behavior. Perhaps we don't really need this, as proper value should be
> set with `branding.conf` in officia
ild time, and then later be replaced with value from
> VersionProps.
>
> To keep current behavior, we treat 'N/A' value as no-op to mimic current
> build behavior. Perhaps we don't really need this, as proper value should be
> set with `branding.conf` in official bui
On Tue, 2 Jul 2024 12:20:17 GMT, Yasumasa Suenaga wrote:
> We cannot pass GNU style options like `--enable-preview` to `jlink
> --add-option`. It is hard to use for complex application.
>
> We have workaround for this issue (see JBS), but I think it is better to fix
> on JDK side.
The propose
Improving plugin option value handling to support passing argument value starts
with "--".
Before the fix, in following example, --add-modules will be considered as
another option for JLink instead of argument value for --add-options.
--add-options --add-modules=jdk.incubator.concurrent
--add-op
On Tue, 3 Dec 2024 17:01:06 GMT, Severin Gehwolf wrote:
>> I think the issue is not the default value, but the special treatment with
>> default value. Is there a reason we didn't set COMPANY_NAME to "N/A" as in
>> branding.conf?
>> https://github.com/openjdk/jdk/blame/master/make/autoconf/spec
1 - 100 of 150 matches
Mail list logo
