Re: RFR: 8283660: Convert com/sun/jndi/ldap/AbstractLdapNamingEnumeration.java finalizer to Cleaner

2025-05-15 Thread Hendrik Schick
On Wed, 14 May 2025 23:51:36 GMT, Brent Christian wrote: > Please review this change to replace the finalizer in > `AbstractLdapNamingEnumeration` with Cleaner. > > (The [first PR](https://github.com/openjdk/jdk/pull/8311) for this fix > started some substantial discussions, leading to, among

Re: RFR: 8351443: Improve robustness of StringBuilder

2025-05-01 Thread Hendrik Schick
On Wed, 30 Apr 2025 14:12:36 GMT, Roger Riggs wrote: > Refactor AbstractStringBuilder to maintain consistency among count, coder, > and value buffers while the buffer capacity is being expanded and/or inflated > from Latin1 to UTF16 representations. > The refactoring pattern is to read and wri

Re: RFR: 8355651: Issues with post-image hook [v2]

2025-04-29 Thread Hendrik Schick
order > - Update > src/jdk.jpackage/linux/classes/jdk/jpackage/internal/LinuxDebBundler.java > >Co-authored-by: Hendrik Schick <30866028+k...@users.noreply.github.com> > - Better test coverage > - Change signature of TKit.assertEquals(String, String, Strin

Re: RFR: 8355636: Speed ​​up Throwable::printStackTrace by reducing object allocation

2025-04-25 Thread Hendrik Schick
On Fri, 25 Apr 2025 01:36:50 GMT, Shaojin Wen wrote: > In the Throwable::printStackTrace method, StringBuilder is created multiple > times to build String. By sharing StringBuilder to build String, object > allocation and copying are reduced. > > In the scenario without suppressed and ourCause

Re: RFR: 8354724: BufferedReader readAllLines and readString methods

2025-04-17 Thread Hendrik Schick
On Thu, 17 Apr 2025 16:18:55 GMT, Brian Burkhalter wrote: > Implement the requested methods and add a test thereof. src/java.base/share/classes/java/io/BufferedReader.java line 459: > 457: * @since 25 > 458: */ > 459: public String readString() throws IOException { Suggestion:

Re: RFR: 8349716: IllegalAccessError when Proxy methods return object of a package-private type

2025-04-13 Thread Hendrik Schick
On Sun, 13 Apr 2025 09:49:46 GMT, Chen Liang wrote: > Proxy currently places proxy classes that proxy interfaces with > package-private return types in dynamic modules. This means that if a return > value is non-null, Proxy cannot return it and throws IllegalAccessError. > > This patch changes