Re: RFR: 8361300: Document exceptions for Unsafe offset methods [v4]

2025-07-08 Thread Doug Lea
On Tue, 8 Jul 2025 17:59:32 GMT, Alan Bateman wrote: >> Tracked in 8360541; I think we can implement in a separate patch. Don't know >> if this is worth backporting to MRs. > > Ah yes, I'd forgotten I created this issue to track clarifying the spec. Sure, the clarification is long past being us

Integrated: 8359919: Minor java.util.concurrent doc improvements

2025-06-26 Thread Doug Lea
On Wed, 18 Jun 2025 17:51:20 GMT, Doug Lea wrote: > This collects miscellaneous open issues that can be resolved with > documentation updates; each indicated by adding JDK issue numbers This pull request has now been integrated. Changeset: ff24088c Author: Doug Lea URL:

Re: RFR: 8359919: Minor java.util.concurrent doc improvements [v19]

2025-06-26 Thread Doug Lea
> This collects miscellaneous open issues that can be resolved with > documentation updates; each indicated by adding JDK issue numbers Doug Lea has updated the pull request incrementally with one additional commit since the last revision: Use javadoc internal linkages

Re: RFR: 8359919: Minor java.util.concurrent doc improvements [v18]

2025-06-25 Thread Doug Lea
On Tue, 24 Jun 2025 15:21:15 GMT, Doug Lea wrote: >> This collects miscellaneous open issues that can be resolved with >> documentation updates; each indicated by adding JDK issue numbers > > Doug Lea has updated the pull request incrementally with one additional >

Re: RFR: 8359919: Minor java.util.concurrent doc improvements [v18]

2025-06-24 Thread Doug Lea
> This collects miscellaneous open issues that can be resolved with > documentation updates; each indicated by adding JDK issue numbers Doug Lea has updated the pull request incrementally with one additional commit since the last revision: Add JDK-8311131 - Changes:

Re: RFR: 8359919: Minor java.util.concurrent doc improvements [v17]

2025-06-24 Thread Doug Lea
> This collects miscellaneous open issues that can be resolved with > documentation updates; each indicated by adding JDK issue numbers Doug Lea has updated the pull request incrementally with 20 additional commits since the last revision: - Merge remote-tracking branch 'refs/rem

Re: RFR: 8359919: Minor java.util.concurrent doc improvements [v16]

2025-06-24 Thread Doug Lea
> This collects miscellaneous open issues that can be resolved with > documentation updates; each indicated by adding JDK issue numbers Doug Lea has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought

Re: RFR: 8359919: Minor java.util.concurrent doc improvements [v15]

2025-06-24 Thread Doug Lea
On Sun, 22 Jun 2025 12:54:29 GMT, Doug Lea wrote: >> This collects miscellaneous open issues that can be resolved with >> documentation updates; each indicated by adding JDK issue numbers > > Doug Lea has updated the pull request with a new target base due to a merge

Re: RFR: 8359919: Minor java.util.concurrent doc improvements [v14]

2025-06-22 Thread Doug Lea
On Sat, 21 Jun 2025 12:46:21 GMT, Doug Lea wrote: >> This collects miscellaneous open issues that can be resolved with >> documentation updates; each indicated by adding JDK issue numbers > > Doug Lea has updated the pull request incrementally with one additional >

Re: RFR: 8359919: Minor java.util.concurrent doc improvements [v15]

2025-06-22 Thread Doug Lea
> This collects miscellaneous open issues that can be resolved with > documentation updates; each indicated by adding JDK issue numbers Doug Lea has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought

Re: RFR: 8359919: Minor java.util.concurrent doc improvements [v11]

2025-06-21 Thread Doug Lea
> This collects miscellaneous open issues that can be resolved with > documentation updates; each indicated by adding JDK issue numbers Doug Lea has updated the pull request incrementally with one additional commit since the last revision: Address review comments; add JDK-8

Re: RFR: 8359919: Minor java.util.concurrent doc improvements [v14]

2025-06-21 Thread Doug Lea
> This collects miscellaneous open issues that can be resolved with > documentation updates; each indicated by adding JDK issue numbers Doug Lea has updated the pull request incrementally with one additional commit since the last revision: Add JDK-6526284 doc update - C

Re: RFR: 8359919: Minor java.util.concurrent doc improvements [v13]

2025-06-21 Thread Doug Lea
> This collects miscellaneous open issues that can be resolved with > documentation updates; each indicated by adding JDK issue numbers Doug Lea has updated the pull request incrementally with one additional commit since the last revision: Add JDK-6625724 as docfix - C

Re: RFR: 8359919: Minor java.util.concurrent doc improvements [v12]

2025-06-21 Thread Doug Lea
> This collects miscellaneous open issues that can be resolved with > documentation updates; each indicated by adding JDK issue numbers Doug Lea has updated the pull request incrementally with one additional commit since the last revision: Add JDK-6714849 doc update - C

Re: RFR: 8359919: Minor java.util.concurrent doc improvements [v10]

2025-06-21 Thread Doug Lea
On Fri, 20 Jun 2025 18:16:08 GMT, Pavel Rappo wrote: >> Doug Lea has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix ARFU type; add JDK-7176957 > > src/java.base/share/classes/java/util/concurrent/Co

Re: RFR: 8359919: Minor java.util.concurrent doc improvements [v8]

2025-06-20 Thread Doug Lea
On Fri, 20 Jun 2025 13:00:52 GMT, Alan Bateman wrote: >> Doug Lea has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Adding JDK-8333172 to doc improvements > > src/java.base/share/classes/java/util/concu

Re: RFR: 8359919: Minor java.util.concurrent doc improvements [v10]

2025-06-20 Thread Doug Lea
> This collects miscellaneous open issues that can be resolved with > documentation updates; each indicated by adding JDK issue numbers Doug Lea has updated the pull request incrementally with one additional commit since the last revision: Fix ARFU type; add JDK-7

Re: RFR: 8359919: Minor java.util.concurrent doc improvements [v9]

2025-06-20 Thread Doug Lea
> This collects miscellaneous open issues that can be resolved with > documentation updates; each indicated by adding JDK issue numbers Doug Lea has updated the pull request incrementally with one additional commit since the last revision: Address review comments; add JDK-6

Re: RFR: 8359919: Minor java.util.concurrent doc improvements [v8]

2025-06-20 Thread Doug Lea
On Thu, 19 Jun 2025 09:39:05 GMT, Viktor Klang wrote: >> Doug Lea has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Adding JDK-8333172 to doc improvements > > src/java.base/share/classes/java/util/concur

Re: RFR: 8359919: Minor java.util.concurrent doc improvements [v8]

2025-06-20 Thread Doug Lea
On Fri, 20 Jun 2025 12:10:42 GMT, Alan Bateman wrote: >> Doug Lea has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Adding JDK-8333172 to doc improvements > > src/java.base/share/classes/java/util/con

Re: RFR: 8359919: Minor java.util.concurrent doc improvements [v8]

2025-06-20 Thread Doug Lea
On Fri, 20 Jun 2025 12:47:43 GMT, Alan Bateman wrote: >> Doug Lea has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Adding JDK-8333172 to doc improvements > > src/java.base/share/classes/java/util/concurrent

Re: RFR: 8359919: Minor java.util.concurrent doc improvements [v8]

2025-06-19 Thread Doug Lea
> This collects miscellaneous open issues that can be resolved with > documentation updates; each indicated by adding JDK issue numbers Doug Lea has updated the pull request incrementally with one additional commit since the last revision: Adding JDK-8333172 to doc improv

Re: RFR: 8359919: Minor java.util.concurrent doc improvements [v7]

2025-06-19 Thread Doug Lea
> This collects miscellaneous open issues that can be resolved with > documentation updates; each indicated by adding JDK issue numbers Doug Lea has updated the pull request incrementally with one additional commit since the last revision: Add JDK-8195628 doc fix - C

Re: RFR: 8359919: Minor java.util.concurrent doc improvements [v6]

2025-06-19 Thread Doug Lea
> This collects miscellaneous open issues that can be resolved with > documentation updates; each indicated by adding JDK issue numbers Doug Lea has updated the pull request incrementally with one additional commit since the last revision: Add JDK-6317534 and JDK-6351533 doc improv

Re: RFR: 8359919: Minor java.util.concurrent doc improvements [v5]

2025-06-19 Thread Doug Lea
> This collects miscellaneous open issues that can be resolved with > documentation updates; each indicated by adding JDK issue numbers Doug Lea has updated the pull request incrementally with one additional commit since the last revision: Add JDK-8190889 docfix - C

Re: RFR: 8359919: Minor java.util.concurrent doc improvements [v4]

2025-06-19 Thread Doug Lea
> This collects miscellaneous open issues that can be resolved with > documentation updates; each indicated by adding JDK issue numbers Doug Lea has updated the pull request incrementally with one additional commit since the last revision: Add JDK-8186959 docfix - C

Re: RFR: 8359919: Minor java.util.concurrent doc improvements [v3]

2025-06-19 Thread Doug Lea
> This collects miscellaneous open issues that can be resolved with > documentation updates; each indicated by adding JDK issue numbers Doug Lea has updated the pull request incrementally with one additional commit since the last revision: Add JDK-8353155 doc impro

Re: RFR: 8359919: Minor java.util.concurrent doc improvements [v2]

2025-06-19 Thread Doug Lea
On Thu, 19 Jun 2025 09:42:01 GMT, Viktor Klang wrote: >> Doug Lea has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Address review comments > > src/java.base/share/classes/java/util/concurrent/CompletionSta

Re: RFR: 8359919: Minor java.util.concurrent doc improvements [v2]

2025-06-19 Thread Doug Lea
> This collects miscellaneous open issues that can be resolved with > documentation updates; each indicated by adding JDK issue numbers Doug Lea has updated the pull request incrementally with one additional commit since the last revision: Address review comments - C

Re: RFR: 8359919: Minor java.util.concurrent doc improvements

2025-06-19 Thread Doug Lea
On Thu, 19 Jun 2025 09:36:19 GMT, Viktor Klang wrote: >> This collects miscellaneous open issues that can be resolved with >> documentation updates; each indicated by adding JDK issue numbers > > src/java.base/share/classes/java/util/concurrent/CompletionStage.java line > 103: > >> 101: * cau

Re: RFR: 8359919: Minor java.util.concurrent doc improvements

2025-06-19 Thread Doug Lea
On Thu, 19 Jun 2025 09:32:43 GMT, Viktor Klang wrote: >> src/java.base/share/classes/java/util/concurrent/Flow.java line 64: >> >>> 62: * control required in most implementations (for example {@link >>> 63: * SubmissionPublisher}), and omits some error processing needed to >>> 64: * fully con

RFR: 8359919: Minor java.util.concurrent doc improvements

2025-06-18 Thread Doug Lea
This collects miscellaneous open issues that can be resolved with documentation updates; each indicated by adding JDK issue numbers - Commit messages: - Revert - Merge remote-tracking branch 'refs/remotes/origin/master' into JDK-8359919 - Initial set of doc updates - Merge branch

Re: RFR: 8359067: Fix typo in DelayScheduler.java

2025-06-18 Thread Doug Lea
On Sun, 8 Jun 2025 09:07:11 GMT, He-Pin(kerr) wrote: > Rename auxilliary to auxiliary @He-Pin please /integrate - PR Comment: https://git.openjdk.org/jdk/pull/25685#issuecomment-2983757923

Re: RFR: 8359067: Fix typo in DelayScheduler.java

2025-06-10 Thread Doug Lea
On Sun, 8 Jun 2025 09:07:11 GMT, He-Pin(kerr) wrote: > Rename auxilliary to auxiliary Thanks for finding and fixing this. - Marked as reviewed by dl (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/25685#pullrequestreview-2912920005

Re: RFR: 8355726: LinkedBlockingDeque fixes and improvements

2025-06-09 Thread Doug Lea
On Mon, 9 Jun 2025 09:24:57 GMT, Viktor Klang wrote: >>> We could likely check if there's any remaining capacity up front, and >>> immediately return false? >> >> We could if you like. I wanted to make as few changes as possible, to not >> introduce unexpected changes. This particular bug was

Re: RFR: 8356553 : Incorrect uses of {@link} in AbstractQueuedLongSynchronizer and AbstractQueuedSynchronizer

2025-05-28 Thread Doug Lea
On Tue, 27 May 2025 09:35:51 GMT, Viktor Klang wrote: > I had to tweak the language a bit to better reflect the intent of the text. This seems OK. Maybe needlessly pedantic, but OK :-) - PR Comment: https://git.openjdk.org/jdk/pull/25462#issuecomment-2915821182

Integrated: 8357146: ForkJoinPool:schedule(*) does not throw RejectedExecutionException when pool is shutdown

2025-05-26 Thread Doug Lea
On Sat, 24 May 2025 11:35:33 GMT, Doug Lea wrote: > Method startDelayScheduler should trap the ISE thrown by > SharedThreadContainer.start and possibly re-try termination before eventually > throwing RejectedExecutionException. This pull request has now been integrated. Changeset:

Re: RFR: 8357146: ForkJoinPool:schedule(*) does not throw RejectedExecutionException when pool is shutdown [v2]

2025-05-26 Thread Doug Lea
> Method startDelayScheduler should trap the ISE thrown by > SharedThreadContainer.start and possibly re-try termination before eventually > throwing RejectedExecutionException. Doug Lea has updated the pull request incrementally with one additional commit since the last revision:

Re: RFR: 8357146: ForkJoinPool:schedule(*) does not throw RejectedExecutionException when pool is shutdown

2025-05-25 Thread Doug Lea
On Sat, 24 May 2025 15:57:17 GMT, Alan Bateman wrote: >> Method startDelayScheduler should trap the ISE thrown by >> SharedThreadContainer.start and possibly re-try termination before >> eventually throwing RejectedExecutionException. > > src/java.base/share/classes/java/util/concurrent/ForkJoi

RFR: 8357146: ForkJoinPool:schedule(*) does not throw RejectedExecutionException when pool is shutdown

2025-05-24 Thread Doug Lea
Method startDelayScheduler should trap the ISE thrown by SharedThreadContainer.start and possibly re-try termination before eventually throwing RejectedExecutionException. - Commit messages: - undo wrong origin - Handle IllegalStateException from SharedThreadContainer.start - Rev

Re: RFR: 8357285 : JSR166 Test case testShutdownNow_delayedTasks failed

2025-05-22 Thread Doug Lea
On Thu, 22 May 2025 14:59:04 GMT, Viktor Klang wrote: >> test/jdk/java/util/concurrent/tck/ScheduledExecutorTest.java line 703: >> >>> 701: final ScheduledThreadPoolExecutor p = new >>> ScheduledThreadPoolExecutor(1); >>> 702: List> tasks = new ArrayList<>(); >>> 703: fi

Re: RFR: 8355726: LinkedBlockingDeque fixes and improvements

2025-05-12 Thread Doug Lea
On Fri, 9 May 2025 14:50:49 GMT, Viktor Klang wrote: >>> I'm a bit uneasy about incrementing the `count` in `linkFirst` but not >>> enforcing the invariant. What's the benefit to changing linkFirst and >>> linkLast to return void instead of keeping the original returning a boolean? >> >> I bas

Re: RFR: 8355726: LinkedBlockingDeque fixes and improvements

2025-05-02 Thread Doug Lea
On Mon, 28 Apr 2025 15:23:18 GMT, kabutz wrote: > We logged several bugs on the LinkedBlockingDeque. This aggregates them into > a single bug report and PR. > > 1. LinkedBlockingDeque does not immediately throw InterruptedException in > put/take > > The LinkedBlockingDeque does not behave con

Re: RFR: 8355369: Remove setAccessible usage for setting final fields in java.util.concurrent [v2]

2025-04-24 Thread Doug Lea
On Wed, 23 Apr 2025 12:38:55 GMT, Alan Bateman wrote: >> Yeah, I originally did that, but the following patch is the "smallest >> change". >> Given that the "original code" obtained the Field instance each call, this >> is still likely a performance improvement. > > This code has always used ge

Re: RFR: 8355369: Remove setAccessible usage for setting final fields in java.util.concurrent [v2]

2025-04-24 Thread Doug Lea
On Wed, 23 Apr 2025 15:22:37 GMT, Viktor Klang wrote: >> This Pull Request replaces the uses of Field + setAccessible to modify final >> fields in java.util.concurrent with Unsafe. > > Viktor Klang has updated the pull request incrementally with one additional > commit since the last revision:

Re: RFR: 8355369: Remove setAccessible usage for setting final fields in java.util.concurrent [v2]

2025-04-24 Thread Doug Lea
On Wed, 23 Apr 2025 17:54:03 GMT, Chen Liang wrote: >> I wonder if we could just change it to return `new >> ConcurrentSkipListSet<>(m)`. COWAL could be changed to return a new object >> too. > > The set only has a map field, and AbstractSet does not define any additional > field. The map shou

Re: RFR: 8353659: SubmissionPublisherTest::testCap1Submit times out

2025-04-07 Thread Doug Lea
On Sun, 6 Apr 2025 12:36:43 GMT, Viktor Klang wrote: > This PR reverts the deactivation changes of the updates to FJP introduced in > JDK-8319447. Looks good. Thanks for tracking this down. - Marked as reviewed by dl (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/24473#p

Integrated: 8319447: Improve performance of delayed task handling

2025-04-05 Thread Doug Lea
On Wed, 19 Feb 2025 16:07:56 GMT, Doug Lea wrote: > (Copied from https://bugs.openjdk.org/browse/JDK-8319447) > > The problems addressed by this CR/PR are that ScheduledThreadPoolExecutor is > both ill-suited for many (if not most) of its applications, and is a > performance

Re: RFR: 8353331: Test ForkJoinPool20Test::testFixedDelaySequence is failing

2025-04-05 Thread Doug Lea
On Tue, 1 Apr 2025 10:56:25 GMT, Alan Bateman wrote: > ForkJoinPool20Test::testFixedDelaySequence is failing intermittently. The > assert that checks that the periodically tasks only executes 8 times is > removed, it may run more than this before it cancelled. Yes, the bound is no longer guara

Re: RFR: 8351933: Inaccurate masking of TC subfield decrement in ForkJoinPool [v2]

2025-03-27 Thread Doug Lea
On Tue, 18 Mar 2025 09:11:00 GMT, Dmitry Chuyko wrote: >> Please review a tiny fix in the ForkJoinPool. Since JDK 9 (JDK-8134852 [1]) >> in one case when TC subfield in ctl field is decremented, the applied >> masking (UMASK, upper bits) may not preserve neighbor RC subfield sometimes. >> In J

Re: RFR: 8319447: Improve performance of delayed task handling [v14]

2025-03-27 Thread Doug Lea
On Thu, 27 Mar 2025 19:29:53 GMT, Simon Hartley wrote: >> Doug Lea has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Address review comments > > src/java.base/share/classes/java/util/concurrent/ForkJoinP

Re: RFR: 8319447: Improve performance of delayed task handling [v15]

2025-03-27 Thread Doug Lea
way that could be extracted > out into (package-private) interfaces if another j.u.c pool type is > introduced. > > Only one of the policy controls in ScheduledThreadPoolExecutor applies to > ForkJoinPools with DelaySchedulers: new method cancelDelayedTasksOnShutdown > controls

Re: RFR: 8319447: Improve performance of delayed task handling [v13]

2025-03-27 Thread Doug Lea
On Thu, 27 Mar 2025 13:27:30 GMT, Alan Bateman wrote: >> Personally I think it's worth it. @AlanBateman, what do you think? > > Right now it's hard to envisage needing to have >2B delayed tasks queued. > Maybe in a few years we might regret this. So maybe better to change it to > return long, I

Re: RFR: 8319447: Improve performance of delayed task handling [v12]

2025-03-27 Thread Doug Lea
On Tue, 25 Mar 2025 19:17:32 GMT, Doug Lea wrote: >> The schedule(Runnable ..) and schedule(Callable ..) methods are a single >> sentence in the interface. The ForkJoinPool methods has more to say about >> cancellation and shutdown. So while it could inherit, doesn't

Re: RFR: 8319447: Improve performance of delayed task handling [v14]

2025-03-27 Thread Doug Lea
way that could be extracted > out into (package-private) interfaces if another j.u.c pool type is > introduced. > > Only one of the policy controls in ScheduledThreadPoolExecutor applies to > ForkJoinPools with DelaySchedulers: new method cancelDelayedTasksOnShutdown > controls

Re: RFR: 8319447: Improve performance of delayed task handling [v13]

2025-03-26 Thread Doug Lea
On Wed, 26 Mar 2025 13:14:08 GMT, Viktor Klang wrote: >> Doug Lea has updated the pull request with a new target base due to a merge >> or a rebase. The pull request now contains 49 commits: >> >> - Merge branch 'openjdk:master' into JDK-8319447 >>

Re: RFR: 8319447: Improve performance of delayed task handling [v13]

2025-03-26 Thread Doug Lea
On Wed, 26 Mar 2025 13:23:12 GMT, Viktor Klang wrote: >> The commonPool can't be shutdown (both shutdown methods are specified to >> have no effect on the common pool) so I suppose it doesn't really matter. > > Heh, that's a fair point, Alan. :) Clarified: * Arranges that scheduled tasks t

Re: RFR: 8319447: Improve performance of delayed task handling [v13]

2025-03-26 Thread Doug Lea
On Wed, 26 Mar 2025 13:12:47 GMT, Viktor Klang wrote: >> Doug Lea has updated the pull request with a new target base due to a merge >> or a rebase. The pull request now contains 49 commits: >> >> - Merge branch 'openjdk:master' into JDK-8319447 >>

Re: RFR: 8319447: Improve performance of delayed task handling [v13]

2025-03-26 Thread Doug Lea
On Wed, 26 Mar 2025 13:05:46 GMT, Viktor Klang wrote: >> Doug Lea has updated the pull request with a new target base due to a merge >> or a rebase. The pull request now contains 49 commits: >> >> - Merge branch 'openjdk:master' into JDK-8319447 >>

Re: RFR: 8319447: Improve performance of delayed task handling [v12]

2025-03-25 Thread Doug Lea
On Tue, 25 Mar 2025 12:06:30 GMT, Alan Bateman wrote: >> src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java line 3507: >> >>> 3505: >>> 3506: /** >>> 3507: * Submits a one-shot task that becomes enabled after the given >> >> If the javadoc for the new methods from the

Re: RFR: 8319447: Improve performance of delayed task handling [v13]

2025-03-25 Thread Doug Lea
way that could be extracted > out into (package-private) interfaces if another j.u.c pool type is > introduced. > > Only one of the policy controls in ScheduledThreadPoolExecutor applies to > ForkJoinPools with DelaySchedulers: new method cancelDelayedTasksOnShutdown > controls whe

Re: RFR: 8319447: Improve performance of delayed task handling [v12]

2025-03-25 Thread Doug Lea
On Tue, 25 Mar 2025 16:41:41 GMT, Viktor Klang wrote: >> Doug Lea has updated the pull request with a new target base due to a merge >> or a rebase. The incremental webrev excludes the unrelated changes brought >> in by the merge/rebase. The pull request contains 47

Re: RFR: 8319447: Improve performance of delayed task handling [v12]

2025-03-25 Thread Doug Lea
On Tue, 25 Mar 2025 16:40:57 GMT, Viktor Klang wrote: >> Doug Lea has updated the pull request with a new target base due to a merge >> or a rebase. The incremental webrev excludes the unrelated changes brought >> in by the merge/rebase. The pull request contains 47

Re: RFR: 8319447: Improve performance of delayed task handling [v12]

2025-03-25 Thread Doug Lea
On Tue, 25 Mar 2025 16:38:55 GMT, Viktor Klang wrote: >> Doug Lea has updated the pull request with a new target base due to a merge >> or a rebase. The incremental webrev excludes the unrelated changes brought >> in by the merge/rebase. The pull request contains 47

Re: RFR: 8319447: Improve performance of delayed task handling [v12]

2025-03-25 Thread Doug Lea
On Tue, 25 Mar 2025 15:40:08 GMT, Viktor Klang wrote: >> Doug Lea has updated the pull request with a new target base due to a merge >> or a rebase. The incremental webrev excludes the unrelated changes brought >> in by the merge/rebase. The pull request contains 47

Re: RFR: 8319447: Improve performance of delayed task handling [v12]

2025-03-25 Thread Doug Lea
On Tue, 25 Mar 2025 15:35:52 GMT, Viktor Klang wrote: >> Doug Lea has updated the pull request with a new target base due to a merge >> or a rebase. The incremental webrev excludes the unrelated changes brought >> in by the merge/rebase. The pull request contains 47

Re: RFR: 8319447: Improve performance of delayed task handling [v12]

2025-03-25 Thread Doug Lea
On Tue, 25 Mar 2025 15:30:22 GMT, Viktor Klang wrote: >> Doug Lea has updated the pull request with a new target base due to a merge >> or a rebase. The incremental webrev excludes the unrelated changes brought >> in by the merge/rebase. The pull request contains 47

Re: RFR: 8319447: Improve performance of delayed task handling [v12]

2025-03-25 Thread Doug Lea
On Tue, 25 Mar 2025 15:14:56 GMT, Viktor Klang wrote: >> Doug Lea has updated the pull request with a new target base due to a merge >> or a rebase. The incremental webrev excludes the unrelated changes brought >> in by the merge/rebase. The pull request contains 47

Re: RFR: 8319447: Improve performance of delayed task handling [v12]

2025-03-22 Thread Doug Lea
way that could be extracted > out into (package-private) interfaces if another j.u.c pool type is > introduced. > > Only one of the policy controls in ScheduledThreadPoolExecutor applies to > ForkJoinPools with DelaySchedulers: new method cancelDelayedTasksOnShutdown > controls whe

Re: RFR: 8319447: Improve performance of delayed task handling [v11]

2025-03-14 Thread Doug Lea
way that could be extracted > out into (package-private) interfaces if another j.u.c pool type is > introduced. > > Only one of the policy controls in ScheduledThreadPoolExecutor applies to > ForkJoinPools with DelaySchedulers: new method cancelDelayedTasksOnShutdown > controls

Re: RFR: 8319447: Improve performance of delayed task handling [v10]

2025-03-13 Thread Doug Lea
way that could be extracted > out into (package-private) interfaces if another j.u.c pool type is > introduced. > > Only one of the policy controls in ScheduledThreadPoolExecutor applies to > ForkJoinPools with DelaySchedulers: new method cancelDelayedTasksOnShutdown > controls

Re: RFR: 8319447: Improve performance of delayed task handling [v9]

2025-03-13 Thread Doug Lea
On Thu, 13 Mar 2025 14:17:29 GMT, Alan Bateman wrote: >> Doug Lea has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Use SharedSecrets for ThreadLocalRandomProbe; other tweaks > > src/java.base/share/class

Re: RFR: 8319447: Improve performance of delayed task handling [v8]

2025-03-11 Thread Doug Lea
On Tue, 11 Mar 2025 13:46:52 GMT, Viktor Klang wrote: >> src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java line 1301: >> >>> 1299: if ((room == 0 ||// pad if no caller-run >>> 1300: a[m & (s - ((internal || task == null || >>> 1301:

Re: RFR: 8319447: Improve performance of delayed task handling [v9]

2025-03-11 Thread Doug Lea
way that could be extracted > out into (package-private) interfaces if another j.u.c pool type is > introduced. > > Only one of the policy controls in ScheduledThreadPoolExecutor applies to > ForkJoinPools with DelaySchedulers: new method cancelDelayedTasksOnShutdown > controls

Re: RFR: 8319447: Improve performance of delayed task handling [v8]

2025-03-09 Thread Doug Lea
way that could be extracted > out into (package-private) interfaces if another j.u.c pool type is > introduced. > > Only one of the policy controls in ScheduledThreadPoolExecutor applies to > ForkJoinPools with DelaySchedulers: new method cancelDelayedTasksOnShutdown > controls

Re: RFR: 8319447: Improve performance of delayed task handling [v6]

2025-03-09 Thread Doug Lea
On Thu, 6 Mar 2025 14:34:00 GMT, Alan Bateman wrote: >> Maybe it's worth using java.time.Duration, although it doesn't fit into the >> API very elegantly. > >> I wonder if the variance of the Consumer to this method should be more >> permissible. Something like: >> >> public ForkJoinTask submi

Re: RFR: 8319447: Improve performance of delayed task handling [v7]

2025-03-08 Thread Doug Lea
way that could be extracted > out into (package-private) interfaces if another j.u.c pool type is > introduced. > > Only one of the policy controls in ScheduledThreadPoolExecutor applies to > ForkJoinPools with DelaySchedulers: new method cancelDelayedTasksOnShutdown > controls whe

Re: RFR: 8319447: Improve performance of delayed task handling [v6]

2025-03-03 Thread Doug Lea
On Sun, 2 Mar 2025 15:49:26 GMT, Viktor Klang wrote: >> Doug Lea has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Reduce volatile reads > > src/java.base/share/classes/java/util/concurrent/DelaySche

Re: RFR: 8319447: Improve performance of delayed task handling [v6]

2025-03-01 Thread Doug Lea
way that could be extracted > out into (package-private) interfaces if another j.u.c pool type is > introduced. > > Only one of the policy controls in ScheduledThreadPoolExecutor applies to > ForkJoinPools with DelaySchedulers: new method cancelDelayedTasksOnShutdown > controls

Re: RFR: 8319447: Improve performance of delayed task handling [v5]

2025-02-28 Thread Doug Lea
way that could be extracted > out into (package-private) interfaces if another j.u.c pool type is > introduced. > > Only one of the policy controls in ScheduledThreadPoolExecutor applies to > ForkJoinPools with DelaySchedulers: new method cancelDelayedTasksOnShutdown > controls

Re: RFR: 8319447: Improve performance of delayed task handling [v4]

2025-02-27 Thread Doug Lea
On Sun, 23 Feb 2025 15:26:48 GMT, Doug Lea wrote: >> (Copied from https://bugs.openjdk.org/browse/JDK-8319447) >> >> The problems addressed by this CR/PR are that ScheduledThreadPoolExecutor is >> both ill-suited for many (if not most) of its applications, and is a &

Re: RFR: 8319447: Improve performance of delayed task handling [v4]

2025-02-26 Thread Doug Lea
On Wed, 26 Feb 2025 13:30:56 GMT, Viktor Klang wrote: >> src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java line 3131: >> >>> 3129: if ((p = (cp = common).parallelism) < 2) >>> 3130: U.compareAndSetInt(cp, PARALLELISM, p, 2); >>> 3131: return cp; >> >

Re: RFR: 8319447: Improve performance of delayed task handling [v4]

2025-02-26 Thread Doug Lea
On Wed, 26 Feb 2025 10:13:12 GMT, Alan Bateman wrote: >> Doug Lea has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Standardize parameter checking > > src/java.base/share/classes/java/util/concurre

Re: RFR: 8319447: Improve performance of delayed task handling

2025-02-25 Thread Doug Lea
On Tue, 25 Feb 2025 19:42:01 GMT, Sunmisc Unsafe wrote: >> Is it possible to use getAndSet instead of cas-loop on #pend? >> >> final Task t = tail.getAndSet(task); >> t.next = task; >> >> but that would require a new head field to bypass, probably not worth the >> gamble if the footprint incre

Re: RFR: 8319447: Improve performance of delayed task handling [v4]

2025-02-25 Thread Doug Lea
On Tue, 25 Feb 2025 17:23:07 GMT, Viktor Klang wrote: >> Doug Lea has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Standardize parameter checking > > test/jdk/java/util/concurrent/tck/ForkJoinPool2

Re: RFR: 8319447: Improve performance of delayed task handling [v4]

2025-02-25 Thread Doug Lea
On Tue, 25 Feb 2025 17:21:56 GMT, Viktor Klang wrote: >> Doug Lea has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Standardize parameter checking > > test/jdk/java/util/concurrent/tck/ForkJoinPool2

Re: RFR: 8319447: Improve performance of delayed task handling [v4]

2025-02-25 Thread Doug Lea
On Tue, 25 Feb 2025 17:06:31 GMT, Viktor Klang wrote: >> Doug Lea has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Standardize parameter checking > > test/jdk/java/util/concurrent/tck/ForkJoinPool2

Re: RFR: 8319447: Improve performance of delayed task handling [v4]

2025-02-25 Thread Doug Lea
On Tue, 25 Feb 2025 17:04:20 GMT, Viktor Klang wrote: >> Doug Lea has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Standardize parameter checking > > test/jdk/java/util/concurrent/tck/ForkJoinPool2

Re: RFR: 8319447: Improve performance of delayed task handling [v4]

2025-02-25 Thread Doug Lea
On Tue, 25 Feb 2025 14:51:29 GMT, Viktor Klang wrote: >> Doug Lea has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Standardize parameter checking > > src/java.base/share/classes/java/util/concurren

Re: RFR: 8319447: Improve performance of delayed task handling [v4]

2025-02-25 Thread Doug Lea
On Tue, 25 Feb 2025 14:46:07 GMT, Viktor Klang wrote: >> Doug Lea has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Standardize parameter checking > > src/java.base/share/classes/java/util/concurren

Re: RFR: 8319447: Improve performance of delayed task handling [v4]

2025-02-25 Thread Doug Lea
On Tue, 25 Feb 2025 14:37:49 GMT, Viktor Klang wrote: >> Doug Lea has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Standardize parameter checking > > src/java.base/share/classes/java/util/concurrent/DelaySc

Re: RFR: 8319447: Improve performance of delayed task handling [v3]

2025-02-23 Thread Doug Lea
On Sat, 22 Feb 2025 14:30:11 GMT, Doug Lea wrote: >> (Copied from https://bugs.openjdk.org/browse/JDK-8319447) >> >> The problems addressed by this CR/PR are that ScheduledThreadPoolExecutor is >> both ill-suited for many (if not most) of its applications, and is a &

Re: RFR: 8319447: Improve performance of delayed task handling [v4]

2025-02-23 Thread Doug Lea
way that could be extracted > out into (package-private) interfaces if another j.u.c pool type is > introduced. > > Only one of the policy controls in ScheduledThreadPoolExecutor applies to > ForkJoinPools with DelaySchedulers: new method cancelDelayedTasksOnShutdown > controls

Re: RFR: 8319447: Improve performance of delayed task handling [v3]

2025-02-22 Thread Doug Lea
way that could be extracted > out into (package-private) interfaces if another j.u.c pool type is > introduced. > > Only one of the policy controls in ScheduledThreadPoolExecutor applies to > ForkJoinPools with DelaySchedulers: new method cancelDelayedTasksOnShutdown > controls

Re: RFR: 8319447: Improve performance of delayed task handling [v2]

2025-02-22 Thread Doug Lea
On Fri, 21 Feb 2025 17:10:24 GMT, Viktor Klang wrote: >> Doug Lea has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Address feedback > > src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java line

Re: RFR: 8319447: Improve performance of delayed task handling [v2]

2025-02-22 Thread Doug Lea
On Fri, 21 Feb 2025 17:16:55 GMT, Viktor Klang wrote: >> Doug Lea has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Address feedback > > src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java li

Re: RFR: 8319447: Improve performance of delayed task handling [v2]

2025-02-22 Thread Doug Lea
On Fri, 21 Feb 2025 17:38:00 GMT, Viktor Klang wrote: >> Doug Lea has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Address feedback > > src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java lin

Re: RFR: 8319447: Improve performance of delayed task handling [v2]

2025-02-22 Thread Doug Lea
On Fri, 21 Feb 2025 17:23:23 GMT, Viktor Klang wrote: >> Doug Lea has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Address feedback > > src/java.base/share/classes/java/util/concurrent/ForkJoinP

Re: RFR: 8319447: Improve performance of delayed task handling [v2]

2025-02-22 Thread Doug Lea
On Fri, 21 Feb 2025 17:11:31 GMT, Viktor Klang wrote: >> Doug Lea has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Address feedback > > src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java

Re: RFR: 8319447: Improve performance of delayed task handling [v2]

2025-02-22 Thread Doug Lea
On Fri, 21 Feb 2025 16:52:41 GMT, Viktor Klang wrote: >> Doug Lea has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Address feedback > > src/java.base/share/classes/java/util/concurrent/ForkJoinT

  1   2   3   4   >