On Sat, 10 May 2025 16:41:17 GMT, fabioromano1 wrote:
> Some changes in `Biginteger`s' bit operations that increase the code
> readability and slightly optimize the execution time.
src/java.base/share/classes/java/math/BigInteger.java line 2642:
> 2640: }
> 2641: // (this.abs()
On Sun, 6 Oct 2024 19:17:24 GMT, Eirik Bjørsnøs wrote:
>> Please review this PR which proposes to change the input buffer size of
>> `ZipFileInflaterInputStream` to be based on the _compressed_ size of a ZIP
>> entry instead of the _uncompressed_ size. This saves allocation since
>> buffers wi
On Mon, 1 Jul 2024 16:28:09 GMT, ExE Boss wrote:
>> j.u.Formatter supports args == null
>
> When `args == null` or `args.length == 0`, then the format string can still
> contain `%%` or `%n`, and those will be formatted to `"%"` and
> [`System.lineSeparator()`] respectively.
>
> [`System.lin
On Sun, 30 Jun 2024 04:54:35 GMT, Shaojin Wen wrote:
>> We need a String format solution with good performance. String Template was
>> once expected, but it has been removed. j.u.Formatter is powerful, but its
>> performance is not good enough.
>>
>> This PR implements a subset of j.u.Formatte
On Sun, 30 Jun 2024 14:57:26 GMT, David Schlosnagle wrote:
>> Shaojin Wen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> laze init for `decimal fast path locale`
>
> src/java.base/share/classes/java/l
On Sat, 29 Jun 2024 18:59:33 GMT, Shaojin Wen wrote:
>> We need a String format solution with good performance. String Template was
>> once expected, but it has been removed. j.u.Formatter is powerful, but its
>> performance is not good enough.
>>
>> This PR implements a subset of j.u.Formatte
On Sat, 29 Jun 2024 16:16:51 GMT, David Schlosnagle wrote:
>> Shaojin Wen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> rename `digit` to `width`
>
> src/java.base/share/classes/java/lang/Strin
On Sat, 29 Jun 2024 11:53:31 GMT, Shaojin Wen wrote:
> We need a String format solution with good performance. String Template was
> once expected, but it has been removed. j.u.Formatter is powerful, but its
> performance is not good enough.
>
> This PR implements a subset of j.u.Formatter cap
On Thu, 12 Oct 2023 00:14:45 GMT, Chen Liang wrote:
>> Code style should be consistent
>
> He means to pull the `radix< Character,MIN_RADIX` and `radix >
> Character.MAX_RADIX` shared code in Integer and Long.parseInt (with radix
> version) to a helper method.
More explicitly I was thinking so
On Tue, 10 Oct 2023 02:54:05 GMT, Shaojin Wen wrote:
> By extracting the code that creates the exception, the CodeSize of these
> methods is less than the default FreqInlineSize 325. and for the scenario
> where the most commonly used radix is not specified and the String coder is
> LATIN1, f
On Thu, 1 Jun 2023 09:37:29 GMT, Aleksey Shipilev wrote:
>> UUID is the very important class that is used to track identities of objects
>> in large scale systems. On some of our systems, `UUID.randomUUID` takes >1%
>> of total CPU time, and is frequently a scalability bottleneck due to
>> `Se
On Thu, 20 Apr 2023 18:39:29 GMT, Naoto Sato wrote:
> The current macro assumes the argument is `jint` because all locations pass
> `jint`. However, this would not work if a wider type such as `jlong` is
> passed. Removing the `unsigned` cast and make the condition explicit would
> make the ma
On Sat, 18 Feb 2023 19:45:34 GMT, Eirik Bjorsnos wrote:
>> src/java.base/share/classes/java/lang/CharacterDataLatin1.java.template line
>> 181:
>>
>>> 179: return ( U <= 'Z' // In range A-Z
>>> 180: || (U >= 0xC0 && U <= 0XDE && U != 0xD7)) // ..or
>>> A-grave-Thorn,
On Sat, 18 Feb 2023 09:21:25 GMT, Eirik Bjorsnos wrote:
> This PR suggests we can speed up `StringLatin1.regionMatchesCI` by applying
> 'the oldest ASCII trick in the book'.
>
> The new static method `CharacterDataLatin1.equalsIgnoreCase` compares two
> latin1 bytes for equality ignoring case.
On Sat, 18 Feb 2023 23:26:08 GMT, Claes Redestad wrote:
> When encoding Strings to US-ASCII we can speed up the happy path
> significantly by using `StringCoding.countPositives` as a speculative check
> for whether there are any chars that needs to be replaced by `'?'`. Once a
> non-ASCII char
On Fri, 17 Feb 2023 09:58:54 GMT, Claes Redestad wrote:
> During work on #12453 @schlosna reported that `array.clone()` might
> underperform `System.arraycopy` in microbenchmarks and I opted to go with
> `arraycopy` throughout while investigating.
>
> Testing on x86 (SandyBridge, AVX2) I obser
On Wed, 8 Feb 2023 10:53:22 GMT, Claes Redestad wrote:
>> This patch adds special-cases to `Arrays.copyOf` and `Arrays.copyOfRange` to
>> clone arrays when `newLength` or range inputs span the input array. This
>> helps eliminate range checks and has been verified to help various String
>> ope
On Wed, 8 Feb 2023 00:07:14 GMT, Claes Redestad wrote:
>> This patch adds special-cases to `Arrays.copyOf` and `Arrays.copyOfRange` to
>> clone arrays when `newLength` or range inputs span the input array. This
>> helps eliminate range checks and has been verified to help various String
>> ope
On Wed, 8 Feb 2023 00:07:14 GMT, Claes Redestad wrote:
>> This patch adds special-cases to `Arrays.copyOf` and `Arrays.copyOfRange` to
>> clone arrays when `newLength` or range inputs span the input array. This
>> helps eliminate range checks and has been verified to help various String
>> ope
On Tue, 8 Nov 2022 23:48:22 GMT, Claes Redestad wrote:
>> Continuing the work initiated by @luhenry to unroll and then intrinsify
>> polynomial hash loops.
>>
>> I've rewired the library changes to route via a single `@IntrinsicCandidate`
>> method. To make this work I've harmonized how they a
On Mon, 31 Oct 2022 20:11:34 GMT, Jim Laskey wrote:
>> Enhance the Java programming language with string templates, which are
>> similar to string literals but contain embedded expressions. A string
>> template is interpreted at run time by replacing each expression with the
>> result of evalu
On Fri, 28 Oct 2022 20:04:18 GMT, Rémi Forax wrote:
>> But it's an implementation details, BTW i wonder if the limitation is still
>> valid, i know that John has changed the implementation of the BSM in that
>> area.
>
> Anyway, i think you are right, this can be public
If this is a public int
On Tue, 23 Aug 2022 18:32:30 GMT, Weibing Xiao wrote:
> 8290313: Produce warning when user specified java.io.tmpdir directory doesn't
> exist
src/java.base/share/classes/java/io/File.java line 2180:
> 2178:
> 2179:
> 2180: if(!tmpdir.exists() || !tmpdir.canWrite()) {
Should this che
On Wed, 27 Jul 2022 22:56:39 GMT, David Schlosnagle wrote:
> I would like to contribute an optimized version of
> `StackTraceElement#toString()` that uses a single StringBuilder throughout
> creation to avoid intermediate `String` allocations.
> `StackTraceElement#toString()`
On Mon, 8 Aug 2022 18:55:39 GMT, Max Mielchen wrote:
>> David Schlosnagle has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request cont
On Tue, 9 Aug 2022 18:35:05 GMT, Mandy Chung wrote:
>> David Schlosnagle has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request cont
String avgt 15 132.781 ±2.095
> ns/op
>
>
> After
>
> Benchmark Mode Cnt Score Error
> Units
> StackTraceElementBench.printStackTrace avgt 15 142909.133 ± 2290.720
> ns/op
> StackTraceElementBench.toStri
String avgt 15 132.781 ±2.095
> ns/op
>
>
> After
>
> Benchmark Mode Cnt Score Error
> Units
> StackTraceElementBench.printStackTrace avgt 15 142909.133 ± 2290.720
> ns/op
> StackTraceElementBench.toStri
On Tue, 2 Aug 2022 14:13:25 GMT, Roger Riggs wrote:
>> David Schlosnagle has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Inline max Integer.stringSize
>
> Are there existing tests that validate the formatt
String avgt 15 132.781 ±2.095
> ns/op
>
>
> After
>
> Benchmark Mode Cnt Score Error
> Units
> StackTraceElementBench.printStackTrace avgt 15 142909.133 ± 2290.720
> ns/op
> StackTraceElementBench.toStri
String avgt 15 132.781 ±2.095
> ns/op
>
>
> After
>
> Benchmark Mode Cnt Score Error
> Units
> StackTraceElementBench.printStackTrace avgt 15 142909.133 ± 2290.720
> ns/op
> StackTraceElementBench.toStri
On Tue, 2 Aug 2022 13:52:30 GMT, Quan Anh Mai wrote:
>> David Schlosnagle has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Estimate length
>
> src/java.base/share/classes/java/lang/StackTraceEl
String avgt 15 132.781 ±2.095
> ns/op
>
>
> After
>
> Benchmark Mode Cnt Score Error
> Units
> StackTraceElementBench.printStackTrace avgt 15 142909.133 ± 2290.720
> ns/op
> StackTraceElementBench.toStri
On Tue, 2 Aug 2022 05:29:38 GMT, Quan Anh Mai wrote:
>> David Schlosnagle has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Address comments
>
> Since constructing a `String` from a `StringBuilder` require
String avgt 15 132.781 ±2.095
> ns/op
>
>
> After
>
> Benchmark Mode Cnt Score Error
> Units
> StackTraceElementBench.printStackTrace avgt 15 142909.133 ± 2290.720
> ns/op
> StackTraceElementBench.toStri
On Mon, 1 Aug 2022 17:24:48 GMT, David Schlosnagle wrote:
>> src/java.base/share/classes/java/lang/StackTraceElement.java line 366:
>>
>>> 364: if (!dropClassLoaderName() && classLoaderName != null &&
>>> !classLoaderName.isEmpty()) {
String avgt 15 132.781 ±2.095
> ns/op
>
>
> After
>
> Benchmark Mode Cnt Score Error
> Units
> StackTraceElementBench.printStackTrace avgt 15 142909.133 ± 2290.720
> ns/op
> StackTraceElementBench.toStri
On Thu, 28 Jul 2022 00:48:32 GMT, Carter Kozak wrote:
>> I would like to contribute an optimized version of
>> `StackTraceElement#toString()` that uses a single StringBuilder throughout
>> creation to avoid intermediate `String` allocations.
>> `StackTraceElement#toString()` is used in a numbe
On Thu, 28 Jul 2022 01:23:53 GMT, David Schlosnagle wrote:
>> src/java.base/share/classes/java/lang/StackTraceElement.java line 374:
>>
>>> 372: * @throws IOException If an I/O error occurs
>>> 373: */
>>> 374: private void appen
On Mon, 1 Aug 2022 17:08:12 GMT, Сергей Цыпанов wrote:
>> I would like to contribute an optimized version of
>> `StackTraceElement#toString()` that uses a single StringBuilder throughout
>> creation to avoid intermediate `String` allocations.
>> `StackTraceElement#toString()` is used in a numb
On Thu, 28 Jul 2022 13:12:57 GMT, Сергей Цыпанов wrote:
>> `Appendable` does not currently have an `append(int)` method on the
>> interface, though `StringBuilder` does. We could add it to `Appendable` via
>> default method if so desired:
>>
>>
>> default Appendable append(int value) {
>>
On Thu, 28 Jul 2022 15:42:15 GMT, Quan Anh Mai wrote:
>> I would like to contribute an optimized version of
>> `StackTraceElement#toString()` that uses a single StringBuilder throughout
>> creation to avoid intermediate `String` allocations.
>> `StackTraceElement#toString()` is used in a numbe
I would like to contribute an optimized version of
`StackTraceElement#toString()` that uses a single StringBuilder throughout
creation to avoid intermediate `String` allocations.
`StackTraceElement#toString()` is used in a number of JDK code paths including
`Throwable#printStackTrace()`, as wel
On Fri, 8 Jul 2022 16:24:16 GMT, Roger Riggs wrote:
>> The `ProcessBuilder.pipelineStart()` implementation does not close all of
>> the file descriptors it uses to create the pipeline of processes.
>>
>> The process calling `pipelineStart()` is creating the pipes between the
>> stages.
>> As e
On Fri, 17 Jun 2022 12:59:17 GMT, Claes Redestad wrote:
> - Refactor micro using a range of parameters to a simpler benchmark that
> tests different values in one pass
> - Reduce iterations and their runtimes, but add forks (important to be able
> to detect run-to-run variation anomalies)
>
>
45 matches
Mail list logo
