On Wed, 16 Jul 2025 15:31:07 GMT, David Beaumont wrote:
>> Refactoring `ImageReader` to make it easy to add preview mode functionality
>> for Valhalla.
>>
>> This PR is a large change to `ImageReader` (effectively a rewrite) but
>> reduces the surface area of
On Wed, 16 Jul 2025 15:31:07 GMT, David Beaumont wrote:
>> Refactoring `ImageReader` to make it easy to add preview mode functionality
>> for Valhalla.
>>
>> This PR is a large change to `ImageReader` (effectively a rewrite) but
>> reduces the surface area of
asy to address).
>
> ### 2. Simplification of directory child node handling
>
> The current `ImageReader` code attempts to create parent directories "on
> demand" for any child nodes it creates. This results in parent directories
> having a non-empty but incomplete
asy to address).
>
> ### 2. Simplification of directory child node handling
>
> The current `ImageReader` code attempts to create parent directories "on
> demand" for any child nodes it creates. This results in parent directories
> having a non-empty but incompl
On Mon, 30 Jun 2025 12:27:40 GMT, David Beaumont wrote:
> Initial benchmark to capture at least some comparative measures of
> ImageReader performance.
>
> Current results on my laptop:
>
> Benchmark Mode Cnt Score
On Wed, 16 Jul 2025 06:03:28 GMT, Alan Bateman wrote:
>> Debatable. It's obviously going to scale any results somewhat based on the
>> size of the resources and number of classes. It's kind nice to see "this
>> change removes at least N micro/milli seconds of time spent" since that's a
>> mini
On Tue, 1 Jul 2025 17:02:27 GMT, David Beaumont wrote:
>> Initial benchmark to capture at least some comparative measures of
>> ImageReader performance.
>>
>> Current results on my laptop:
>>
>> Benchmark M
asy to address).
>
> ### 2. Simplification of directory child node handling
>
> The current `ImageReader` code attempts to create parent directories "on
> demand" for any child nodes it creates. This results in parent directories
> having a non-empty but incompl
asy to address).
>
> ### 2. Simplification of directory child node handling
>
> The current `ImageReader` code attempts to create parent directories "on
> demand" for any child nodes it creates. This results in parent directories
> having a non-empty but incompl
On Fri, 11 Jul 2025 14:41:30 GMT, David Beaumont wrote:
>> Refactoring `ImageReader` to make it easy to add preview mode functionality
>> for Valhalla.
>>
>> This PR is a large change to `ImageReader` (effectively a rewrite) but
>> reduces the surface area of
asy to address).
>
> ### 2. Simplification of directory child node handling
>
> The current `ImageReader` code attempts to create parent directories "on
> demand" for any child nodes it creates. This results in parent directories
> having a non-empty but incompl
On Mon, 14 Jul 2025 20:11:51 GMT, Roger Riggs wrote:
>> David Beaumont has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Linting of a few minor issues (nothing serious).
>>
>> * Linting of minor is
asy to address).
>
> ### 2. Simplification of directory child node handling
>
> The current `ImageReader` code attempts to create parent directories "on
> demand" for any child nodes it creates. This results in parent directories
> having a non-empty but incompl
asy to address).
>
> ### 2. Simplification of directory child node handling
>
> The current `ImageReader` code attempts to create parent directories "on
> demand" for any child nodes it creates. This results in parent directories
> having a non-empty but incompl
On Fri, 4 Jul 2025 12:40:43 GMT, Andrey Turbanov wrote:
>> David Beaumont has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Feedback related changes.
>
> src/java.base/share/classes/jdk/internal/jimage/ImageR
asy to address).
>
> ### 2. Simplification of directory child node handling
>
> The current `ImageReader` code attempts to create parent directories "on
> demand" for any child nodes it creates. This results in parent directories
> having a non-empty but incompl
On Wed, 2 Jul 2025 12:51:27 GMT, Alan Bateman wrote:
>> David Beaumont has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Small feedback related tweaks.
>
> src/java.base/share/classes/jdk/internal/module
On Wed, 2 Jul 2025 08:38:40 GMT, David Beaumont wrote:
>> Refactoring `ImageReader` to make it easy to add preview mode functionality
>> for Valhalla.
>>
>> This PR is a large change to `ImageReader` (effectively a rewrite) but
>> reduces the surface area of
asy to address).
>
> ### 2. Simplification of directory child node handling
>
> The current `ImageReader` code attempts to create parent directories "on
> demand" for any child nodes it creates. This results in parent directories
> having a non-empty but incompl
On Tue, 1 Jul 2025 14:32:41 GMT, ExE Boss wrote:
>> David Beaumont has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Small feedback related tweaks.
>
> src/java.base/share/classes/jdk/internal/jimage/ImageR
On Tue, 1 Jul 2025 18:30:56 GMT, Roger Riggs wrote:
>> David Beaumont has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Small feedback related tweaks.
>
> src/java.base/share/classes/jdk/internal/ji
On Tue, 1 Jul 2025 14:29:51 GMT, Alan Bateman wrote:
>> David Beaumont has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Feedback changes.
>>
>> * Making some simple tests parametrized.
>&g
asy to address).
>
> ### 2. Simplification of directory child node handling
>
> The current `ImageReader` code attempts to create parent directories "on
> demand" for any child nodes it creates. This results in parent directories
> having a non-empty but incompl
On Tue, 1 Jul 2025 18:45:49 GMT, Roger Riggs wrote:
>> test/jdk/jdk/internal/jimage/ImageReaderTest.java line 78:
>>
>>> 76:
>>> 77: @Test
>>> 78: public void testModuleDirectories() throws IOException {
>>
>> I could make these more data driven (i.e. parametrized) if people want.
>
>
On Tue, 1 Jul 2025 19:54:10 GMT, David Beaumont wrote:
>> src/java.base/share/classes/jdk/internal/module/SystemModuleFinders.java
>> line 456:
>>
>>> 454: Optional node =
>>> Optional.ofNullable(reader.findNode(nodeName));
>>> 455:
On Tue, 1 Jul 2025 14:29:28 GMT, Alan Bateman wrote:
>> David Beaumont has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Updates based on feedback.
>
> src/java.base/share/classes/jdk/internal/module/Syste
asy to address).
>
> ### 2. Simplification of directory child node handling
>
> The current `ImageReader` code attempts to create parent directories "on
> demand" for any child nodes it creates. This results in parent directories
> having a non-empty but incompl
On Tue, 1 Jul 2025 14:37:50 GMT, Alan Bateman wrote:
>> Refactoring `ImageReader` to make it easy to add preview mode functionality
>> for Valhalla.
>>
>> This PR is a large change to `ImageReader` (effectively a rewrite) but
>> reduces the surface area of the API significantly, reduces code c
On Tue, 1 Jul 2025 18:38:26 GMT, Roger Riggs wrote:
>> Refactoring `ImageReader` to make it easy to add preview mode functionality
>> for Valhalla.
>>
>> This PR is a large change to `ImageReader` (effectively a rewrite) but
>> reduces the surface area of the API significantly, reduces code co
3.752 ± 6.873
> ms/op
>
> The upcoming changes to ImageReader should show significant improvements to
> these results.
David Beaumont has updated the pull request incrementally with one additional
commit since the last revision:
Adding comment about maintainability.
---
On Tue, 1 Jul 2025 07:25:35 GMT, Alan Bateman wrote:
>> David Beaumont has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Some tidying up relating to the state objects.
>
> test/micro/org/op
On Mon, 30 Jun 2025 23:27:49 GMT, David Beaumont wrote:
> Refactoring `ImageReader` to make it easy to add preview mode functionality
> for Valhalla.
>
> This PR is a large change to `ImageReader` (effectively a rewrite) but
> reduces the surface area of the API significantl
Refactoring `ImageReader` to make it easy to add preview mode functionality for
Valhalla.
This PR is a large change to `ImageReader` (effectively a rewrite) but reduces
the surface area of the API significantly, reduces code complexity and
increases performance/memory efficiency. The need for t
3.752 ± 6.873
> ms/op
>
> The upcoming changes to ImageReader should show significant improvements to
> these results.
David Beaumont has updated the pull request incrementally with one additional
commit since the last revision:
Some tidying up relating to the state objects.
--
On Mon, 30 Jun 2025 13:18:19 GMT, David Beaumont wrote:
>> Initial benchmark to capture at least some comparative measures of
>> ImageReader performance.
>>
>> Current results on my laptop:
>>
>> Benchmark M
3.752 ± 6.873
> ms/op
>
> The upcoming changes to ImageReader should show significant improvements to
> these results.
David Beaumont has updated the pull request incrementally with one additional
commit since the last revision:
Renaming class.
-
Changes:
- all
On Mon, 30 Jun 2025 12:27:40 GMT, David Beaumont wrote:
> Initial benchmark to capture at least some comparative measures of
> ImageReader performance.
>
> Current results on my laptop:
>
> Benchmark Mode Cnt Score
On Mon, 30 Jun 2025 12:27:40 GMT, David Beaumont wrote:
> Initial benchmark to capture at least some comparative measures of
> ImageReader performance.
>
> Current results on my laptop:
>
> Benchmark Mode Cnt Score
Initial benchmark to capture at least some comparative measures of ImageReader
performance.
Current results on my laptop:
Benchmark Mode Cnt ScoreError
Units
NewImageBenchmark.warmCache_CountAllNodes avgt5 0.785 ± 0.140
ms/op
NewI
On Wed, 11 Jun 2025 08:30:18 GMT, Christian Stein wrote:
>> Please review this fix to correctly parse tokens in an argument file that
>> contains trailing comments without preceding whitespace characters before
>> the '#' comment marker, the number sign.
>>
>> The specifaction of the `java` Co
On Mon, 12 May 2025 09:40:56 GMT, David Beaumont wrote:
> Adding read-only support to ZipFileSystem.
>
> The new `accessMode` environment property allows for readOnly and readWrite
> values, and ensures that the requested mode is consistent with what's
> returned.
>
&
inal (sadly there are still non-final fields, but only a split of
> this class into two types can fix that, since determining multi-jar support
> requires reading the file system).
David Beaumont has updated the pull request incrementally with one additional
commit since
inal (sadly there are still non-final fields, but only a split of
> this class into two types can fix that, since determining multi-jar support
> requires reading the file system).
David Beaumont has updated the pull request incrementally with one additional
commit since the last revisi
inal (sadly there are still non-final fields, but only a split of
> this class into two types can fix that, since determining multi-jar support
> requires reading the file system).
David Beaumont has updated the pull request with a new target base due to a
merge or a rebase. The incremental
inal (sadly there are still non-final fields, but only a split of
> this class into two types can fix that, since determining multi-jar support
> requires reading the file system).
David Beaumont has updated the pull request incrementally with one additional
commit since the last revisio
inal (sadly there are still non-final fields, but only a split of
> this class into two types can fix that, since determining multi-jar support
> requires reading the file system).
David Beaumont has updated the pull request incrementally with one additional
commit since the last revisio
inal (sadly there are still non-final fields, but only a split of
> this class into two types can fix that, since determining multi-jar support
> requires reading the file system).
David Beaumont has updated the pull request incrementally with one additional
commit since the last revisio
On Mon, 19 May 2025 12:54:37 GMT, Jaikiran Pai wrote:
>> David Beaumont has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fixed test.
>
> test/jdk/jdk/nio/zipfs/NewFileSystemTests.java line 224:
>
>
inal (sadly there are still non-final fields, but only a split of
> this class into two types can fix that, since determining multi-jar support
> requires reading the file system).
David Beaumont has updated the pull request incrementally with one additional
commit since the last revisio
inal (sadly there are still non-final fields, but only a split of
> this class into two types can fix that, since determining multi-jar support
> requires reading the file system).
David Beaumont has updated the pull request incrementally with one additional
commit since the last revision
inal (sadly there are still non-final fields, but only a split of
> this class into two types can fix that, since determining multi-jar support
> requires reading the file system).
David Beaumont has updated the pull request incrementally with one additional
commit since the last revision:
On Mon, 19 May 2025 12:58:00 GMT, Jaikiran Pai wrote:
>> David Beaumont has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fixed test.
>
> test/jdk/jdk/nio/zipfs/NewFileSystemTests.java line 239:
>
inal (sadly there are still non-final fields, but only a split of
> this class into two types can fix that, since determining multi-jar support
> requires reading the file system).
David Beaumont has updated the pull request incrementally with one additional
commit since the last revision:
On Mon, 19 May 2025 12:39:22 GMT, Jaikiran Pai wrote:
>> David Beaumont has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fixed test.
>
> src/jdk.zipfs/share/classes/jdk/nio/zipfs/ZipFileS
inal (sadly there are still non-final fields, but only a split of
> this class into two types can fix that, since determining multi-jar support
> requires reading the file system).
David Beaumont has updated the pull request incrementally with one additional
commit since the last re
On Fri, 16 May 2025 14:37:28 GMT, Jaikiran Pai wrote:
>> David Beaumont has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Changes based on review feedback.
>
> src/jdk.zipfs/share/classes/jdk/nio/zip
On Fri, 16 May 2025 15:35:18 GMT, Lance Andersen wrote:
>> src/jdk.zipfs/share/classes/jdk/nio/zipfs/ZipFileSystem.java line 259:
>>
>>> 257:
>>> 258: // Pass "this" as a parameter after everything else is set up.
>>> 259: this.rootdir = new ZipPath(this, new byte[]{'/'});
>>
>
On Fri, 16 May 2025 14:23:38 GMT, Jaikiran Pai wrote:
>> David Beaumont has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Changes based on review feedback.
>
> src/jdk.zipfs/share/classes/jdk/nio/zip
On Fri, 16 May 2025 15:17:40 GMT, Lance Andersen wrote:
>> src/jdk.zipfs/share/classes/jdk/nio/zipfs/ZipFileSystem.java line 221:
>>
>>> 219: }
>>> 220: // sm and existence check
>>> 221: zfpath.getFileSystem().provider().checkAccess(zfpath,
>>> java.nio.file.AccessMode.
On Wed, 14 May 2025 16:42:07 GMT, Lance Andersen wrote:
>> David Beaumont has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Changes based on review feedback.
>
> test/jdk/jdk/nio/zipfs/Test
On Fri, 16 May 2025 15:19:26 GMT, Lance Andersen wrote:
>> src/jdk.zipfs/share/classes/jdk/nio/zipfs/ZipFileSystem.java line 230:
>>
>>> 228: // It requires 'entryLookup' and 'readOnly' to have safe
>>> defaults (which
>>> 229: // is why they are the only non-final fields), and
On Fri, 16 May 2025 15:38:33 GMT, Lance Andersen wrote:
>> src/jdk.zipfs/share/classes/module-info.java line 299:
>>
>>> 297: *
>>> 298: * Any other values will cause an {@code
>>> IllegalArgumentException}
>>> 299: * to be thrown.
>>
>> The wording lo
inal (sadly there are still non-final fields, but only a split of
> this class into two types can fix that, since determining multi-jar support
> requires reading the file system).
David Beaumont has updated the pull request incrementally with one additional
commit since the last revision
On Mon, 12 May 2025 20:12:53 GMT, David Beaumont wrote:
>> src/jdk.zipfs/share/classes/module-info.java line 281:
>>
>>> 279: * Even if a zip file system is writable ({@code fs.isReadOnly()
>>> == false}),
>>> 280: * this says nothin
On Wed, 14 May 2025 17:04:01 GMT, Lance Andersen wrote:
>> David Beaumont has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix comment based on current behaviour.
>
> test/jdk/jdk/nio/zipfs/NewFileSystem
On Tue, 13 May 2025 06:12:11 GMT, Alan Bateman wrote:
>> Is this comment just agreeing with the proposed behaviour stated here?
>>
>> At the moment the code prohibits "read-only && create". It's an illegal
>> argument exception (see tests).
>>
>> The only allowed access mode options with "crea
On Wed, 14 May 2025 15:40:41 GMT, Lance Andersen wrote:
>> David Beaumont has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix comment based on current behaviour.
>
> src/jdk.zipfs/share/classes/jdk/nio/zi
On Wed, 14 May 2025 16:39:18 GMT, Lance Andersen wrote:
>> David Beaumont has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix comment based on current behaviour.
>
> test/jdk/jdk/nio/zipfs/NewFileSystem
On Tue, 13 May 2025 13:56:34 GMT, Jaikiran Pai wrote:
>> David Beaumont has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix comment based on current behaviour.
>
> src/jdk.zipfs/share/classes/jdk/nio/zip
On Wed, 14 May 2025 07:43:54 GMT, Alan Bateman wrote:
>> I'll file an issue for this today, shortly.
>
> I created JDK-8356888 yesterday and [bplb](https://github.com/bplb) has
> picked it up already.
So does this mean the code is good as-is now?
-
PR Review Comment: https://git.o
On Tue, 13 May 2025 13:48:32 GMT, Jaikiran Pai wrote:
>> David Beaumont has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix comment based on current behaviour.
>
> src/jdk.zipfs/share/classes/jdk/nio/zip
On Tue, 13 May 2025 12:32:56 GMT, Jaikiran Pai wrote:
>> David Beaumont has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix comment based on current behaviour.
>
> src/jdk.zipfs/share/classes/jdk/nio/zip
On Mon, 12 May 2025 15:57:35 GMT, Alan Bateman wrote:
>> David Beaumont has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix comment based on current behaviour.
>
> src/jdk.zipfs/share/classes/module
On Mon, 12 May 2025 16:04:22 GMT, Alan Bateman wrote:
>> David Beaumont has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix comment based on current behaviour.
>
> src/jdk.zipfs/share/classes/module
On Mon, 12 May 2025 10:16:33 GMT, David Beaumont wrote:
>> Adding read-only support to ZipFileSystem.
>>
>> The new `accessMode` environment property allows for readOnly and readWrite
>> values, and ensures that the requested mode is consistent with what's
>&g
inal (sadly there are still non-final fields, but only a split of
> this class into two types can fix that, since determining multi-jar support
> requires reading the file system).
David Beaumont has updated the pull request incrementally with one additional
commit sinc
inal (sadly there are still non-final fields, but only a split of
> this class into two types can fix that, since determining multi-jar support
> requires reading the file system).
David Beaumont has updated the pull request incrementally with one additional
commit since the last revi
On Mon, 12 May 2025 09:40:56 GMT, David Beaumont wrote:
> Adding read-only support to ZipFileSystem.
>
> The new `accessMode` environment property allows for readOnly and readWrite
> values, and ensures that the requested mode is consistent with what's
> returned.
>
&
Adding read-only support to ZipFileSystem.
The new `accessMode` environment property allows for readOnly and readWrite
values, and ensures that the requested mode is consistent with what's returned.
This involved a little refactoring to ensure that "read only" state was set
initially and only u
On Thu, 8 May 2025 13:16:25 GMT, Per Minborg wrote:
>> This sketch shows how "Stable Updaters" can be used to create stable
>> computations of `@Stable` fields. Only one updater is needed per class,
>> similar to `AtomicIntegerFieldUpdater`.
>
> Per Minborg has updated the pull request incremen
On Wed, 7 May 2025 09:23:45 GMT, Per Minborg wrote:
>> This sketch shows how "Stable Updaters" can be used to create stable
>> computations of `@Stable` fields. Only one updater is needed per class,
>> similar to `AtomicIntegerFieldUpdater`.
>
> Per Minborg has updated the pull request incremen
On Wed, 16 Apr 2025 12:12:14 GMT, David Beaumont wrote:
> Increasing timeout for deadlock detection and adjusting for the timeout
> factor in higher tiers.
This pull request has now been integrated.
Changeset: e01e33d1
Author: David Beaumont
Committer: Daniel Fuchs
URL:
> Increasing timeout for deadlock detection and adjusting for the timeout
> factor in higher tiers.
David Beaumont has updated the pull request incrementally with one additional
commit since the last revision:
Removing test from the problem list.
-
Changes:
- all:
Increasing timeout for deadlock detection and adjusting for the timeout factor
in higher tiers.
-
Commit messages:
- Increasing timeout for deadlock detection.
Changes: https://git.openjdk.org/jdk/pull/24687/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=24687&range=00
Add null pointer guard in test formatter (since it can be called with a log
record without parameters).
-
Commit messages:
- Adding null check for test formatter.
Changes: https://git.openjdk.org/jdk/pull/24619/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=24619&range=00
On Mon, 14 Apr 2025 10:56:45 GMT, David Beaumont wrote:
> Add null pointer guard in test formatter (since it can be called with a log
> record without parameters).
This pull request has now been integrated.
Changeset: 313c34ae
Author: David Beaumont
Committer: Daniel Fuch
On Tue, 8 Apr 2025 11:00:27 GMT, David Beaumont wrote:
> 8353683: j.u.l.Handler classes create deadlock risk via synchronized
> publish() method.
>
> 1. Remove synchronization of calls to publish() in Handlers in
> java.util.logging package.
> 2. Add explanatory comments t
On Tue, 8 Apr 2025 16:15:13 GMT, Chen Liang wrote:
>> 8353683: j.u.l.Handler classes create deadlock risk via synchronized
>> publish() method.
>>
>> 1. Remove synchronization of calls to publish() in Handlers in
>> java.util.logging package.
>> 2. Add explanatory comments to various affected
On Tue, 8 Apr 2025 11:00:27 GMT, David Beaumont wrote:
> 8353683: j.u.l.Handler classes create deadlock risk via synchronized
> publish() method.
>
> 1. Remove synchronization of calls to publish() in Handlers in
> java.util.logging package.
> 2. Add explanatory comments t
8353683: j.u.l.Handler classes create deadlock risk via synchronized publish()
method.
1. Remove synchronization of calls to publish() in Handlers in
java.util.logging package.
2. Add explanatory comments to various affected methods.
3. Add a test to ensure deadlocks no longer occur.
Note that
e deadlocks no longer occur.
>
> Note that this change does not address issue in MemoryHandler (see
> JDK-8349208).
David Beaumont has updated the pull request incrementally with one additional
commit since the last revision:
Tweak wording.
-
Changes:
- all: https://
On Thu, 6 Feb 2025 12:07:57 GMT, David Beaumont wrote:
> 8349206: j.u.l.Handler classes create deadlock risk via synchronized
> publish() method.
>
> 1. Remove synchronization of calls to publish() in Handlers in
> java.util.logging package.
> 2. Add explanatory comments t
On Wed, 2 Apr 2025 13:54:03 GMT, Daniel Fuchs wrote:
>> David Beaumont has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Reworking user warnings about synchronization and deadlocking based on
>> Joe's c
e deadlocks no longer occur.
>
> Note that this change does not address issue in MemoryHandler (see
> JDK-8349208).
David Beaumont has updated the pull request incrementally with one additional
commit since the last revision:
Reworking user warnings about synchronization and deadlo
On Mon, 3 Mar 2025 10:15:53 GMT, David Beaumont wrote:
>> 8349206: j.u.l.Handler classes create deadlock risk via synchronized
>> publish() method.
>>
>> 1. Remove synchronization of calls to publish() in Handlers in
>> java.util.logging package.
>> 2.
e deadlocks no longer occur.
>
> Note that this change does not address issue in MemoryHandler (see
> JDK-8349208).
David Beaumont has updated the pull request incrementally with one additional
commit since the last revision:
Final round of comment tweaks.
-
Changes:
- al
On Sun, 2 Mar 2025 03:16:02 GMT, Jason Mehrens wrote:
>> I'd have to disagree with the points you make.
>>
>> The fact is that loggers are never expected to modify the passed parameters.
>> To ask people to "disown" the parameters they pass to a logger requires that
>> your best advice on how
e deadlocks no longer occur.
>
> Note that this change does not address issue in MemoryHandler (see
> JDK-8349208).
David Beaumont has updated the pull request incrementally with one additional
commit since the last revision:
Final round of comment tweaks.
-
Changes:
- al
On Tue, 25 Feb 2025 01:19:14 GMT, Stuart Marks wrote:
>> David Beaumont has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Tweaking @implNote for better rendering.
>
> src/java.logging/share/classes/java/u
On Fri, 28 Feb 2025 09:28:29 GMT, Daniel Fuchs wrote:
>> David Beaumont has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix @implNote to @apiNote.
>
> src/java.logging/share/classes/java/util/loggi
1 - 100 of 133 matches
Mail list logo
