Re: RFR: 8359761: JDK 25 RDP1 L10n resource files update [v7]

2025-06-25 Thread Damon Nguyen
On Wed, 25 Jun 2025 21:28:16 GMT, Alisen Chung wrote: >> This issue is responsible for updating the translations of all the >> localize(able) resources in the JDK since the previous L10n drop. > > Alisen Chung has updated the pull request incrementally with one additional > commit since the las

Re: RFR: 8359761: JDK 25 RDP1 L10n resource files update [v4]

2025-06-24 Thread Damon Nguyen
On Tue, 24 Jun 2025 14:59:18 GMT, Weijun Wang wrote: >> Alisen Chung has updated the pull request incrementally with one additional >> commit since the last revision: >> >> update to german translations > > src/java.base/share/classes/sun/security/util/resources/security_zh_CN.properties > l

Re: RFR: 8359761: JDK 25 RDP1 L10n resource files update [v3]

2025-06-18 Thread Damon Nguyen
On Tue, 17 Jun 2025 23:15:05 GMT, Justin Lu wrote: >> Alisen Chung has updated the pull request incrementally with one additional >> commit since the last revision: >> >> remove double quotes > > src/jdk.jdi/share/classes/com/sun/tools/example/debug/tty/TTYResources_de.java > line 2: > >> 1

Re: [jdk24] RFR: 8347498: JDK 24 RDP2 L10n resource files update

2025-01-24 Thread Damon Nguyen
hored by Justin Lu on 24 Jan 2025 and was > reviewed by Severin Gehwolf, Damon Nguyen, Naoto Sato, Joe Wang and Alexey > Semenyuk. Backport looks fine and normal to me. - Marked as reviewed by dnguyen (Committer). PR Review: https://git.openjdk.org/jdk/pull/23307#pullrequestreview-2573707535

Re: RFR: 8347498: JDK 24 RDP2 L10n resource files update

2025-01-17 Thread Damon Nguyen
On Fri, 17 Jan 2025 23:18:43 GMT, Justin Lu wrote: > Should the copyright years be 2025, unless they were _published_ in 2024? I saw the same but forgot to mention it after looking up the original files to compare to German. I'm also not sure if this should be 2024 vs 2025. I'd assume 2024 sin

Re: RFR: 8347498: JDK 24 RDP2 L10n resource files update

2025-01-17 Thread Damon Nguyen
On Fri, 17 Jan 2025 22:42:05 GMT, Justin Lu wrote: >> src/jdk.jlink/share/classes/jdk/tools/jmod/resources/jmod_de.properties line >> 60: >> >>> 58: main.opt.target-platform.arg=target-platform >>> 59: main.opt.module-path=Modulpfad >>> 60: main.opt.hash-modules=Berechnet und erfasst Hashes zur

Re: RFR: 8347498: JDK 24 RDP2 L10n resource files update

2025-01-17 Thread Damon Nguyen
On Fri, 17 Jan 2025 22:29:15 GMT, Justin Lu wrote: > Please review this PR which contains the l10n translations for between RDP1 > and RDP2 for the JDK24 stabilization branch. > > Note that these translations are only associated with changes made to the > stabilization branch. This PR will not

Re: RFR: 8347498: JDK 24 RDP2 L10n resource files update

2025-01-17 Thread Damon Nguyen
On Fri, 17 Jan 2025 22:29:15 GMT, Justin Lu wrote: > Please review this PR which contains the l10n translations for between RDP1 > and RDP2 for the JDK24 stabilization branch. > > Note that these translations are only associated with changes made to the > stabilization branch. This PR will not

Re: [jdk24] RFR: 8345327: JDK 24 RDP1 L10n resource files update

2024-12-17 Thread Damon Nguyen
> The commit being backported was authored by Justin Lu on 16 Dec 2024 and was > reviewed by Naoto Sato, Damon Nguyen, Joe Wang, Alexander Matveev, Severin > Gehwolf, Jan Lahoda, Pavel Rappo and Alexey Semenyuk. > > Thanks! Backports look good. - Marked as reviewed b

Re: RFR: 8345327: JDK 24 RDP1 L10n resource files update [v2]

2024-12-12 Thread Damon Nguyen
On Tue, 10 Dec 2024 19:35:21 GMT, Justin Lu wrote: >> Please review this PR which contains the open L10n drop changes for RDP1. >> >> I recommend viewing the improved diffs which are built out by Jon's tool >> here: https://cr.openjdk.org/~jlu/output/. As always, I can not confirm the >> corr

Re: RFR: 8345327: JDK 24 RDP1 L10n resource files update

2024-12-05 Thread Damon Nguyen
On Thu, 5 Dec 2024 22:36:12 GMT, Justin Lu wrote: > Please review this PR which contains the open L10n drop changes for RDP1. > > I recommend viewing the improved diffs which are built out by Jon's tool > here: https://cr.openjdk.org/~jlu/output/. As always, I can not confirm the > correctnes

Re: RFR: 8345327: JDK 24 RDP1 L10n resource files update

2024-12-05 Thread Damon Nguyen
On Fri, 6 Dec 2024 00:30:03 GMT, Justin Lu wrote: >> src/jdk.compiler/share/classes/com/sun/tools/javac/resources/javac_zh_CN.properties >> line 190: >> >>> 188: javac.opt.Xdoclint.package.args = [-]<程序包>(,[-]<程序包>)* >>> 189: >>> 190: javac.opt.Xdoclint.package.desc=在特定的程序包中启用或禁用检查。每个 >>> 是\

Re: RFR: 8345327: JDK 24 RDP1 L10n resource files update

2024-12-05 Thread Damon Nguyen
On Fri, 6 Dec 2024 00:24:27 GMT, Damon Nguyen wrote: > Looks generally fine overall. But, looking at the URL for the differences in > each file per language, I see changes for > `src/jdk.compiler/share/classes/com/sun/tools/javac/resources/launcher`. I > don't see any changes

Re: RFR: 8345327: JDK 24 RDP1 L10n resource files update

2024-12-05 Thread Damon Nguyen
On Thu, 5 Dec 2024 22:36:12 GMT, Justin Lu wrote: > Please review this PR which contains the open L10n drop changes for RDP1. > > I recommend viewing the improved diffs which are built out by Jon's tool > here: https://cr.openjdk.org/~jlu/output/. As always, I can not confirm the > correctnes

[jdk23] Integrated: 8333827: JDK 23 RDP1 L10n resource files update

2024-06-13 Thread Damon Nguyen
On Thu, 13 Jun 2024 21:38:48 GMT, Damon Nguyen wrote: > Hi all, > > This pull request contains a backport of commit > [c4702ca8](https://github.com/openjdk/jdk/commit/c4702ca8c026e2d265aca0126fd3fb7bc5bb392a) > from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.

[jdk23] RFR: 8333827: JDK 23 RDP1 L10n resource files update

2024-06-13 Thread Damon Nguyen
Hi all, This pull request contains a backport of commit [c4702ca8](https://github.com/openjdk/jdk/commit/c4702ca8c026e2d265aca0126fd3fb7bc5bb392a) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Damon Nguyen on 13 Jun 2024 and was

Integrated: 8333827: JDK 23 RDP1 L10n resource files update

2024-06-13 Thread Damon Nguyen
On Fri, 7 Jun 2024 22:46:44 GMT, Damon Nguyen wrote: > This issue is responsible for updating the translations of all the > localize(able) resources in the JDK. Primarily, the changes between JDK 22 > RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated.

Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v4]

2024-06-12 Thread Damon Nguyen
On Mon, 10 Jun 2024 23:11:04 GMT, Jonathan Gibbons wrote: >> @jonathan-gibbons I just realized that this change to the German file >> matches the file with the Japanese and Chinese localized files. By that I >> mean the "backwards" translations are also present for the Japanese and >> Chinese

Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v4]

2024-06-12 Thread Damon Nguyen
> Gibbons' diff tool for l10n: > https://cr.openjdk.org/~dnguyen/output2/ Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision: Undo translation for some words - Changes: - all: https://git.openjdk.org/jdk/pull/196

Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v3]

2024-06-11 Thread Damon Nguyen
> Gibbons' diff tool for l10n: > https://cr.openjdk.org/~dnguyen/output2/ Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision: Revert updated translation - Changes: - all: https://git.openjdk.org/jdk/pull/19609/f

Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v2]

2024-06-11 Thread Damon Nguyen
On Tue, 11 Jun 2024 06:00:19 GMT, Christian Stein wrote: >> "Ausgabefächer" is the best German translation here. > > The reason for going with "Bereich (area)" instead of "Fach (compartment)" is > that an area is more general compared to a compartment. At least in German: > every "Fach" is a "B

Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v2]

2024-06-10 Thread Damon Nguyen
On Mon, 10 Jun 2024 22:19:49 GMT, Chris Plummer wrote: >> Damon Nguyen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Remove double quotes > > src/jdk.jdi/share/classes/com/sun/tools/example/debug/tty/TT

Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v2]

2024-06-10 Thread Damon Nguyen
> Gibbons' diff tool for l10n: > https://cr.openjdk.org/~dnguyen/output2/ Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision: Remove double quotes - Changes: - all: https://git.openjdk.org/jdk/pull/19609/files

Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update

2024-06-10 Thread Damon Nguyen
On Mon, 10 Jun 2024 20:12:42 GMT, Jonathan Gibbons wrote: >> This is what I've determined as well. I planned to leave these untranslated >> to reduce noise between drops as well. > > While we do not translate Java keywords (when used as such, e.g. "`class` not > allowed here"), and option names

Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update

2024-06-10 Thread Damon Nguyen
On Mon, 10 Jun 2024 20:46:46 GMT, Naoto Sato wrote: > Did not look at each for translation accuracy (did some for Japanese), but > looks good overall. It's great to see diffs in native languages, rather than > those cryptic `\u` notation! Justin's tool is responsible for this. Made the pro

Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update

2024-06-10 Thread Damon Nguyen
On Mon, 10 Jun 2024 20:20:52 GMT, Phil Race wrote: >> This issue is responsible for updating the translations of all the >> localize(able) resources in the JDK. Primarily, the changes between JDK 22 >> RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated. >> >> The transl

Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update

2024-06-10 Thread Damon Nguyen
On Mon, 10 Jun 2024 20:12:42 GMT, Jonathan Gibbons wrote: >> This is what I've determined as well. I planned to leave these untranslated >> to reduce noise between drops as well. > > While we do not translate Java keywords (when used as such, e.g. "`class` not > allowed here"), and option names

Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update

2024-06-10 Thread Damon Nguyen
On Mon, 10 Jun 2024 20:20:26 GMT, Jonathan Gibbons wrote: >> This issue is responsible for updating the translations of all the >> localize(able) resources in the JDK. Primarily, the changes between JDK 22 >> RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated. >> >> The

Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update

2024-06-10 Thread Damon Nguyen
On Sun, 9 Jun 2024 22:49:11 GMT, Justin Lu wrote: >> This issue is responsible for updating the translations of all the >> localize(able) resources in the JDK. Primarily, the changes between JDK 22 >> RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated. >> >> The transla

RFR: 8333827: JDK 23 RDP1 L10n resource files update

2024-06-10 Thread Damon Nguyen
This issue is responsible for updating the translations of all the localize(able) resources in the JDK. Primarily, the changes between JDK 22 RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated. The translation tool adjusted some definitions, which causes some changes in

Re: RFR: 8312572: JDK 21 RDP2 L10n resource files update

2023-07-27 Thread Damon Nguyen
On Thu, 27 Jul 2023 06:48:32 GMT, Justin Lu wrote: >> src/jdk.jshell/share/classes/jdk/internal/jshell/tool/resources/l10n.properties >> line 185: >> >>> 183: jshell.console.no.javadoc = >>> 184: jshell.console.do.nothing = Do nothing >>> 185: jshell.console.choice = Choice:\u0020 >> >> I see

Re: RFR: 8312572: JDK 21 RDP2 L10n resource files update

2023-07-26 Thread Damon Nguyen
On Wed, 26 Jul 2023 20:41:36 GMT, Justin Lu wrote: > Please review this PR which contains the translations for updates to > localized resources in the JDK since RDP1. > > Included in this change are improved translations for certain values, which > also includes global updates for translations

[jdk20] Integrated: 8301206: Fix issue with LocaleData after JDK-8300719

2023-01-27 Thread Damon Nguyen
On Fri, 27 Jan 2023 01:43:11 GMT, Damon Nguyen wrote: > Localization update didn't include an update to LocaleData file. This PR > addresses this by updating the file with the newly translated values. The > LocaleDataTest now passes. This should address the recent relat

Re: [jdk20] RFR: 8301206: Fix issue with LocaleData after JDK-8300719 [v2]

2023-01-26 Thread Damon Nguyen
On Fri, 27 Jan 2023 02:02:34 GMT, Naoto Sato wrote: > The fix itself looks good. Add the bug id to `LocaleDataTest.java` Added BugID to the list of BugID's in `LocaleDataTest.java` - PR: https://git.openjdk.org/jdk20/pull/118

Re: [jdk20] RFR: 8301206: Fix issue with LocaleData after JDK-8300719 [v2]

2023-01-26 Thread Damon Nguyen
> Localization update didn't include an update to LocaleData file. This PR > addresses this by updating the file with the newly translated values. The > LocaleDataTest now passes. This should address the recent related failures to > LocaleData. Damon Nguyen has updated

[jdk20] RFR: 8301206: Fix issue with LocaleData after JDK-8300719

2023-01-26 Thread Damon Nguyen
Localization update didn't include an update to LocaleData file. This PR addresses this by updating the file with the newly translated values. The LocaleDataTest now passes. This should address the recent related failures to LocaleData. - Commit messages: - Update LocaleData Chan

[jdk20] Integrated: 8300719: JDK 20 RDP2 L10n resource files update

2023-01-26 Thread Damon Nguyen
On Tue, 24 Jan 2023 20:50:00 GMT, Damon Nguyen wrote: > Open l10n drop. Files have been updated with translated versions. Whitespace > tool has been ran on files. > All tests passed This pull request has now been integrated. Changeset: a67b1e77 Author: Damon Nguyen Committer: N

Re: [jdk20] RFR: 8300719: JDK 20 RDP2 L10n resource files update [v5]

2023-01-25 Thread Damon Nguyen
On Wed, 25 Jan 2023 22:38:38 GMT, Jonathan Gibbons wrote: >> It's not a noun. It's an adjective that I had to synthesize for extra >> clarity and closeness to Java Language Specification (JLS). The English >> version of that entry is as follows: >> >> doclet.throwsInheritDocUnsupported=@in

Re: [jdk20] RFR: 8300719: JDK 20 RDP2 L10n resource files update [v9]

2023-01-25 Thread Damon Nguyen
> Open l10n drop. Files have been updated with translated versions. Whitespace > tool has been ran on files. > All tests passed Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision: Replace exception-type - Changes

Re: [jdk20] RFR: 8300719: JDK 20 RDP2 L10n resource files update [v2]

2023-01-25 Thread Damon Nguyen
On Wed, 25 Jan 2023 08:17:26 GMT, danielpeintner wrote: >> Damon Nguyen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Change German help of jar command > > src/jdk.jartool/share/classes/sun/tools/jar/re

Re: [jdk20] RFR: 8300719: JDK 20 RDP2 L10n resource files update [v8]

2023-01-25 Thread Damon Nguyen
> Open l10n drop. Files have been updated with translated versions. Whitespace > tool has been ran on files. > All tests passed Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision: Update German translation -

Re: [jdk20] RFR: 8300719: JDK 20 RDP2 L10n resource files update [v5]

2023-01-25 Thread Damon Nguyen
On Wed, 25 Jan 2023 17:49:59 GMT, Weijun Wang wrote: >> Damon Nguyen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Revert culture attribute > > src/jdk.javadoc/share/classes/jdk/javadoc/inte

Re: [jdk20] RFR: 8300719: JDK 20 RDP2 L10n resource files update [v7]

2023-01-25 Thread Damon Nguyen
> Open l10n drop. Files have been updated with translated versions. Whitespace > tool has been ran on files. > All tests passed Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision: Revert one more punctuation -

Re: [jdk20] RFR: 8300719: JDK 20 RDP2 L10n resource files update [v6]

2023-01-25 Thread Damon Nguyen
> Open l10n drop. Files have been updated with translated versions. Whitespace > tool has been ran on files. > All tests passed Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision: Revert translated punctuation -

Re: [jdk20] RFR: 8300719: JDK 20 RDP2 L10n resource files update [v3]

2023-01-24 Thread Damon Nguyen
On Tue, 24 Jan 2023 23:16:02 GMT, Alexey Semenyuk wrote: >> Damon Nguyen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Change localization codes. Add CNY back > > src/jdk.jpackage/windows/classes/j

Re: [jdk20] RFR: 8300719: JDK 20 RDP2 L10n resource files update [v2]

2023-01-24 Thread Damon Nguyen
On Tue, 24 Jan 2023 22:55:43 GMT, Alexey Semenyuk wrote: >> Damon Nguyen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Change German help of jar command > > src/jdk.jpackage/windows/classes/j

Re: [jdk20] RFR: 8300719: JDK 20 RDP2 L10n resource files update [v3]

2023-01-24 Thread Damon Nguyen
On Tue, 24 Jan 2023 23:02:58 GMT, Justin Lu wrote: >> Damon Nguyen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Change localization codes. Add CNY back > > src/jdk.jlink/share/classes/jdk/tools/jlink/r

Re: [jdk20] RFR: 8300719: JDK 20 RDP2 L10n resource files update [v5]

2023-01-24 Thread Damon Nguyen
> Open l10n drop. Files have been updated with translated versions. Whitespace > tool has been ran on files. > All tests passed Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision: Revert culture attribute -

Re: [jdk20] RFR: 8300719: JDK 20 RDP2 L10n resource files update [v4]

2023-01-24 Thread Damon Nguyen
> Open l10n drop. Files have been updated with translated versions. Whitespace > tool has been ran on files. > All tests passed Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision: Remove trailing whitespace -

Re: [jdk20] RFR: 8300719: JDK 20 RDP2 L10n resource files update [v3]

2023-01-24 Thread Damon Nguyen
On Tue, 24 Jan 2023 22:49:20 GMT, Naoto Sato wrote: >> This change was made because it was compared to the original >> messages.properties. In that file, the respective line is given as >> `MANAGE_HOTSPOT_MBEANS_IN_COLON_=Manage Hotspot MBeans in:` with no trailing >> space. That's why in this

Re: [jdk20] RFR: 8300719: JDK 20 RDP2 L10n resource files update [v3]

2023-01-24 Thread Damon Nguyen
On Tue, 24 Jan 2023 22:14:36 GMT, Naoto Sato wrote: >> Damon Nguyen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Change localization codes. Add CNY back > > src/jdk.localedata/share/

Re: [jdk20] RFR: 8300719: JDK 20 RDP2 L10n resource files update [v2]

2023-01-24 Thread Damon Nguyen
On Tue, 24 Jan 2023 22:12:02 GMT, Naoto Sato wrote: >> Damon Nguyen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Change German help of jar command > > src/jdk.jpackage/windows/classes/j

Re: [jdk20] RFR: 8300719: JDK 20 RDP2 L10n resource files update [v3]

2023-01-24 Thread Damon Nguyen
> Open l10n drop. Files have been updated with translated versions. Whitespace > tool has been ran on files. > All tests passed Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision: Change localization codes. Add

Re: [jdk20] RFR: 8300719: JDK 20 RDP2 L10n resource files update [v2]

2023-01-24 Thread Damon Nguyen
On Tue, 24 Jan 2023 22:05:55 GMT, Naoto Sato wrote: >> Damon Nguyen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Change German help of jar command > > src/jdk.jconsole/share/classe

Re: [jdk20] RFR: 8300719: JDK 20 RDP2 L10n resource files update [v2]

2023-01-24 Thread Damon Nguyen
> Open l10n drop. Files have been updated with translated versions. Whitespace > tool has been ran on files. > All tests passed Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision: Change German help of ja

Re: [jdk20] RFR: 8300719: JDK 20 RDP2 L10n resource files update

2023-01-24 Thread Damon Nguyen
On Tue, 24 Jan 2023 20:50:00 GMT, Damon Nguyen wrote: > Open l10n drop. Files have been updated with translated versions. Whitespace > tool has been ran on files. > All tests passed @magicus @LanceAndersen @jonathan-gibbons @pavelrappo @dougxc @lahodaj Could you review the changes

Re: [jdk20] RFR: 8300719: JDK 20 RDP2 L10n resource files update

2023-01-24 Thread Damon Nguyen
On Tue, 24 Jan 2023 20:50:00 GMT, Damon Nguyen wrote: > Open l10n drop. Files have been updated with translated versions. Whitespace > tool has been ran on files. > All tests passed @prrace @wangweij @naotoj @JoeWang-Java @plummercj @alexeysemenyukoracle Could you review the changes

[jdk20] RFR: 8300719: JDK 20 RDP2 L10n resource files update

2023-01-24 Thread Damon Nguyen
Open l10n drop. Files have been updated with translated versions. Whitespace tool has been ran on files. All tests passed - Commit messages: - Remove currency symbol entries - Remove whitespace using tool - Remove double quotes generated by translation tool - Revert translation's

[jdk20] Integrated: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10

2022-12-16 Thread Damon Nguyen
On Wed, 14 Dec 2022 23:40:52 GMT, Damon Nguyen wrote: > Open l10n drop > All tests passed This pull request has now been integrated. Changeset: c997b5bf Author: Damon Nguyen Committer: Naoto Sato URL: https://git.openjdk.org/jdk20/commit/c997b5bffd0ebbd6d68332572639c8cea0

Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v5]

2022-12-16 Thread Damon Nguyen
On Fri, 16 Dec 2022 17:26:18 GMT, Phil Race wrote: >> Damon Nguyen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Revert old translation. Fix lang codes > > src/demo/share/jfc/SwingSet2/resources/swin

Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v8]

2022-12-16 Thread Damon Nguyen
> Open l10n drop > All tests passed Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision: Swingset newline - Changes: - all: https://git.openjdk.org/jdk20/pull/35/files - new: https://git.openjdk.org/jdk20/pull/35

Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v4]

2022-12-16 Thread Damon Nguyen
On Fri, 16 Dec 2022 15:02:42 GMT, Weijun Wang wrote: >> I didn't do the translation myself so I'm not sure the best approach to >> resolve this. I can manually replace these translations with one or the >> other. However, it's determine which parts of the code translate to >> 被视为存在安全风险" or "存在

Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v7]

2022-12-16 Thread Damon Nguyen
> Open l10n drop > All tests passed Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision: Revert swingset. Consistency in CN - Changes: - all: https://git.openjdk.org/jdk20/pull/35/files - new: https://git.openj

Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v5]

2022-12-16 Thread Damon Nguyen
On Fri, 16 Dec 2022 09:46:14 GMT, Daniel Fuchs wrote: >> src/java.base/share/classes/sun/launcher/resources/launcher_de.properties >> line 34: >> >>> 32: # Translators please note do not translate the options themselves >>> 33: java.launcher.opt.footer = \-cp >> und ZIP-/JAR-Dateien>\n-

Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v6]

2022-12-16 Thread Damon Nguyen
> Open l10n drop > All tests passed Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision: Fix missing dash - Changes: - all: https://git.openjdk.org/jdk20/pull/35/files - new: https://git.openjdk.org/jdk20/pull/35

Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v5]

2022-12-16 Thread Damon Nguyen
On Fri, 16 Dec 2022 03:38:54 GMT, Damon Nguyen wrote: >> Open l10n drop >> All tests passed > > Damon Nguyen has updated the pull request incrementally with one additional > commit since the last revision: > > Revert old translation. Fix lang codes Right, Naoto

Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v5]

2022-12-15 Thread Damon Nguyen
On Fri, 16 Dec 2022 03:38:54 GMT, Damon Nguyen wrote: >> Open l10n drop >> All tests passed > > Damon Nguyen has updated the pull request incrementally with one additional > commit since the last revision: > > Revert old translation. Fix lang codes @dfuch Could

Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v4]

2022-12-15 Thread Damon Nguyen
On Thu, 15 Dec 2022 23:30:52 GMT, Weijun Wang wrote: >> Damon Nguyen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Revert double quote as well > > src/java.base/share/classes/sun/security/tools/keytool/R

Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v2]

2022-12-15 Thread Damon Nguyen
On Thu, 15 Dec 2022 23:12:58 GMT, Alexander Matveev wrote: >> Damon Nguyen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Removed trailing whitespace > > src/jdk.jpackage/windows/classes/j

Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v3]

2022-12-15 Thread Damon Nguyen
On Fri, 16 Dec 2022 00:17:15 GMT, Damon Nguyen wrote: >> src/jdk.jpackage/windows/classes/jdk/jpackage/internal/resources/MsiInstallerStrings_de.wxl >> line 2: >> >>> 1: >>> 2: >> xmlns="http://schemas.microsoft.com/wix/2006/localization"

Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v3]

2022-12-15 Thread Damon Nguyen
On Fri, 16 Dec 2022 01:02:03 GMT, Damon Nguyen wrote: >> Looks like translation is done on files before JDK-8293462 was integrated >> (before Sep 26). See >> [commit](https://github.com/openjdk/jdk20/commit/1e222bccd3807c1be0d1d824e0f

Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v5]

2022-12-15 Thread Damon Nguyen
> Open l10n drop > All tests passed Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision: Revert old translation. Fix lang codes - Changes: - all: https://git.openjdk.org/jdk20/pull/35/files - new: https://git.openj

Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v3]

2022-12-15 Thread Damon Nguyen
On Fri, 16 Dec 2022 00:51:55 GMT, Alexander Matveev wrote: >> I'm not sure for the decisions of change in punctuation and for the missing >> {1} as I didn't do the translation myself. Would this be better to be >> reverted? > > Looks like translation is done on files before JDK-8293462 was int

Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v3]

2022-12-15 Thread Damon Nguyen
On Thu, 15 Dec 2022 23:13:22 GMT, Alexander Matveev wrote: >> Damon Nguyen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix https and changed URL back > > src/jdk.jpackage/windows/classes/j

Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v3]

2022-12-15 Thread Damon Nguyen
On Thu, 15 Dec 2022 22:57:31 GMT, Alexander Matveev wrote: >> Damon Nguyen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix https and changed URL back > > src/jdk.jpackage/share/classes/j

Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v4]

2022-12-15 Thread Damon Nguyen
> Open l10n drop > All tests passed Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision: Revert double quote as well - Changes: - all: https://git.openjdk.org/jdk20/pull/35/files - new: https://git.openjdk.org/jdk2

Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v2]

2022-12-15 Thread Damon Nguyen
On Thu, 15 Dec 2022 18:52:45 GMT, Naoto Sato wrote: >> Damon Nguyen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Removed trailing whitespace > > src/jdk.jdeps/share/classes/com/sun/tools/jdeps/resourc

Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v3]

2022-12-15 Thread Damon Nguyen
> Open l10n drop > All tests passed Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision: Fix https and changed URL back - Changes: - all: https://git.openjdk.org/jdk20/pull/35/files - new: https://git.openjdk.org

Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v2]

2022-12-15 Thread Damon Nguyen
On Thu, 15 Dec 2022 02:23:34 GMT, Damon Nguyen wrote: >> src/jdk.jlink/share/classes/jdk/tools/jmod/resources/jmod_de.properties line >> 26: >> >>> 24: # >>> 25: >>> 26: jmod.description=JMOD-Dateien erstellen und den Inhalt vorhandener >>

Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v2]

2022-12-15 Thread Damon Nguyen
On Thu, 15 Dec 2022 01:13:32 GMT, Justin Lu wrote: >> src/jdk.jlink/share/classes/jdk/tools/jlink/resources/plugins_zh_CN.properties >> line 188: >> >>> 186: main.plugin.module=\u63D2\u4EF6\u6A21\u5757 >>> 187: >>> 188: main.plugin.category=\u7C7B\u522B >> >> As Naoto pointed out, it looks l

Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v2]

2022-12-14 Thread Damon Nguyen
> Open l10n drop > All tests passed Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision: Removed trailing whitespace - Changes: - all: https://git.openjdk.org/jdk20/pull/35/files - new: https://git.openjdk.org/jdk2

Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10

2022-12-14 Thread Damon Nguyen
On Thu, 15 Dec 2022 01:04:12 GMT, Justin Lu wrote: >> Open l10n drop >> All tests passed > > src/jdk.jlink/share/classes/jdk/tools/jmod/resources/jmod_de.properties line > 26: > >> 24: # >> 25: >> 26: jmod.description=JMOD-Dateien erstellen und den Inhalt vorhandener >> JMOD-Dateien auflisten

[jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10

2022-12-14 Thread Damon Nguyen
Open l10n drop All tests passed - Commit messages: - open l10n drop Changes: https://git.openjdk.org/jdk20/pull/35/files Webrev: https://webrevs.openjdk.org/?repo=jdk20&pr=35&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8298133 Stats: 1177 lines in 110 files changed: 783