Integrated: 8311939: Excessive allocation of Matcher.groups array

2023-08-17 Thread Cristian Vat
On Sat, 15 Jul 2023 18:24:59 GMT, Cristian Vat wrote: > Reduces excessive allocation of Matcher.groups array when the original > Pattern has no groups or less than 9 groups. > > Original clamping to 10 possibly due to documented behavior from javadoc: > "In this clas

Re: RFR: 8311939: Excessive allocation of Matcher.groups array [v7]

2023-08-16 Thread Cristian Vat
that group index. > So a group index outside groups array length must never match. Cristian Vat has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains seve

Re: RFR: 8311939: Excessive allocation of Matcher.groups array [v6]

2023-08-15 Thread Cristian Vat
that group index. > So a group index outside groups array length must never match. Cristian Vat has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six addi

Re: RFR: 8311939: Excessive allocation of Matcher.groups array [v2]

2023-08-10 Thread Cristian Vat
On Fri, 28 Jul 2023 08:40:30 GMT, Aleksey Shipilev wrote: >> Cristian Vat has updated the pull request incrementally with one additional >> commit since the last revision: >> >> reduce allocations also for Matcher.usePattern > > Shouldn't the similar chan

Re: RFR: 8311939: Excessive allocation of Matcher.groups array [v5]

2023-08-03 Thread Cristian Vat
On Thu, 3 Aug 2023 14:42:45 GMT, Cristian Vat wrote: >> Reduces excessive allocation of Matcher.groups array when the original >> Pattern has no groups or less than 9 groups. >> >> Original clamping to 10 possibly due to documented behavior from javadoc: >> &qu

Re: RFR: 8311939: Excessive allocation of Matcher.groups array [v5]

2023-08-03 Thread Cristian Vat
that group index. > So a group index outside groups array length must never match. Cristian Vat has updated the pull request incrementally with one additional commit since the last revision: review condition - Changes: - all: https://git.openjdk.org/jdk/pull/14894/files

Re: RFR: 8311939: Excessive allocation of Matcher.groups array [v4]

2023-07-28 Thread Cristian Vat
On Fri, 28 Jul 2023 12:15:21 GMT, Cristian Vat wrote: >> Reduces excessive allocation of Matcher.groups array when the original >> Pattern has no groups or less than 9 groups. >> >> Original clamping to 10 possibly due to documented behavior from javadoc: >> &qu

Re: RFR: 8311939: Excessive allocation of Matcher.groups array [v2]

2023-07-28 Thread Cristian Vat
On Fri, 28 Jul 2023 08:25:55 GMT, Aleksey Shipilev wrote: >> Cristian Vat has updated the pull request incrementally with one additional >> commit since the last revision: >> >> reduce allocations also for Matcher.usePattern > > src/java.base/share/classes/jav

Re: RFR: 8311939: Excessive allocation of Matcher.groups array [v4]

2023-07-28 Thread Cristian Vat
that group index. > So a group index outside groups array length must never match. Cristian Vat has updated the pull request incrementally with one additional commit since the last revision: changes and test for CIBackRef - Changes: - all: https://git.openjdk.org/jdk/pull/14894

Re: RFR: 8311939: Excessive allocation of Matcher.groups array [v3]

2023-07-28 Thread Cristian Vat
On Fri, 28 Jul 2023 09:29:48 GMT, Cristian Vat wrote: >> Reduces excessive allocation of Matcher.groups array when the original >> Pattern has no groups or less than 9 groups. >> >> Original clamping to 10 possibly due to documented behavior from javadoc: >> &qu

Re: RFR: 8311939: Excessive allocation of Matcher.groups array [v3]

2023-07-28 Thread Cristian Vat
that group index. > So a group index outside groups array length must never match. Cristian Vat has updated the pull request incrementally with one additional commit since the last revision: remove new line - Changes: - all: https://git.openjdk.org/jdk/pull/14894/files

Re: RFR: 8311939: Excessive allocation of Matcher.groups array [v2]

2023-07-28 Thread Cristian Vat
On Sat, 22 Jul 2023 12:13:10 GMT, Cristian Vat wrote: >> Reduces excessive allocation of Matcher.groups array when the original >> Pattern has no groups or less than 9 groups. >> >> Original clamping to 10 possibly due to documented behavior from javadoc: >> &qu

Re: RFR: 8311939: Excessive allocation of Matcher.groups array [v2]

2023-07-22 Thread Cristian Vat
On Sat, 22 Jul 2023 12:13:10 GMT, Cristian Vat wrote: >> Reduces excessive allocation of Matcher.groups array when the original >> Pattern has no groups or less than 9 groups. >> >> Original clamping to 10 possibly due to documented behavior from javadoc: >> &qu

Re: RFR: 8311939: Excessive allocation of Matcher.groups array [v2]

2023-07-22 Thread Cristian Vat
that group index. > So a group index outside groups array length must never match. Cristian Vat has updated the pull request incrementally with one additional commit since the last revision: reduce allocations also for Matcher.usePattern - Changes: - all: https://git.openjdk

RFR: 8311939: Excessive allocation of Matcher.groups array

2023-07-18 Thread Cristian Vat
Reduces excessive allocation of Matcher.groups array when the original Pattern has no groups or less than 9 groups. Original clamping to 10 possibly due to documented behavior from javadoc: "In this class, \1 through \9 are always interpreted as back references, " Only with Matcher changes RegE