Re: RFR: 8307513: C2: intrinsify Math.max(long,long) and Math.min(long,long) [v14]

2025-03-10 Thread Christian Hagedorn
On Fri, 7 Mar 2025 06:19:03 GMT, Galder ZamarreƱo wrote: >> This patch intrinsifies `Math.max(long, long)` and `Math.min(long, long)` in >> order to help improve vectorization performance. >> >> Currently vectorization does not kick in for loops containing either of >> these calls because of t

Re: RFR: 8333477: Delete extra empty spaces in Makefiles

2024-06-04 Thread Christian Hagedorn
On Tue, 4 Jun 2024 07:47:46 GMT, SendaoYan wrote: > Hi all, > This PR several extra empty spaces and extra empty lines in several > Makefiles. It's trivial fix, no risk. > > Thanks. Looks good! Somehow the integrate command did not work. - Marked as reviewed by chagedorn (Revie

Re: RFR: 8332228: TypePollution.java: Unrecognized VM option 'UseSecondarySuperCache'

2024-05-28 Thread Christian Hagedorn
On Tue, 28 May 2024 14:01:44 GMT, Martin Doerr wrote: > Fix obvious typo in micro benchmark. Looks good and trivial! - Marked as reviewed by chagedorn (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/19427#pullrequestreview-2083086912

Re: [jdk21] RFR: 8310829: guarantee(!HAS_PENDING_EXCEPTION) failed in ExceptionTranslation::doit

2023-07-03 Thread Christian Hagedorn
On Mon, 3 Jul 2023 07:13:14 GMT, Tobias Hartmann wrote: > Backport of [JDK-8310829](https://bugs.openjdk.java.net/browse/JDK-8310829). > Applies cleanly. > > Thanks, > Tobias Looks good. - Marked as reviewed by chagedorn (Reviewer). PR Review: https://git.openjdk.org/jdk21/pull/

Re: RFR: JDK-8027711: Unify wildcarding syntax for CompileCommand and CompileOnly [v6]

2023-06-11 Thread Christian Hagedorn
On Sat, 10 Jun 2023 12:25:57 GMT, Tobias Holenstein wrote: >> At the moment `CompileCommand` and `CompileOnly` use different syntax for >> matching methods. >> >> ### Old CompileOnly format >> - matching a **method name** with **class name** and **package name**: >> `-XX:CompileOnly=package/p

Re: RFR: JDK-8027711: Unify wildcarding syntax for CompileCommand and CompileOnly [v5]

2023-06-09 Thread Christian Hagedorn
On Fri, 9 Jun 2023 13:44:20 GMT, Tobias Holenstein wrote: >> At the moment `CompileCommand` and `CompileOnly` use different syntax for >> matching methods. >> >> ### Old CompileOnly format >> - matching a **method name** with **class name** and **package name**: >> `-XX:CompileOnly=package/pa

Re: RFR: JDK-8027711: Unify wildcarding syntax for CompileCommand and CompileOnly [v4]

2023-06-09 Thread Christian Hagedorn
On Fri, 9 Jun 2023 13:24:20 GMT, Tobias Holenstein wrote: >> At the moment `CompileCommand` and `CompileOnly` use different syntax for >> matching methods. >> >> ### Old CompileOnly format >> - matching a **method name** with **class name** and **package name**: >> `-XX:CompileOnly=package/pa

Re: RFR: JDK-8282797: CompileCommand parsing errors should exit VM [v3]

2023-05-31 Thread Christian Hagedorn
On Wed, 24 May 2023 11:05:01 GMT, Tobias Holenstein wrote: >> Currently, errors during compile command parsing just print an error but >> don't exit the VM. As a result, issues go unnoticed. >> >> With this PR the behavior is changed to exit the VM when an error occurs. >> >> E.g. `java -XX:

Re: RFR: JDK-8027711: Unify wildcarding syntax for CompileCommand and CompileOnly [v2]

2023-05-31 Thread Christian Hagedorn
>> with `CompileOnly` and plug it into compile command file. Syntax used by >> CompileOnly is also not very intuitive. >> >> `CompileOnly` is convenient because it's shorter to write and takes lists of >> patterns, whereas `CompileCommand` only takes one patter

Re: RFR: JDK-8282797: CompileCommand parsing errors should exit VM

2023-05-24 Thread Christian Hagedorn
On Tue, 2 May 2023 11:35:54 GMT, Tobias Holenstein wrote: > Currently, errors during compile command parsing just print an error but > don't exit the VM. As a result, issues go unnoticed. > > With this PR the behavior is changed to exit the VM when an error occurs. > > E.g. `java -XX:Compile

Re: RFR: JDK-8027711: Unify wildcarding syntax for CompileCommand and CompileOnly

2023-05-23 Thread Christian Hagedorn
On Thu, 4 May 2023 13:36:22 GMT, Tobias Holenstein wrote: > At the moment `CompileCommand` and `CompileOnly` use different syntax for > matching methods. > > ### Old CompileOnly format > - matching a **method name** with **class name** and **package name**: > `-XX:CompileOnly=package/path/Cla