On Wed, 11 Jun 2025 11:22:57 GMT, Volkan Yazici wrote:
> Both `javax/script/PluggableContextTest.java` and its companion
> `test/jdk/javax/script/MyContext.java` were added in
> [JDK-6398614](https://bugs.openjdk.org/browse/JDK-6398614).
> [JDK-8246113](https://bugs.openjdk.org/browse/JDK-8246
On Wed, 12 Feb 2025 16:47:29 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change in
>> `jdk.tools.jlink.internal.plugins.ZipPlugin` which proposes to close the
>> `Deflater` instance cleanly? This addresses
>> https://bugs.openjdk.org/browse/JDK-8349907.
>>
>> As noted in tha
On Mon, 20 Jan 2025 12:12:20 GMT, Alan Bateman wrote:
>> Extend the support for optional dependences to allow for a service to be
>> optional. The post-resolution consistency check specified by
>> `Configuration.resolve` is relaxed to allow for the possibility that the
>> service from a module
On Thu, 9 Jan 2025 09:20:51 GMT, Christian Stein wrote:
>> Please review this change that improves the launcher mode detection by
>> reading the initial two characters from the started file for being a shebang
>> script. It addresses the reported confusing error messages and also supports
>> m
On Tue, 5 Nov 2024 16:16:13 GMT, Christian Stein wrote:
> Please review this change that improves the launcher mode detection by
> reading the initial two characters from the started file for being a shebang
> script. It addresses the reported confusing error messages and also supports
> more
On Fri, 6 Sep 2024 06:26:47 GMT, Athijegannathan Sundararajan
wrote:
> fixed spelling to be consistent with the rest of the man page.
This pull request has been closed without being integrated.
-
PR: https://git.openjdk.org/jdk/pull/20882
On Fri, 6 Sep 2024 06:26:47 GMT, Athijegannathan Sundararajan
wrote:
> fixed spelling to be consistent with the rest of the man page.
closed because of conflicts
-
PR Comment: https://git.openjdk.org/jdk/pull/20882#issuecomment-2490229186
On Tue, 29 Oct 2024 12:40:59 GMT, Sean Mullan wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main ch
On Mon, 7 Oct 2024 04:23:20 GMT, Jaikiran Pai wrote:
> Can I please get a review for this change which proposes to deprecate for
> removal the `jrunscript` tool?
>
> The `jrunscript` tool as documented in its specification
> https://docs.oracle.com/en/java/javase/23/docs/specs/man/jrunscript.
On Fri, 6 Sep 2024 08:45:53 GMT, Alan Bateman wrote:
>> fixed spelling to be consistent with the rest of the man page.
>
> I checked the OED and it does seem to be uncountable, which makes me wonder
> about other places, e.g. JLS 7.7.1.
@AlanBateman @pavelrappo I did double check. "dependence"
fixed spelling to be consistent with the rest of the man page.
-
Commit messages:
- 8337422: spelling error in jlink documentation
Changes: https://git.openjdk.org/jdk/pull/20882/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=20882&range=00
Issue: https://bugs.openjdk.or
On Tue, 23 Jul 2024 04:55:16 GMT, Athijegannathan Sundararajan
wrote:
> removed extra whitespaces
This pull request has now been integrated.
Changeset: 0e555b5d
Author: Athijegannathan Sundararajan
URL:
https://git.openjdk.org/jdk/commit/0e555b5ded819cc3b363673320dc848c32186
> removed extra whitespaces
Athijegannathan Sundararajan has updated the pull request incrementally with
one additional commit since the last revision:
removed space in --limit-modules option as well (review comment)
-
Changes:
- all: https://git.openjdk.org/jdk/pull/20
removed extra whitespaces
-
Commit messages:
- 8204582: Extra spaces in jlink documentation make it incorrect
Changes: https://git.openjdk.org/jdk/pull/20292/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=20292&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8204582
On Wed, 10 Jul 2024 17:01:00 GMT, Jorn Vernee wrote:
> Hi all,
>
> This pull request contains a backport of commit
> [6f7f0f1d](https://github.com/openjdk/jdk/commit/6f7f0f1de05fdc0f6a88ccd90b806e8a5c5074ef)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
> The commit bein
On Wed, 10 Jul 2024 16:08:51 GMT, Jorn Vernee wrote:
> Hi all,
>
> This pull request contains a backport of commit
> [c80e2eb3](https://github.com/openjdk/jdk/commit/c80e2eb35c4eb03f17a2a31e979e5c369453e203)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
> The commit bein
On Wed, 24 Jan 2024 06:50:36 GMT, Eirik Bjørsnøs wrote:
>> Please review this PR which rewrites the BadFactoryTest to pure Java/JUnit.
>> The test is currently implemented using a mix of shell script and a Java
>> main method.
>>
>> Reviewers may notice the following changes:
>>
>> - The she
On Wed, 10 Jan 2024 06:32:54 GMT, Athijegannathan Sundararajan
wrote:
> backported from jdk mainline "as is" without any modifications.
This pull request has now been integrated.
Changeset: 33f07b56
Author:Athijegannathan Sundararajan
URL:
https://git.openjdk.org
backported from jdk mainline "as is" without any modifications.
-
Commit messages:
- Backport 176606d0cb9117ca9080261f898cd57339fa5a85
Changes: https://git.openjdk.org/jdk22/pull/49/files
Webrev: https://webrevs.openjdk.org/?repo=jdk22&pr=49&range=00
Issue: https://bugs.openjdk.o
On Mon, 8 Jan 2024 13:24:55 GMT, Athijegannathan Sundararajan
wrote:
> Adding missing "@ since 9" in javadoc comment of the public classes,
> interfaces and packages of the jdk.dynalink module.
This pull request has now been integrated.
Changeset: 176606d0
Author:
Adding missing "@ since 9" in javadoc comment of the public classes, interfaces
and packages of the jdk.dynalink module.
-
Commit messages:
- 8310995: missing @since tags in 36 jdk.dynalink classes
Changes: https://git.openjdk.org/jdk/pull/17305/files
Webrev: https://webrevs.openj
On Fri, 8 Sep 2023 10:52:06 GMT, Maurizio Cimadamore
wrote:
>> This PR adds a privileged block surrounding the request to load the fallback
>> linker library in LibFallback.
>> The lack of this block is causing test failures when platforms using the
>> fallback linker are tested using a securi
On Mon, 5 Dec 2022 10:31:52 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-434 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] - https://openjdk
On Tue, 15 Nov 2022 02:10:01 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which proposes to fix
> https://bugs.openjdk.org/browse/JDK-8292317?
>
> The `java.util.Iterator` has a `forEachRemaining(Consumer action)`
> method. As per its contract, the implementations are ex
On Fri, 16 Sep 2022 02:59:32 GMT, Joe Darcy wrote:
> Analogous fix to one already done for javax.lang.model.SourceVersion
> (JDK-8293768), the links to JVMS 19 and 20 are not currently valid, but
> redirect to the spec language page
>
> https://docs.oracle.com/javase/specs/index.html
>
> The
On Thu, 23 Jun 2022 12:59:34 GMT, Jaikiran Pai wrote:
> Can I please get a review for this change which fixes an issue in
> `jdk.internal.jimage.ImageReader`?
>
> The `ImageReader` maintains a map of `nodes` which it uses to keep track of
> directories/resources from within the image. When a
26 matches
Mail list logo
