Re: RFR: 8356438: Update OutputAnalyzer to optionally print process output as it happens [v2]

2025-06-10 Thread Alice Pellegrini
On Mon, 9 Jun 2025 04:03:28 GMT, David Holmes wrote: >> test/lib/jdk/test/lib/process/OutputBuffer.java line 150: >> >>> 148: this.p = p; >>> 149: logProgress("Gathering output"); >>> 150: boolean verbose = Boolean.getBoolean("outputanalyzer.verbose"); >> >> Putting a system p

Re: RFR: 8356438: Update OutputAnalyzer to optionally print process output as it happens [v2]

2025-06-05 Thread Alice Pellegrini
On Thu, 5 Jun 2025 13:11:39 GMT, David Holmes wrote: > To where is the output going "as it happens"? If the `outputanalyzer.verbose` flag is set, the output is going to be printed to the console, in addition to being stored in the buffer > If you use OutputAnalyzer correctly then on failure al

Re: RFR: 8356438: Update OutputAnalyzer to optionally print process output as it happens [v2]

2025-06-05 Thread Alice Pellegrini
buffer.verbose` would make it cleaner, and avoid referencing the > OutputAnalyzer in the OutputBuffer implementation. Alice Pellegrini has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/

RFR: 8356438: Update OutputAnalyzer to optionally print process output as it happens

2025-06-05 Thread Alice Pellegrini
The implemented solution modifies the `OutputBuffer` implementation instead of the `OutputAnalyzer` implementation. This is because the **OutputBuffer implementation which handles processes** (LazyOutputBuffer) starts a thread in its constructor, so we would need to add a strange additional cons