On Wed, 9 Jul 2025 21:14:17 GMT, Chen Liang wrote:
> Currently, DirectCodeBuilder is erroneously missing argument checks for a few
> of its override methods that take arguments such as Opcode and the array size
> for multianewarray and the switches, which would write something before
> throwin
On Thu, 10 Jul 2025 21:01:18 GMT, Chen Liang wrote:
> The `class` file format often only stores lists up to 65535 in size because
> size is encoded as a u2. Currently, we truncate the list size and write all
> contents, creating malformed `class` files. Almost all scenarios where such
> oversi
On Fri, 11 Jul 2025 14:25:40 GMT, Chen Liang wrote:
>> The `class` file format often only stores lists up to 65535 in size because
>> size is encoded as a u2. Currently, we truncate the list size and write all
>> contents, creating malformed `class` files. Almost all scenarios where such
>> ov
On Thu, 10 Jul 2025 21:47:35 GMT, Chen Liang wrote:
> Noticed this error when I was verifying all sizes are u2 compatible and
> verified with a test that fails on mainline with ConstantPoolException
> (because we write a size of 2 with 1-length list content) and works in this
> patch. Problem
On Thu, 10 Jul 2025 22:32:45 GMT, Chen Liang wrote:
> Currently, the aforementioned two methods do not throw NPE upon null input,
> but throw IAE.
>
> This behavior is bad for composition: `bsmEntry` actually throws IAE for
> nested null in the argument list/array, and other APIs are similarly
On Wed, 9 Jul 2025 21:14:17 GMT, Chen Liang wrote:
> Currently, DirectCodeBuilder is erroneously missing argument checks for a few
> of its override methods that take arguments such as Opcode and the array size
> for multianewarray and the switches, which would write something before
> throwin
#26200
>
> The commit being backported was authored by Chen Liang on 9 Jul 2025 and was
> reviewed by Adam Sotona. This is doc and test only, so eligible for RDP
> backports.
>
> Thanks!
Marked as reviewed by asotona (Reviewer).
-
PR Review: https://git.openjdk.org
On Tue, 8 Jul 2025 20:28:23 GMT, Chen Liang wrote:
>> In the `class` file format, a lot of the values are `u1` or `u2`; the
>> Class-File API consistently model them with `int`. However, the API does
>> not, in general, validate that int values passed to the factory methods are
>> not out of t
On Tue, 8 Jul 2025 18:46:00 GMT, Chen Liang wrote:
> In a recent inspection of all methods that accept an `int` argument in the
> Class-File API, I noticed this method that validates its argument but did not
> document the validation. The behavior is to throw IOOBE. We can simply
> document th
On Mon, 7 Jul 2025 23:21:58 GMT, Chen Liang wrote:
> The class file API verifier seems to be based off a version of hotspot
> verifier before Mar 3 2021. We are thus missing a few patches in the hotspot
> verifier:
> [JDK-8350029](https://bugs.openjdk.org/browse/JDK-8350029)
> [JDK-8340110](ht
On Wed, 28 May 2025 17:56:07 GMT, Adam Sotona wrote:
> java.lang.classfile.Signature.ArrayTypeSig.of constraint check did not
> include dimensions of the given component if the component is an array.
>
> This patch fixes the constraint check, corrects the @throws description and
On Wed, 28 May 2025 17:56:07 GMT, Adam Sotona wrote:
> java.lang.classfile.Signature.ArrayTypeSig.of constraint check did not
> include dimensions of the given component if the component is an array.
>
> This patch fixes the constraint check, corrects the @throws description and
On Mon, 28 Apr 2025 20:50:58 GMT, Chen Liang wrote:
> Some dynamic constant pool entries with heavy symbolic descriptors currently
> don't share them, yet they are used by stack map generation, and computing a
> new descriptor every time introduces a heavy cost.
>
> This cost is obvious if byt
On Mon, 28 Apr 2025 01:43:32 GMT, Chen Liang wrote:
> Transforms can run on a stream of class file elements. Currently, that stream
> can only be from a CompoundElement. We can allow a ClassFileBuilder to
> provide such a stream too; a recent request
> https://mail.openjdk.org/pipermail/classf
On Sun, 27 Apr 2025 03:38:35 GMT, Chen Liang wrote:
>> Internal explicit counter support for Code max_stack and max_locals has been
>> already added in #24807. Since that example works well, we may consider
>> opening this functionality up to general users under strict restrictions.
>>
>> This
On Fri, 25 Apr 2025 16:36:53 GMT, Chen Liang wrote:
>> The ClassFile API promotes usage of constant nominal descriptors over
>> literal strings. However, for `class` file parsing, currently the efficient
>> way to check if a constant pool entry matches a desired descriptor is via
>> unrolling
On Tue, 22 Apr 2025 23:55:54 GMT, Chen Liang wrote:
> In the future value objects JEP, class files must have one of ACC_IDENTITY
> (now ACC_SUPER), ACC_ABSTRACT, and ACC_FINAL bits set, otherwise they are
> rejected. The current default flag has none of these bits set, meaning that
> it will n
On Wed, 23 Apr 2025 00:21:05 GMT, Chen Liang wrote:
>> The ClassFile API promotes usage of constant nominal descriptors over
>> literal strings. However, for `class` file parsing, currently the efficient
>> way to check if a constant pool entry matches a desired descriptor is via
>> unrolling
On Tue, 22 Apr 2025 23:55:54 GMT, Chen Liang wrote:
> In the future value objects JEP, class files must have one of ACC_IDENTITY
> (now ACC_SUPER), ACC_ABSTRACT, and ACC_FINAL bits set, otherwise they are
> rejected. The current default flag has none of these bits set, meaning that
> it will n
On Tue, 22 Apr 2025 23:28:38 GMT, Chen Liang wrote:
> A few pattern matching switches exist in the core parts of ClassFile API
> responsible for transformations and parsing. They are likely to be used in
> early bootstrap, and pattern matching switches require bootstrap methods,
> which depend
On Tue, 22 Apr 2025 17:20:15 GMT, Chen Liang wrote:
>> The downcallHandle method in Linker has a complex implementation, and type
>> switches is triggered in multiple places in that handle.
>>
>> After bytestacks analysis of a simple program that links the native
>> implementation of Class::fo
On Thu, 17 Apr 2025 00:08:55 GMT, Chen Liang wrote:
> The downcallHandle method in Linker has a complex implementation, and type
> switches is triggered in multiple places in that handle.
>
> After bytestacks analysis of a simple program that links the native
> implementation of Class::forName
On Fri, 7 Feb 2025 19:25:04 GMT, Chen Liang wrote:
> Make UnknownAttribute and CustomAttribute delivered in code traversal, and
> make sure stack maps update the label references after a code transform when
> it is reused. Other code-bound attributes are not updated as they cannot be
> supplie
On Thu, 27 Mar 2025 17:38:49 GMT, David M. Lloyd wrote:
>> Provide method overloads to the ClassFile interface of the
>> java.lang.classfile API which allow parsing of classes found in memory
>> segments, as well as allowing built class files to be output to them.
>
> David M. Lloyd has updated
On Thu, 27 Mar 2025 17:38:49 GMT, David M. Lloyd wrote:
>> Provide method overloads to the ClassFile interface of the
>> java.lang.classfile API which allow parsing of classes found in memory
>> segments, as well as allowing built class files to be output to them.
>
> David M. Lloyd has updated
On Thu, 27 Mar 2025 15:19:37 GMT, David M. Lloyd wrote:
>> Provide method overloads to the ClassFile interface of the
>> java.lang.classfile API which allow parsing of classes found in memory
>> segments, as well as allowing built class files to be output to them.
>
> David M. Lloyd has updated
On Tue, 25 Mar 2025 15:27:05 GMT, David M. Lloyd wrote:
>> Provide method overloads to the ClassFile interface of the
>> java.lang.classfile API which allow parsing of classes found in memory
>> segments, as well as allowing built class files to be output to them.
>
> David M. Lloyd has updated
On Tue, 25 Mar 2025 15:27:05 GMT, David M. Lloyd wrote:
>> Provide method overloads to the ClassFile interface of the
>> java.lang.classfile API which allow parsing of classes found in memory
>> segments, as well as allowing built class files to be output to them.
>
> David M. Lloyd has updated
On Mon, 24 Feb 2025 08:09:00 GMT, Adam Sotona wrote:
> j.l.classfile package-summary contains many code snippets.
> Some of the shorter snippets are embedded in the javadoc and therefore are
> not validated by the tests.
> One embedded code snippet contains a typo, and two sni
On Mon, 24 Feb 2025 08:09:00 GMT, Adam Sotona wrote:
> j.l.classfile package-summary contains many code snippets.
> Some of the shorter snippets are embedded in the javadoc and therefore are
> not validated by the tests.
> One embedded code snippet contains a typo, and two sni
j.l.classfile package-summary contains many code snippets.
Some of the shorter snippets are embedded in the javadoc and therefore are not
validated by the tests.
One embedded code snippet contains a typo, and two snippets do not reflect the
actual API method name.
This patch fixes the code snipp
On Tue, 11 Feb 2025 16:36:24 GMT, Chen Liang wrote:
>> src/java.base/share/classes/java/lang/classfile/constantpool/Utf8Entry.java
>> line 95:
>>
>>> 93: * @since 25
>>> 94: */
>>> 95: boolean equalsSymbol(ClassDesc desc);
>>
>> Ambiguity of class internal name vs. descriptor ser
On Tue, 11 Feb 2025 02:26:57 GMT, Chen Liang wrote:
> The ClassFile API promotes usage of constant nominal descriptors over literal
> strings. However, for `class` file parsing, currently the efficient way to
> check if a constant pool entry matches a desired descriptor is via unrolling
> them
On Fri, 7 Feb 2025 19:40:44 GMT, Chen Liang wrote:
> In CodeBuilder, validation for a slot was missing due to concurrent patches,
> and the original patch did not add effective tests for CodeBuilder because of
> the complex exceptional behaviors. Now the bug is fixed with renames to
> prevent
On Mon, 27 Jan 2025 15:16:12 GMT, Chen Liang wrote:
> Please review a non-clean backport of #23277, the final patch in the
> improvements to the Class-File API. The backport is non-clean because a new
> JAVA_25_VERSION constant was added in 25; otherwise the patch applied cleanly.
>
> Tests: N
On Fri, 24 Jan 2025 22:42:27 GMT, Chen Liang wrote:
>> This is the last piece in the API documentation improvement of the
>> Class-File API.
>>
>> This includes general documentation about transforms, models (and
>> traversals), options, constants, and CodeBuilder factories. In particular,
>
On Thu, 23 Jan 2025 19:48:55 GMT, Chen Liang wrote:
> This is the last piece in the API documentation improvement of the Class-File
> API.
>
> This includes general documentation about transforms, models (and
> traversals), options, constants, and CodeBuilder factories. In particular,
> this
On Thu, 23 Jan 2025 16:55:20 GMT, Chen Liang wrote:
> This is a non-clean backport the java.lang.classfile.attribute documentation
> improvements 973c630777d4075bc85c7ddc1eb02cc65904344d to JDK 24 , the release
> where the API is finalized. Also backported a tier1 docs build hotfix
> 28e01e655
On Thu, 23 Jan 2025 07:14:42 GMT, Adam Sotona wrote:
> JDK-8345486 moved
> java.lang.classfile.components.snippet-files.PackageSnippets to
> jdk.internal.classfile.components.snippet-files folder. However change of the
> package name declared in the snippet file was omitted.
On Thu, 23 Jan 2025 07:14:42 GMT, Adam Sotona wrote:
> JDK-8345486 moved
> java.lang.classfile.components.snippet-files.PackageSnippets to
> jdk.internal.classfile.components.snippet-files folder. However change of the
> package name declared in the snippet file was omitted.
JDK-8345486 moved java.lang.classfile.components.snippet-files.PackageSnippets
to jdk.internal.classfile.components.snippet-files folder. However change of
the package name declared in the snippet file was omitted.
Please review.
Thank you,
Adam
-
Commit messages:
- 8348283: jav
On Mon, 13 Jan 2025 08:14:08 GMT, Adam Sotona wrote:
>> There are no more consumers of ASM library except for hotspot tests.
>> This patch moves ASM library from java.base module to the hotspot test
>> libraries location and fixes the tests.
>>
>> Please review.
&
On Tue, 7 Jan 2025 12:49:40 GMT, Adam Sotona wrote:
> There are no more consumers of ASM library except for hotspot tests.
> This patch moves ASM library from java.base module to the hotspot test
> libraries location and fixes the tests.
>
> Please review.
>
> Than
On Mon, 13 Jan 2025 08:14:08 GMT, Adam Sotona wrote:
>> There are no more consumers of ASM library except for hotspot tests.
>> This patch moves ASM library from java.base module to the hotspot test
>> libraries location and fixes the tests.
>>
>> Please review.
&
On Fri, 10 Jan 2025 20:50:20 GMT, Chen Liang wrote:
> This is a non-clean backport of bcefab5e55d4527a38dcab550581a734c1564608,
> because afe543414f58a04832d4f07dea1d64954a0b which fixes a Javadoc link
> error was also included in this backport. This backports Javadoc
> improvements to th
On Mon, 13 Jan 2025 07:40:06 GMT, Adam Sotona wrote:
>> There are no more consumers of ASM library except for hotspot tests.
>> This patch moves ASM library from java.base module to the hotspot test
>> libraries location and fixes the tests.
>>
>> Please review.
&
> There are no more consumers of ASM library except for hotspot tests.
> This patch moves ASM library from java.base module to the hotspot test
> libraries location and fixes the tests.
>
> Please review.
>
> Thanks,
> Adam
Adam Sotona has updated the pull reques
On Mon, 13 Jan 2025 07:40:06 GMT, Adam Sotona wrote:
>> There are no more consumers of ASM library except for hotspot tests.
>> This patch moves ASM library from java.base module to the hotspot test
>> libraries location and fixes the tests.
>>
>> Please review.
&
> There are no more consumers of ASM library except for hotspot tests.
> This patch moves ASM library from java.base module to the hotspot test
> libraries location and fixes the tests.
>
> Please review.
>
> Thanks,
> Adam
Adam Sotona has updated the pull reques
On Fri, 10 Jan 2025 20:25:06 GMT, Chen Liang wrote:
>> Improve documentation for `class` file attributes. This include better
>> specification for user attributes, some more general information about
>> attributes, such as the usage of non-JVMS attributes, and updated some
>> attribute informa
On Fri, 10 Jan 2025 07:32:24 GMT, Chen Liang wrote:
> Improve documentation for `class` file attributes. This include better
> specification for user attributes, some more general information about
> attributes, such as the usage of non-JVMS attributes, and updated some
> attribute information
> There are no more consumers of ASM library except for hotspot tests.
> This patch moves ASM library from java.base module to the hotspot test
> libraries location and fixes the tests.
>
> Please review.
>
> Thanks,
> Adam
Adam Sotona has updated the pull reques
> There are no more consumers of ASM library except for hotspot tests.
> This patch moves ASM library from java.base module to the hotspot test
> libraries location and fixes the tests.
>
> Please review.
>
> Thanks,
> Adam
Adam Sotona has updated the pull reques
> There are no more consumers of ASM library except for hotspot tests.
> This patch moves ASM library from java.base module to the hotspot test
> libraries location and fixes the tests.
>
> Please review.
>
> Thanks,
> Adam
Adam Sotona has updated the pull reques
On Thu, 9 Jan 2025 08:40:37 GMT, Adam Sotona wrote:
>> There are no more consumers of ASM library except for hotspot tests.
>> This patch moves ASM library from java.base module to the hotspot test
>> libraries location and fixes the tests.
>>
>> Please review.
&
> There are no more consumers of ASM library except for hotspot tests.
> This patch moves ASM library from java.base module to the hotspot test
> libraries location and fixes the tests.
>
> Please review.
>
> Thanks,
> Adam
Adam Sotona has updated the pull reques
On Wed, 8 Jan 2025 07:21:36 GMT, Adam Sotona wrote:
>> There are no more consumers of ASM library except for hotspot tests.
>> This patch moves ASM library from java.base module to the hotspot test
>> libraries location and fixes the tests.
>>
>> Please review.
&
> There are no more consumers of ASM library except for hotspot tests.
> This patch moves ASM library from java.base module to the hotspot test
> libraries location and fixes the tests.
>
> Please review.
>
> Thanks,
> Adam
Adam Sotona has updated the pull reques
On Wed, 8 Jan 2025 06:57:04 GMT, Alan Bateman wrote:
>
> you can revert the changes that we have in the jdk repo so it goes back to
> .org.objectweb.asm
that represents a refactoring with >1200 changes in >250 files across multiple
repositories
-
PR Comment: https://git.openjdk.
On Wed, 8 Jan 2025 01:45:48 GMT, Leonid Mesnik wrote:
>> There are no more consumers of ASM library except for hotspot tests.
>> This patch moves ASM library from java.base module to the hotspot test
>> libraries location and fixes the tests.
>>
>> Please review.
>>
>> Thanks,
>> Adam
>
> I th
On Tue, 7 Jan 2025 12:49:40 GMT, Adam Sotona wrote:
> There are no more consumers of ASM library except for hotspot tests.
> This patch moves ASM library from java.base module to the hotspot test
> libraries location and fixes the tests.
>
> Please review.
>
> Thanks,
&g
There are no more consumers of ASM library except for hotspot tests.
This patch moves ASM library from java.base module to the hotspot test
libraries location and fixes the tests.
Please review.
Thanks,
Adam
-
Commit messages:
- fixed TestMHUnloaded
- patching hotspot tests
- re
On Mon, 6 Jan 2025 21:41:17 GMT, Chen Liang wrote:
>> Improve documentation for constant pool entries. This include some models
>> for those entries, symbolic descriptors, and some general guidance in
>> package summary.
>>
>> APIDiff: https://cr.openjdk.org/~liach/apidiff/cf-consts/
>> Javad
On Fri, 3 Jan 2025 12:46:27 GMT, Adam Sotona wrote:
> ASM-based benchmarks were useful to directly compare performance of ASM and
> Class-File API.
> However Class-File API performance history is now continuously tracked and
> direct comparison to ASM becomes obsolete.
>
>
On Mon, 6 Jan 2025 08:51:49 GMT, Adam Sotona wrote:
>> ASM-based benchmarks were useful to directly compare performance of ASM and
>> Class-File API.
>> However Class-File API performance history is now continuously tracked and
>> direct comparison to ASM becomes obs
On Mon, 6 Jan 2025 08:56:09 GMT, Adam Sotona wrote:
>> This patch removes obsolete ASM-based transformations from Class-File API
>> tests.
>>
>> Please review.
>>
>> Thanks,
>> Adam
>
> Adam Sotona has updated the pull request incrementa
On Fri, 3 Jan 2025 12:19:54 GMT, Adam Sotona wrote:
> This patch removes obsolete ASM-based transformations from Class-File API
> tests.
>
> Please review.
>
> Thanks,
> Adam
This pull request has now been integrated.
Changeset: c027f2ed
Author:Adam Soto
On Fri, 3 Jan 2025 12:06:05 GMT, Adam Sotona wrote:
> This PR removes obsolete java.base exports of jdk.internal.objectweb.asm
> packages to jdk.jfr module.
>
> Please review.
>
> Thanks,
> Adam
This pull request has now been integrated.
Changeset: e0695e0e
Author
On Mon, 6 Jan 2025 08:45:48 GMT, Adam Sotona wrote:
>> This PR removes obsolete java.base exports of jdk.internal.objectweb.asm
>> packages to jdk.jfr module.
>>
>> Please review.
>>
>> Thanks,
>> Adam
>
> Adam Sotona has updated the pull req
> This patch removes obsolete ASM-based transformations from Class-File API
> tests.
>
> Please review.
>
> Thanks,
> Adam
Adam Sotona has updated the pull request incrementally with one additional
commit since the last revision:
updated copyright year
--
est/micro/org/openjdk/bench/jdk/classfile.
>
> Please review.
>
> Thanks,
> Adam
Adam Sotona has updated the pull request incrementally with one additional
commit since the last revision:
updated copyright years
-
Changes:
- all: https://git.openjdk.org
> This PR removes obsolete java.base exports of jdk.internal.objectweb.asm
> packages to jdk.jfr module.
>
> Please review.
>
> Thanks,
> Adam
Adam Sotona has updated the pull request incrementally with one additional
commit since the last revision:
u
ASM-based benchmarks were useful to directly compare performance of ASM and
Class-File API.
However Class-File API performance history is now continuously tracked and
direct comparison to ASM becomes obsolete.
This patch removes ASM-based benchmarks from
test/micro/org/openjdk/bench/jdk/classfi
This patch removes obsolete ASM-based transformations from Class-File API tests.
Please review.
Thanks,
Adam
-
Commit messages:
- 8346983: Remove ASM-based transforms from Class-File API tests
Changes: https://git.openjdk.org/jdk/pull/22913/files
Webrev: https://webrevs.openjdk.
This PR removes obsolete java.base exports of jdk.internal.objectweb.asm
packages to jdk.jfr module.
Please review.
Thanks,
Adam
-
Commit messages:
- 8346981: Remove obsolete java.base exports of jdk.internal.objectweb.asm
packages
Changes: https://git.openjdk.org/jdk/pull/22912
On Thu, 12 Dec 2024 00:20:13 GMT, Chen Liang wrote:
>> Improve documentation for constant pool entries. This include some models
>> for those entries, symbolic descriptors, and some general guidance in
>> package summary.
>>
>> APIDiff: https://cr.openjdk.org/~liach/apidiff/cf-consts/
>> Java
On Wed, 11 Dec 2024 08:06:19 GMT, Adam Sotona wrote:
> Class-File API lost debug printing capability with removal of the
> j.l.classfile.components.ClassPrinter in JDK-8345343.
>
> This is a backport of
> https://github.com/openjdk/jdk/commit/f88c1c6ff86b8f29a71647e46
On Wed, 11 Dec 2024 08:06:19 GMT, Adam Sotona wrote:
> Class-File API lost debug printing capability with removal of the
> j.l.classfile.components.ClassPrinter in JDK-8345343.
>
> This is a backport of
> https://github.com/openjdk/jdk/commit/f88c1c6ff86b8f29a71647e46
On Fri, 22 Nov 2024 13:42:32 GMT, Jan Lahoda wrote:
> There is a new preview language feature, `requires transitive java.base;`.
> And the `java.se` module is permitted to use the feature, without being
> marked as preview (i.e. the `java.se` module participates in preview). This
> is currentl
> This is a noreg-doc backport - these additions are clarifications to the
> ClassFile API's java.lang.classfile.instruction package, and are permissible
> in RDP1 and RDP2.
>
> The commit being backported was authored by Chen Liang on 10 Dec 2024 and was
> reviewed
8345773: Class-File API debug printing capability
-
Commit messages:
- Backport f88c1c6ff86b8f29a71647e46136b6432bb67619
Changes: https://git.openjdk.org/jdk/pull/22675/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=22675&range=00
Issue: https://bugs.openjdk.org/browse/J
On Mon, 9 Dec 2024 10:25:01 GMT, Adam Sotona wrote:
> Class-File API lost debug printing capability with removal of the
> `j.l.classfile.components.ClassPrinter` in JDK-8345343.
> This PR adds `j.l.classfile.CompoundElement::toDebugString` method to restore
> the capability.
>
On Mon, 9 Dec 2024 18:09:21 GMT, Adam Sotona wrote:
>> Class-File API lost debug printing capability with removal of the
>> `j.l.classfile.components.ClassPrinter` in JDK-8345343.
>> This PR adds `j.l.classfile.CompoundElement::toDebugString` method to
>> restore the c
On Wed, 4 Dec 2024 18:41:53 GMT, Chen Liang wrote:
>> Improve the documentation for classfile instructions. Includes links to all
>> opcodes, usage notes for instructions, and other various fixes.
>>
>> API Diff:
>> https://cr.openjdk.org/~liach/apidiff/cf-instr/java.base/module-summary.html
>
> Class-File API lost debug printing capability with removal of the
> `j.l.classfile.components.ClassPrinter` in JDK-8345343.
> This PR adds `j.l.classfile.CompoundElement::toDebugString` method to restore
> the capability.
>
> Please review.
>
> Thank you,
> Adam
> Class-File API lost debug printing capability with removal of the
> `j.l.classfile.components.ClassPrinter` in JDK-8345343.
> This PR adds `j.l.classfile.CompoundElement::toDebugString` method to restore
> the capability.
>
> Please review.
>
> Thank you,
> Adam
> Class-File API lost debug printing capability with removal of the
> `j.l.classfile.components.ClassPrinter` in JDK-8345343.
> This PR adds `j.l.classfile.CompoundElement::toDebugString` method to restore
> the capability.
>
> Please review.
>
> Thank you,
> Adam
Class-File API lost debug printing capability with removal of the
`j.l.classfile.components.ClassPrinter` in JDK-8345343.
This PR adds `j.l.classfile.CompoundElement::toDebugString` method to restore
the capability.
Please review.
Thank you,
Adam
-
Commit messages:
- unused impor
On Thu, 5 Dec 2024 20:44:59 GMT, Chen Liang wrote:
>> Remove the redundant `@enablePreview` and `--enable-preview` flags for
>> enabling ClassFile API in the tests. The remainder of these flags in all
>> tests seem to serve preview APIs (such as ScopedValue) or language features
>> (primitive
On Wed, 4 Dec 2024 14:23:07 GMT, Chen Liang wrote:
> Over the years there have been significant rounds of cleanup to try and keep
> the classfile API as focussed and true to its underlying functional core as
> possible. One of the side-effects of such cleanups was to move higher-level
> functi
On Mon, 2 Dec 2024 18:06:53 GMT, Chen Liang wrote:
>> Change the return type of PoolEntry and AnnotationValue tags to int, as in
>> TypeAnnotation TargetType and StackMapFrameInfo frameType. The main impact
>> is that AnnotationValue tags should be converted to char before printing now.
>>
>>
On Mon, 2 Dec 2024 23:55:00 GMT, Chen Liang wrote:
> The java.lang.classfile.components package was underused and had almost no
> usage feedback; as a result, it did not caught attention during the preview
> process of the Class-File API, until the late adoption when Class-File API is
> sure t
On Mon, 2 Dec 2024 23:55:00 GMT, Chen Liang wrote:
> The java.lang.classfile.components package was underused and had almost no
> usage feedback; as a result, it did not caught attention during the preview
> process of the Class-File API, until the late adoption when Class-File API is
> sure t
On Wed, 27 Nov 2024 23:10:15 GMT, Chen Liang wrote:
> Remove the redundant `@enablePreview` and `--enable-preview` flags for
> enabling ClassFile API in the tests. The remainder of these flags in all
> tests seem to serve preview APIs (such as ScopedValue) or language features
> (primitive pa
On Mon, 25 Nov 2024 07:35:58 GMT, Adam Sotona wrote:
>> ClassPrinter prints `null` values as `String` "null" or as
>> `String.valueOf(ConstantDescs.BSM_NULL_CONSTANT)`, based on context.
>>
>> This patch unifies handling of `null` values.
>>
On Fri, 22 Nov 2024 10:24:12 GMT, Adam Sotona wrote:
> ClassPrinter prints `null` values as `String` "null" or as
> `String.valueOf(ConstantDescs.BSM_NULL_CONSTANT)`, based on context.
>
> This patch unifies handling of `null` values.
> They are now e
son and Yaml format is `null` value printed unquoted and in Xml as
> ``.
> In Json and Yaml is `"null"` `String` printed quoted to distinguish from the
> `null` value.
>
> Please review.
>
> Thank you,
> Adam
Adam Sotona has updated the pull request inc
ClassPrinter prints `null` values as `String` "null" or as
`String.valueOf(ConstantDescs.BSM_NULL_CONSTANT)`, based on context.
This patch unifies handling of `null` values.
They are now exclusively represented as `ConstantDescs.BSM_NULL_CONSTANT`.
In Json and Yaml format is `null` value printed
On Wed, 20 Nov 2024 23:03:43 GMT, Chen Liang wrote:
>> Improve the documentation for classfile instructions. Includes links to all
>> opcodes, usage notes for instructions, and other various fixes.
>>
>> API Diff:
>> https://cr.openjdk.org/~liach/apidiff/cf-instr/java.base/module-summary.html
On Wed, 20 Nov 2024 23:03:43 GMT, Chen Liang wrote:
>> Improve the documentation for classfile instructions. Includes links to all
>> opcodes, usage notes for instructions, and other various fixes.
>>
>> API Diff:
>> https://cr.openjdk.org/~liach/apidiff/cf-instr/java.base/module-summary.html
1 - 100 of 1154 matches
Mail list logo
