Re: RFR: 8361842: Move input validation checks to Java for java.lang.StringCoding intrinsics [v8]

2025-07-18 Thread John R Rose
On Fri, 18 Jul 2025 23:18:16 GMT, John R Rose wrote: > If (as in this case) IC2 loops over calls to IC1 Correction; I meant IC1 calls IC2, in a loop, N times. We don't want a pre-loop in M1 that checks each of N distinct arguments to IC2 (like N calls to M2 would), but rather a batch check rou

Re: RFR: 8355223: Improve documentation on @IntrinsicCandidate [v7]

2025-07-18 Thread Chen Liang
On Wed, 21 May 2025 21:31:16 GMT, Chen Liang wrote: >> In offline discussion, we noted that the documentation on this annotation >> does not recommend minimizing the intrinsified section and moving whatever >> can be done in Java to Java; thus I prepared this documentation update, to >> shrink

Withdrawn: 8355223: Improve documentation on @IntrinsicCandidate

2025-07-18 Thread duke
On Mon, 21 Apr 2025 19:29:44 GMT, Chen Liang wrote: > In offline discussion, we noted that the documentation on this annotation > does not recommend minimizing the intrinsified section and moving whatever > can be done in Java to Java; thus I prepared this documentation update, to > shrink a "

Re: RFR: 8361842: Move input validation checks to Java for java.lang.StringCoding intrinsics [v8]

2025-07-18 Thread John R Rose
On Thu, 17 Jul 2025 15:33:37 GMT, Raffaello Giulietti wrote: > What is the thinking when an `@IntrinsicCandidate` method invokes another > `@IntrinsicCandidate` method? Which part is responsible for the checks? This is a good question. Suppose IC1 calls IC2 and both are intrinsic candidates,

Integrated: 8345836: Stable annotation documentation is incomplete

2025-07-18 Thread Ioi Lam
On Wed, 16 Jul 2025 17:45:23 GMT, Ioi Lam wrote: > Please review this documentation update, authored by @rose00 and originally > pushed to the Leyden repo in [this > PR](https://github.com/openjdk/leyden/pull/26), where more comments can be > found regarding this update. This pull request has

Re: RFR: 8345836: Stable annotation documentation is incomplete

2025-07-18 Thread Ioi Lam
On Thu, 17 Jul 2025 17:07:48 GMT, Chen Liang wrote: >> Please review this documentation update, authored by @rose00 and originally >> pushed to the Leyden repo in [this >> PR](https://github.com/openjdk/leyden/pull/26), where more comments can be >> found regarding this update. > > Marked as r

Re: RFR: 8362448: Make use of the Double.toString(double) algorithm in java.text.DecimalFormat [v5]

2025-07-18 Thread Naoto Sato
On Fri, 18 Jul 2025 21:12:41 GMT, Raffaello Giulietti wrote: >> Align the behavior of `DecimalFormat` on `double`s with that of `Formatter`. > > Raffaello Giulietti has updated the pull request incrementally with one > additional commit since the last revision: > > Refactoring to paramateriz

Re: RFR: 8362448: Make use of the Double.toString(double) algorithm in java.text.DecimalFormat [v5]

2025-07-18 Thread Raffaello Giulietti
> Align the behavior of `DecimalFormat` on `double`s with that of `Formatter`. Raffaello Giulietti has updated the pull request incrementally with one additional commit since the last revision: Refactoring to paramaterized tests. - Changes: - all: https://git.openjdk.org/jdk/pu

Re: RFR: 8315131: Clarify VarHandle set/get access on 32-bit platforms [v3]

2025-07-18 Thread Raffaello Giulietti
On Thu, 17 Jul 2025 23:15:44 GMT, John R Rose wrote: >> Yep, to distinguish access and the encapsulated read-modify-write atomicity, >> I decided to avoid using "atomic"/"non-atomic" altogether - now it is just >> "make no atomicity guarantee" > > Not sure this is relevant, but isn't "opaque" a

Integrated: 8351073: [macos] jpackage produces invalid Java runtime DMG bundles

2025-07-18 Thread Alexander Matveev
On Mon, 7 Jul 2025 22:19:12 GMT, Alexander Matveev wrote: > Re-submission of https://github.com/openjdk/jdk/pull/25314 after merge > conflict was resolved. Old PR will be closed. > > All comments are addressed from old PR. Merge conflict was significant, so it > is like new fix. > > Fixed jpa

Re: RFR: 8362448: Make use of the Double.toString(double) algorithm in java.text.DecimalFormat [v4]

2025-07-18 Thread Naoto Sato
On Fri, 18 Jul 2025 19:58:30 GMT, Raffaello Giulietti wrote: >> Align the behavior of `DecimalFormat` on `double`s with that of `Formatter`. > > Raffaello Giulietti has updated the pull request incrementally with one > additional commit since the last revision: > > Removed temporary comment

Re: RFR: 8351073: [macos] jpackage produces invalid Java runtime DMG bundles [v10]

2025-07-18 Thread Alexey Semenyuk
On Fri, 18 Jul 2025 20:04:57 GMT, Alexander Matveev wrote: >> Re-submission of https://github.com/openjdk/jdk/pull/25314 after merge >> conflict was resolved. Old PR will be closed. >> >> All comments are addressed from old PR. Merge conflict was significant, so >> it is like new fix. >> >>

Re: RFR: 8351073: [macos] jpackage produces invalid Java runtime DMG bundles [v10]

2025-07-18 Thread Alexander Matveev
> Re-submission of https://github.com/openjdk/jdk/pull/25314 after merge > conflict was resolved. Old PR will be closed. > > All comments are addressed from old PR. Merge conflict was significant, so it > is like new fix. > > Fixed jpackage to produce valid Java runtimes based on description be

Re: RFR: 8351073: [macos] jpackage produces invalid Java runtime DMG bundles [v9]

2025-07-18 Thread Alexander Matveev
On Fri, 18 Jul 2025 02:47:04 GMT, Alexander Matveev wrote: >> Re-submission of https://github.com/openjdk/jdk/pull/25314 after merge >> conflict was resolved. Old PR will be closed. >> >> All comments are addressed from old PR. Merge conflict was significant, so >> it is like new fix. >> >>

Re: RFR: 8362376: Use @Stable annotation in Java FDLIBM implementation [v3]

2025-07-18 Thread Raffaello Giulietti
On Thu, 17 Jul 2025 21:40:13 GMT, Joe Darcy wrote: >> Add `@Stable` to the static final arrays used in the Java port of FDLIBM. > > Joe Darcy has updated the pull request incrementally with one additional > commit since the last revision: > > Implement review feedback. Since the refactoring

Re: RFR: 8362448: Make use of the Double.toString(double) algorithm in java.text.DecimalFormat [v4]

2025-07-18 Thread Raffaello Giulietti
> Align the behavior of `DecimalFormat` on `double`s with that of `Formatter`. Raffaello Giulietti has updated the pull request incrementally with one additional commit since the last revision: Removed temporary comment from tests. - Changes: - all: https://git.openjdk.org/jdk/

Re: RFR: 8362448: Make use of the Double.toString(double) algorithm in java.text.DecimalFormat [v3]

2025-07-18 Thread Raffaello Giulietti
> Align the behavior of `DecimalFormat` on `double`s with that of `Formatter`. Raffaello Giulietti has updated the pull request incrementally with one additional commit since the last revision: Added tests. - Changes: - all: https://git.openjdk.org/jdk/pull/26364/files - new:

Re: RFR: 8357728: Optimize Executable#synthesizeAllParams

2025-07-18 Thread Chen Liang
On Tue, 24 Jun 2025 22:32:30 GMT, Chen Liang wrote: > Currently, fake parameters are created with "arg0" etc. strings that are > retained for class file methods with no MethodParameters attribute. The > original issue report observes many of these strings present in the heap. To > address this

FFM - Optimizing string reads in MemorySegment

2025-07-18 Thread Liam Miller-Cushon
Hi, I have a question about the performance of string reads in MemorySegment. There was some discussion about reading strings with known lengths in JDK-8333843, and the outcome was to update the getString javadoc to recommend: byte[] bytes = new byte[length]; MemorySegment.copy(segment, JAVA_BYT

Re: RFR: 8360037: Refactor ImageReader in preparation for Valhalla support [v12]

2025-07-18 Thread Roger Riggs
On Wed, 16 Jul 2025 15:31:07 GMT, David Beaumont wrote: >> Refactoring `ImageReader` to make it easy to add preview mode functionality >> for Valhalla. >> >> This PR is a large change to `ImageReader` (effectively a rewrite) but >> reduces the surface area of the API significantly, reduces cod

Re: RFR: 8361587: AssertionError in File.listFiles() when path is empty and -esa is enabled [v8]

2025-07-18 Thread Brian Burkhalter
On Wed, 16 Jul 2025 13:30:08 GMT, Alan Bateman wrote: > Hello Brian, I'm late to this discussion. I think there are a couple of more > places in this code which need attention. Thanks for catching this, @jaikiran. As you no doubt already observed, this has been fixed by #26353 in the mainline

Integrated: 8357380: java/lang/StringBuilder/RacingSBThreads.java times out with C1

2025-07-18 Thread Roger Riggs
On Fri, 18 Jul 2025 15:06:33 GMT, Roger Riggs wrote: > Reduced number of iterations from 10 million to 1 million to reduce cpu time This pull request has now been integrated. Changeset: 30d20036 Author:Roger Riggs URL: https://git.openjdk.org/jdk/commit/30d20036987c9d68eb76b1e040182

Re: RFR: 8357728: Optimize Executable#synthesizeAllParams

2025-07-18 Thread Joe Darcy
On Tue, 24 Jun 2025 22:32:30 GMT, Chen Liang wrote: > Currently, fake parameters are created with "arg0" etc. strings that are > retained for class file methods with no MethodParameters attribute. The > original issue report observes many of these strings present in the heap. To > address this

Re: RFR: 8362376: Use @Stable annotation in Java FDLIBM implementation [v3]

2025-07-18 Thread Joe Darcy
On Fri, 18 Jul 2025 13:40:15 GMT, Chen Liang wrote: > This array unrolling looks right to me. I'll write a regression test case to make sure. - PR Comment: https://git.openjdk.org/jdk/pull/26341#issuecomment-3090070661

Re: RFR: 8357380: java/lang/StringBuilder/RacingSBThreads.java times out with C1

2025-07-18 Thread Jaikiran Pai
On Fri, 18 Jul 2025 15:06:33 GMT, Roger Riggs wrote: > Reduced number of iterations from 10 million to 1 million to reduce cpu time Looks good and trivial to me. - Marked as reviewed by jpai (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/26389#pullrequestreview-3033958779

RFR: 8357380: java/lang/StringBuilder/RacingSBThreads.java times out with C1

2025-07-18 Thread Roger Riggs
Reduced number of iterations from 10 million to 1 million to reduce cpu time - Commit messages: - 8357380: java/lang/StringBuilder/RacingSBThreads.java times out with C1 Changes: https://git.openjdk.org/jdk/pull/26389/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=26389&ra

Integrated: 8362169: Pointer passed to upcall may get wrong scope

2025-07-18 Thread Jorn Vernee
On Mon, 14 Jul 2025 15:33:35 GMT, Jorn Vernee wrote: > Issue copied from the JBS issue: > > When an upcall stub accepts a by-value struct, and the struct is passed by > the underlying ABI as a pointer to a temporary copy on the caller's stack > (for instance on Windows when the struct doesn't

Withdrawn: 8357823: Changes in StringBuilder (JDK-8351443) caused a 1-3% regression in biojava

2025-07-18 Thread Roger Riggs
On Fri, 30 May 2025 14:01:04 GMT, Roger Riggs wrote: > Comment out assertions added in JDK-8351443 from > AbstractStringBuilder.ensureCapacityNewCoder that increase the codesize, > preventing some inlining, and reducing performance > >assert coder == newCoder || newCoder == UTF16 : "ba

Re: RFR: 8357823: Changes in StringBuilder (JDK-8351443) caused a 1-3% regression in biojava [v2]

2025-07-18 Thread Roger Riggs
On Wed, 11 Jun 2025 11:35:09 GMT, Roger Riggs wrote: >> Comment out assertions added in JDK-8351443 from >> AbstractStringBuilder.ensureCapacityNewCoder that increase the codesize, >> preventing some inlining, and reducing performance >> >>assert coder == newCoder || newCoder == UTF16

Re: RFR: 8362376: Use @Stable annotation in Java FDLIBM implementation [v3]

2025-07-18 Thread Chen Liang
On Thu, 17 Jul 2025 21:40:13 GMT, Joe Darcy wrote: >> Add `@Stable` to the static final arrays used in the Java port of FDLIBM. > > Joe Darcy has updated the pull request incrementally with one additional > commit since the last revision: > > Implement review feedback. This array unrolling l

Re: RFR: 8351073: [macos] jpackage produces invalid Java runtime DMG bundles [v9]

2025-07-18 Thread Alexey Semenyuk
On Fri, 18 Jul 2025 02:47:04 GMT, Alexander Matveev wrote: >> Re-submission of https://github.com/openjdk/jdk/pull/25314 after merge >> conflict was resolved. Old PR will be closed. >> >> All comments are addressed from old PR. Merge conflict was significant, so >> it is like new fix. >> >>

Re: RFR: 8359419: AArch64: Relax min vector length to 32-bit for short vectors [v4]

2025-07-18 Thread Xiaohong Gong
On Wed, 9 Jul 2025 01:23:43 GMT, Xiaohong Gong wrote: >> ### Background >> On AArch64, the minimum vector length supported is 64-bit for basic types, >> except for `byte` and `boolean` (32-bit and 16-bit respectively to match >> special Vector API features). This limitation prevents intrinsific

Re: RFR: 8362376: Use @Stable annotation in Java FDLIBM implementation [v3]

2025-07-18 Thread Raffaello Giulietti
On Thu, 17 Jul 2025 21:40:13 GMT, Joe Darcy wrote: >> Add `@Stable` to the static final arrays used in the Java port of FDLIBM. > > Joe Darcy has updated the pull request incrementally with one additional > commit since the last revision: > > Implement review feedback. Looks fine --