On Thu, 17 Jul 2025 06:33:43 GMT, Brian Burkhalter wrote:
> Hi all,
>
> This pull request contains a backport of commit
> [be0161a8](https://github.com/openjdk/jdk/commit/be0161a8e63096f3a21ce6ea1e055ee1c4ed63ad)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
> Th
Hi all,
This pull request contains a backport of commit
[be0161a8](https://github.com/openjdk/jdk/commit/be0161a8e63096f3a21ce6ea1e055ee1c4ed63ad)
from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
The commit being backported was authored by Brian Burkhalter on 17 Jul 2025
On Wed, 9 Jul 2025 10:32:47 GMT, Pooja-DP wrote:
> Bug reference: https://bugs.openjdk.org/browse/JDK-8361697
>
> The following message is removed:
>
> `
> MSG_BundlerFailed=Error: Bundler "{1}" ({0}) failed to produce a package`
>
> Signed-off-by: Pooja.D.P1
@Pooja-DP
Your change (at versi
On Wed, 16 Jul 2025 16:54:55 GMT, Brian Burkhalter wrote:
> Address the same problem as in #26224 but for the `listFiles` variants with a
> filter parameter.
This pull request has now been integrated.
Changeset: be0161a8
Author:Brian Burkhalter
URL:
https://git.openjdk.org/jdk/comm
On Thu, 17 Jul 2025 06:13:30 GMT, Volkan Yazici wrote:
>> Validate input in `java.lang.StringCoding` intrinsic Java wrappers, improve
>> their documentation, enhance the checks in the associated IR or assembly
>> code, and adapt them to cause VM crash on invalid input.
>>
>> ## Implementation
On Wed, 16 Jul 2025 19:31:26 GMT, Brian Burkhalter wrote:
>> Address the same problem as in #26224 but for the `listFiles` variants with
>> a filter parameter.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8362429: S
On Thu, 17 Jul 2025 06:13:30 GMT, Volkan Yazici wrote:
>> Validate input in `java.lang.StringCoding` intrinsic Java wrappers, improve
>> their documentation, enhance the checks in the associated IR or assembly
>> code, and adapt them to cause VM crash on invalid input.
>>
>> ## Implementation
On Wed, 16 Jul 2025 05:28:55 GMT, Tobias Hartmann wrote:
>> Volkan Yazici has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 12 additional
>> commi
> Validate input in `java.lang.StringCoding` intrinsic Java wrappers, improve
> their documentation, enhance the checks in the associated IR or assembly
> code, and adapt them to cause VM crash on invalid input.
>
> ## Implementation notes
>
> The goal of the associated umbrella issue
> [JDK-8
On Thu, 10 Jul 2025 12:23:06 GMT, Volkan Yazici wrote:
>> Volkan Yazici has refreshed the contents of this pull request, and previous
>> commits have been removed. The incremental views will show differences
>> compared to the previous content of the PR. The pull request contains one
>> new co
On Wed, 16 Jul 2025 14:30:44 GMT, Alexey Semenyuk wrote:
>> Alexander Matveev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8351073: [macos] jpackage produces invalid Java runtime DMG bundles [v4]
>
> src/jdk.jpackage/share/classes/jdk
On Wed, 16 Jul 2025 15:03:05 GMT, Alexey Semenyuk wrote:
>> Alexander Matveev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8351073: [macos] jpackage produces invalid Java runtime DMG bundles [v3]
>
> src/jdk.jpackage/macosx/classes/jd
On Wed, 16 Jul 2025 20:05:51 GMT, Alexander Matveev
wrote:
>> Re-submission of https://github.com/openjdk/jdk/pull/25314 after merge
>> conflict was resolved. Old PR will be closed.
>>
>> All comments are addressed from old PR. Merge conflict was significant, so
>> it is like new fix.
>>
>>
> Re-submission of https://github.com/openjdk/jdk/pull/25314 after merge
> conflict was resolved. Old PR will be closed.
>
> All comments are addressed from old PR. Merge conflict was significant, so it
> is like new fix.
>
> Fixed jpackage to produce valid Java runtimes based on description be
On Wed, 16 Jul 2025 14:20:47 GMT, Alexey Semenyuk wrote:
>> Alexander Matveev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8351073: [macos] jpackage produces invalid Java runtime DMG bundles [v4]
>
> test/jdk/tools/jpackage/junit/shar
On Mon, 14 Jul 2025 15:33:35 GMT, Jorn Vernee wrote:
> Issue copied from the JBS issue:
>
> When an upcall stub accepts a by-value struct, and the struct is passed by
> the underlying ABI as a pointer to a temporary copy on the caller's stack
> (for instance on Windows when the struct doesn't
On Wed, 16 Jul 2025 02:01:57 GMT, Alexander Matveev
wrote:
>> Re-submission of https://github.com/openjdk/jdk/pull/25314 after merge
>> conflict was resolved. Old PR will be closed.
>>
>> All comments are addressed from old PR. Merge conflict was significant, so
>> it is like new fix.
>>
>>
> Re-submission of https://github.com/openjdk/jdk/pull/25314 after merge
> conflict was resolved. Old PR will be closed.
>
> All comments are addressed from old PR. Merge conflict was significant, so it
> is like new fix.
>
> Fixed jpackage to produce valid Java runtimes based on description be
> Validate input in `java.lang.StringCoding` intrinsic Java wrappers, improve
> their documentation, enhance the checks in the associated IR or assembly
> code, and adapt them to cause VM crash on invalid input.
>
> ## Implementation notes
>
> The goal of the associated umbrella issue
> [JDK-8
> Validate input in `java.lang.StringCoding` intrinsic Java wrappers, improve
> their documentation, enhance the checks in the associated IR or assembly
> code, and adapt them to cause VM crash on invalid input.
>
> ## Implementation notes
>
> The goal of the associated umbrella issue
> [JDK-8
> Address the same problem as in #26224 but for the `listFiles` variants with a
> filter parameter.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
8362429: Simplify listFile loops; add non-null filter tests
-
Chang
On Wed, 16 Jul 2025 19:05:30 GMT, Brian Burkhalter wrote:
>> src/java.base/share/classes/java/io/File.java line 1227:
>>
>>> 1225: File f = new File(s, this);
>>> 1226: if ((filter == null) || filter.accept(f))
>>> 1227: files.add(f);
>>
>> Ra
On Wed, 16 Jul 2025 18:26:51 GMT, Alan Bateman wrote:
>> Brian Burkhalter has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8362429: Add list(FilenameFilter) and toURL()
>
> src/java.base/share/classes/java/io/File.java line 1227:
>
>> 12
On Wed, 16 Jul 2025 04:53:04 GMT, Joe Darcy wrote:
> Add `@Stable` to the static final arrays used in the Java port of FDLIBM.
The methods directly affected by this update are atan, exp, and sin, cos, tan.
The sin, cos, and tan method are affected by the updates to KernelRemPio2 and
tan is als
On Wed, 16 Jul 2025 18:32:13 GMT, John R Rose wrote:
> The effect of this PR is to make the affected array elements eligible for
> constant-folding by the JIT.
>
> The contract of `@Stable` is private to the JDK, since it is a trusted
> annotation. The trusted user promises not to change the a
On Wed, 16 Jul 2025 04:53:04 GMT, Joe Darcy wrote:
> Add `@Stable` to the static final arrays used in the Java port of FDLIBM.
The effect of this PR is to make the affected array elements eligible for
constant-folding by the JIT.
The contract of `@Stable` is private to the JDK, since it is a t
On Wed, 16 Jul 2025 17:46:33 GMT, Brian Burkhalter wrote:
>> Address the same problem as in #26224 but for the `listFiles` variants with
>> a filter parameter.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8362429: A
On Wed, 16 Jul 2025 17:46:33 GMT, Brian Burkhalter wrote:
>> Address the same problem as in #26224 but for the `listFiles` variants with
>> a filter parameter.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8362429: A
Please review this documentation update, authored by @rose00 and originally
pushed to the Leyden repo in [this
PR](https://github.com/openjdk/leyden/pull/26), where more comments can be
found regarding this update.
-
Commit messages:
- 8345836: stable annotation documentation is i
> Address the same problem as in #26224 but for the `listFiles` variants with a
> filter parameter.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
8362429: Add list(FilenameFilter) and toURL()
-
Changes:
- all: h
On Wed, 16 Jul 2025 13:42:45 GMT, cagliostro92 wrote:
>> src/java.base/share/classes/java/util/Properties.java line 78:
>>
>>> 76: * the call to the {@code propertyNames} or {@code list} method
>>> 77: * will fail if it is called on a "compromised" {@code Properties}
>>> 78: * object that con
Address the same problem as in #26224 but for the `listFiles` variants with a
filter parameter.
-
Commit messages:
- 8362429: AssertionError in File.listFiles(FileFilter | FilenameFilter)
Changes: https://git.openjdk.org/jdk/pull/26353/files
Webrev: https://webrevs.openjdk.org/?r
On Wed, 16 Jul 2025 13:30:08 GMT, Alan Bateman wrote:
> @bplb Can you check the test coverage again? Its important that EmptyTest
> exercises every method.
Yes.
-
PR Comment: https://git.openjdk.org/jdk/pull/26224#issuecomment-3079290576
On Wed, 16 Jul 2025 15:31:07 GMT, David Beaumont wrote:
>> Refactoring `ImageReader` to make it easy to add preview mode functionality
>> for Valhalla.
>>
>> This PR is a large change to `ImageReader` (effectively a rewrite) but
>> reduces the surface area of the API significantly, reduces cod
On Tue, 15 Jul 2025 18:21:22 GMT, Brian Burkhalter wrote:
> Hi all,
>
> This pull request contains a backport of commit
> [eefbfdce](https://github.com/openjdk/jdk/commit/eefbfdce315237eeec4aceceb476d86314304e81)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
> The commit
On Wed, 16 Jul 2025 13:24:35 GMT, Erik Gahlin wrote:
> 8361640: JFR: RandomAccessFile::readLine emits events for each character
This pull request has now been integrated.
Changeset: 93260d63
Author:Erik Gahlin
URL:
https://git.openjdk.org/jdk/commit/93260d639e5204a35de4f574dee773302
On Wed, 16 Jul 2025 15:31:07 GMT, David Beaumont wrote:
>> Refactoring `ImageReader` to make it easy to add preview mode functionality
>> for Valhalla.
>>
>> This PR is a large change to `ImageReader` (effectively a rewrite) but
>> reduces the surface area of the API significantly, reduces cod
> Refactoring `ImageReader` to make it easy to add preview mode functionality
> for Valhalla.
>
> This PR is a large change to `ImageReader` (effectively a rewrite) but
> reduces the surface area of the API significantly, reduces code complexity
> and increases performance/memory efficiency. Th
> Refactoring `ImageReader` to make it easy to add preview mode functionality
> for Valhalla.
>
> This PR is a large change to `ImageReader` (effectively a rewrite) but
> reduces the surface area of the API significantly, reduces code complexity
> and increases performance/memory efficiency. Th
On Wed, 16 Jul 2025 02:01:57 GMT, Alexander Matveev
wrote:
>> Re-submission of https://github.com/openjdk/jdk/pull/25314 after merge
>> conflict was resolved. Old PR will be closed.
>>
>> All comments are addressed from old PR. Merge conflict was significant, so
>> it is like new fix.
>>
>>
Unfortunately, after diving into this, I found that the jspawnhelper
version checks (JDK-8325621) that guard against JDK in-place-updates also
rely on the liveness signal. See comment in
https://bugs.openjdk.org/browse/JDK-8362257.
I find the check itself quite questionable, but I did not want to
On Wed, 16 Jul 2025 10:32:41 GMT, fabioromano1 wrote:
>> src/java.base/share/classes/java/math/BigInteger.java line 2755:
>>
>>> 2753: * is even and this BigInteger is negative, an {@code
>>> ArithmeticException} will be
>>> 2754: * thrown.
>>> 2755: *
>>
>> I think this specifi
On Mon, 30 Jun 2025 12:27:40 GMT, David Beaumont wrote:
> Initial benchmark to capture at least some comparative measures of
> ImageReader performance.
>
> Current results on my laptop:
>
> Benchmark Mode Cnt ScoreError
> Units
> NewImageBenchma
On Tue, 1 Jul 2025 17:02:27 GMT, David Beaumont wrote:
>> Initial benchmark to capture at least some comparative measures of
>> ImageReader performance.
>>
>> Current results on my laptop:
>>
>> Benchmark Mode Cnt ScoreError
>> Units
>> NewImage
On Wed, 16 Jul 2025 02:01:57 GMT, Alexander Matveev
wrote:
>> Re-submission of https://github.com/openjdk/jdk/pull/25314 after merge
>> conflict was resolved. Old PR will be closed.
>>
>> All comments are addressed from old PR. Merge conflict was significant, so
>> it is like new fix.
>>
>>
On Wed, 16 Jul 2025 02:01:57 GMT, Alexander Matveev
wrote:
>> Re-submission of https://github.com/openjdk/jdk/pull/25314 after merge
>> conflict was resolved. Old PR will be closed.
>>
>> All comments are addressed from old PR. Merge conflict was significant, so
>> it is like new fix.
>>
>>
On Tue, 1 Jul 2025 17:02:27 GMT, David Beaumont wrote:
>> Initial benchmark to capture at least some comparative measures of
>> ImageReader performance.
>>
>> Current results on my laptop:
>>
>> Benchmark Mode Cnt ScoreError
>> Units
>> NewImage
On Tue, 15 Jul 2025 21:27:16 GMT, David Beaumont wrote:
> Oddly while the status at the bottom of the conversation says it has "2
> approvals", the tickbox:
>
> ```
> Change must be properly reviewed (2 reviews required, with at least 1
> Reviewer, 1 Author
> ```
>
> is not checked. I can try
On Wed, 16 Jul 2025 13:24:35 GMT, Erik Gahlin wrote:
> 8361640: JFR: RandomAccessFile::readLine emits events for each character
Marked as reviewed by alanb (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/26349#pullrequestreview-3025177849
> Trivial PR to enhance Javadoc for the `Properties#list` method, which has
> cost me some debugging time.
cagliostro92 has updated the pull request incrementally with one additional
commit since the last revision:
8358530: adds warnings against non-String values in Properties class
document
On Tue, 15 Jul 2025 16:29:11 GMT, Justin Lu wrote:
>> cagliostro92 has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8358530: adds warnings against non-String values in Properties class
>> documentation
>
> src/java.base/share/classes/jav
On Wed, 9 Jul 2025 10:32:47 GMT, Pooja-DP wrote:
> Bug reference: https://bugs.openjdk.org/browse/JDK-8361697
>
> The following message is removed:
>
> `
> MSG_BundlerFailed=Error: Bundler "{1}" ({0}) failed to produce a package`
>
> Signed-off-by: Pooja.D.P1
Marked as reviewed by asemenyuk
On Wed, 16 Jul 2025 13:24:35 GMT, Erik Gahlin wrote:
> 8361640: JFR: RandomAccessFile::readLine emits events for each character
Marked as reviewed by mgronlun (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/26349#pullrequestreview-3025094693
On Wed, 9 Jul 2025 10:32:47 GMT, Pooja-DP wrote:
> Bug reference: https://bugs.openjdk.org/browse/JDK-8361697
>
> The following message is removed:
>
> `
> MSG_BundlerFailed=Error: Bundler "{1}" ({0}) failed to produce a package`
>
> Signed-off-by: Pooja.D.P1
Looks good. Trivial duplicate r
8361640: JFR: RandomAccessFile::readLine emits events for each character
-
Commit messages:
- Backport 9bef2d1610647dec18f9e81cbac3dddbbf99dd6d
Changes: https://git.openjdk.org/jdk/pull/26349/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=26349&range=00
Issue: https://bu
On Wed, 16 Jul 2025 09:28:33 GMT, Jaikiran Pai wrote:
> Hello Brian, I'm late to this discussion. I think there are a couple of more
> places in this code which need attention. The private `File` constructor
> which has this `assert` gets invoked from 3 different `File.listFiles()`
> methods.
On Wed, 16 Jul 2025 06:03:28 GMT, Alan Bateman wrote:
>> Debatable. It's obviously going to scale any results somewhat based on the
>> size of the resources and number of classes. It's kind nice to see "this
>> change removes at least N micro/milli seconds of time spent" since that's a
>> mini
> Can I please get a review of this change which proposes to address the issue
> noted in https://bugs.openjdk.org/browse/JDK-8357708?
>
> As noted in the issue, the current code in
> `com.sun.jndi.ldap.Connection.readReply()` is susceptible to throwing a
> `ServiceUnavailableException` even wh
On Tue, 8 Jul 2025 16:10:17 GMT, Darragh Conway wrote:
> Refactored extract method to encapsulate Windows specific test logic
LGTM
-
PR Comment: https://git.openjdk.org/jdk/pull/26193#issuecomment-3078122822
On Wed, 16 Jul 2025 10:01:00 GMT, Raffaello Giulietti
wrote:
>> fabioromano1 has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Removed useless instruction
>
> src/java.base/share/classes/java/math/BigInteger.java line 2755:
>
>> 2753:
On Wed, 9 Jul 2025 10:32:47 GMT, Pooja-DP wrote:
> Bug reference: https://bugs.openjdk.org/browse/JDK-8361697
>
> The following message is removed:
>
> `
> MSG_BundlerFailed=Error: Bundler "{1}" ({0}) failed to produce a package`
>
> Signed-off-by: Pooja.D.P1
core-libs
-
PR Com
On Sat, 12 Jul 2025 09:18:27 GMT, fabioromano1 wrote:
>> This PR implements nth root computation for BigIntegers using Newton method.
>
> fabioromano1 has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Removed useless instruction
src/java.bas
On Tue, 15 Jul 2025 17:36:22 GMT, Brian Burkhalter wrote:
>> Changes to address `File.listFiles` invoked on an empty path. This fixes an
>> oversight in #22821.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8361587:
On Fri, 11 Jul 2025 19:02:31 GMT, Chen Liang wrote:
>> On 32 bit platforms, when an access to long/double is aligned, it is
>> supported but not atomic. The original wording in
>> `MethodHandles::byteBufferViewVarHandle` sounds as if it is not supported at
>> all. We can fix that by borrowing
> Validate input in `java.lang.StringCoding` intrinsic Java wrappers, improve
> their documentation, enhance the checks in the associated IR or assembly
> code, and adapt them to cause VM crash on invalid input.
>
> ## Implementation notes
>
> The goal of the associated umbrella issue
> [JDK-8
On Tue, 15 Jul 2025 18:21:22 GMT, Brian Burkhalter wrote:
> Hi all,
>
> This pull request contains a backport of commit
> [eefbfdce](https://github.com/openjdk/jdk/commit/eefbfdce315237eeec4aceceb476d86314304e81)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
> The commit
On Tue, 15 Jul 2025 12:51:09 GMT, Matthias Baesken wrote:
> When using GCC static analyzer (-fanalyzer), the following issue is reported.
> Seems `c->mode` is initialized later in the method, but we use it already in
> the exception, this looks wrong.
>
>
> /jdk/src/java.base/unix/native/libja
On Tue, 15 Jul 2025 12:51:09 GMT, Matthias Baesken wrote:
> When using GCC static analyzer (-fanalyzer), the following issue is reported.
> Seems `c->mode` is initialized later in the method, but we use it already in
> the exception, this looks wrong.
>
>
> /jdk/src/java.base/unix/native/libja
68 matches
Mail list logo
