On Tue, 15 Jul 2025 12:51:09 GMT, Matthias Baesken wrote:
> When using GCC static analyzer (-fanalyzer), the following issue is reported.
> Seems `c->mode` is initialized later in the method, but we use it already in
> the exception, this looks wrong.
>
>
> /jdk/src/java.base/unix/native/libja
On Tue, 1 Jul 2025 16:50:09 GMT, David Beaumont wrote:
>> test/micro/org/openjdk/bench/jdk/internal/jrtfs/ImageReaderBenchmark.java
>> line 230:
>>
>>> 228: // Created by running "java -verbose:class", throwing away
>>> anonymous inner
>>> 229: // classes and anything without a reliabl
On Tue, 15 Jul 2025 01:10:05 GMT, Joe Darcy wrote:
> From discussions related to IEEE 754, a few explicit test cases were
> identified where plausible, but incorrect, implementations of fma using
> higher precision. These test cases are useful to include in the regression
> tests of the float-
On Tue, 15 Jul 2025 01:10:05 GMT, Joe Darcy wrote:
> From discussions related to IEEE 754, a few explicit test cases were
> identified where plausible, but incorrect, implementations of fma using
> higher precision. These test cases are useful to include in the regression
> tests of the float-
On Tue, 15 Jul 2025 21:23:06 GMT, David Beaumont wrote:
>> Refactoring `ImageReader` to make it easy to add preview mode functionality
>> for Valhalla.
>>
>> This PR is a large change to `ImageReader` (effectively a rewrite) but
>> reduces the surface area of the API significantly, reduces cod
On Tue, 15 Jul 2025 20:24:04 GMT, Volkan Yazici wrote:
>> Validate input in `java.lang.StringCoding` intrinsic Java wrappers, improve
>> their documentation, enhance the checks in the associated IR or assembly
>> code, and adapt them to cause VM crash on invalid input.
>>
>> ## Implementation
Thanks, Roger, I will proceed with removing the old workaround then.
On Tue, Jul 15, 2025 at 5:05 PM Roger Riggs wrote:
> Hi Thomas,
>
> Simpler is better on both sides of the protocol.
> The version check will have happened before this part of the protocol so
> there's no confusion about matchi
On Wed, 16 Jul 2025 04:53:04 GMT, Joe Darcy wrote:
> Add `@Stable` to the static final arrays used in the Java port of FDLIBM.
Some small refactorings could be used to make a few non-static arrays static.
-
PR Comment: https://git.openjdk.org/jdk/pull/26341#issuecomment-3076738696
Add `@Stable` to the static final arrays used in the Java port of FDLIBM.
-
Commit messages:
- JDK-8362376: Use @Stable annotation in Java FDLIBM implementation
Changes: https://git.openjdk.org/jdk/pull/26341/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=26341&range=00
On Wed, 9 Jul 2025 01:23:43 GMT, Xiaohong Gong wrote:
>> ### Background
>> On AArch64, the minimum vector length supported is 64-bit for basic types,
>> except for `byte` and `boolean` (32-bit and 16-bit respectively to match
>> special Vector API features). This limitation prevents intrinsific
On Fri, 11 Jul 2025 19:02:31 GMT, Chen Liang wrote:
>> On 32 bit platforms, when an access to long/double is aligned, it is
>> supported but not atomic. The original wording in
>> `MethodHandles::byteBufferViewVarHandle` sounds as if it is not supported at
>> all. We can fix that by borrowing
On Tue, 15 Jul 2025 02:31:03 GMT, Alexey Semenyuk wrote:
>> [19:14:45.620] jdk.jpackage.internal.model.PackagerException:
>> java.lang.ClassCastException: class com.sun.proxy.jdk.proxy1.$Proxy0 cannot
>> be cast to class jdk.jpackage.internal.MacApplicationLayout
>> (com.sun.proxy.jdk.proxy1.$
On Mon, 14 Jul 2025 23:25:58 GMT, Alexey Semenyuk wrote:
>> Alexander Matveev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8351073: [macos] jpackage produces invalid Java runtime DMG bundles [v3]
>
> src/jdk.jpackage/macosx/classes/jd
On Mon, 14 Jul 2025 23:08:53 GMT, Alexey Semenyuk wrote:
>> I need it inside `createMacApplication()` before `MacApplication` instance
>> is created.
>
> If you need a property of a `MacApplication` instance, create it and get the
> property.
> `MacApplicationBuilder.validatedBundleIdentifier()
On Fri, 11 Jul 2025 16:44:05 GMT, Alexander Matveev
wrote:
>> Re-submission of https://github.com/openjdk/jdk/pull/25314 after merge
>> conflict was resolved. Old PR will be closed.
>>
>> All comments are addressed from old PR. Merge conflict was significant, so
>> it is like new fix.
>>
>>
> Re-submission of https://github.com/openjdk/jdk/pull/25314 after merge
> conflict was resolved. Old PR will be closed.
>
> All comments are addressed from old PR. Merge conflict was significant, so it
> is like new fix.
>
> Fixed jpackage to produce valid Java runtimes based on description be
On Mon, 16 Jun 2025 21:19:45 GMT, Johannes Graham wrote:
>> This PR replaces construction of intermediate strings to be parsed with more
>> direct manipulation of numbers. It also has a more streamlined mechanism of
>> handling `Long.MIN_VALUE` when parsing longs by using
>> `Long.parseUnsigne
StackFrame.SetValues, StackFrame.GetValues, ThreadReference.PopFrames, and
ThreadReference.ForceEarlyReturn all need updated language related to
OPAQUE_FRAME error.
(1) The spec for JVMTI says the following for GetLocalsXXX and SetLocalsXXX
The implementation is unable to set the frame locals
On Tue, 15 Jul 2025 20:24:04 GMT, Volkan Yazici wrote:
>> Validate input in `java.lang.StringCoding` intrinsic Java wrappers, improve
>> their documentation, enhance the checks in the associated IR or assembly
>> code, and adapt them to cause VM crash on invalid input.
>>
>> ## Implementation
On Mon, 30 Jun 2025 06:01:44 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this doc-only change which proposes to clarify
>> the current implementation of the `java.util.Properties.list(...)` methods?
>>
>> As noted in https://bugs.openjdk.org/browse/JDK-8360575, the current
>> impl
On Tue, 1 Jul 2025 17:02:27 GMT, David Beaumont wrote:
>> Initial benchmark to capture at least some comparative measures of
>> ImageReader performance.
>>
>> Current results on my laptop:
>>
>> Benchmark Mode Cnt ScoreError
>> Units
>> NewImage
> Refactoring `ImageReader` to make it easy to add preview mode functionality
> for Valhalla.
>
> This PR is a large change to `ImageReader` (effectively a rewrite) but
> reduces the surface area of the API significantly, reduces code complexity
> and increases performance/memory efficiency. Th
On Wed, 9 Jul 2025 05:45:01 GMT, Erik Gahlin wrote:
> Could I have a review of the change that prevents RandomAccessFile::readLine
> from emitting an event per character? This leads to unnecessary overhead,
> both with or without JFR enabled.
>
> Testing: tier1 + tier2 + jdk/jdk/jfr
>
> Than
On Tue, 15 Jul 2025 20:24:22 GMT, Volkan Yazici wrote:
>> src/java.base/share/classes/sun/nio/cs/ISO_8859_1.java line 201:
>>
>>> 199: int len = (dlen < slen) ? dlen : slen;
>>> 200: try {
>>> 201: int ret = len <= 0 ? 0 : encodeISOArray(sa, sp, da,
>>>
On Tue, 15 Jul 2025 19:45:33 GMT, Roger Riggs wrote:
>> Volkan Yazici has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - Minimize the number of touched lines in `vmIntrinsics.hpp`
>> - Remove Markdown-styling in comments
>> - Improve
On Tue, 15 Jul 2025 19:25:31 GMT, Roger Riggs wrote:
>> Volkan Yazici has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - Minimize the number of touched lines in `vmIntrinsics.hpp`
>> - Remove Markdown-styling in comments
>> - Improve
> Validate input in `java.lang.StringCoding` intrinsic Java wrappers, improve
> their documentation, enhance the checks in the associated IR or assembly
> code, and adapt them to cause VM crash on invalid input.
>
> ## Implementation notes
>
> The goal of the associated umbrella issue
> [JDK-8
On Tue, 15 Jul 2025 19:21:28 GMT, Volkan Yazici wrote:
>> Validate input in `java.lang.StringCoding` intrinsic Java wrappers, improve
>> their documentation, enhance the checks in the associated IR or assembly
>> code, and adapt them to cause VM crash on invalid input.
>>
>> ## Implementation
On Mon, 14 Jul 2025 10:32:24 GMT, Damon Fenacci wrote:
> I left a couple of minor comments. I also noticed that you haven't yet added
> the benchmark results to the description: do you want to run them again after
> the reviews?
@dafedafe, thanks so much for the review! I've implemented the ch
On Mon, 14 Jul 2025 09:11:08 GMT, Damon Fenacci wrote:
>> Volkan Yazici has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - Minimize the number of touched lines in `vmIntrinsics.hpp`
>> - Remove Markdown-styling in comments
>> - Improv
On Mon, 14 Jul 2025 10:27:45 GMT, Damon Fenacci wrote:
>> Volkan Yazici has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - Minimize the number of touched lines in `vmIntrinsics.hpp`
>> - Remove Markdown-styling in comments
>> - Improv
On Mon, 14 Jul 2025 08:49:44 GMT, Damon Fenacci wrote:
>> Volkan Yazici has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - Minimize the number of touched lines in `vmIntrinsics.hpp`
>> - Remove Markdown-styling in comments
>> - Improv
> Validate input in `java.lang.StringCoding` intrinsic Java wrappers, improve
> their documentation, enhance the checks in the associated IR or assembly
> code, and adapt them to cause VM crash on invalid input.
>
> ## Implementation notes
>
> The goal of the associated umbrella issue
> [JDK-8
On Tue, 15 Jul 2025 11:05:27 GMT, David Beaumont wrote:
>> Refactoring `ImageReader` to make it easy to add preview mode functionality
>> for Valhalla.
>>
>> This PR is a large change to `ImageReader` (effectively a rewrite) but
>> reduces the surface area of the API significantly, reduces cod
On Tue, 15 Jul 2025 11:05:27 GMT, David Beaumont wrote:
>> Refactoring `ImageReader` to make it easy to add preview mode functionality
>> for Valhalla.
>>
>> This PR is a large change to `ImageReader` (effectively a rewrite) but
>> reduces the surface area of the API significantly, reduces cod
On Tue, 15 Jul 2025 10:22:08 GMT, David Beaumont wrote:
>> src/java.base/share/classes/jdk/internal/jimage/ImageReader.java line 182:
>>
>>> 180:
>>> 181: private static final class SharedImageReader extends
>>> BasicImageReader {
>>> 182: // TODO: Should this be OPEN_FILES or open
On Tue, 15 Jul 2025 17:09:23 GMT, Erik Gahlin wrote:
>> Could I have a review of the change that prevents RandomAccessFile::readLine
>> from emitting an event per character? This leads to unnecessary overhead,
>> both with or without JFR enabled.
>>
>> Testing: tier1 + tier2 + jdk/jdk/jfr
>>
Hi all,
This pull request contains a backport of commit
[eefbfdce](https://github.com/openjdk/jdk/commit/eefbfdce315237eeec4aceceb476d86314304e81)
from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
The commit being backported was authored by Brian Burkhalter on 15 Jul 2025 and
was
On Wed, 9 Jul 2025 18:04:08 GMT, Brian Burkhalter wrote:
> Changes to address `File.listFiles` invoked on an empty path. This fixes an
> oversight in #22821.
This pull request has now been integrated.
Changeset: eefbfdce
Author:Brian Burkhalter
URL:
https://git.openjdk.org/jdk/comm
On Tue, 15 Jul 2025 17:09:23 GMT, Erik Gahlin wrote:
>> Could I have a review of the change that prevents RandomAccessFile::readLine
>> from emitting an event per character? This leads to unnecessary overhead,
>> both with or without JFR enabled.
>>
>> Testing: tier1 + tier2 + jdk/jdk/jfr
>>
On Tue, 15 Jul 2025 17:36:22 GMT, Brian Burkhalter wrote:
>> Changes to address `File.listFiles` invoked on an empty path. This fixes an
>> oversight in #22821.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8361587:
On Mon, 14 Jul 2025 04:53:13 GMT, Xueming Shen wrote:
> Regex class should conform to **_Level 1_** of [Unicode Technical Standard
> #18: Unicode Regular Expressions](http://www.unicode.org/reports/tr18/), plus
> RL2.1 Canonical Equivalents and RL2.2 Extended Grapheme Clusters.
>
> This PR pri
On Tue, 15 Jul 2025 17:47:29 GMT, Xueming Shen wrote:
>> Regex class should conform to **_Level 1_** of [Unicode Technical Standard
>> #18: Unicode Regular Expressions](http://www.unicode.org/reports/tr18/),
>> plus RL2.1 Canonical Equivalents and RL2.2 Extended Grapheme Clusters.
>>
>> This P
On Tue, 15 Jul 2025 16:09:38 GMT, Alan Bateman wrote:
>> Erik Gahlin has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove traceImplReadLine
>
> src/java.base/share/classes/java/io/RandomAccessFile.java line 1039:
>
>> 1037: }
>> 1
> Regex class should conform to **_Level 1_** of [Unicode Technical Standard
> #18: Unicode Regular Expressions](http://www.unicode.org/reports/tr18/), plus
> RL2.1 Canonical Equivalents and RL2.2 Extended Grapheme Clusters.
>
> This PR primarily addresses conformance with RL1.5: Simple Loose Ma
On Tue, 15 Jul 2025 17:44:00 GMT, Xueming Shen wrote:
>> Regex class should conform to **_Level 1_** of [Unicode Technical Standard
>> #18: Unicode Regular Expressions](http://www.unicode.org/reports/tr18/),
>> plus RL2.1 Canonical Equivalents and RL2.2 Extended Grapheme Clusters.
>>
>> This P
> Changes to address `File.listFiles` invoked on an empty path. This fixes an
> oversight in #22821.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
8361587: Fix mkdirs sub-test
-
Changes:
- all: https://git.openj
On Tue, 15 Jul 2025 17:03:18 GMT, Brian Burkhalter wrote:
>> Okay, but if I read this correctly then these methods will test mkdirs with
>> a non-empty path as child will be "/child" or "\child". In order to test
>> mkdirs with an empty path then I think we need `assertFalse(f.mkdirs());`
>
>>
> Could I have a review of the change that prevents RandomAccessFile::readLine
> from emitting an event per character? This leads to unnecessary overhead,
> both with or without JFR enabled.
>
> Testing: tier1 + tier2 + jdk/jdk/jfr
>
> Thanks
> Erik
Erik Gahlin has updated the pull request in
On Fri, 11 Jul 2025 15:34:26 GMT, Brian Burkhalter wrote:
>> src/java.base/unix/classes/java/io/UnixFileSystem.java line 120:
>>
>>> 118: public String resolve(String parent, String child) {
>>> 119: if (child.isEmpty()) return parent;
>>> 120: if (parent.isEmpty()) return ch
On Tue, 15 Jul 2025 16:43:49 GMT, Alan Bateman wrote:
>> Yes. The OS-dependent `mkdirs` sub-tests reflect the actual behavior.
>
> Okay, but if I read this correctly then these methods will test mkdirs with a
> non-empty path as child will be "/child" or "\child". In order to test
> mkdirs wit
On Tue, 15 Jul 2025 15:11:07 GMT, Xueming Shen wrote:
>> Regex class should conform to **_Level 1_** of [Unicode Technical Standard
>> #18: Unicode Regular Expressions](http://www.unicode.org/reports/tr18/),
>> plus RL2.1 Canonical Equivalents and RL2.2 Extended Grapheme Clusters.
>>
>> This P
On Tue, 15 Jul 2025 15:27:06 GMT, Brian Burkhalter wrote:
>> test/jdk/java/io/File/EmptyPath.java line 283:
>>
>>> 281: assertTrue(child.mkdirs());
>>> 282: assertTrue(child.delete());
>>> 283: }
>>
>> The updated proposal is local to listFiles and doesn't change
On Tue, 20 May 2025 16:03:14 GMT, cagliostro92 wrote:
> Trivial PR to enhance Javadoc for the `Properties#list` method, which has
> cost me some debugging time.
The copyright year for this file should also be updated: `1995, 2025,`
Also, the PR title will need to be changed to,
_8358530: Prop
On Tue, 15 Jul 2025 15:11:07 GMT, Xueming Shen wrote:
>> Regex class should conform to **_Level 1_** of [Unicode Technical Standard
>> #18: Unicode Regular Expressions](http://www.unicode.org/reports/tr18/),
>> plus RL2.1 Canonical Equivalents and RL2.2 Extended Grapheme Clusters.
>>
>> This P
On Tue, 15 Jul 2025 14:31:45 GMT, Xueming Shen wrote:
>> Maybe I missed it, but do we have anything to make it clear that it returns
>> null if either stdin or stdout are redirected?
>
> we do have wordings like " If the virtual machine is started from an
> interactive command line without redi
On Wed, 9 Jul 2025 05:45:01 GMT, Erik Gahlin wrote:
> Could I have a review of the change that prevents RandomAccessFile::readLine
> from emitting an event per character? This leads to unnecessary overhead,
> both with or without JFR enabled.
>
> Testing: tier1 + tier2 + jdk/jdk/jfr
>
> Than
On Tue, 15 Jul 2025 15:41:59 GMT, Quan Anh Mai wrote:
>> Ian Graves has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Condensing test data
>
> I believe this is inadequate, an `Associative` will allow reduction
> operation. You need to ad
On Tue, 15 Jul 2025 15:41:59 GMT, Quan Anh Mai wrote:
> I believe this is inadequate, an `Associative` will allow reduction
> operation. You need to add support for `SUADD` to that, too.
Grrr... yes thank you for spotting that obvious omission. We can do that in a
follow on PR, but without any
On Mon, 14 Jul 2025 21:43:58 GMT, Ian Graves wrote:
>> Adding SUADD an associative operation in the Vector API. Saturated addition
>> on fixed-width unsigned integers is provably associative.
>
> Ian Graves has updated the pull request incrementally with one additional
> commit since the last r
On Tue, 15 Jul 2025 06:36:46 GMT, Alan Bateman wrote:
>> Brian Burkhalter has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8361587: Improve previous commit
>
> test/jdk/java/io/File/EmptyPath.java line 283:
>
>> 281: assertTr
On Mon, 14 Jul 2025 22:39:56 GMT, Naoto Sato wrote:
>> This accompanies the fix for
>> [JDK-8361613](https://bugs.openjdk.org/browse/JDK-8361613), which restricts
>> `System.console()` to return a `Console` instance only when both standard
>> input and output are connected to a terminal. The c
On Mon, 30 Jun 2025 06:01:44 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this doc-only change which proposes to clarify
>> the current implementation of the `java.util.Properties.list(...)` methods?
>>
>> As noted in https://bugs.openjdk.org/browse/JDK-8360575, the current
>> impl
On Tue, 15 Jul 2025 01:10:05 GMT, Joe Darcy wrote:
> From discussions related to IEEE 754, a few explicit test cases were
> identified where plausible, but incorrect, implementations of fma using
> higher precision. These test cases are useful to include in the regression
> tests of the float-
On Mon, 14 Jul 2025 07:28:09 GMT, Xueming Shen wrote:
>> src/java.base/share/classes/jdk/internal/util/regex/CaseFolding.java.template
>> line 99:
>>
>>> 97: */
>>> 98: public static int[] getClassRangeClosingCharacters(int start, int
>>> end) {
>>> 99: int[] expanded = new in
> Regex class should conform to **_Level 1_** of [Unicode Technical Standard
> #18: Unicode Regular Expressions](http://www.unicode.org/reports/tr18/), plus
> RL2.1 Canonical Equivalents and RL2.2 Extended Grapheme Clusters.
>
> This PR primarily addresses conformance with RL1.5: Simple Loose Ma
Hi Thomas,
Simpler is better on both sides of the protocol.
The version check will have happened before this part of the protocol so
there's no confusion about matching expectations.
I agree that removing it is preferred.
Roger
On 7/15/25 10:44 AM, Thomas Stüfe wrote:
Hi,
I am currently wo
Hi,
I am currently working on removing (eventually) the vfork mode. Before we
can do this, we need a bit better error diagnostics. I do this by gently
improving the error handling throughout the code, so that we can generate
IOExceptions based on more exact knowledge.
While working at this, I re-
On Wed, 2 Jul 2025 16:47:36 GMT, Ian Graves wrote:
> Adding SUADD an associative operation in the Vector API. Saturated addition
> on fixed-width unsigned integers is provably associative.
This pull request has now been integrated.
Changeset: b65fdf5a
Author:Ian Graves
URL:
https:/
On Tue, 15 Jul 2025 13:29:03 GMT, Alan Bateman wrote:
>> src/java.base/share/classes/java/lang/System.java line 244:
>>
>>> 242: *
>>> 243: * @return The system console, if any, otherwise {@code null}.
>>> 244: * @see Console
>>
>> The method declaration already links to Console
On Wed, 9 Jul 2025 05:45:01 GMT, Erik Gahlin wrote:
> Could I have a review of the change that prevents RandomAccessFile::readLine
> from emitting an event per character? This leads to unnecessary overhead,
> both with or without JFR enabled.
>
> Testing: tier1 + tier2 + jdk/jdk/jfr
>
> Than
On Wed, 4 Jun 2025 13:12:33 GMT, Shaojin Wen wrote:
>> Some static final arrays of BigInteger and BigDecimal are stable and
>> immutable. We should add `@Stable` to give the optimizer more information
>
> Shaojin Wen has updated the pull request with a new target base due to a
> merge or a reba
On Tue, 15 Jul 2025 12:51:09 GMT, Matthias Baesken wrote:
> When using GCC static analyzer (-fanalyzer), the following issue is reported.
> Seems `c->mode` is initialized later in the method, but we use it already in
> the exception, this looks wrong.
>
>
> /jdk/src/java.base/unix/native/libja
On Tue, 15 Jul 2025 13:25:16 GMT, Alan Bateman wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Reflects review comments
>
> src/java.base/share/classes/java/lang/System.java line 244:
>
>> 242: *
>> 243: *
On Mon, 14 Jul 2025 20:23:25 GMT, Naoto Sato wrote:
>> In prior JDK releases, `System.console()` could return a `Console` instance
>> even when the JVM was not attached to an interactive terminal. This could
>> lead to confusion, particularly when input was not from a keyboard or output
>> was
On Wed, 4 Jun 2025 14:22:43 GMT, Raffaello Giulietti
wrote:
> Another step in enhancing floating-point <-> decimal conversions.
This pull request has now been integrated.
Changeset: 563e8762
Author:Raffaello Giulietti
URL:
https://git.openjdk.org/jdk/commit/563e8762464fd1b291eb18f5
When using GCC static analyzer (-fanalyzer), the following issue is reported.
Seems `c->mode` is initialized later in the method, but we use it already in
the exception, this looks wrong.
/jdk/src/java.base/unix/native/libjava/ProcessImpl_md.c: In function
'Java_java_lang_ProcessImpl_forkAndExe
Apologies, that description is pretty lousy. A more explicit description of
the leak (the one in my test in https://github.com/openjdk/jdk/pull/26296)
would be: A class loaded by classloader 'C' statically references an
Executor created via newSingleThreadExecutor(threadFactory). The
ThreadFactory
> Refactoring `ImageReader` to make it easy to add preview mode functionality
> for Valhalla.
>
> This PR is a large change to `ImageReader` (effectively a rewrite) but
> reduces the surface area of the API significantly, reduces code complexity
> and increases performance/memory efficiency. Th
On 11/07/2025 15:42, Chris Dennis wrote:
Hi All,
I believe I've identified a bug in
Executors.AutoShutdownDelegatedExecutorService that can trigger a
classloader leak even in the presence of "correct" Executor
lifecycling. AutoShutdownDelegatedExecutorService only unlinks the
PhantomReferenc
On Fri, 11 Jul 2025 14:41:30 GMT, David Beaumont wrote:
>> Refactoring `ImageReader` to make it easy to add preview mode functionality
>> for Valhalla.
>>
>> This PR is a large change to `ImageReader` (effectively a rewrite) but
>> reduces the surface area of the API significantly, reduces cod
> Refactoring `ImageReader` to make it easy to add preview mode functionality
> for Valhalla.
>
> This PR is a large change to `ImageReader` (effectively a rewrite) but
> reduces the surface area of the API significantly, reduces code complexity
> and increases performance/memory efficiency. Th
On Mon, 14 Jul 2025 20:11:51 GMT, Roger Riggs wrote:
>> David Beaumont has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Linting of a few minor issues (nothing serious).
>>
>> * Linting of minor issues.
>> * Factored out the module
On Tue, 20 May 2025 16:03:14 GMT, cagliostro92 wrote:
> Trivial PR to enhance Javadoc for the `Properties#list` method, which has
> cost me some debugging time.
It does appear true that a `ClassCastException` is thrown if a value is not a
String for `Properties.list(PrintWriter)` and the behav
On Fri, 11 Jul 2025 20:51:38 GMT, Justin Lu wrote:
>> Trivial PR to enhance Javadoc for the `Properties#list` method, which has
>> cost me some debugging time.
>
> It does appear true that a `ClassCastException` is thrown if a value is not a
> String for `Properties.list(PrintWriter)` and the b
Trivial PR to enhance Javadoc for the `Properties#list` method, which has cost
me some debugging time.
-
Commit messages:
- 8358530: adds warnings against non-String values in Properties class
documentation
Changes: https://git.openjdk.org/jdk/pull/25334/files
Webrev: https://we
On Sat, 12 Jul 2025 17:36:54 GMT, Matthias Baesken wrote:
>> The following is reported when building with the gcc static analyzer
>> (-fanalyzer) :
>>
>>
>> /jdk/src/java.base/unix/native/libjava/java_props_md.c:244:17: warning: leak
>> of 'temp' [CWE-401] [-Wanalyzer-malloc-leak]
>> 244 |
On Fri, 11 Jul 2025 12:45:55 GMT, Matthias Baesken wrote:
> The following is reported when building with the gcc static analyzer
> (-fanalyzer) :
>
>
> /jdk/src/java.base/unix/native/libjava/java_props_md.c:244:17: warning: leak
> of 'temp' [CWE-401] [-Wanalyzer-malloc-leak]
> 244 | return
On Sat, 12 Jul 2025 17:36:54 GMT, Matthias Baesken wrote:
>> The following is reported when building with the gcc static analyzer
>> (-fanalyzer) :
>>
>>
>> /jdk/src/java.base/unix/native/libjava/java_props_md.c:244:17: warning: leak
>> of 'temp' [CWE-401] [-Wanalyzer-malloc-leak]
>> 244 |
89 matches
Mail list logo
