On Sat, 12 Jul 2025 04:25:31 GMT, Brian Burkhalter wrote:
>> Changes to address `File.listFiles` invoked on an empty path. This fixes an
>> oversight in #22821.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8361587:
On Wed, 9 Jul 2025 02:58:28 GMT, Sergey Bylokhov wrote:
> Please review the application of the `@Serial` annotation
> ([JDK-8202385](https://bugs.openjdk.org/browse/JDK-8202385)) to types in the
> java.logging module to enable stricter compile-time checking of
> serialization-related declarati
On Mon, 14 Jul 2025 20:23:25 GMT, Naoto Sato wrote:
>> In prior JDK releases, `System.console()` could return a `Console` instance
>> even when the JVM was not attached to an interactive terminal. This could
>> lead to confusion, particularly when input was not from a keyboard or output
>> was
On Wed, 9 Jul 2025 05:45:01 GMT, Erik Gahlin wrote:
> Could I have a review of the change that prevents RandomAccessFile::readLine
> from emitting an event per character? This leads to unnecessary overhead,
> both with or without JFR enabled.
>
> Testing: tier1 + tier2 + jdk/jdk/jfr
>
> Than
On Mon, 30 Jun 2025 06:01:44 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this doc-only change which proposes to clarify
>> the current implementation of the `java.util.Properties.list(...)` methods?
>>
>> As noted in https://bugs.openjdk.org/browse/JDK-8360575, the current
>> impl
On Mon, 30 Jun 2025 18:05:58 GMT, Raffaello Giulietti
wrote:
>> Another step in enhancing floating-point <-> decimal conversions.
>
> Raffaello Giulietti has updated the pull request with a new target base due
> to a merge or a rebase. The incremental webrev excludes the unrelated changes
> br
On Tue, 1 Jul 2025 14:09:49 GMT, David Beaumont wrote:
>> David Beaumont has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Linting of a few minor issues (nothing serious).
>>
>> * Linting of minor issues.
>> * Factored out the modul
On Fri, 11 Jul 2025 14:41:30 GMT, David Beaumont wrote:
>> Refactoring `ImageReader` to make it easy to add preview mode functionality
>> for Valhalla.
>>
>> This PR is a large change to `ImageReader` (effectively a rewrite) but
>> reduces the surface area of the API significantly, reduces cod
On Tue, 15 Jul 2025 02:15:56 GMT, Alexander Matveev
wrote:
>> Maybe run jpackage with `--verbose` flag?
>
> [19:14:45.620] jdk.jpackage.internal.model.PackagerException:
> java.lang.ClassCastException: class com.sun.proxy.jdk.proxy1.$Proxy0 cannot
> be cast to class jdk.jpackage.internal.MacAp
On Tue, 15 Jul 2025 02:13:41 GMT, Alexey Semenyuk wrote:
>> It does not print call stack. Not sure why. Once I figure it I will update.
>
> Maybe run jpackage with `--verbose` flag?
[19:14:45.620] jdk.jpackage.internal.model.PackagerException:
java.lang.ClassCastException: class com.sun.proxy.j
On Tue, 15 Jul 2025 01:45:11 GMT, Alexander Matveev
wrote:
>> What is the full stack trace?
>
> It does not print call stack. Not sure why. Once I figure it I will update.
Maybe run jpackage with `--verbose` flag?
-
PR Review Comment: https://git.openjdk.org/jdk/pull/26173#discuss
On Tue, 15 Jul 2025 01:29:44 GMT, Alexey Semenyuk wrote:
>> Getting following exception at runtime with code above:
>>
>> java.lang.ClassCastException: class com.sun.proxy.jdk.proxy1.$Proxy0 cannot
>> be cast to class jdk.jpackage.internal.MacApplicationLayout
>> (com.sun.proxy.jdk.proxy1.$Pro
On Mon, 14 Jul 2025 23:33:36 GMT, Alexander Matveev
wrote:
>> Try,
>>
>>
>> builder.task(MacCopyAppImageTaskID.SIGN_RUNTIME_BUNDLE)
>>
>> .appImageAction(MacPackagingPipeline::signApplicationBundle)
>> .add();
>
> Getting following excep
>From discussions related to IEEE 754, a few explicit test cases were
>identified where plausible, but incorrect, implementations of fma using higher
>precision. These test cases are useful to include in the regression tests of
>the float-precision and Float16-precision fused multiple add method
> Regex class should conform to **_Level 1_** of [Unicode Technical Standard
> #18: Unicode Regular Expressions](http://www.unicode.org/reports/tr18/), plus
> RL2.1 Canonical Equivalents and RL2.2 Extended Grapheme Clusters.
>
> This PR primarily addresses conformance with RL1.5: Simple Loose Ma
On Thu, 10 Jul 2025 22:32:45 GMT, Chen Liang wrote:
> Currently, the aforementioned two methods do not throw NPE upon null input,
> but throw IAE.
>
> This behavior is bad for composition: `bsmEntry` actually throws IAE for
> nested null in the argument list/array, and other APIs are similarly
On Thu, 10 Jul 2025 22:32:45 GMT, Chen Liang wrote:
> Currently, the aforementioned two methods do not throw NPE upon null input,
> but throw IAE.
>
> This behavior is bad for composition: `bsmEntry` actually throws IAE for
> nested null in the argument list/array, and other APIs are similarly
On Mon, 14 Jul 2025 23:16:14 GMT, Alexey Semenyuk wrote:
>> One is used by `appImageAction` and second by `packageAction`. Maybe I am
>> misusing appImageAction and packageAction. These two actions requires
>> different argument `AppImageBuildEnv` vs `PackageBuildEnv`.
>
> Try,
>
>
> builder
On Fri, 11 Jul 2025 16:44:05 GMT, Alexander Matveev
wrote:
>> Re-submission of https://github.com/openjdk/jdk/pull/25314 after merge
>> conflict was resolved. Old PR will be closed.
>>
>> All comments are addressed from old PR. Merge conflict was significant, so
>> it is like new fix.
>>
>>
On Fri, 11 Jul 2025 16:44:05 GMT, Alexander Matveev
wrote:
>> Re-submission of https://github.com/openjdk/jdk/pull/25314 after merge
>> conflict was resolved. Old PR will be closed.
>>
>> All comments are addressed from old PR. Merge conflict was significant, so
>> it is like new fix.
>>
>>
On Mon, 14 Jul 2025 20:13:06 GMT, Xueming Shen wrote:
>> Regex class should conform to **_Level 1_** of [Unicode Technical Standard
>> #18: Unicode Regular Expressions](http://www.unicode.org/reports/tr18/),
>> plus RL2.1 Canonical Equivalents and RL2.2 Extended Grapheme Clusters.
>>
>> This P
On Wed, 9 Jul 2025 01:27:32 GMT, Alexander Matveev wrote:
>> src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/MacPackagingPipeline.java
>> line 311:
>>
>>> 309: }
>>> 310:
>>> 311: private static void sign(AppImageBuildEnv>> MacApplicationLayout> env) throws IOException {
>>
>> I
On Thu, 10 Jul 2025 00:27:55 GMT, Alexander Matveev
wrote:
>> src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/resources/RuntimeBundle-Info.plist.template
>> line 6:
>>
>>> 4:
>>> 5: CFBundleDevelopmentRegion
>>> 6: English
>>
>> I'm surprised there is no standard way to
On Wed, 9 Jul 2025 00:31:39 GMT, Alexander Matveev wrote:
>> src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/MacApplicationBuilder.java
>> line 184:
>>
>>> 182: }
>>> 183:
>>> 184: public String validatedBundleIdentifier() throws ConfigException {
>>
>> This method is private on
On Mon, 14 Jul 2025 22:39:56 GMT, Naoto Sato wrote:
>> This accompanies the fix for
>> [JDK-8361613](https://bugs.openjdk.org/browse/JDK-8361613), which restricts
>> `System.console()` to return a `Console` instance only when both standard
>> input and output are connected to a terminal. The c
On Thu, 10 Jul 2025 01:30:19 GMT, Alexander Matveev
wrote:
> runtimeImageDir is a value of --runtime-image in case of runtime installer.
This duplicates `Package.predefinedAppImage()` function. In case of runtime
packaging, the "predefined app image" should be the value of `--runtime-image`.
On Wed, 9 Jul 2025 01:32:38 GMT, Alexander Matveev wrote:
> RUNTIME_PACKAGE_LAYOUT points to "Contents/Home". Bundle is "Contents/Home",
> "Contents/MacOS" and "Contents/Info.plist".
Right, so `RUNTIME_PACKAGE_LAYOUT` points to a bundle just like
[ApplicationLayoutUtils.MAC_APPLICATION_LAYOUT]
> This accompanies the fix for
> [JDK-8361613](https://bugs.openjdk.org/browse/JDK-8361613), which restricts
> `System.console()` to return a `Console` instance only when both standard
> input and output are connected to a terminal. The change here is solely a
> specification clarification and
On Mon, 14 Jul 2025 21:43:58 GMT, Ian Graves wrote:
>> Adding SUADD an associative operation in the Vector API. Saturated addition
>> on fixed-width unsigned integers is provably associative.
>
> Ian Graves has updated the pull request incrementally with one additional
> commit since the last r
> Adding SUADD an associative operation in the Vector API. Saturated addition
> on fixed-width unsigned integers is provably associative.
Ian Graves has updated the pull request incrementally with one additional
commit since the last revision:
Condensing test data
-
Changes:
-
On Mon, 14 Jul 2025 17:15:57 GMT, Naoto Sato wrote:
> This accompanies the fix for
> [JDK-8361613](https://bugs.openjdk.org/browse/JDK-8361613), which restricts
> `System.console()` to return a `Console` instance only when both standard
> input and output are connected to a terminal. The chang
On Mon, 14 Jul 2025 19:38:04 GMT, Naoto Sato wrote:
>> src/java.base/share/classes/java/io/Console.java line 49:
>>
>>> 47: * was launched. If the virtual machine is started automatically, for
>>> 48: * example by a background job scheduler, or if one or both of the
>>> 49: * standard input
On Mon, 14 Jul 2025 18:10:53 GMT, Naoto Sato wrote:
> Looks good. Thanks for adding case folding support which is long overdue 🙂
> Since this is adding a new support for casefolding for character class
> ranges, I think CSR and a release note should be considered.
Thanks for the review. Arguab
On Mon, 14 Jul 2025 17:57:22 GMT, Justin Lu wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update test/jdk/java/io/Console/LocaleTest.java
>>
>> Co-authored-by: Andrey Turbanov
>
> test/jdk/java/io/Console/Def
> In prior JDK releases, `System.console()` could return a `Console` instance
> even when the JVM was not attached to an interactive terminal. This could
> lead to confusion, particularly when input was not from a keyboard or output
> was redirected, such as to or from a file or pipe, especially
> Regex class should conform to **_Level 1_** of [Unicode Technical Standard
> #18: Unicode Regular Expressions](http://www.unicode.org/reports/tr18/), plus
> RL2.1 Canonical Equivalents and RL2.2 Extended Grapheme Clusters.
>
> This PR primarily addresses conformance with RL1.5: Simple Loose Ma
On Tue, 1 Jul 2025 17:02:27 GMT, David Beaumont wrote:
>> Initial benchmark to capture at least some comparative measures of
>> ImageReader performance.
>>
>> Current results on my laptop:
>>
>> Benchmark Mode Cnt ScoreError
>> Units
>> NewImage
On Mon, 14 Jul 2025 18:56:11 GMT, Justin Lu wrote:
>> This accompanies the fix for
>> [JDK-8361613](https://bugs.openjdk.org/browse/JDK-8361613), which restricts
>> `System.console()` to return a `Console` instance only when both standard
>> input and output are connected to a terminal. The ch
On Mon, 14 Jul 2025 17:15:57 GMT, Naoto Sato wrote:
> This accompanies the fix for
> [JDK-8361613](https://bugs.openjdk.org/browse/JDK-8361613), which restricts
> `System.console()` to return a `Console` instance only when both standard
> input and output are connected to a terminal. The chang
On Fri, 11 Jul 2025 22:07:01 GMT, Naoto Sato wrote:
>> In prior JDK releases, `System.console()` could return a `Console` instance
>> even when the JVM was not attached to an interactive terminal. This could
>> lead to confusion, particularly when input was not from a keyboard or output
>> was
> Adding SUADD an associative operation in the Vector API. Saturated addition
> on fixed-width unsigned integers is provably associative.
Ian Graves has updated the pull request incrementally with one additional
commit since the last revision:
Cleaning up test cases
-
Changes:
On Mon, 14 Jul 2025 07:54:31 GMT, Xueming Shen wrote:
>> Regex class should conform to **_Level 1_** of [Unicode Technical Standard
>> #18: Unicode Regular Expressions](http://www.unicode.org/reports/tr18/),
>> plus RL2.1 Canonical Equivalents and RL2.2 Extended Grapheme Clusters.
>>
>> This P
On Mon, Jul 14, 2025 at 10:14 AM fabioromano1 wrote:
>
> On Sat, 12 Jul 2025 09:18:27 GMT, fabioromano1 wrote:
>
> >> This PR implements nth root computation for BigIntegers using Newton
method.
> >
> > fabioromano1 has updated the pull request incrementally with one
additional commit since the l
On Mon, 30 Jun 2025 06:01:44 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this doc-only change which proposes to clarify
>> the current implementation of the `java.util.Properties.list(...)` methods?
>>
>> As noted in https://bugs.openjdk.org/browse/JDK-8360575, the current
>> impl
This accompanies the fix for
[JDK-8361613](https://bugs.openjdk.org/browse/JDK-8361613), which restricts
`System.console()` to return a `Console` instance only when both standard input
and output are connected to a terminal. The change here is solely a
specification clarification and tightening
On Sun, 13 Jul 2025 14:20:22 GMT, Chen Liang wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Alan's review - no need to state the number of characters
>
> src/java.base/share/classes/java/util/Properties.java line
On Mon, 14 Jul 2025 15:43:58 GMT, Raffaello Giulietti
wrote:
>> @rgiulietti The convergence of the recurrence is guaranteed if the initial
>> estimate is larger than or equal to the exact value, AFAIK no guarantee is
>> given when the estimate is smaller than the exact value.
>
> This is my hu
On Sat, 12 Jul 2025 17:36:54 GMT, Matthias Baesken wrote:
>> The following is reported when building with the gcc static analyzer
>> (-fanalyzer) :
>>
>>
>> /jdk/src/java.base/unix/native/libjava/java_props_md.c:244:17: warning: leak
>> of 'temp' [CWE-401] [-Wanalyzer-malloc-leak]
>> 244 |
On Sat, 12 Jul 2025 09:18:27 GMT, fabioromano1 wrote:
>> This PR implements nth root computation for BigIntegers using Newton method.
>
> fabioromano1 has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Removed useless instruction
The integers
On Tue, 8 Jul 2025 16:10:17 GMT, Darragh Conway wrote:
> Refactored extract method to encapsulate Windows specific test logic
Thanks for the suggestion, I'll create a separate ticket for that junit
conversion...
-
PR Comment: https://git.openjdk.org/jdk/pull/26193#issuecomment-307
On Mon, 14 Jul 2025 15:52:19 GMT, fabioromano1 wrote:
> This is my hunch as well. So while the use of `nextUp()` and `ceil()`
> certainly help to achieve an overestimate, I'm less sure that this is
> sufficient when using `pow()`. If the latter has some error bigger than a few
> ulps, then we
Issue copied from the JBS issue:
When an upcall stub accepts a by-value struct, and the struct is passed by the
underlying ABI as a pointer to a temporary copy on the caller's stack (for
instance on Windows when the struct doesn't fit into a single register), a
scope is created for the duration
On Fri, Jul 11, 2025 at 11:44 AM fabioromano1 wrote:
>
> On Fri, 11 Jul 2025 18:07:31 GMT, fabioromano1 wrote:
>
> >> This PR implements nth root computation for BigIntegers using Newton
method.
> >
> > fabioromano1 has updated the pull request incrementally with one
additional commit since the l
On Mon, 14 Jul 2025 15:43:58 GMT, Raffaello Giulietti
wrote:
> This is my hunch as well. So while the use of `nextUp()` and `ceil()`
> certainly help to achieve an overestimate, I'm less sure that this is
> sufficient when using `pow()`. If the latter has some error bigger than a few
> ulps,
On Mon, 14 Jul 2025 15:46:47 GMT, fabioromano1 wrote:
>> src/java.base/share/classes/java/math/MutableBigInteger.java line 1936:
>>
>>> 1934: * where {@code nthRoot(., n)} denotes the mathematical {@code
>>> n}th root.
>>> 1935: * The contents of {@code this} are not changed. The
>>>
On Mon, 14 Jul 2025 14:32:45 GMT, Raffaello Giulietti
wrote:
>> fabioromano1 has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Removed useless instruction
>
> src/java.base/share/classes/java/math/MutableBigInteger.java line 1936:
>
>> 1
On Mon, 14 Jul 2025 15:40:18 GMT, fabioromano1 wrote:
>> src/java.base/share/classes/java/math/MutableBigInteger.java line 1964:
>>
>>> 1962: final double rad = Math.nextUp(x >= 0 ? x : x + 0x1p64);
>>> 1963: final double approx = n == 3 ? Math.cbrt(rad) :
>>> Math.pow(r
On Mon, 14 Jul 2025 14:33:26 GMT, Raffaello Giulietti
wrote:
>> fabioromano1 has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Removed useless instruction
>
> src/java.base/share/classes/java/math/MutableBigInteger.java line 1964:
>
>> 1
On Fri, 11 Jul 2025 19:57:54 GMT, Alexander Matveev
wrote:
> Test updated to expect `jpackage` to PASS in case of
> `--mac-signing-key-user-name` and FAIL in case of
> `-mac-app-image-sign-identity`. See explanation below.
>
> Case 1: Only common name of certificate is used (PASS):
> jpackage
On Sat, 12 Jul 2025 09:18:27 GMT, fabioromano1 wrote:
>> This PR implements nth root computation for BigIntegers using Newton method.
>
> fabioromano1 has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Removed useless instruction
I'm looking
On Sat, 12 Jul 2025 09:18:27 GMT, fabioromano1 wrote:
>> This PR implements nth root computation for BigIntegers using Newton method.
>
> fabioromano1 has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Removed useless instruction
I agree that
On Fri, 11 Jul 2025 15:31:53 GMT, Nizar Benalla wrote:
>> Once https://bugs.openjdk.org/browse/JDK-8358769 is resolved,
>> JavaBaseCheckSince no longer needs to be problemlisted.
>
> Nizar Benalla has updated the pull request with a new target base due to a
> merge or a rebase. The pull request
On Tue, 17 Jun 2025 15:22:24 GMT, Nizar Benalla wrote:
> Once https://bugs.openjdk.org/browse/JDK-8358769 is resolved,
> JavaBaseCheckSince no longer needs to be problemlisted.
This pull request has now been integrated.
Changeset: bcd86d57
Author:Nizar Benalla
URL:
https://git.open
On Tue, 8 Jul 2025 16:10:17 GMT, Darragh Conway wrote:
> Refactored extract method to encapsulate Windows specific test logic
Hi @DarraghConway , Could you please convert this test to junit test. example :
open/test/jdk/java/io/File/DeleteReadOnly.java
-
PR Comment: https://git.op
On Thu, 26 Jun 2025 10:48:37 GMT, Volkan Yazici wrote:
> Validate input in `java.lang.StringCoding` intrinsic Java wrappers, improve
> their documentation, enhance the checks in the associated IR or assembly
> code, and adapt them to cause VM crash on invalid input.
>
> ## Implementation notes
> Hi all,
>
> please review this change that implements (currently Draft) JEP: G1:
> Improve Application Throughput with a More Efficient Write-Barrier.
>
> The reason for posting this early is that this is a large change, and the JEP
> process is already taking very long with no end in sight
On Mon, 7 Jul 2025 12:36:40 GMT, Thomas Schatzl wrote:
>> Hi all,
>>
>> please review this change that implements (currently Draft) JEP: G1:
>> Improve Application Throughput with a More Efficient Write-Barrier.
>>
>> The reason for posting this early is that this is a large change, and the
Hi Chris,
I've opened the following JBS issue based on your email:
https://bugs.openjdk.org/browse/JDK-8362123
If you intend to open a PR against the issue, please make sure that the OCA
status is in order and that there's a regression test associated with the
proposed fix.
Cheers,
√
Viktor
On Mon, 7 Jul 2025 12:36:40 GMT, Thomas Schatzl wrote:
>> Hi all,
>>
>> please review this change that implements (currently Draft) JEP: G1:
>> Improve Application Throughput with a More Efficient Write-Barrier.
>>
>> The reason for posting this early is that this is a large change, and the
On Mon, 14 Jul 2025 05:08:58 GMT, Chen Liang wrote:
>> Xueming Shen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> update to address the review comments
>
> make/jdk/src/classes/build/tools/generatecharacter/CaseFolding.java line 45:
>
> Regex class should conform to **_Level 1_** of [Unicode Technical Standard
> #18: Unicode Regular Expressions](http://www.unicode.org/reports/tr18/), plus
> RL2.1 Canonical Equivalents and RL2.2 Extended Grapheme Clusters.
>
> This PR primarily addresses conformance with RL1.5: Simple Loose Ma
On Mon, 14 Jul 2025 05:01:17 GMT, Chen Liang wrote:
>> Regex class should conform to **_Level 1_** of [Unicode Technical Standard
>> #18: Unicode Regular Expressions](http://www.unicode.org/reports/tr18/),
>> plus RL2.1 Canonical Equivalents and RL2.2 Extended Grapheme Clusters.
>>
>> This PR
Hi Jige,
The current behavior is what's currently achievable within the constraints of
the Gatherer-model, if that changes in the future it would also mean that there
could be stronger "guarantees" made.
In the mean time, the good news is that if you're not satisfied with the
behavior offered
73 matches
Mail list logo
