Re: [External] : Re: Question about mapConcurrent() Behavior and Happens-Before Guarantees

2025-07-12 Thread Jige Yu
Thanks for pressing on that, Viktor! I think I was fooled by my quick-and-dirty test. As I tried to harden it, I failed to deduce consistent behavior about what parallel stream does when unchecked exceptions happen. And in fact, it seems like it does *not* interrupt pending threads (?). With this

Re: RFR: 8361959: [GCC static analyzer] java_props_md.c leak of 'temp' variable is reported [v2]

2025-07-12 Thread Kim Barrett
On Sat, 12 Jul 2025 17:36:54 GMT, Matthias Baesken wrote: >> The following is reported when building with the gcc static analyzer >> (-fanalyzer) : >> >> >> /jdk/src/java.base/unix/native/libjava/java_props_md.c:244:17: warning: leak >> of 'temp' [CWE-401] [-Wanalyzer-malloc-leak] >> 244 |

Re: RFR: 8361959: [GCC static analyzer] java_props_md.c leak of 'temp' variable is reported [v2]

2025-07-12 Thread Matthias Baesken
> The following is reported when building with the gcc static analyzer > (-fanalyzer) : > > > /jdk/src/java.base/unix/native/libjava/java_props_md.c:244:17: warning: leak > of 'temp' [CWE-401] [-Wanalyzer-malloc-leak] > 244 | return 0; > > > Seems we have to free temp in an early return. M

Re: RFR: 8361959: [GCC static analyzer] java_props_md.c leak of 'temp' variable is reported

2025-07-12 Thread Matthias Baesken
On Fri, 11 Jul 2025 13:04:37 GMT, Aleksey Shipilev wrote: > There is another instance a few lines below. See around where > `free(encoding_variant);` happen. Hi I noticed that one too ! Seems we have to adjust it too , I first thought that it is not needed there but it is. Not sure why the G

Re: RFR: 8077587: BigInteger Roots [v23]

2025-07-12 Thread fabioromano1
> This PR implements nth root computation for BigIntegers using Newton method. fabioromano1 has updated the pull request incrementally with one additional commit since the last revision: Removed useless instruction - Changes: - all: https://git.openjdk.org/jdk/pull/24898/files

Re: RFR: 8077587: BigInteger Roots [v22]

2025-07-12 Thread fabioromano1
> This PR implements nth root computation for BigIntegers using Newton method. fabioromano1 has updated the pull request incrementally with one additional commit since the last revision: Code simplification - Changes: - all: https://git.openjdk.org/jdk/pull/24898/files - new: