> Changes to address `File.listFiles` invoked on an empty path. This fixes an
> oversight in #22821.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
8361587: Improve previous commit
-
Changes:
- all: https://git.o
On Fri, 11 Jul 2025 19:02:31 GMT, Chen Liang wrote:
>> On 32 bit platforms, when an access to long/double is aligned, it is
>> supported but not atomic. The original wording in
>> `MethodHandles::byteBufferViewVarHandle` sounds as if it is not supported at
>> all. We can fix that by borrowing
On Fri, 14 Mar 2025 15:49:44 GMT, Magnus Ihse Bursie wrote:
> We should allow pre-built JVMs to be included in a build, so they are just
> copied into place, and the jvm.cfg file properly updated.
This pull request has been closed without being integrated.
-
PR: https://git.openjd
On Thu, 10 Jul 2025 21:47:35 GMT, Chen Liang wrote:
> Noticed this error when I was verifying all sizes are u2 compatible and
> verified with a test that fails on mainline with ConstantPoolException
> (because we write a size of 2 with 1-length list content) and works in this
> patch. Problem
On Wed, 9 Jul 2025 19:33:38 GMT, Chen Liang wrote:
> Hi all,
>
> This pull request contains a backport of commit
> [c9bea773](https://github.com/openjdk/jdk/commit/c9bea77342672715f8f720d7311d66c2b3ac9f8a)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. #26200
>
> The commit
On Thu, 10 Jul 2025 21:47:35 GMT, Chen Liang wrote:
> Noticed this error when I was verifying all sizes are u2 compatible and
> verified with a test that fails on mainline with ConstantPoolException
> (because we write a size of 2 with 1-length list content) and works in this
> patch. Problem
On Wed, 9 Jul 2025 19:33:38 GMT, Chen Liang wrote:
> Hi all,
>
> This pull request contains a backport of commit
> [c9bea773](https://github.com/openjdk/jdk/commit/c9bea77342672715f8f720d7311d66c2b3ac9f8a)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. #26200
>
> The commit
On Wed, 9 Jul 2025 21:14:17 GMT, Chen Liang wrote:
> Currently, DirectCodeBuilder is erroneously missing argument checks for a few
> of its override methods that take arguments such as Opcode and the array size
> for multianewarray and the switches, which would write something before
> throwin
On Wed, 9 Jul 2025 21:14:17 GMT, Chen Liang wrote:
> Currently, DirectCodeBuilder is erroneously missing argument checks for a few
> of its override methods that take arguments such as Opcode and the array size
> for multianewarray and the switches, which would write something before
> throwin
> In prior JDK releases, `System.console()` could return a `Console` instance
> even when the JVM was not attached to an interactive terminal. This could
> lead to confusion, particularly when input was not from a keyboard or output
> was redirected, such as to or from a file or pipe, especially
On Fri, 11 Jul 2025 19:57:54 GMT, Alexander Matveev
wrote:
> Test updated to expect `jpackage` to PASS in case of
> `--mac-signing-key-user-name` and FAIL in case of
> `-mac-app-image-sign-identity`. See explanation below.
>
> Case 1: Only common name of certificate is used (PASS):
> jpackage
On Fri, 11 Jul 2025 18:46:14 GMT, Naoto Sato wrote:
> In prior JDK releases, `System.console()` could return a `Console` instance
> even when the JVM was not attached to an interactive terminal. This could
> lead to confusion, particularly when input was not from a keyboard or output
> was red
> Changes to address `File.listFiles` invoked on an empty path. This fixes an
> oversight in #22821.
Brian Burkhalter has updated the pull request incrementally with two additional
commits since the last revision:
- 8361587: Address the error directly in listFiles
- 8361587: Revert changes to
Test updated to expect `jpackage` to PASS in case of
`--mac-signing-key-user-name` and FAIL in case of
`-mac-app-image-sign-identity`. See explanation below.
Case 1: Only common name of certificate is used (PASS):
jpackage --type dmg -i input -n Test --main-class components.DynamicTreeDemo
--ma
> This PR implements nth root computation for BigIntegers using Newton method.
fabioromano1 has updated the pull request incrementally with one additional
commit since the last revision:
small change for readability
-
Changes:
- all: https://git.openjdk.org/jdk/pull/24898/files
On Fri, 11 Jul 2025 19:02:31 GMT, Chen Liang wrote:
>> On 32 bit platforms, when an access to long/double is aligned, it is
>> supported but not atomic. The original wording in
>> `MethodHandles::byteBufferViewVarHandle` sounds as if it is not supported at
>> all. We can fix that by borrowing
On Fri, 11 Jul 2025 14:27:21 GMT, Chen Liang wrote:
>> On 32 bit platforms, when an access to long/double is aligned, it is
>> supported but not atomic. The original wording in
>> `MethodHandles::byteBufferViewVarHandle` sounds as if it is not supported at
>> all. We can fix that by borrowing
On Fri, 11 Jul 2025 17:45:01 GMT, Paul Sandoz wrote:
>> Chen Liang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Correct term is atomic, not word tearing
>
> src/java.base/share/classes/java/lang/foreign/MemoryLayout.java line 281:
>
> On 32 bit platforms, when an access to long/double is aligned, it is
> supported but not atomic. The original wording in
> `MethodHandles::byteBufferViewVarHandle` sounds as if it is not supported at
> all. We can fix that by borrowing the improved specification from
> `MemoryLayout::varHandl
In prior JDK releases, `System.console()` could return a `Console` instance
even when the JVM was not attached to an interactive terminal. This could lead
to confusion, particularly when input was not from a keyboard or output was
redirected, such as to or from a file or pipe, especially when us
On Fri, 11 Jul 2025 18:07:31 GMT, fabioromano1 wrote:
>> This PR implements nth root computation for BigIntegers using Newton method.
>
> fabioromano1 has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Avoid to discard fraction bits in the ini
> This PR implements nth root computation for BigIntegers using Newton method.
fabioromano1 has updated the pull request incrementally with one additional
commit since the last revision:
Avoid to discard fraction bits in the initial estimate
-
Changes:
- all: https://git.openjd
Apologies if this has been discussed before.
The explanation for the exception for negative n ("This would cause
the operation to yield a non-integer value.") feels wrong to me. I think
the definition of the result as: x.signum() * floor(abs(nthRoot(x, n)))
works fine for that case, if nthRoot(x,-
On Fri, 11 Jul 2025 09:05:40 GMT, Christian Stein wrote:
> Please review the change to update to using jtreg 8.
>
> The primary change is to the `jib-profiles.js` file, which specifies the
> version of jtreg to use, for those systems that rely on this file. In
> addition, the requiredVersion h
On Fri, 11 Jul 2025 14:27:21 GMT, Chen Liang wrote:
>> On 32 bit platforms, when an access to long/double is aligned, it is
>> supported but not atomic. The original wording in
>> `MethodHandles::byteBufferViewVarHandle` sounds as if it is not supported at
>> all. We can fix that by borrowing
On Fri, 11 Jul 2025 09:05:40 GMT, Christian Stein wrote:
> Please review the change to update to using jtreg 8.
>
> The primary change is to the `jib-profiles.js` file, which specifies the
> version of jtreg to use, for those systems that rely on this file. In
> addition, the requiredVersion h
On Fri, 11 Jul 2025 14:27:21 GMT, Chen Liang wrote:
>> On 32 bit platforms, when an access to long/double is aligned, it is
>> supported but not atomic. The original wording in
>> `MethodHandles::byteBufferViewVarHandle` sounds as if it is not supported at
>> all. We can fix that by borrowing
On Thu, 10 Jul 2025 21:44:32 GMT, Alexander Matveev
wrote:
>> Re-submission of https://github.com/openjdk/jdk/pull/25314 after merge
>> conflict was resolved. Old PR will be closed.
>>
>> All comments are addressed from old PR. Merge conflict was significant, so
>> it is like new fix.
>>
>>
> Re-submission of https://github.com/openjdk/jdk/pull/25314 after merge
> conflict was resolved. Old PR will be closed.
>
> All comments are addressed from old PR. Merge conflict was significant, so it
> is like new fix.
>
> Fixed jpackage to produce valid Java runtimes based on description be
On Fri, 11 Jul 2025 14:27:21 GMT, Chen Liang wrote:
>> On 32 bit platforms, when an access to long/double is aligned, it is
>> supported but not atomic. The original wording in
>> `MethodHandles::byteBufferViewVarHandle` sounds as if it is not supported at
>> all. We can fix that by borrowing
On Fri, 11 Jul 2025 14:03:44 GMT, Adam Sotona wrote:
>> Currently, DirectCodeBuilder is erroneously missing argument checks for a
>> few of its override methods that take arguments such as Opcode and the array
>> size for multianewarray and the switches, which would write something before
>> t
On Fri, 11 Jul 2025 03:45:14 GMT, Xiaohong Gong wrote:
>> Ian Graves has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Adding masked associative tests
>
> src/jdk.incubator.vector/share/classes/jdk/incubator/vector/VectorOperators.java
>
On Fri, 11 Jul 2025 15:31:53 GMT, Nizar Benalla wrote:
>> Once https://bugs.openjdk.org/browse/JDK-8358769 is resolved,
>> JavaBaseCheckSince no longer needs to be problemlisted.
>
> Nizar Benalla has updated the pull request with a new target base due to a
> merge or a rebase. The pull request
On Fri, 11 Jul 2025 07:24:24 GMT, Alan Bateman wrote:
> [...] look to special casing the empty parent in the listFiles methods [...].
Will investigate.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/26224#discussion_r2201046992
> Once https://bugs.openjdk.org/browse/JDK-8358769 is resolved,
> JavaBaseCheckSince no longer needs to be problemlisted.
Nizar Benalla has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains two commits:
- Merge branch 'master' into proble
On Wed, 9 Jul 2025 21:14:17 GMT, Chen Liang wrote:
> Currently, DirectCodeBuilder is erroneously missing argument checks for a few
> of its override methods that take arguments such as Opcode and the array size
> for multianewarray and the switches, which would write something before
> throwin
Hi All,
I believe I've identified a bug in
Executors.AutoShutdownDelegatedExecutorService that can trigger a
classloader leak even in the presence of "correct" Executor lifecycling.
AutoShutdownDelegatedExecutorService only unlinks the PhantomReference used
for cleanup handling when it is shutdown
> This PR implements nth root computation for BigIntegers using Newton method.
fabioromano1 has updated the pull request incrementally with one additional
commit since the last revision:
Optimize the computation of the input's shift
Optimize the computation of the input's shift, in order
> Refactoring `ImageReader` to make it easy to add preview mode functionality
> for Valhalla.
>
> This PR is a large change to `ImageReader` (effectively a rewrite) but
> reduces the surface area of the API significantly, reduces code complexity
> and increases performance/memory efficiency. Th
On Thu, 10 Jul 2025 21:01:18 GMT, Chen Liang wrote:
> The `class` file format often only stores lists up to 65535 in size because
> size is encoded as a u2. Currently, we truncate the list size and write all
> contents, creating malformed `class` files. Almost all scenarios where such
> oversi
On Fri, 11 Jul 2025 13:17:04 GMT, Chen Liang wrote:
>> Right, "word tearing" and "non-atomic access" are different notions.
>
> True, word tearing is racing a single memory location. Good that we
> discovered another spec bug and could fix it in time for 25.
I have changed to use the correct te
On Thu, 10 Jul 2025 21:01:18 GMT, Chen Liang wrote:
> The `class` file format often only stores lists up to 65535 in size because
> size is encoded as a u2. Currently, we truncate the list size and write all
> contents, creating malformed `class` files. Almost all scenarios where such
> oversi
On Fri, 11 Jul 2025 14:25:40 GMT, Chen Liang wrote:
>> The `class` file format often only stores lists up to 65535 in size because
>> size is encoded as a u2. Currently, we truncate the list size and write all
>> contents, creating malformed `class` files. Almost all scenarios where such
>> ov
> On 32 bit platforms, when an access to long/double is aligned, it is
> supported but not atomic. The original wording in
> `MethodHandles::byteBufferViewVarHandle` sounds as if it is not supported at
> all. We can fix that by borrowing the improved specification from
> `MemoryLayout::varHandl
On Thu, 10 Jul 2025 21:47:35 GMT, Chen Liang wrote:
> Noticed this error when I was verifying all sizes are u2 compatible and
> verified with a test that fails on mainline with ConstantPoolException
> (because we write a size of 2 with 1-length list content) and works in this
> patch. Problem
On Thu, 10 Jul 2025 22:32:45 GMT, Chen Liang wrote:
> Currently, the aforementioned two methods do not throw NPE upon null input,
> but throw IAE.
>
> This behavior is bad for composition: `bsmEntry` actually throws IAE for
> nested null in the argument list/array, and other APIs are similarly
On Wed, 9 Jul 2025 21:14:17 GMT, Chen Liang wrote:
> Currently, DirectCodeBuilder is erroneously missing argument checks for a few
> of its override methods that take arguments such as Opcode and the array size
> for multianewarray and the switches, which would write something before
> throwin
On Wed, 9 Jul 2025 19:33:38 GMT, Chen Liang wrote:
> Hi all,
>
> This pull request contains a backport of commit
> [c9bea773](https://github.com/openjdk/jdk/commit/c9bea77342672715f8f720d7311d66c2b3ac9f8a)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. #26200
>
> The commit
On Fri, 6 Jun 2025 08:08:09 GMT, fabioromano1 wrote:
>> This PR implements nth root computation for BigIntegers using Newton method.
>
> fabioromano1 has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Update "since" version
Right.
--
On Fri, 11 Jul 2025 12:38:56 GMT, Raffaello Giulietti
wrote:
> On the other hand, the code contains about 80 lines just to find the initial
> estimate. To ensure that the code is readable and maintainable, it either
> needs to be documented better, possibly with math, or simplified so that the
On Fri, 11 Jul 2025 13:05:09 GMT, Raffaello Giulietti
wrote:
>> src/java.base/share/classes/java/lang/invoke/MethodHandles.java line 4311:
>>
>>> 4309: * access modes {@code get} and {@code set} for {@code long},
>>> {@code
>>> 4310: * double} are supported but might lead to
On Fri, 11 Jul 2025 08:19:43 GMT, Aleksey Shipilev wrote:
>> On 32 bit platforms, when an access to long/double is aligned, it is
>> supported but not atomic. The original wording in
>> `MethodHandles::byteBufferViewVarHandle` sounds as if it is not supported at
>> all. We can fix that by borr
On Fri, 11 Jul 2025 12:45:55 GMT, Matthias Baesken wrote:
> The following is reported when building with the gcc static analyzer
> (-fanalyzer) :
>
>
> /jdk/src/java.base/unix/native/libjava/java_props_md.c:244:17: warning: leak
> of 'temp' [CWE-401] [-Wanalyzer-malloc-leak]
> 244 | return
The following is reported when building with the gcc static analyzer
(-fanalyzer) :
/jdk/src/java.base/unix/native/libjava/java_props_md.c:244:17: warning: leak of
'temp' [CWE-401] [-Wanalyzer-malloc-leak]
244 | return 0;
Seems we have to free temp in an early return.
-
Commit
On Fri, 6 Jun 2025 08:08:09 GMT, fabioromano1 wrote:
>> This PR implements nth root computation for BigIntegers using Newton method.
>
> fabioromano1 has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Update "since" version
Sure, the initial
> Refactoring `ImageReader` to make it easy to add preview mode functionality
> for Valhalla.
>
> This PR is a large change to `ImageReader` (effectively a rewrite) but
> reduces the surface area of the API significantly, reduces code complexity
> and increases performance/memory efficiency. Th
On Fri, 4 Jul 2025 12:40:43 GMT, Andrey Turbanov wrote:
>> David Beaumont has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Feedback related changes.
>
> src/java.base/share/classes/jdk/internal/jimage/ImageReader.java line 193:
>
>> 191:
Bug reference: https://bugs.openjdk.org/browse/JDK-8361697
The following message is removed:
`
MSG_BundlerFailed=Error: Bundler "{1}" ({0}) failed to produce a package`
Signed-off-by: Pooja.D.P1
-
Commit messages:
- Update MainResources.properties with duplicate message removal
On Wed, 9 Jul 2025 05:45:01 GMT, Erik Gahlin wrote:
> Could I have a review of the change that prevents RandomAccessFile::readLine
> from emitting an event per character? This leads to unnecessary overhead,
> both with or without JFR enabled.
>
> Testing: tier1 + tier2 + jdk/jdk/jfr
>
> Than
Please review the change to update to using jtreg 8.
The primary change is to the `jib-profiles.js` file, which specifies the
version of jtreg to use, for those systems that rely on this file. In addition,
the requiredVersion has been updated in the various `TEST.ROOT` files.
-
Com
On Thu, 10 Jul 2025 20:54:24 GMT, John R Rose wrote:
>> Validate input in `java.lang.StringCoding` intrinsic Java wrappers, improve
>> their documentation, enhance the checks in the associated IR or assembly
>> code, and adapt them to cause VM crash on invalid input.
>>
>> ## Implementation no
On Thu, 10 Jul 2025 23:40:15 GMT, Chen Liang wrote:
> On 32 bit platforms, when an access to long/double is aligned, it is
> supported but not atomic. The original wording in
> `MethodHandles::byteBufferViewVarHandle` sounds as if it is not supported at
> all. We can fix that by borrowing the
On Thu, 10 Jul 2025 22:47:12 GMT, Brian Burkhalter wrote:
>> Changes to address `File.listFiles` invoked on an empty path. This fixes an
>> oversight in #22821.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8361587:
63 matches
Mail list logo
