Assuming the test code and my reading of the mapConcurrent() code haven't
misled me, I think this observation suggests that if an *upstream exception*
terminates the stream, mapConcurrent() may not be able to properly cancel
or interrupt the virtual threads it has already started. This could
potent
Please review this change that removes the class jdk.internal.ref.Cleaner.
It is no longer used after JDK-8344332.
Testing: mach5 tier1-3
-
Commit messages:
- remove jdk.internal.ref.Cleaner
Changes: https://git.openjdk.org/jdk/pull/26141/files
Webrev: https://webrevs.openjdk.org
Yes.
I got two tests that show the behavior difference between downstream
exception and upstream exception:
@Test public void mapConcurrently_upstreamFailureDoesNotInterrupt() {
ConcurrentLinkedQueue started = new ConcurrentLinkedQueue<>();
ConcurrentLinkedQueue interrupted = new ConcurrentLin
On Wed, 2 Jul 2025 11:00:44 GMT, Manuel Hässig wrote:
> When a check in `CommandLineOptionTest` fails, the `AssertionError` message
> contains the expected value, but not the observed value. To reduce the amount
> of digging in the logs we have to do when analyzing a failure, this PR adds
> th
On Wed, 2 Jul 2025 11:00:44 GMT, Manuel Hässig wrote:
> When a check in `CommandLineOptionTest` fails, the `AssertionError` message
> contains the expected value, but not the observed value. To reduce the amount
> of digging in the logs we have to do when analyzing a failure, this PR adds
> th
On Wed, 2 Jul 2025 13:54:02 GMT, David Beaumont wrote:
>> Refactoring `ImageReader` to make it easy to add preview mode functionality
>> for Valhalla.
>>
>> This PR is a large change to `ImageReader` (effectively a rewrite) but
>> reduces the surface area of the API significantly, reduces code
On Wed, 2 Jul 2025 07:47:31 GMT, Daniel Jeliński wrote:
>> src/java.base/share/classes/sun/security/ssl/X509Authentication.java line
>> 224:
>>
>>> 222: // TODO in future, when QuicTLSEngine might become a
>>> public exported interface
>>> 223: // we should have a metho
On Fri, 4 Jul 2025 09:11:40 GMT, Andrew Haley wrote:
> This looks good. Thanks.
Thanks so much for your review!
-
PR Comment: https://git.openjdk.org/jdk/pull/26057#issuecomment-3035115512
On Thu, 3 Jul 2025 06:10:28 GMT, Xiaohong Gong wrote:
>> ### Background
>> On AArch64, the minimum vector length supported is 64-bit for basic types,
>> except for `byte` and `boolean` (32-bit and 16-bit respectively to match
>> special Vector API features). This limitation prevents intrinsific
