Re: RFR: 8359732: Make standard i/o encoding related system properties `StaticProperty` [v4]

2025-06-20 Thread Alan Bateman
On Fri, 20 Jun 2025 18:44:47 GMT, Naoto Sato wrote: >> Refactored the internal handling of `stdin/out/err.encoding` to allow >> setting them only via command-line options by converting them into >> `StaticProperty`. This change prevents unexpected behavior caused by >> applications modifying t

Re: RFR: 8359732: Make standard i/o encoding related system properties `StaticProperty` [v4]

2025-06-20 Thread Roger Riggs
On Fri, 20 Jun 2025 18:44:47 GMT, Naoto Sato wrote: >> Refactored the internal handling of `stdin/out/err.encoding` to allow >> setting them only via command-line options by converting them into >> `StaticProperty`. This change prevents unexpected behavior caused by >> applications modifying t

Re: RFR: 8359919: Minor java.util.concurrent doc improvements [v8]

2025-06-20 Thread Alan Bateman
On Thu, 19 Jun 2025 22:49:17 GMT, Doug Lea wrote: >> This collects miscellaneous open issues that can be resolved with >> documentation updates; each indicated by adding JDK issue numbers > > Doug Lea has updated the pull request incrementally with one additional > commit since the last revisio

Re: RFR: 8359732: Make standard i/o encoding related system properties `StaticProperty` [v3]

2025-06-20 Thread Naoto Sato
On Thu, 19 Jun 2025 11:03:43 GMT, Alan Bateman wrote: > Latest version looks okay but I think better to drop the change to > System.initPhase1. Reverted the changes in the `System` class. Also, there were two sites that used `StaticProperty` class outside the `java.base` module. I replaced the

Re: RFR: 8359732: Make standard i/o encoding related system properties `StaticProperty` [v4]

2025-06-20 Thread Naoto Sato
> Refactored the internal handling of `stdin/out/err.encoding` to allow setting > them only via command-line options by converting them into `StaticProperty`. > This change prevents unexpected behavior caused by applications modifying > these properties at runtime using `System.setProperty()`.

Re: RFR: 8359919: Minor java.util.concurrent doc improvements [v8]

2025-06-20 Thread Alan Bateman
On Thu, 19 Jun 2025 22:49:17 GMT, Doug Lea wrote: >> This collects miscellaneous open issues that can be resolved with >> documentation updates; each indicated by adding JDK issue numbers > > Doug Lea has updated the pull request incrementally with one additional > commit since the last revisio

Re: RFR: 8359919: Minor java.util.concurrent doc improvements [v8]

2025-06-20 Thread Doug Lea
On Fri, 20 Jun 2025 13:00:52 GMT, Alan Bateman wrote: >> Doug Lea has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Adding JDK-8333172 to doc improvements > > src/java.base/share/classes/java/util/concurrent/SubmissionPublisher.java > lin

Re: RFR: 8359919: Minor java.util.concurrent doc improvements [v8]

2025-06-20 Thread Alan Bateman
On Thu, 19 Jun 2025 22:49:17 GMT, Doug Lea wrote: >> This collects miscellaneous open issues that can be resolved with >> documentation updates; each indicated by adding JDK issue numbers > > Doug Lea has updated the pull request incrementally with one additional > commit since the last revisio

Re: RFR: 8359919: Minor java.util.concurrent doc improvements [v10]

2025-06-20 Thread Pavel Rappo
On Fri, 20 Jun 2025 15:54:49 GMT, Doug Lea wrote: >> This collects miscellaneous open issues that can be resolved with >> documentation updates; each indicated by adding JDK issue numbers > > Doug Lea has updated the pull request incrementally with one additional > commit since the last revisio

Re: RFR: 8358533: Improve performance of java.io.Reader.readAllLines

2025-06-20 Thread Xueming Shen
On Fri, 20 Jun 2025 15:52:08 GMT, Roger Riggs wrote: >> My suggestion is to call `new StringBuilder(0)` as it is possible this is >> completely unused because we always hit the `eol && sb.length() == 0` path >> below. > > The change is motivated by performance, but there will be many inputs tha

Re: RFR: 8359919: Minor java.util.concurrent doc improvements [v10]

2025-06-20 Thread Doug Lea
> This collects miscellaneous open issues that can be resolved with > documentation updates; each indicated by adding JDK issue numbers Doug Lea has updated the pull request incrementally with one additional commit since the last revision: Fix ARFU type; add JDK-7176957 - Change

Re: RFR: 8358533: Improve performance of java.io.Reader.readAllLines

2025-06-20 Thread Chen Liang
On Thu, 19 Jun 2025 10:53:14 GMT, Markus KARG wrote: >>> Is there a reason for this pre-allocation? >> >> What would you suggest? Start with a smaller allocation and increase it if >> needed? There is no possibility of knowing the length of the stream. > > As this PR explicitly targets performa

Re: RFR: 8358533: Improve performance of java.io.Reader.readAllLines

2025-06-20 Thread Roger Riggs
On Fri, 20 Jun 2025 15:50:53 GMT, Chen Liang wrote: >> As this PR explicitly targets performance and as the aim of this method is >> to keep **all** content in-memory anyways, I wonder if it would be >> acceptable and even faster to pre-allocate `new >> StringBuilder(TRANSFER_BUFFER_SIZE)`? In

Re: RFR: 8359919: Minor java.util.concurrent doc improvements [v8]

2025-06-20 Thread Pavel Rappo
On Fri, 20 Jun 2025 13:50:08 GMT, Doug Lea wrote: >> src/java.base/share/classes/java/util/concurrent/atomic/AtomicReferenceFieldUpdater.java >> line 86: >> >>> 84: * } >>> 85: * // ... and so on >>> 86: * }} >> >> I wonder if this should be convert to a `{@snippet ..}` and have it hand

Re: RFR: 8359919: Minor java.util.concurrent doc improvements [v8]

2025-06-20 Thread Alan Bateman
On Thu, 19 Jun 2025 22:49:17 GMT, Doug Lea wrote: >> This collects miscellaneous open issues that can be resolved with >> documentation updates; each indicated by adding JDK issue numbers > > Doug Lea has updated the pull request incrementally with one additional > commit since the last revisio

Re: RFR: 8359732: Make standard i/o encoding related system properties `StaticProperty` [v3]

2025-06-20 Thread Roger Riggs
On Wed, 18 Jun 2025 18:24:43 GMT, Naoto Sato wrote: >> Refactored the internal handling of `stdin/out/err.encoding` to allow >> setting them only via command-line options by converting them into >> `StaticProperty`. This change prevents unexpected behavior caused by >> applications modifying t

Re: RFR: 8359919: Minor java.util.concurrent doc improvements [v9]

2025-06-20 Thread Doug Lea
> This collects miscellaneous open issues that can be resolved with > documentation updates; each indicated by adding JDK issue numbers Doug Lea has updated the pull request incrementally with one additional commit since the last revision: Address review comments; add JDK-6374942 ---

Re: RFR: 8359735: [Ubuntu 25.10] java/lang/ProcessBuilder/Basic.java, java/lang/ProcessHandle/InfoTest.java fail due to rust-coreutils

2025-06-20 Thread Roger Riggs
On Mon, 16 Jun 2025 22:49:02 GMT, Vladimir Petko wrote: > To accommodate systems like Ubuntu 25.10 that use Rust coreutils, this PR > updates tests that previously assumed BusyBox was the only environment to use > symlinks for core utilities. > > Changes: > - `java/lang/ProcessBuilder/Basic.

Re: RFR: 8359919: Minor java.util.concurrent doc improvements [v8]

2025-06-20 Thread Doug Lea
On Thu, 19 Jun 2025 09:39:05 GMT, Viktor Klang wrote: >> Doug Lea has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Adding JDK-8333172 to doc improvements > > src/java.base/share/classes/java/util/concurrent/CompletionStage.java line > 15

Re: RFR: 8359919: Minor java.util.concurrent doc improvements [v8]

2025-06-20 Thread Doug Lea
On Fri, 20 Jun 2025 12:10:42 GMT, Alan Bateman wrote: >> Doug Lea has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Adding JDK-8333172 to doc improvements > > src/java.base/share/classes/java/util/concurrent/TimeUnit.java line 402: > >> 4

Integrated: 8359735: [Ubuntu 25.10] java/lang/ProcessBuilder/Basic.java, java/lang/ProcessHandle/InfoTest.java fail due to rust-coreutils

2025-06-20 Thread Vladimir Petko
On Mon, 16 Jun 2025 22:49:02 GMT, Vladimir Petko wrote: > To accommodate systems like Ubuntu 25.10 that use Rust coreutils, this PR > updates tests that previously assumed BusyBox was the only environment to use > symlinks for core utilities. > > Changes: > - `java/lang/ProcessBuilder/Basic.

Re: RFR: 8359919: Minor java.util.concurrent doc improvements [v8]

2025-06-20 Thread Doug Lea
On Fri, 20 Jun 2025 12:47:43 GMT, Alan Bateman wrote: >> Doug Lea has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Adding JDK-8333172 to doc improvements > > src/java.base/share/classes/java/util/concurrent/ScheduledExecutorService.java >

Re: RFR: 8359919: Minor java.util.concurrent doc improvements [v8]

2025-06-20 Thread Pavel Rappo
On Thu, 19 Jun 2025 10:51:35 GMT, Doug Lea wrote: >> @pavelrappo Indeed, "Reactive Streams" would be better. Perhaps something >> like this: >> >> Suggestion: >> >> * fully conform to the Reactive Streams specification. > > Thanks; done. Nit of a nit: would it make sense to also change "reac

Re: RFR: 8359919: Minor java.util.concurrent doc improvements [v8]

2025-06-20 Thread Alan Bateman
On Thu, 19 Jun 2025 22:49:17 GMT, Doug Lea wrote: >> This collects miscellaneous open issues that can be resolved with >> documentation updates; each indicated by adding JDK issue numbers > > Doug Lea has updated the pull request incrementally with one additional > commit since the last revisio