Re: RFR: 8359919: Minor java.util.concurrent doc improvements [v8]

2025-06-19 Thread Doug Lea
> This collects miscellaneous open issues that can be resolved with > documentation updates; each indicated by adding JDK issue numbers Doug Lea has updated the pull request incrementally with one additional commit since the last revision: Adding JDK-8333172 to doc improvements -

Re: RFR: 8359919: Minor java.util.concurrent doc improvements [v7]

2025-06-19 Thread Doug Lea
> This collects miscellaneous open issues that can be resolved with > documentation updates; each indicated by adding JDK issue numbers Doug Lea has updated the pull request incrementally with one additional commit since the last revision: Add JDK-8195628 doc fix - Changes: -

Re: RFR: 8359761: JDK 25 RDP1 L10n resource files update [v2]

2025-06-19 Thread Johannes Döbler
On Wed, 18 Jun 2025 15:25:42 GMT, Alexey Ivanov wrote: >> Alisen Chung has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fix unicode escapes > > src/java.base/share/classes/sun/security/tools/keytool/resources/keytool_de.properties > line

Re: RFR: 8359919: Minor java.util.concurrent doc improvements [v6]

2025-06-19 Thread Doug Lea
> This collects miscellaneous open issues that can be resolved with > documentation updates; each indicated by adding JDK issue numbers Doug Lea has updated the pull request incrementally with one additional commit since the last revision: Add JDK-6317534 and JDK-6351533 doc improvements ---

Re: RFR: 8359919: Minor java.util.concurrent doc improvements [v5]

2025-06-19 Thread Viktor Klang
On Thu, 19 Jun 2025 11:58:33 GMT, Doug Lea wrote: >> This collects miscellaneous open issues that can be resolved with >> documentation updates; each indicated by adding JDK issue numbers > > Doug Lea has updated the pull request incrementally with one additional > commit since the last revisio

Re: RFR: 8359830: Incorrect os.version reported on macOS Tahoe 26 (Beta)

2025-06-19 Thread Alan Bateman
On Wed, 18 Jun 2025 06:01:43 GMT, Jaikiran Pai wrote: > Can I please get a review of this change which proposes to address the issue > noted in https://bugs.openjdk.org/browse/JDK-8359830? > > macOS operating system's newer version 26 (currently in Beta) is reported as > a 16 by older versions

Re: RFR: 8359936: StableValues can release the underlying function after complete computation [v3]

2025-06-19 Thread Per Minborg
On Thu, 19 Jun 2025 11:01:28 GMT, ExE Boss wrote: >> Per Minborg has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains eight additional >> commits sin

Re: RFR: 8359936: StableValues can release the underlying function after complete computation [v3]

2025-06-19 Thread Per Minborg
On Thu, 19 Jun 2025 09:59:41 GMT, Per Minborg wrote: >> This PR proposes to release the underlying function if a stable function or >> collection has invoked its underlying supplier exhaustively so that it can >> be collected. >> >> This PR passes tier1, tier2, and tier3 testing on multiple pl

Re: Interest in Java based attach provider implementation?

2025-06-19 Thread Magnus Ihse Bursie
Hi Philippe, There is an ongoing effort about "Panamization" (that is, adapting it to use FFM instead of JNI) of native code in the JDK in general. This is discussed on the core-libs-dev mailing list. I've cc:ed them. I think it would be beneficial if you coordinate your efforts with the Panam

Re: Gatherer JavaDoc

2025-06-19 Thread Viktor Klang
Hi Cay! Thanks for the questions, see my responses below: >1. "Gatherers whose integrator is an instance of Gatherer.Integrator.Greedy >can be >assumed not to short-circuit, *and the return value of invoking >>Gatherer.Integrator.integrate(Object, Object, Downstream) does not need to be >>insp

Re: RFR: 8359919: Minor java.util.concurrent doc improvements [v5]

2025-06-19 Thread Doug Lea
> This collects miscellaneous open issues that can be resolved with > documentation updates; each indicated by adding JDK issue numbers Doug Lea has updated the pull request incrementally with one additional commit since the last revision: Add JDK-8190889 docfix - Changes: - a

Re: RFR: 8359919: Minor java.util.concurrent doc improvements [v4]

2025-06-19 Thread Doug Lea
> This collects miscellaneous open issues that can be resolved with > documentation updates; each indicated by adding JDK issue numbers Doug Lea has updated the pull request incrementally with one additional commit since the last revision: Add JDK-8186959 docfix - Changes: - a

Re: RFR: 8359919: Minor java.util.concurrent doc improvements [v3]

2025-06-19 Thread Doug Lea
> This collects miscellaneous open issues that can be resolved with > documentation updates; each indicated by adding JDK issue numbers Doug Lea has updated the pull request incrementally with one additional commit since the last revision: Add JDK-8353155 doc improvement - Chang

Re: RFR: 8358533: Improve performance of java.io.Reader.readAllLines

2025-06-19 Thread Markus KARG
On Wed, 18 Jun 2025 00:04:37 GMT, Brian Burkhalter wrote: > Replaces the implementation `readAllCharsAsString().lines().toList()` with > reading into a temporary `char` array which is then processed to detect line > terminators and copy non-terminating characters into strings which are added >

Re: RFR: 8358533: Improve performance of java.io.Reader.readAllLines

2025-06-19 Thread Markus KARG
On Wed, 18 Jun 2025 16:57:22 GMT, Brian Burkhalter wrote: >> src/java.base/share/classes/java/io/Reader.java line 455: >> >>> 453: List lines = new ArrayList(); >>> 454: >>> 455: StringBuilder sb = new StringBuilder(82); >> >> Is there a reason for this pre-allocation? If the w

Re: RFR: 8358533: Improve performance of java.io.Reader.readAllLines

2025-06-19 Thread Markus KARG
On Wed, 18 Jun 2025 16:45:33 GMT, Brian Burkhalter wrote: >> I think we should treat "\r\n" as a single line terminator? for example >> >> "hello\r\nworld".lines().forEach(line -> out.format("[%s]\n", line)); >> => >> [hello] >> [world] >> >> instead of (the current impl) >> >> [hello] >> []

Re: RFR: 8359919: Minor java.util.concurrent doc improvements [v2]

2025-06-19 Thread Doug Lea
On Thu, 19 Jun 2025 09:42:01 GMT, Viktor Klang wrote: >> Doug Lea has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Address review comments > > src/java.base/share/classes/java/util/concurrent/CompletionStage.java line > 155: > >> 153:

Re: RFR: 8359919: Minor java.util.concurrent doc improvements [v2]

2025-06-19 Thread Doug Lea
> This collects miscellaneous open issues that can be resolved with > documentation updates; each indicated by adding JDK issue numbers Doug Lea has updated the pull request incrementally with one additional commit since the last revision: Address review comments - Changes: -

Re: RFR: 8359936: StableValues can release the underlying function after complete computation [v3]

2025-06-19 Thread ExE Boss
On Thu, 19 Jun 2025 09:59:41 GMT, Per Minborg wrote: >> This PR proposes to release the underlying function if a stable function or >> collection has invoked its underlying supplier exhaustively so that it can >> be collected. >> >> This PR passes tier1, tier2, and tier3 testing on multiple pl

Re: RFR: 8359732: Make standard i/o encoding related system properties `StaticProperty` [v3]

2025-06-19 Thread Alan Bateman
On Wed, 18 Jun 2025 18:24:43 GMT, Naoto Sato wrote: >> Refactored the internal handling of `stdin/out/err.encoding` to allow >> setting them only via command-line options by converting them into >> `StaticProperty`. This change prevents unexpected behavior caused by >> applications modifying t

Re: On Period and DateTimeFormatter

2025-06-19 Thread Stephen Colebourne
The term "Period" derives from early versions of ISO-8601. You will note that the standard ISO-8601 format for Period is P1Y2M3D, where the "P" stands for "Period". The spec has changed over time. The original 1998 version [1] is where Joda-Time, and thus Java-Time derive their names. The 2016 ver

Re: RFR: 8359919: Minor java.util.concurrent doc improvements

2025-06-19 Thread Doug Lea
On Thu, 19 Jun 2025 09:36:19 GMT, Viktor Klang wrote: >> This collects miscellaneous open issues that can be resolved with >> documentation updates; each indicated by adding JDK issue numbers > > src/java.base/share/classes/java/util/concurrent/CompletionStage.java line > 103: > >> 101: * cau

Re: RFR: 8359919: Minor java.util.concurrent doc improvements

2025-06-19 Thread Doug Lea
On Thu, 19 Jun 2025 09:32:43 GMT, Viktor Klang wrote: >> src/java.base/share/classes/java/util/concurrent/Flow.java line 64: >> >>> 62: * control required in most implementations (for example {@link >>> 63: * SubmissionPublisher}), and omits some error processing needed to >>> 64: * fully con

Gatherer JavaDoc

2025-06-19 Thread Cay Horstmann
Hi, I have trio of minor questions about the Gatherer JavaDoc at https://download.java.net/java/early_access/jdk25/docs/api/java.base/java/util/stream/Gatherer.html 1. "Gatherers whose integrator is an instance of Gatherer.Integrator.Greedy can be assumed not to short-circuit, *and the return v

Re: RFR: 8359936: StableValues can release the underlying function after complete computation [v3]

2025-06-19 Thread Per Minborg
> This PR proposes to release the underlying function if a stable function or > collection has invoked its underlying supplier exhaustively so that it can be > collected. > > This PR passes tier1, tier2, and tier3 testing on multiple platforms. Per Minborg has updated the pull request with a ne

Re: RFR: 8359919: Minor java.util.concurrent doc improvements

2025-06-19 Thread Viktor Klang
On Wed, 18 Jun 2025 17:51:20 GMT, Doug Lea wrote: > This collects miscellaneous open issues that can be resolved with > documentation updates; each indicated by adding JDK issue numbers src/java.base/share/classes/java/util/concurrent/CompletionStage.java line 103: > 101: * cause. This distin

Re: RFR: 8359919: Minor java.util.concurrent doc improvements

2025-06-19 Thread Viktor Klang
On Wed, 18 Jun 2025 18:25:39 GMT, Pavel Rappo wrote: >> This collects miscellaneous open issues that can be resolved with >> documentation updates; each indicated by adding JDK issue numbers > > src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java line 143: > >> 141: * that take

Re: RFR: 8359919: Minor java.util.concurrent doc improvements

2025-06-19 Thread Viktor Klang
On Wed, 18 Jun 2025 18:55:19 GMT, Pavel Rappo wrote: >> This collects miscellaneous open issues that can be resolved with >> documentation updates; each indicated by adding JDK issue numbers > > src/java.base/share/classes/java/util/concurrent/Flow.java line 64: > >> 62: * control required in

Re: RFR: 8359936: StableValues can release the underlying function after complete computation [v2]

2025-06-19 Thread Per Minborg
On Thu, 19 Jun 2025 08:57:44 GMT, Viktor Klang wrote: >> Per Minborg has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix performance regression > > src/java.base/share/classes/jdk/internal/lang/stable/StableValueImpl.java > line 150: >

Re: RFR: 8359936: StableValues can release the underlying function after complete computation [v2]

2025-06-19 Thread Viktor Klang
On Thu, 19 Jun 2025 06:59:31 GMT, Per Minborg wrote: >> This PR proposes to release the underlying function if a stable function or >> collection has invoked its underlying supplier exhaustively so that it can >> be collected. >> >> This PR passes tier1, tier2, and tier3 testing on multiple pl

Integrated: 8359123: Misleading examples in jmod man page

2025-06-19 Thread Ana Maria Mihalceanu
On Thu, 12 Jun 2025 07:57:20 GMT, Ana Maria Mihalceanu wrote: > Please review my PR. This PR includes the following: > > - [x] Fix a small typo in a word and copyright. > - [x] Enhance description for `--target-platform`. > - [x] Rearrange `jmod create` example from basic to complex. This pull