> This PR proposes to release the underlying function if a stable function or
> collection has invoked its underlying supplier exhaustively so that it can be
> collected.
>
> This PR passes tier1, tier2, and tier3 testing on multiple platforms.
Per Minborg has updated the pull request increment
On Wed, 18 Jun 2025 07:17:13 GMT, Ana Maria Mihalceanu wrote:
>> Please review my PR. This PR includes the following:
>>
>> - [x] Fix a small typo in a word and copyright.
>> - [x] Enhance description for `--target-platform`.
>> - [x] Rearrange `jmod create` example from basic to complex.
>
> An
I can certainly agree that there might have been a better name than Period.
I like your suggestion, and I would even go further and suggest that
Interval would have been a better term.
But Period is certainly acceptable. It captures the meaning well enough --
a period of time between 2 events.
ht
On Wed, 18 Jun 2025 14:45:32 GMT, Alexey Ivanov wrote:
>> Alisen Chung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix unicode escapes
>
> src/demo/share/jfc/SwingSet2/resources/swingset_de.properties line 460:
>
>> 458: SliderDemo.
Improve the documentation of Process use of system resources.
Describe the implementation closing streams when no longer referenced.
Clarify the interactions between inputStream and inputReader and errorStream
and errorReader.
Add advice and example using try-with-resources to open and close stre
On Wed, 18 Jun 2025 17:51:20 GMT, Doug Lea wrote:
> This collects miscellaneous open issues that can be resolved with
> documentation updates; each indicated by adding JDK issue numbers
src/java.base/share/classes/java/util/concurrent/Flow.java line 64:
> 62: * control required in most implem
On Tue, 17 Jun 2025 23:15:05 GMT, Justin Lu wrote:
>> Alisen Chung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> remove double quotes
>
> src/jdk.jdi/share/classes/com/sun/tools/example/debug/tty/TTYResources_de.java
> line 2:
>
>> 1
Hi Pavel,
On 6/18/25 4:29 AM, Pavel Rappo wrote:
The second question is about DateTimeFormatter. I recently had to
parse a date that resembles output of asctime: Sat Jul 16 02:03:55
+ 1994. It's fine and dandy until you parse a date in September.
That time format expects "Sep", while the for
> This issue is responsible for updating the translations of all the
> localize(able) resources in the JDK since the previous L10n drop.
Alisen Chung has updated the pull request incrementally with one additional
commit since the last revision:
remove double quotes
-
Changes:
On Wed, 18 Jun 2025 17:51:20 GMT, Doug Lea wrote:
> This collects miscellaneous open issues that can be resolved with
> documentation updates; each indicated by adding JDK issue numbers
src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java line 143:
> 141: * that take too long. T
On Wed, 18 Jun 2025 07:08:21 GMT, Volkan Yazici wrote:
> I've verified that all relevant occurrences of `std{in,err,out}.encoding` are
> covered, except the ones `src/java.base/share/classes/java/lang/System.java`,
> which, I presume, is left out intentionally.
Initially I left them as it is t
> Refactored the internal handling of `stdin/out/err.encoding` to allow setting
> them only via command-line options by converting them into `StaticProperty`.
> This change prevents unexpected behavior caused by applications modifying
> these properties at runtime using `System.setProperty()`.
On Wed, 18 Jun 2025 17:51:20 GMT, Doug Lea wrote:
> This collects miscellaneous open issues that can be resolved with
> documentation updates; each indicated by adding JDK issue numbers
I think the problem in `AtomicReferenceFieldUpdater` being passed a static
field exists for the other kinds
This collects miscellaneous open issues that can be resolved with documentation
updates; each indicated by adding JDK issue numbers
-
Commit messages:
- Revert
- Merge remote-tracking branch 'refs/remotes/origin/master' into JDK-8359919
- Initial set of doc updates
- Merge branch
On Wed, 18 Jun 2025 15:03:06 GMT, Roger Riggs wrote:
>> src/java.base/share/classes/module-info.java line 287:
>>
>>> 285: jdk.jpackage,
>>> 286: jdk.jshell,
>>> 287: jdk.net;
>>
>> At some point we will need to re-visit all these qualified exports so that
>> java.base
> Refactored the internal handling of `stdin/out/err.encoding` to allow setting
> them only via command-line options by converting them into `StaticProperty`.
> This change prevents unexpected behavior caused by applications modifying
> these properties at runtime using `System.setProperty()`.
Period is like Duration - they are both "lengths of time", just using
different units (so they are both a TemporalAmount).
Similar to how LocalDateTime vs. Instant are both "points in time", just
using different units (so they are both a Temporal).
But you bring up a good point - perhaps Calendar
We are talking about a period, not an interval. I used the word
"interval" in my previous email in the sense close to that def. #5
from your dictionary link:
> : a set of real numbers between two numbers either including or excluding one
> or both of them
So to me, an interval between two dates
On Wed, 18 Jun 2025 02:26:48 GMT, Chen Liang wrote:
> Is there a reason for this pre-allocation?
What would you suggest? Start with a smaller allocation and increase it if
needed? There is no possibility of knowing the length of the stream.
-
PR Review Comment: https://git.openjdk
On Wed, 18 Jun 2025 09:47:57 GMT, Joel Sikström wrote:
> Should the other localizations for the launcher help text (in
> `launcher_.properties`) also be updated? I see that only the German,
> Japanese and Chinese localizations have been updated so far.
Those languages (de/ja/zh-CN) are the one
On Wed, 18 Jun 2025 02:38:04 GMT, Chen Liang wrote:
> Edit: No, we need to check empty lines.
Right. I caught this during testing.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/25863#discussion_r2155088265
On Wed, 18 Jun 2025 06:01:43 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which proposes to address the issue
> noted in https://bugs.openjdk.org/browse/JDK-8359830?
>
> macOS operating system's newer version 26 (currently in Beta) is reported as
> a 16 by older versions
On Wed, 18 Jun 2025 02:33:40 GMT, Xueming Shen wrote:
> I think we should treat "\r\n" as a single line terminator?
You are correct: that needs to be fixed:
jshell> Reader r = new StringReader("hello\r\nworld")
r ==> java.io.StringReader@480bdb19
jshell> r.readAllLines()
$3 ==> [hello, , world
On Wed, 18 Jun 2025 16:25:29 GMT, Justin Lu wrote:
>> src/demo/share/jfc/SwingSet2/resources/swingset_de.properties line 1:
>>
>>> 1: # Copyright (c) 2010, 2022, Oracle and/or its affiliates. All rights
>>> reserved.
>>
>> Shall the copyright year be updated?
>
> In the past, we usually don't
On Wed, 18 Jun 2025 15:34:38 GMT, Alexey Ivanov wrote:
>> Alisen Chung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix unicode escapes
>
> src/demo/share/jfc/SwingSet2/resources/swingset_de.properties line 1:
>
>> 1: # Copyright (c)
On Wed, 18 Jun 2025 15:28:49 GMT, Alexey Ivanov wrote:
>> Alisen Chung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix unicode escapes
>
> src/java.base/share/classes/sun/security/util/resources/security_zh_CN.properties
> line 56:
On Tue, 17 Jun 2025 23:34:52 GMT, Alisen Chung wrote:
>> This issue is responsible for updating the translations of all the
>> localize(able) resources in the JDK since the previous L10n drop.
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the las
This PR proposes to release the underlying function if a stable function or
collection has invoked its underlying supplier exhaustively so that it can be
collected.
-
Commit messages:
- Clean up
- Fix bug
- Simplify
- Revert to records
- Make code more like the old one
- Add r
On Tue, 17 Jun 2025 21:47:49 GMT, Justin Lu wrote:
>> Please review this PR which finishes Applet removal for the test:
>> jdk/internal/loader/URLClassPath/ClassnameCharTest.java.
>>
>> `testclasses.jar` is updated such that the two classes no longer extend
>> Applet.
>>
>>
>> $ javap fo\ o.
How does it not model an interval?
Here is the official documentation.
*Obtains a Period consisting of the number of years, months, and days
between two dates.*
https://docs.oracle.com/en/java/javase/24/docs/api/java.base/java/time/Period.html#between(java.time.LocalDate,java.time.LocalDate)
An
On Wed, 18 Jun 2025 07:50:31 GMT, Alan Bateman wrote:
>> Refactored the internal handling of `stdin/out/err.encoding` to allow
>> setting them only via command-line options by converting them into
>> `StaticProperty`. This change prevents unexpected behavior caused by
>> applications modifying
On Tue, 17 Jun 2025 20:16:05 GMT, Naoto Sato wrote:
> Refactored the internal handling of `stdin/out/err.encoding` to allow setting
> them only via command-line options by converting them into `StaticProperty`.
> This change prevents unexpected behavior caused by applications modifying
> these
On Wed, 18 Jun 2025 06:01:43 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which proposes to address the issue
> noted in https://bugs.openjdk.org/browse/JDK-8359830?
>
> macOS operating system's newer version 26 (currently in Beta) is reported as
> a 16 by older versions
On Wed, 18 Jun 2025 09:20:12 GMT, Shaojin Wen wrote:
> If we want better performance, we should go a step further and overload the
> readAllLines method in the Reader implementation class.
Perhaps, but not in this request. A separate issue should be filed and
addressed subsequently.
-
On Wed, 18 Jun 2025 06:01:43 GMT, Jaikiran Pai wrote:
> Existing tests in tier1, tier2 and tier3 continue to pass with this change.
> If anyone has access to a macOS 26 Beta, I request them to build this change
> and run tier1 tests to help verify that there aren't any failures.
I got access t
Hello, I have two questions on java.time API.
The first one is about documentation for java.time.Period. When I get
back to the API after a long period (no pun intended) of not using it,
it takes me a while to recall that Period does __NOT__ model an
interval between two specific points in time, s
On Sun, 8 Jun 2025 09:07:11 GMT, He-Pin(kerr) wrote:
> Rename auxilliary to auxiliary
This pull request has now been integrated.
Changeset: f07f5ce9
Author:He-Pin(kerr)
Committer: Viktor Klang
URL:
https://git.openjdk.org/jdk/commit/f07f5ce9845c59348dc785cd5ee26391dd7e36c8
Stats:
On Sun, 8 Jun 2025 09:07:11 GMT, He-Pin(kerr) wrote:
> Rename auxilliary to auxiliary
@He-Pin please /integrate
-
PR Comment: https://git.openjdk.org/jdk/pull/25685#issuecomment-2983757923
On Tue, 17 Jun 2025 23:34:52 GMT, Alisen Chung wrote:
>> This issue is responsible for updating the translations of all the
>> localize(able) resources in the JDK since the previous L10n drop.
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the las
On Wed, 26 Mar 2025 07:54:48 GMT, Jan Lahoda wrote:
> The `java.io.Console` has several backends: a simple on in `java.base`, a
> more convenient one in `jdk.internal.le` (with line-reading based on JLine)
> and one for JShell.
>
> The backend based on JLine is proving to be a somewhat problem
On Tue, 17 Jun 2025 23:34:52 GMT, Alisen Chung wrote:
>> This issue is responsible for updating the translations of all the
>> localize(able) resources in the JDK since the previous L10n drop.
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the las
On Wed, 18 Jun 2025 00:04:37 GMT, Brian Burkhalter wrote:
> Replaces the implementation `readAllCharsAsString().lines().toList()` with
> reading into a temporary `char` array which is then processed to detect line
> terminators and copy non-terminating characters into strings which are added
>
Once [8346295](https://bugs.openjdk.org/browse/JDK-8346295) is resolved,
JavaBaseCheckSince no longer needs to be problemlisted.
-
Depends on: https://git.openjdk.org/jdk/pull/25854
Commit messages:
- this test no longer needs to be problem listed
Changes: https://git.openjdk.org/
On Tue, 17 Jun 2025 15:22:24 GMT, Nizar Benalla wrote:
> Once [8346295](https://bugs.openjdk.org/browse/JDK-8346295) is resolved,
> JavaBaseCheckSince no longer needs to be problemlisted.
Marked as reviewed by syan (Committer).
-
PR Review: https://git.openjdk.org/jdk/pull/25855#p
On Tue, 17 Jun 2025 20:16:05 GMT, Naoto Sato wrote:
> Refactored the internal handling of `stdin/out/err.encoding` to allow setting
> them only via command-line options by converting them into `StaticProperty`.
> This change prevents unexpected behavior caused by applications modifying
> these
On Tue, 17 Jun 2025 20:16:05 GMT, Naoto Sato wrote:
> Refactored the internal handling of `stdin/out/err.encoding` to allow setting
> them only via command-line options by converting them into `StaticProperty`.
> This change prevents unexpected behavior caused by applications modifying
> these
On Wed, 18 Jun 2025 07:17:13 GMT, Ana Maria Mihalceanu wrote:
>> Please review my PR. This PR includes the following:
>>
>> - [x] Fix a small typo in a word and copyright.
>> - [x] Enhance description for `--target-platform`.
>> - [x] Rearrange `jmod create` example from basic to complex.
>
> An
On Wed, 18 Jun 2025 07:17:13 GMT, Ana Maria Mihalceanu wrote:
>> Please review my PR. This PR includes the following:
>>
>> - [x] Fix a small typo in a word and copyright.
>> - [x] Enhance description for `--target-platform`.
>> - [x] Rearrange `jmod create` example from basic to complex.
>
> An
> Please review my PR. This PR includes the following:
>
> - [x] Fix a small typo in a word and copyright.
> - [x] Enhance description for `--target-platform`.
> - [x] Rearrange `jmod create` example from basic to complex.
Ana Maria Mihalceanu has updated the pull request incrementally with one
On Wed, 18 Jun 2025 07:02:59 GMT, Alan Bateman wrote:
>> Ana Maria Mihalceanu has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update commands and description according to review.
>
> src/jdk.jlink/share/man/jmod.md line 186:
>
>> 184:
On Tue, 17 Jun 2025 20:16:05 GMT, Naoto Sato wrote:
> Refactored the internal handling of `stdin/out/err.encoding` to allow setting
> them only via command-line options by converting them into `StaticProperty`.
> This change prevents unexpected behavior caused by applications modifying
> these
On Tue, 17 Jun 2025 17:08:17 GMT, Ana Maria Mihalceanu wrote:
>> Please review my PR. This PR includes the following:
>>
>> - [x] Fix a small typo in a word and copyright.
>> - [x] Enhance description for `--target-platform`.
>> - [x] Rearrange `jmod create` example from basic to complex.
>
> An
52 matches
Mail list logo