On Fri, 13 Jun 2025 21:46:42 GMT, Raffaello Giulietti
wrote:
>> Documenting a suggestion for `float` arguments.
>
> Raffaello Giulietti has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Suggestion by reviewer.
Marked as reviewed by darcy (R
On Fri, 13 Jun 2025 21:46:42 GMT, Raffaello Giulietti
wrote:
>> Documenting a suggestion for `float` arguments.
>
> Raffaello Giulietti has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Suggestion by reviewer.
Marked as reviewed by bpb (Rev
> Documenting a suggestion for `float` arguments.
Raffaello Giulietti has updated the pull request incrementally with one
additional commit since the last revision:
Suggestion by reviewer.
-
Changes:
- all: https://git.openjdk.org/jdk/pull/25805/files
- new: https://git.openj
On Fri, 13 Jun 2025 15:21:38 GMT, Raffaello Giulietti
wrote:
> Documenting a suggestion for `float` arguments.
src/java.base/share/classes/java/math/BigDecimal.java line 1380:
> 1378: * Double#toString(double)}.
> 1379: *
> 1380: * While a {@code float} argument {@code v} can b
On Thu, 12 Jun 2025 15:29:55 GMT, Jaikiran Pai wrote:
> I went back and looked at the JDK-5017871 issue through which the `fo
> o.class` was being tested and from what I see in there, the current test
> changes continue to test that issue. I think there might be better ways to
> test that orig
On Fri, 13 Jun 2025 18:39:14 GMT, Brian Burkhalter wrote:
>> I usually start a sentence on a new line because that generates less noise
>> when diffing in the future.
>> The HTML renders it in the same paragraph as the preceding text.
>
> Makes sense.
> I usually start a sentence on a new line
On Fri, 13 Jun 2025 17:47:16 GMT, Justin Lu wrote:
>> Please review this PR which finishes Applet removal for the test:
>> jdk/internal/loader/URLClassPath/ClassnameCharTest.java.
>>
>> `testclasses.jar` is updated such that the two classes no longer extend
>> Applet.
>>
>>
>> $ javap fo\ o.
On Thu, 12 Jun 2025 22:52:21 GMT, Justin Lu wrote:
>> Unfortunately some check is required (a test fails), but I now realize what
>> I had was wrong. The issue is that on line 1084
>> (https://github.com/openjdk/jdk/pull/25644/files#diff-79e6fd549b5ec5e7f49658581beddcb07fcbb0c09ae8e1117c385b665
> This PR replaces construction of intermediate strings to be parsed with more
> direct manipulation of numbers. It also has a more streamlined mechanism of
> handling `Long.MIN_VALUE` when parsing longs by using `Long.parseUnsignedLong`
>
> As a small side-effect it also eliminates the use of a
On Fri, 13 Jun 2025 17:47:16 GMT, Justin Lu wrote:
>> Please review this PR which finishes Applet removal for the test:
>> jdk/internal/loader/URLClassPath/ClassnameCharTest.java.
>>
>> `testclasses.jar` is updated such that the two classes no longer extend
>> Applet.
>>
>>
>> $ javap fo\ o.
> Please review this PR which finishes Applet removal for the test:
> jdk/internal/loader/URLClassPath/ClassnameCharTest.java.
>
> `testclasses.jar` is updated such that the two classes no longer extend
> Applet.
>
>
> $ javap fo\ o.class
> public class fo o {
> }
> $ javap æ$'\302\211'$'\302
On Fri, 13 Jun 2025 18:10:03 GMT, Raffaello Giulietti
wrote:
>> src/java.base/share/classes/java/math/BigDecimal.java line 1383:
>>
>>> 1381: * the result usually contains too many trailing digits compared
>>> 1382: * to the precision of a {@code float}.
>>> 1383: * Consider usin
On Fri, 13 Jun 2025 15:21:38 GMT, Raffaello Giulietti
wrote:
> Documenting a suggestion for `float` arguments.
Marked as reviewed by bpb (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/25805#pullrequestreview-2925970196
On Fri, 13 Jun 2025 17:39:38 GMT, Brian Burkhalter wrote:
>> Documenting a suggestion for `float` arguments.
>
> src/java.base/share/classes/java/math/BigDecimal.java line 1383:
>
>> 1381: * the result usually contains too many trailing digits compared
>> 1382: * to the precision of a
On Fri, 13 Jun 2025 17:47:16 GMT, Justin Lu wrote:
>> Please review this PR which finishes Applet removal for the test:
>> jdk/internal/loader/URLClassPath/ClassnameCharTest.java.
>>
>> `testclasses.jar` is updated such that the two classes no longer extend
>> Applet.
>>
>>
>> $ javap fo\ o.
On Thu, 12 Jun 2025 07:57:20 GMT, Ana Maria Mihalceanu wrote:
> Please review my PR. This PR includes the following:
>
> - [x] Fix a small typo in a word and copyright.
> - [x] Enhance description for `--target-platform`.
> - [x] Rearrange `jmod create` example from basic to complex.
Changes re
On Thu, 12 Jun 2025 21:42:26 GMT, Lance Andersen wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Address offline review -> comments for maintainers, simplify exc and
>> JAR_PATH
>
> test/jdk/jdk/internal/loader/URLCl
On Fri, 13 Jun 2025 15:21:38 GMT, Raffaello Giulietti
wrote:
> Documenting a suggestion for `float` arguments.
src/java.base/share/classes/java/math/BigDecimal.java line 1383:
> 1381: * the result usually contains too many trailing digits compared
> 1382: * to the precision of a {@co
Documenting a suggestion for `float` arguments.
-
Commit messages:
- 8358804: Improve the API Note of BigDecimal.valueOf(double)
Changes: https://git.openjdk.org/jdk/pull/25805/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=25805&range=00
Issue: https://bugs.openjdk.org/
On Tue, 7 Jan 2025 10:39:18 GMT, Shaojin Wen wrote:
> In PR #22928, UUID introduced long-based vectorized hexadecimal to string
> conversion, which can also be used in Integer::toHexString and
> Long::toHexString to eliminate table lookups. The benefit of eliminating
> table lookups is that th
On Thu, 12 Jun 2025 18:05:04 GMT, Justin Lu wrote:
>> Please review this PR which finishes Applet removal for the test:
>> jdk/internal/loader/URLClassPath/ClassnameCharTest.java.
>>
>> `testclasses.jar` is updated such that the two classes no longer extend
>> Applet.
>>
>>
>> $ javap fo\ o.
In PR #22928, UUID introduced long-based vectorized hexadecimal to string
conversion, which can also be used in Integer::toHexString and
Long::toHexString to eliminate table lookups. The benefit of eliminating table
lookups is that the performance is better when cache misses occur.
On Tue, 7 Jan 2025 10:39:18 GMT, Shaojin Wen wrote:
> In PR #22928, UUID introduced long-based vectorized hexadecimal to string
> conversion, which can also be used in Integer::toHexString and
> Long::toHexString to eliminate table lookups. The benefit of eliminating
> table lookups is that th
On Tue, 7 Jan 2025 10:39:18 GMT, Shaojin Wen wrote:
> In PR #22928, UUID introduced long-based vectorized hexadecimal to string
> conversion, which can also be used in Integer::toHexString and
> Long::toHexString to eliminate table lookups. The benefit of eliminating
> table lookups is that th
On Tue, 7 Jan 2025 10:39:18 GMT, Shaojin Wen wrote:
> In PR #22928, UUID introduced long-based vectorized hexadecimal to string
> conversion, which can also be used in Integer::toHexString and
> Long::toHexString to eliminate table lookups. The benefit of eliminating
> table lookups is that th
On Tue, 7 Jan 2025 22:16:19 GMT, Francesco Nigro wrote:
>> In PR #22928, UUID introduced long-based vectorized hexadecimal to string
>> conversion, which can also be used in Integer::toHexString and
>> Long::toHexString to eliminate table lookups. The benefit of eliminating
>> table lookups is
On Tue, 7 Jan 2025 10:39:18 GMT, Shaojin Wen wrote:
> In PR #22928, UUID introduced long-based vectorized hexadecimal to string
> conversion, which can also be used in Integer::toHexString and
> Long::toHexString to eliminate table lookups. The benefit of eliminating
> table lookups is that th
On Wed, 11 Jun 2025 11:22:57 GMT, Volkan Yazici wrote:
> Both `javax/script/PluggableContextTest.java` and its companion
> `test/jdk/javax/script/MyContext.java` were added in
> [JDK-6398614](https://bugs.openjdk.org/browse/JDK-6398614).
> [JDK-8246113](https://bugs.openjdk.org/browse/JDK-8246
On Fri, 13 Jun 2025 08:52:37 GMT, Athijegannathan Sundararajan
wrote:
>> Both `javax/script/PluggableContextTest.java` and its companion
>> `test/jdk/javax/script/MyContext.java` were added in
>> [JDK-6398614](https://bugs.openjdk.org/browse/JDK-6398614).
>> [JDK-8246113](https://bugs.openjdk
On Wed, 11 Jun 2025 11:22:57 GMT, Volkan Yazici wrote:
> Both `javax/script/PluggableContextTest.java` and its companion
> `test/jdk/javax/script/MyContext.java` were added in
> [JDK-6398614](https://bugs.openjdk.org/browse/JDK-6398614).
> [JDK-8246113](https://bugs.openjdk.org/browse/JDK-8246
> Passes the `Charset` read from the `stdin.encoding` system property while
> creating `InputStreamReader` or `Scanner` instances for `System.in`.
>
> `stdin.encoding` is a recently added property for Java 25 in
> [JDK-8350703](https://bugs.openjdk.org/browse/JDK-8350703). Employing it
> throug
31 matches
Mail list logo
