On Fri, 16 May 2025 06:14:57 GMT, Thomas Stuefe wrote:
> Not for JDK 25
>
> See the companion CSR (https://bugs.openjdk.org/browse/JDK-8357090) for the
> ratio behind this removal.
>
> Patch
>
> - removes all code handling the VFORK mode.
> - removes or rewrites comments explaining use of vf
On Thu, 12 Jun 2025 00:34:11 GMT, Stuart Marks wrote:
> I'd describe this as "space plus ASCII control characters." Would something
> like that make more sense?
Yeah, I think so
-
PR Review Comment: https://git.openjdk.org/jdk/pull/25762#discussion_r2141368745
On Wed, 11 Jun 2025 23:57:48 GMT, Naoto Sato wrote:
>> src/java.base/share/classes/java/lang/String.java line 3837:
>>
>>> 3835: *
>>> 3836: * @apiNote
>>> 3837: * This method uses a ASCII-based definition of space characters
>>> that are to be
>>
>> "a ASCII" or "an ASCII"?
>
>
> Add a note to String.trim pointing to the String.strip family of methods.
>
> Add notes cross-linking String.isBlank and String.isEmpty.
Stuart Marks has updated the pull request incrementally with one additional
commit since the last revision:
Use {@return ...} inline tag.
-
On Thu, 12 Jun 2025 00:35:12 GMT, Stuart Marks wrote:
>> src/java.base/share/classes/java/lang/String.java line 3937:
>>
>>> 3935:
>>> 3936: /**
>>> 3937: * Returns {@code true} if the string is empty or contains only
>>
>> This method seems like a good candidate to use `{@return ...}
On Wed, 11 Jun 2025 23:57:02 GMT, Justin Lu wrote:
>> Add a note to String.trim pointing to the String.strip family of methods.
>>
>> Add notes cross-linking String.isBlank and String.isEmpty.
>
> src/java.base/share/classes/java/lang/String.java line 3937:
>
>> 3935:
>> 3936: /**
>> 3937:
On Wed, 11 Jun 2025 22:39:48 GMT, Stuart Marks wrote:
> Add a note to String.trim pointing to the String.strip family of methods.
>
> Add notes cross-linking String.isBlank and String.isEmpty.
src/java.base/share/classes/java/lang/String.java line 3937:
> 3935:
> 3936: /**
> 3937: *
On Wed, 11 Jun 2025 23:43:40 GMT, Brian Burkhalter wrote:
>> Add a note to String.trim pointing to the String.strip family of methods.
>>
>> Add notes cross-linking String.isBlank and String.isEmpty.
>
> src/java.base/share/classes/java/lang/String.java line 3837:
>
>> 3835: *
>> 3836:
On Mon, 9 Jun 2025 23:44:20 GMT, Justin Lu wrote:
>> Johannes Graham has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> catch ArithmeticException
>
> src/java.base/share/classes/jdk/internal/math/FloatingDecimal.java line 1848:
>
>> 1846:
On Tue, 10 Jun 2025 15:41:47 GMT, Johannes Graham wrote:
>> This PR replaces construction of intermediate strings to be parsed with more
>> direct manipulation of numbers. It also has a more streamlined mechanism of
>> handling `Long.MIN_VALUE` when parsing longs by using
>> `Long.parseUnsigne
On Wed, 11 Jun 2025 22:39:48 GMT, Stuart Marks wrote:
> Add a note to String.trim pointing to the String.strip family of methods.
>
> Add notes cross-linking String.isBlank and String.isEmpty.
src/java.base/share/classes/java/lang/String.java line 3837:
> 3835: *
> 3836: * @apiNote
>
Add a note to String.trim pointing to the String.strip family of methods.
Add notes cross-linking String.isBlank and String.isEmpty.
-
Commit messages:
- Updates to String javadoc.
Changes: https://git.openjdk.org/jdk/pull/25762/files
Webrev: https://webrevs.openjdk.org/?repo=jdk
> Please review this PR which finishes Applet removal for the test:
> jdk/internal/loader/URLClassPath/ClassnameCharTest.java.
>
> `testclasses.jar` is updated such that the two classes no longer extend
> Applet.
>
>
> $ javap fo\ o.class
> public class fo o {
> }
> $ javap æ$'\302\211'$'\302
On Wed, 11 Jun 2025 07:15:43 GMT, SendaoYan wrote:
> Hi all,
>
> I think use `@requires (os.family == "windows")` is more elegant than thow
> jtreg.SkippedException in test java/io/File/MaxPath.java.
>
> On linux before this PR, run this test jtreg report:
>
>
> TEST: java/io/File/MaxPath.ja
On Mon, 9 Jun 2025 20:42:43 GMT, Justin Lu wrote:
> Please review this PR which finishes Applet removal for the test:
> jdk/internal/loader/URLClassPath/ClassnameCharTest.java.
>
> `testclasses.jar` is updated such that the two classes no longer extend
> Applet.
>
>
> $ javap fo\ o.class
>
On Wed, 11 Jun 2025 07:15:43 GMT, SendaoYan wrote:
> Hi all,
>
> I think use `@requires (os.family == "windows")` is more elegant than thow
> jtreg.SkippedException in test java/io/File/MaxPath.java.
>
> On linux before this PR, run this test jtreg report:
>
>
> TEST: java/io/File/MaxPath.ja
On Wed, 11 Jun 2025 17:24:11 GMT, Per Minborg wrote:
>> This PR proposes to improve the 'MemorySegment.getString(long offset,
>> Charset charset)` method documentation with respect to multi-octet concerns.
>
> Per Minborg has updated the pull request incrementally with one additional
> commit s
> We logged several bugs on the LinkedBlockingDeque. This aggregates them into
> a single bug report and PR.
>
> 1. LinkedBlockingDeque does not immediately throw InterruptedException in
> put/take
>
> The LinkedBlockingDeque does not behave consistently with other concurrency
> components. If
On Tue, 10 Jun 2025 17:01:24 GMT, Per Minborg wrote:
>> This PR proposes to improve the 'MemorySegment.getString(long offset,
>> Charset charset)` method documentation with respect to multi-octet concerns.
>
> Per Minborg has updated the pull request incrementally with one additional
> commit s
On Tue, 10 Jun 2025 18:36:15 GMT, Naoto Sato wrote:
> This regression was introduced by the removal of the COMPAT locale provider,
> which partially broke support for the first year in the Japanese calendar. In
> the Japanese calendar system, the first year of an era should be formatted
> usin
> This PR proposes to improve the 'MemorySegment.getString(long offset, Charset
> charset)` method documentation with respect to multi-octet concerns.
Per Minborg has updated the pull request incrementally with one additional
commit since the last revision:
Improve wording
-
Cha
On Wed, 11 Jun 2025 16:56:48 GMT, Justin Lu wrote:
> so I used the ClassFile API to create those class files.
Use of ClassFile API I think is a good approach.
> Using JDKToolFinder.getCompileJDKTool("jar") with the CF API seems reasonable
> to do all the work dynamically. I will take a look, t
> This PR proposes to improve the 'MemorySegment.getString(long offset, Charset
> charset)` method documentation with respect to multi-octet concerns.
Per Minborg has updated the pull request incrementally with one additional
commit since the last revision:
Update src/java.base/share/classes/
On Tue, 10 Jun 2025 17:01:24 GMT, Per Minborg wrote:
>> This PR proposes to improve the 'MemorySegment.getString(long offset,
>> Charset charset)` method documentation with respect to multi-octet concerns.
>
> Per Minborg has updated the pull request incrementally with one additional
> commit s
On Wed, 11 Jun 2025 08:30:18 GMT, Christian Stein wrote:
>> Please review this fix to correctly parse tokens in an argument file that
>> contains trailing comments without preceding whitespace characters before
>> the '#' comment marker, the number sign.
>>
>> The specifaction of the `java` Co
On Mon, 9 Jun 2025 20:42:43 GMT, Justin Lu wrote:
> Please review this PR which finishes Applet removal for the test:
> jdk/internal/loader/URLClassPath/ClassnameCharTest.java.
>
> `testclasses.jar` is updated such that the two classes no longer extend
> Applet.
>
>
> $ javap fo\ o.class
>
On Mon, 9 Jun 2025 19:04:23 GMT, Naoto Sato wrote:
> The parallel loading of JavaTimeSupplementary was a historical artifact from
> the introduction of JSR 310, which additionally loads resouces that had not
> existed before. Since the COMPAT locale provider which relied on this
> mechanism ha
On Mon, 9 Jun 2025 20:42:43 GMT, Justin Lu wrote:
> Please review this PR which finishes Applet removal for the test:
> jdk/internal/loader/URLClassPath/ClassnameCharTest.java.
>
> `testclasses.jar` is updated such that the two classes no longer extend
> Applet.
>
>
> $ javap fo\ o.class
>
On Wed, 11 Jun 2025 07:46:09 GMT, Justin Lu wrote:
> So we are updating the CLDRConverter to adapt the old COMPAT style pattern:
> "" when using Japanese calendar for LONG or FULL `SimpleDateFormat`
> patterns, such that it can replicate the old "gannen" style which emits the 元.
Yes, that’
On Mon, 9 Jun 2025 20:07:53 GMT, Naoto Sato wrote:
>> The parallel loading of JavaTimeSupplementary was a historical artifact from
>> the introduction of JSR 310, which additionally loads resouces that had not
>> existed before. Since the COMPAT locale provider which relied on this
>> mechanis
On Thu, 8 May 2025 13:58:54 GMT, Alan Bateman wrote:
>> Would it be possible to paste in here, or in the JBS issue, some examples of
>> the path provided to LoadLibrary with some commentary on the sym links
>> created on the file system.
>
>> You might be correct. We'll see what @AlanBateman an
On Tue, 10 Jun 2025 18:36:15 GMT, Naoto Sato wrote:
> This regression was introduced by the removal of the COMPAT locale provider,
> which partially broke support for the first year in the Japanese calendar. In
> the Japanese calendar system, the first year of an era should be formatted
> usin
On Fri, 6 Jun 2025 10:38:11 GMT, erifan wrote:
>> This patch optimizes the following patterns:
>> For integer types:
>>
>> (XorV (VectorMaskCmp src1 src2 cond) (Replicate -1))
>> => (VectorMaskCmp src1 src2 ncond)
>> (XorVMask (VectorMaskCmp src1 src2 cond) (MaskAll m1))
>> => (VectorMas
On Wed, 11 Jun 2025 08:47:56 GMT, Xiaohong Gong wrote:
>> erifan has updated the pull request incrementally with one additional commit
>> since the last revision:
>>
>> Support negating unsigned comparison for BoolTest::mask
>>
>> Added a static method `negate_mask(mask btm)` into BoolTe
On Wed, 11 Jun 2025 11:41:41 GMT, David Beaumont wrote:
>> Christian Stein has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Extract shared function to compute current token
>
> test/jdk/tools/launcher/ArgFileSyntax.java line 177:
>
>> 17
On Wed, 11 Jun 2025 09:52:19 GMT, kabutz wrote:
>> We logged several bugs on the LinkedBlockingDeque. This aggregates them into
>> a single bug report and PR.
>>
>> 1. LinkedBlockingDeque does not immediately throw InterruptedException in
>> put/take
>>
>> The LinkedBlockingDeque does not beh
On Wed, 11 Jun 2025 09:52:19 GMT, kabutz wrote:
>> We logged several bugs on the LinkedBlockingDeque. This aggregates them into
>> a single bug report and PR.
>>
>> 1. LinkedBlockingDeque does not immediately throw InterruptedException in
>> put/take
>>
>> The LinkedBlockingDeque does not beh
On Wed, 11 Jun 2025 08:30:18 GMT, Christian Stein wrote:
>> Please review this fix to correctly parse tokens in an argument file that
>> contains trailing comments without preceding whitespace characters before
>> the '#' comment marker, the number sign.
>>
>> The specifaction of the `java` Co
> Comment out assertions added in JDK-8351443 from
> AbstractStringBuilder.ensureCapacityNewCoder that increase the codesize,
> preventing some inlining, and reducing performance
>
>assert coder == newCoder || newCoder == UTF16 : "bad new coder UTF16
> -> LATIN1";
>assert count
Both `javax/script/PluggableContextTest.java` and its companion
`test/jdk/javax/script/MyContext.java` were added in
[JDK-6398614](https://bugs.openjdk.org/browse/JDK-6398614).
[JDK-8246113](https://bugs.openjdk.org/browse/JDK-8246113) removed
`PluggableContextTest`, yet forgot `MyContext`, and
On Mon, 2 Jun 2025 23:32:39 GMT, Shaojin Wen wrote:
> The performance figures under x64 show that the performance of
> StringBuilders.appendWithIntLatin1 scenario drops by about 6%, but the
> performance of StringBuilders.appendWithLongLatin1 does not drop.
All of the JMH tests for StringBuild
> Passes the `Charset` read from the `stdin.encoding` system property while
> creating `InputStreamReader` or `Scanner` instances for `System.in`.
>
> `stdin.encoding` is a recently added property for Java 25 in
> [JDK-8350703](https://bugs.openjdk.org/browse/JDK-8350703). Employing it
> throug
On Wed, 11 Jun 2025 10:29:52 GMT, Volkan Yazici wrote:
>> Volkan Yazici has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Improve code style
>>
>> Co-authored-by: Andrey Turbanov
>
> test/jdk/javax/script/MyContext.java line 52:
>
>
On Thu, 5 Jun 2025 10:13:24 GMT, Volkan Yazici wrote:
>> Passes the `Charset` read from the `stdin.encoding` system property while
>> creating `InputStreamReader` or `Scanner` instances for `System.in`.
>>
>> `stdin.encoding` is a recently added property for Java 25 in
>> [JDK-8350703](https:/
On Thu, 5 Jun 2025 10:13:24 GMT, Volkan Yazici wrote:
>> Passes the `Charset` read from the `stdin.encoding` system property while
>> creating `InputStreamReader` or `Scanner` instances for `System.in`.
>>
>> `stdin.encoding` is a recently added property for Java 25 in
>> [JDK-8350703](https:/
On Wed, 11 Jun 2025 09:17:57 GMT, Viktor Klang wrote:
>> kabutz has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Removed sizes from LBD constructors - not necessary
>> - More optimizing volatile reads
>
> test/jdk/java/util/concurrent/
> We logged several bugs on the LinkedBlockingDeque. This aggregates them into
> a single bug report and PR.
>
> 1. LinkedBlockingDeque does not immediately throw InterruptedException in
> put/take
>
> The LinkedBlockingDeque does not behave consistently with other concurrency
> components. If
On Tue, 10 Jun 2025 16:03:47 GMT, kabutz wrote:
>> We logged several bugs on the LinkedBlockingDeque. This aggregates them into
>> a single bug report and PR.
>>
>> 1. LinkedBlockingDeque does not immediately throw InterruptedException in
>> put/take
>>
>> The LinkedBlockingDeque does not beh
On Wed, 11 Jun 2025 07:43:55 GMT, Emanuel Peter wrote:
>> `VectorOperators.XXX` is not compile time constants, we can't use `switch`
>> here.
>
> Oh. Ok. Well at least add a `RuntimeException` to an `else` branch then, I
> would suggest :)
Make sense!
-
PR Review Comment: https:/
On Wed, 11 Jun 2025 08:30:51 GMT, Emanuel Peter wrote:
>>> You are checking IRNode.XOR_VL, "= 0". But you are comparing floats. Does
>>> that make sense?
>>
>> The bottom types of `float` and `double` vector masks are casted to `int`
>> and `long`. Seems this is by design? So this is correct.
On Tue, 10 Jun 2025 08:15:58 GMT, Christian Stein wrote:
>> Or the handling of `#` can be merged with the previous case ... somehow.
>
> Extracting a method wouldn't really simplify the code, as many local
> variables are in play.
>
> Merging the cases also ends up in more if-else constructs in
On Wed, 11 Jun 2025 08:20:20 GMT, erifan wrote:
> > You are checking IRNode.XOR_VL, "= 0". But you are comparing floats. Does
> > that make sense?
> The bottom types of float and double vector masks are casted to int and long.
> Seems this is by design? So this is correct.
This is a `float` t
> Please review this fix to correctly parse tokens in an argument file that
> contains trailing comments without preceding whitespace characters before the
> '#' comment marker, the number sign.
>
> The specifaction of the `java` Command has in section [java Command-Line
> Argument
> Files](ht
On Wed, 11 Jun 2025 05:31:00 GMT, Emanuel Peter wrote:
> You are checking IRNode.XOR_VL, "= 0". But you are comparing floats. Does
> that make sense?
The bottom types of `float` and `double` vector masks are casted to `int` and
`long`. Seems this is by design? So this is correct.
As for `cont
On Tue, 10 Jun 2025 18:36:15 GMT, Naoto Sato wrote:
> This regression was introduced by the removal of the COMPAT locale provider,
> which partially broke support for the first year in the Japanese calendar. In
> the Japanese calendar system, the first year of an era should be formatted
> usin
On Wed, 11 Jun 2025 07:31:48 GMT, erifan wrote:
>> test/hotspot/jtreg/compiler/vectorapi/VectorMaskCompareNotTest.java line 158:
>>
>>> 156: } else if (op == VectorOperators.UGT) {
>>> 157: Asserts.assertEquals(compareUnsigned(a, b) <= 0, r);
>>> 158: }
>>
>> Please
On Wed, 11 Jun 2025 05:23:12 GMT, Emanuel Peter wrote:
>> erifan has updated the pull request incrementally with one additional commit
>> since the last revision:
>>
>> Support negating unsigned comparison for BoolTest::mask
>>
>> Added a static method `negate_mask(mask btm)` into BoolTe
Hi all,
I think use `@requires (os.family == "windows")` is more elegrant than thow
jtreg.SkippedException in test java/io/File/MaxPath.java.
On linux before this PR, run this test jtreg report:
TEST: java/io/File/MaxPath.java
TEST RESULT: Passed. Skipped: jtreg.SkippedException: This test is
58 matches
Mail list logo
