On Wed, 4 Jun 2025 21:54:15 GMT, Naoto Sato wrote:
> The resource files in `java.base` are supposed to be US English only, but
> they also need to use UTF-8 as some of the names are non-ASCII (e.g., Türkiye)
@naotoj, shall we add this note as a comment to places where `-utf8` is added?
---
> Reverts certain [JDK-8353197](https://bugs.openjdk.org/browse/JDK-8353197)
> (which implements JavaDoc improvement and precautionary naming for certain
> unsafe methods in `jdk.internal.access.JavaLangAccess`) changes that are
> found to be incorrect. See the JBS issue for details on the follo
On Wed, 4 Jun 2025 11:39:34 GMT, Per Minborg wrote:
>>> I wonder if we should add that implementations of the affected method
>>> _shall_ do bounds checking to reduce the likelihood of a new/updated native
>>> implementation miss that?
>>
>> @minborg, would you mind elaborating on this a bit,
On Wed, 4 Jun 2025 06:47:59 GMT, Jaikiran Pai wrote:
> Can I please get a review of this trivial doc-only change to the
> `jdk.zipfs`'s documentation? This moves the `accessMode` property listing to
> the top of the table instead of being at the bottom. With this change, the
> text about throw
On Wed, 4 Jun 2025 21:54:15 GMT, Naoto Sato wrote:
> Changes to generate CLDR resource bundles in UTF-8 encoding. The resource
> files in `java.base` are supposed to be US English only, but they also need
> to use UTF-8 as some of the names are non-ASCII (e.g., Türkiye)
Looks like this PR did
On Sun, 1 Jun 2025 04:53:46 GMT, Hannes Greule wrote:
> This change addresses a NPE in javap when trying to print a class with
> minorVersion != 0. With this change, we fall back to the methods that don't
> take a `ClassFileFormatVersion` in such case.
This pull request has now been integrated
On Mon, 2 Jun 2025 20:06:34 GMT, Hannes Greule wrote:
>> This change addresses a NPE in javap when trying to print a class with
>> minorVersion != 0. With this change, we fall back to the methods that don't
>> take a `ClassFileFormatVersion` in such case.
>
> Hannes Greule has updated the pull
On Mon, 2 Jun 2025 20:06:34 GMT, Hannes Greule wrote:
>> This change addresses a NPE in javap when trying to print a class with
>> minorVersion != 0. With this change, we fall back to the methods that don't
>> take a `ClassFileFormatVersion` in such case.
>
> Hannes Greule has updated the pull
On Mon, 2 Jun 2025 20:06:34 GMT, Hannes Greule wrote:
>> This change addresses a NPE in javap when trying to print a class with
>> minorVersion != 0. With this change, we fall back to the methods that don't
>> take a `ClassFileFormatVersion` in such case.
>
> Hannes Greule has updated the pull
On Wed, 4 Jun 2025 21:20:46 GMT, Justin Lu wrote:
> Please review this PR which improves occurrences of lazy computation in
> `Locale` and `BaseLocale`.
>
> Existing lazy initialization strategies such as CHM, static nested class, and
> local inner class are replaced with Stable Values.
>
> L
On Wed, 4 Jun 2025 16:04:08 GMT, Erik Gahlin wrote:
>> src/java.base/share/classes/java/net/Socket.java line 970:
>>
>>> 968: long end = SocketReadEvent.timestamp();
>>> 969: long duration = end - start;
>>> 970: if (SocketReadEvent.shouldThrottleCommit(durati
On Wed, 4 Jun 2025 23:09:08 GMT, Nizar Benalla wrote:
>> Get JDK 26 underway.
>
> Nizar Benalla has updated the pull request incrementally with one additional
> commit since the last revision:
>
> fix typo
Marked as reviewed by iris (Reviewer).
-
PR Review: https://git.openjdk.
> Get JDK 26 underway.
Nizar Benalla has updated the pull request incrementally with one additional
commit since the last revision:
fix typo
-
Changes:
- all: https://git.openjdk.org/jdk/pull/25008/files
- new: https://git.openjdk.org/jdk/pull/25008/files/09df3b66..9929da7b
On Mon, 2 Jun 2025 20:06:34 GMT, Hannes Greule wrote:
>> This change addresses a NPE in javap when trying to print a class with
>> minorVersion != 0. With this change, we fall back to the methods that don't
>> take a `ClassFileFormatVersion` in such case.
>
> Hannes Greule has updated the pull
> Get JDK 26 underway.
Nizar Benalla has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains 22 commits:
- use a different bug ID to problemlist `kevinrushforth `
- Merge branch 'master' into jdk.8355746
- Merge branch 'master' into jdk.83
On Wed, 4 Jun 2025 16:50:15 GMT, Johannes Döbler wrote:
>> Interesting. This `@NoOverride` idea could be useful on a subclass that
>> wants to make sure it overrides everything. (Maybe `@NoInherit` would be a
>> better name.) Meanwhile for JDK-8357272 (PR
>> https://github.com/openjdk/jdk/pull
On Wed, 4 Jun 2025 12:08:09 GMT, Per Minborg wrote:
> The newly marked arrays are indeed only updated once. Can we see any
> benchmark showing a performance gain?
I ran `make test TEST="micro:java.math.BigDecimals` on a MacBook M1 Pro, and
there was no performance improvement with the Stable a
On Tue, 3 Jun 2025 11:14:36 GMT, Nizar Benalla wrote:
>> Get JDK 26 underway.
>
> Nizar Benalla has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains 20 commits:
>
> - Merge branch 'master' into jdk.8355746
> - Problemlist JavaBaseChec
On Wed, 4 Jun 2025 20:44:12 GMT, Kevin Rushforth wrote:
>> Nizar Benalla has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 20 commits:
>>
>> - Merge branch 'master' into jdk.8355746
>> - Problemlist JavaBaseCheckSince
>> - Revert
Please review this PR which improves occurrences of lazy computation in
`Locale` and `BaseLocale`.
Existing lazy initialization strategies such as CHM, static nested class, and
local inner class are replaced with Stable Values.
Lambda usage is intentionally avoided in this change during `Locale
On Tue, 3 Jun 2025 11:14:36 GMT, Nizar Benalla wrote:
>> Get JDK 26 underway.
>
> Nizar Benalla has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains 20 commits:
>
> - Merge branch 'master' into jdk.8355746
> - Problemlist JavaBaseChec
On Tue, 3 Jun 2025 11:14:36 GMT, Nizar Benalla wrote:
>> Get JDK 26 underway.
>
> Nizar Benalla has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains 20 commits:
>
> - Merge branch 'master' into jdk.8355746
> - Problemlist JavaBaseChec
On Tue, 3 Jun 2025 11:10:30 GMT, Nizar Benalla wrote:
> I have problemlisted
> `tools/sincechecker/modules/java.base/JavaBaseCheckSince.java` as it is
> failing due to the symbol information lagging behind.
What is your plan for addressing this? In its current state, that problem list
entry w
On Tue, 3 Jun 2025 11:14:36 GMT, Nizar Benalla wrote:
>> Get JDK 26 underway.
>
> Nizar Benalla has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains 20 commits:
>
> - Merge branch 'master' into jdk.8355746
> - Problemlist JavaBaseChec
On Sat, 31 May 2025 17:27:30 GMT, Ian Graves wrote:
>> Removing incorrect assumptions and assertions from a breaking test related
>> to https://bugs.openjdk.org/browse/JDK-8358218
>
> Ian Graves has updated the pull request with a new target base due to a merge
> or a rebase. The pull request n
On Sat, 31 May 2025 16:18:59 GMT, Ian Graves wrote:
> Removing incorrect assumptions and assertions from a breaking test related to
> https://bugs.openjdk.org/browse/JDK-8358218
This pull request has now been integrated.
Changeset: 901144ee
Author:Ian Graves
URL:
https://git.openjd
On Mon, 2 Jun 2025 12:58:15 GMT, Chen Liang wrote:
>> This change addresses a NPE in javap when trying to print a class with
>> minorVersion != 0. With this change, we fall back to the methods that don't
>> take a `ClassFileFormatVersion` in such case.
>
> That sounds right.
@liach is there an
On Tue, 3 Jun 2025 16:47:20 GMT, Justin Lu wrote:
> Please review this PR which modifies the
> test/jdk/java/util/TimeZone/Bug8167143.java "testCompat" case to be
> repurposed to check the implicit locales for the FALLBACK BreakIterator and
> Collator providers. (FALLBACK is the primary provid
>Ultimately, the question is whether mapConcurrent() should be optimized
>primarily for preserving input sequence, or for enabling maximum throughput
>and flexibility in concurrent scenarios, including efficient "first-to-finish"
>patterns.
The answer to that is clear in the specification for t
On Wed, 4 Jun 2025 07:12:42 GMT, Kim Barrett wrote:
>> Please review this change which adds a native method providing the
>> implementation of Reference::get. Referece::get is an intrinsic candidate,
>> so
>> this native method implementation is only used when the intrinsic is not.
>>
>> Curre
On Wed, 4 Jun 2025 15:46:36 GMT, Daniel Fuchs wrote:
>> Hi,
>>
>> Please find here a PR for the implementation of [JEP 517: HTTP/3 for the
>> HTTP Client API](https://openjdk.org/jeps/517).
>>
>> The CSR can be viewed at [JDK-8350588: Implement JEP 517: HTTP/3 for the
>> HTTP Client API](http
On Wed, 4 Jun 2025 07:12:42 GMT, Kim Barrett wrote:
>> Please review this change which adds a native method providing the
>> implementation of Reference::get. Referece::get is an intrinsic candidate,
>> so
>> this native method implementation is only used when the intrinsic is not.
>>
>> Curre
> This PR builds on a concept John Rose told me about some time ago. Instead of
> combining memory operations of various sizes, a single large and skewed
> memory operation can be made to clean up the tail of remaining bytes.
>
> This has the effect of simplifying and shortening the code. The nu
On Wed, 4 Jun 2025 16:19:23 GMT, Stuart Marks wrote:
>> It would be helpful in situations like this to have the inverse annotation
>> -- "All methods should be overridden, except the ones marked `@NoOverride`".
>
> Interesting. This `@NoOverride` idea could be useful on a subclass that wants
>
On Tue, 3 Jun 2025 17:13:45 GMT, Justin Lu wrote:
> Please review this trivial doc correction to
> `Locale.getISOCountries(Locale.IsoCountryCode type)` which makes it apparent
> that the returned Set is unmodifiable. Associated CSR filed.
This pull request has now been integrated.
Changeset:
On Wed, 4 Jun 2025 09:53:13 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which proposes to address the issue
> noted in https://bugs.openjdk.org/browse/JDK-8349914?
>
> The ZIP specification allows for more than one entry to have the same file
> name (and may have differ
On Fri, 16 May 2025 10:26:11 GMT, Daniel Fuchs wrote:
>> Daniel Fuchs has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 422 commits:
>>
>> - merge latest changes from master branch
>> - Undo whitespace change
>> - Remove unnecess
On Fri, 30 May 2025 14:01:04 GMT, Roger Riggs wrote:
> Comment out assertions added in JDK-8351443 from
> AbstractStringBuilder.ensureCapacityNewCoder that increase the codesize,
> preventing some inlining, and reducing performance
>
>assert coder == newCoder || newCoder == UTF16 : "ba
On Wed, 4 Jun 2025 04:08:36 GMT, Joe Darcy wrote:
>> The `@Override` annotation has been inconsistently applied in the
>> collections implementations. In practice since so many methods are
>> overridden, and some test would likely fail if a method weren't overridden
>> properly, the annotation
Hi Viktor,
Thank you for the detailed explanation and the links to the Javadoc for
findFirst() and limit(). You're absolutely correct in your characterization
of these operations – they are indeed concerned with encounter order, and
parallel execution doesn't inherently change that unless the stre
On Thu, 29 May 2025 00:21:35 GMT, Stuart Marks wrote:
> For a full explanation, see the bug report
> [JDK-8358015](https://bugs.openjdk.org/browse/JDK-8358015).
>
> This PR includes three related changes:
> * New overrides in SequencedMap view collection implementations, which
> improve their
On Wed, 4 Jun 2025 14:32:31 GMT, Alan Bateman wrote:
>> Erik Gahlin has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix adjust boundary
>
> src/java.base/share/classes/java/net/Socket.java line 970:
>
>> 968: long end = Sock
On Wed, 4 Jun 2025 14:16:56 GMT, Alan Bateman wrote:
>> Erik Gahlin has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix adjust boundary
>
> src/jdk.jfr/share/classes/jdk/jfr/Throttle.java line 77:
>
>> 75: * Specifying {@code "off"
> Hi,
>
> Please find here a PR for the implementation of [JEP 517: HTTP/3 for the HTTP
> Client API](https://openjdk.org/jeps/517).
>
> The CSR can be viewed at [JDK-8350588: Implement JEP 517: HTTP/3 for the HTTP
> Client API](https://bugs.openjdk.org/browse/JDK-8350588)
>
> This JEP propose
On Wed, 4 Jun 2025 06:47:59 GMT, Jaikiran Pai wrote:
> Can I please get a review of this trivial doc-only change to the
> `jdk.zipfs`'s documentation? This moves the `accessMode` property listing to
> the top of the table instead of being at the bottom. With this change, the
> text about throw
> Can I please get a review of this trivial doc-only change to the
> `jdk.zipfs`'s documentation? This moves the `accessMode` property listing to
> the top of the table instead of being at the bottom. With this change, the
> text about throwing `IllegalArgumentException` when `create=true` and
On Wed, 4 Jun 2025 14:56:59 GMT, Jaikiran Pai wrote:
>> src/jdk.zipfs/share/classes/module-info.java line 195:
>>
>>> 193: * If the value is {@code true}, the ZIP file system provider
>>> creates a
>>> 194: * new ZIP or JAR file if it does not exist. Specifying the
>>> {@code cre
On Wed, 4 Jun 2025 15:03:11 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this trivial doc-only change to the
>> `jdk.zipfs`'s documentation? This moves the `accessMode` property listing to
>> the top of the table instead of being at the bottom. With this change, the
>> text about t
On Wed, 4 Jun 2025 09:35:25 GMT, Daniel Fuchs wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Daniel's suggestion - consistent use of {@code "readOnly"}
>
> src/jdk.zipfs/share/classes/module-info.java line 195:
>
Hi Jige,
First of all—you're most welcome. Thanks for your insightful questions.
>Temptation for Race Semantics: The beauty of mapConcurrent() integrating with
>the Stream API means developers will naturally be drawn to use it for
>race-like scenarios. Operations like findFirst() or limit(N) to
On Tue, 3 Jun 2025 12:50:49 GMT, Erik Gahlin wrote:
>> Could I have review of an enhancement that adds rate-limited sampling to
>> Java events, including five events in the JDK (SocketRead, SocketWrite,
>> FileRead, FileWrite, and JavaExceptionThrow).
>>
>> Testing: test/jdk/jdk/jfr
>>
>> Tha
On Wed, 4 Jun 2025 14:22:43 GMT, Raffaello Giulietti
wrote:
> Another step in enhancing floating-point <-> decimal conversions.
Changes include, but are not limited to:
- Accessing `g0()` and `g1()` with the exponent rather than the negated
exponent.
- Inverting the order of the `MathUtils.g`
Another step in enhancing floating-point <-> decimal conversions.
-
Commit messages:
- 8358540: Enhance MathUtils in view of FloatingDecimal enhancements
Changes: https://git.openjdk.org/jdk/pull/25641/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=25641&range=00
Issue:
On Wed, 4 Jun 2025 14:03:49 GMT, Raffaello Giulietti
wrote:
>> Please do _not_ fix the `mag` issue in this PR.
>> I'll take care of it in a future PR.
>
> I just filed [JDK-8358599](https://bugs.openjdk.org/browse/JDK-8358599).
> Please do _not_ fix the `mag` issue in this PR. I'll take care of
Hi Viktor,
Thank you for sharing that the general feedback on mapConcurrent() has been
positive and for the insights into the ongoing enhancements, especially
around interruption handling and work-in-progress tracking.
To clarify my own position, I am also extremely enthusiastic about the
mapConc
On Wed, 4 Jun 2025 13:53:09 GMT, Raffaello Giulietti
wrote:
>> BigInteger is an object that is considered immutable, but its field mag is
>> actually changed. This is incredible and should be fixed here. It is easy to
>> make mistakes.
>
> Please do _not_ fix the `mag` issue in this PR.
> I'll
On Fri, 30 May 2025 22:21:34 GMT, Shaojin Wen wrote:
>> src/java.base/share/classes/java/math/BigInteger.java line 192:
>>
>>> 190: * zero-length mag array.
>>> 191: */
>>> 192: @Stable
>>
>> `BigInteger.mag` gets written to a few times during computation in
>> `BigInteger.large
On Wed, 4 Jun 2025 06:47:59 GMT, Jaikiran Pai wrote:
> Can I please get a review of this trivial doc-only change to the
> `jdk.zipfs`'s documentation? This moves the `accessMode` property listing to
> the top of the table instead of being at the bottom. With this change, the
> text about throw
On Wed, 4 Jun 2025 08:35:01 GMT, Jaikiran Pai wrote:
> Hello Volkan, the alphabetical ordering wasn't an intention of this change.
> But after what you noted, I was almost considering making it alphabetically
> ordered, but then I noticed that I will also have to move down the properties
> `en
On Wed, 4 Jun 2025 06:47:59 GMT, Jaikiran Pai wrote:
> Can I please get a review of this trivial doc-only change to the
> `jdk.zipfs`'s documentation? This moves the `accessMode` property listing to
> the top of the table instead of being at the bottom. With this change, the
> text about throw
SonarCloud points out that ThreadLock class introduced by
[JDK-8357650](https://bugs.openjdk.org/browse/JDK-8357650) can be turned into
static nested class. I don't think this shows any real bug yet, as unreferenced
enclosing class reference gets nowhere. But it would be nice to be extra crisp
On Wed, 4 Jun 2025 06:47:59 GMT, Jaikiran Pai wrote:
> Can I please get a review of this trivial doc-only change to the
> `jdk.zipfs`'s documentation? This moves the `accessMode` property listing to
> the top of the table instead of being at the bottom. With this change, the
> text about throw
On Wed, 4 Jun 2025 06:47:59 GMT, Jaikiran Pai wrote:
> Can I please get a review of this trivial doc-only change to the
> `jdk.zipfs`'s documentation? This moves the `accessMode` property listing to
> the top of the table instead of being at the bottom. With this change, the
> text about throw
Can I please get a review of this change which proposes to address the issue
noted in https://bugs.openjdk.org/browse/JDK-8349914?
The ZIP specification allows for more than one entry to have the same file name
(and may have different file data). In such situation, as noted in the linked
issue,
Can I please get a review of this trivial doc-only change to the `jdk.zipfs`'s
documentation? This moves the `accessMode` property listing to the top of the
table instead of being at the bottom. With this change, the text about throwing
`IllegalArgumentException` when `create=true` and `accessMo
On Wed, 4 Jun 2025 06:47:59 GMT, Jaikiran Pai wrote:
> Can I please get a review of this trivial doc-only change to the
> `jdk.zipfs`'s documentation? This moves the `accessMode` property listing to
> the top of the table instead of being at the bottom. With this change, the
> text about throw
On Tue, 27 May 2025 19:48:11 GMT, Stefan Lobbenmeier wrote:
>> The documentation suggests that --linux-package-deps is a boolean option,
>> while in fact it is a string option with dependencies separated by comma and
>> space
>>
>> You can tell that this option is supposed to have an argument
> Some static final arrays of BigInteger and BigDecimal are stable and
> immutable. We should add `@Stable` to give the optimizer more information
Shaojin Wen has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes bro
On Fri, 30 May 2025 22:07:06 GMT, Shaojin Wen wrote:
>> Some static final arrays of BigInteger and BigDecimal are stable and
>> immutable. We should add `@Stable` to give the optimizer more information
>
> Shaojin Wen has updated the pull request incrementally with one additional
> commit since
On Wed, 4 Jun 2025 11:31:21 GMT, Erik Gahlin wrote:
> @AlanBateman Do you have time for a review?
Yes, looking at the changes.
-
PR Comment: https://git.openjdk.org/jdk/pull/25559#issuecomment-2939787559
On Fri, 30 May 2025 19:30:50 GMT, Vladimir Ivanov wrote:
>> Much of the point of this change is to let us later remove the interpreter/c1
>> intrinsics for this function. I think what you are saying is that might be
>> tricky if `get()` is the intrinsic. So maybe I should just go ahead now with
>
On Tue, 3 Jun 2025 09:10:04 GMT, Volkan Yazici wrote:
> > I wonder if we should add that implementations of the affected method
> > _shall_ do bounds checking to reduce the likelihood of a new/updated native
> > implementation miss that?
>
> @minborg, would you mind elaborating on this a bit,
On Tue, 3 Jun 2025 12:50:49 GMT, Erik Gahlin wrote:
>> Could I have review of an enhancement that adds rate-limited sampling to
>> Java events, including five events in the JDK (SocketRead, SocketWrite,
>> FileRead, FileWrite, and JavaExceptionThrow).
>>
>> Testing: test/jdk/jdk/jfr
>>
>> Tha
On Mon, 2 Jun 2025 13:26:36 GMT, Aleksey Shipilev wrote:
>> SonarCloud complains that since
>> [JDK-8356080](https://bugs.openjdk.org/browse/JDK-8356080) we are using
>> `Boolean` boxes in `ReverseOrderListView`. This change `boolean` ->
>> `Boolean` was made in
>> [JDK-8356080](https://bugs.
On Sat, 11 Jan 2025 07:10:53 GMT, He-Pin(kerr) wrote:
> Motivation:
> When a user passes a wrong parameter, the current implementation throws an
> IllegalArgumentException with an error message `null`, which is not helpful.
>
> Modification:
> Add detail error messages.
>
> Result:
> Helpful m
On Wed, 14 May 2025 14:23:31 GMT, Magnus Ihse Bursie wrote:
> I found a few other places in the code that can be cleaned up after the
> conversion to UTF-8.
This pull request has now been integrated.
Changeset: edf92721
Author:Magnus Ihse Bursie
URL:
https://git.openjdk.org/jdk/com
> Please review this change which adds a native method providing the
> implementation of Reference::get. Referece::get is an intrinsic candidate, so
> this native method implementation is only used when the intrinsic is not.
>
> Currently there is intrinsic support by the interpreter, C1, C2, and
On Wed, 21 May 2025 05:42:34 GMT, Kim Barrett wrote:
>> Kim Barrett has updated the pull request incrementally with three additional
>> commits since the last revision:
>>
>> - add description of BufferCleaner class
>> - exception handling in cleaner for backward consistency
>> - detabify
>
78 matches
Mail list logo
