Re: RFR: 8358078: javap crashes with NPE on preview class file

2025-06-01 Thread Hannes Greule
On Mon, 2 Jun 2025 00:56:51 GMT, Chen Liang wrote: > I recommend we fallback to use CFFV.latest() explicitly for now. FYI we will > likely add a new CFFV for all preview features, which we will likely use as > the default if we encounter an old preview class file. We can then swap > latest() w

Re: RFR: 8353686: Optimize Math.cbrt for x86 64 bit platforms [v6]

2025-06-01 Thread David Holmes
On Mon, 2 Jun 2025 03:49:42 GMT, Mohamed Issa wrote: > When you say "most of the non-x86 platforms", are you referring to the ones > with processor types listed below? Yes - 3 of the 5 non-x86 platforms. > It looks like aarch64 and riscv don't take that route and would fall back to > the defa

Re: RFR: 8353686: Optimize Math.cbrt for x86 64 bit platforms [v6]

2025-06-01 Thread Mohamed Issa
On Mon, 2 Jun 2025 02:08:55 GMT, David Holmes wrote: > This change also broke most of the non-x86 platforms, due to the new > intrinsic not being implemented on those platforms. When you say "most of the non-x86 platforms", are you referring to the ones with processor types listed below? 1. j

Re: RFR: 8353686: Optimize Math.cbrt for x86 64 bit platforms [v6]

2025-06-01 Thread David Holmes
On Fri, 30 May 2025 19:34:16 GMT, Mohamed Issa wrote: >> The goal of this PR is to implement an x86_64 intrinsic for >> java.lang.Math.cbrt() using libm. There is a new set of micro-benchmarks are >> included to check the performance of specific input value ranges to help >> prevent regression

Re: RFR: 8358078: javap crashes with NPE on preview class file

2025-06-01 Thread Chen Liang
On Sun, 1 Jun 2025 04:53:46 GMT, Hannes Greule wrote: > This change addresses a NPE in javap when trying to print a class with > minorVersion != 0. With this change, we fall back to the methods that don't > take a `ClassFileFormatVersion` in such case. I recommend we fallback to use CFFV.lates

Re: RFR: 8351594: JFR: Rate-limited sampling of Java events [v2]

2025-06-01 Thread Erik Gahlin
On Sat, 31 May 2025 21:20:17 GMT, Markus Grönlund wrote: >> Erik Gahlin has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Some reviewer feedback > > src/jdk.jfr/share/classes/jdk/jfr/internal/EventInstrumentation.java line 261: > >> 259:

Re: RFR: 8351594: JFR: Rate-limited sampling of Java events [v2]

2025-06-01 Thread Erik Gahlin
> Could I have review of an enhancement that adds rate-limited sampling to Java > event, including five events in the JDK (SocketRead, SocketWrite, FileRead, > FileWrite, and JavaExceptionThrow). > > Testing: test/jdk/jdk/jfr > > Thanks > Erik Erik Gahlin has updated the pull request increment

Re: RFR: 8351594: JFR: Rate-limited sampling of Java events

2025-06-01 Thread Markus Grönlund
On Fri, 30 May 2025 22:30:25 GMT, Erik Gahlin wrote: > Could I have review of an enhancement that adds rate-limited sampling to Java > event, including five events in the JDK (SocketRead, SocketWrite, FileRead, > FileWrite, and JavaExceptionThrow). > > Testing: test/jdk/jdk/jfr > > Thanks > E

Re: RFR: 8351594: JFR: Rate-limited sampling of Java events

2025-06-01 Thread Markus Grönlund
On Fri, 30 May 2025 22:30:25 GMT, Erik Gahlin wrote: > Could I have review of an enhancement that adds rate-limited sampling to Java > event, including five events in the JDK (SocketRead, SocketWrite, FileRead, > FileWrite, and JavaExceptionThrow). > > Testing: test/jdk/jdk/jfr > > Thanks > E

Re: RFR: 8351594: JFR: Rate-limited sampling of Java events

2025-06-01 Thread Markus Grönlund
On Fri, 30 May 2025 22:30:25 GMT, Erik Gahlin wrote: > Could I have review of an enhancement that adds rate-limited sampling to Java > event, including five events in the JDK (SocketRead, SocketWrite, FileRead, > FileWrite, and JavaExceptionThrow). > > Testing: test/jdk/jdk/jfr > > Thanks > E

Should mapConcurrent() respect time order instead of input order?

2025-06-01 Thread Jige Yu
It seems like for most people, input order isn't that important for concurrent work, and concurrent results being in non-deterministic order is often expected. If mapConcurrent() just respect output encounter order: It'll be able to achieve *higher throughput* if an early task is slow, For exampl

Re: RFR: 8351594: JFR: Rate-limited sampling of Java events

2025-06-01 Thread Markus Grönlund
On Fri, 30 May 2025 22:30:25 GMT, Erik Gahlin wrote: > Could I have review of an enhancement that adds rate-limited sampling to Java > event, including five events in the JDK (SocketRead, SocketWrite, FileRead, > FileWrite, and JavaExceptionThrow). > > Testing: test/jdk/jdk/jfr > > Thanks > E

Re: RFR: 8351594: JFR: Rate-limited sampling of Java events

2025-06-01 Thread Erik Gahlin
On Sat, 31 May 2025 20:13:01 GMT, Markus Grönlund wrote: >> Could I have review of an enhancement that adds rate-limited sampling to >> Java event, including five events in the JDK (SocketRead, SocketWrite, >> FileRead, FileWrite, and JavaExceptionThrow). >> >> Testing: test/jdk/jdk/jfr >> >>

Re: RFR: 8358217: jdk/incubator/vector/PreferredSpeciesTest.java#id0 failures - expected [128] but found [256] [v2]

2025-06-01 Thread SendaoYan
On Sat, 31 May 2025 17:27:30 GMT, Ian Graves wrote: >> Removing incorrect assumptions and assertions from a breaking test related >> to https://bugs.openjdk.org/browse/JDK-8358218 > > Ian Graves has updated the pull request with a new target base due to a merge > or a rebase. The pull request n